On 04/25/2018 07:46 AM, Pavel Dovgalyuk wrote: > This patch introduces 'info replay' monitor command and > corresponding qmp request. > These commands request the current record/replay mode, replay log file name, > and the execution step (number or recorded/replayed instructions). > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > ---
Focusing on the QMP portion: > +++ b/qapi/misc.json > @@ -3449,3 +3449,39 @@ > ## > { 'command': 'x-oob-test', 'data' : { 'lock': 'bool' }, > 'allow-oob': true } > + > +## > +# @ReplayInfo: > +# > +# Status of the record/replay mode. > +# > +# @mode: current mode. > +# > +# @filename: name of the record/replay log file. > +# > +# @step: current step number. > +# > +# Since: 2.13 > +# > +## > +{ 'struct': 'ReplayInfo', > + 'data': { 'mode': 'ReplayMode', '*filename': 'str', 'step': 'int' } } > + > + > +## > +# @info_replay: Please call this 'query-replay', for consistency with other QMP commands (your version looks too much like an HMP command). > +# > +# Retrieves the status of the execution record/replay. > +# > +# Returns: structure with the properties of the record/replay. > +# > +# Since: 2.13 > +# > +# Example: > +# > +# -> { "execute": "info_replay" } > +# <- { "return": { "mode": "play", "filename": "log.rr", "step": 220414 } } > +# > +## > +{ 'command': 'info_replay', > + 'returns': 'ReplayInfo' } Please put these additions to misc.json be grouped closer to the existing ReplayMode definition > diff --git a/replay/Makefile.objs b/replay/Makefile.objs > index cee6539..6694e3e 100644 > --- a/replay/Makefile.objs > +++ b/replay/Makefile.objs > @@ -6,4 +6,5 @@ common-obj-y += replay-input.o > common-obj-y += replay-char.o > common-obj-y += replay-snapshot.o > common-obj-y += replay-net.o > -common-obj-y += replay-audio.o > \ No newline at end of file Eww, that's an existing trivial bug that we should fix (POSIX says that Makefiles should be text files, and that text files should end in a newline). Just because GNU make handles a missing trailing newline on makefile include fragments doesn't mean we should rely on it. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature