Re: [Qemu-devel] [RFC PATCH 7/7] virtio-fs: Allow mapping of journal

2018-12-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote:
> On 12/10/18 11:31 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" 
> > 
> > The 'journal' is a shared block of RAM between QEMU and it's
> 
> s/it's/its/ (here, you want possessive)

Fixed.

Dave

> > fuse daemon.  It's typically a shmfs file and it's specified as:
> 
> whereas here, both uses of "it's" are correct as contractions for "it is"
> (although I might use just "is" instead of "it's" for that last instance).
> 
> > 
> > -device
> > vhost-user-fs-pci,chardev=char0,tag=myfs,cache-size=1G,versiontable=/dev/shm/mdvt1,journal=/dev/shm/journal1
> > 
> > It gets mapped into the PCI bar after the version table.
> > 
> > Signed-off-by: Dr. David Alan Gilbert 
> > ---
> 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.   +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK



Re: [Qemu-devel] [RFC PATCH 7/7] virtio-fs: Allow mapping of journal

2018-12-10 Thread Eric Blake

On 12/10/18 11:31 AM, Dr. David Alan Gilbert (git) wrote:

From: "Dr. David Alan Gilbert" 

The 'journal' is a shared block of RAM between QEMU and it's


s/it's/its/ (here, you want possessive)


fuse daemon.  It's typically a shmfs file and it's specified as:


whereas here, both uses of "it's" are correct as contractions for "it 
is" (although I might use just "is" instead of "it's" for that last 
instance).




-device
vhost-user-fs-pci,chardev=char0,tag=myfs,cache-size=1G,versiontable=/dev/shm/mdvt1,journal=/dev/shm/journal1

It gets mapped into the PCI bar after the version table.

Signed-off-by: Dr. David Alan Gilbert 
---



--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org