Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Fam Zheng

On 2014年01月05日 02:39, Peter Lieven wrote:

~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51
QEMU  -- ./qemu
QEMU_IMG  -- ./qemu-img
QEMU_IO   -- ./qemu-io
QEMU_NBD  -- /usr/local/bin/qemu-nbd
IMGFMT-- qcow2 (compat=1.1)
IMGPROTO  -- file
PLATFORM  -- Linux/x86_64 lieven-pc 3.2.0-57-generic
SOCKET_SCM_HELPER --

051 - output mismatch (see 051.out.bad)
--- 051.out2014-01-04 19:11:31.557812472 +0100
+++ 051.out.bad2014-01-04 19:38:03.185810819 +0100
@@ -91,7 +91,6 @@
  QEMU X.Y.Z monitor - type 'help' for more information
  (qemu) QEMU_PROG: -drive if=virtio: Device needs media, but drive is empty
  QEMU_PROG: -drive if=virtio: Device initialization failed.
-QEMU_PROG: -drive if=virtio: Device initialization failed.
  QEMU_PROG: -drive if=virtio: Device 'virtio-blk-pci' could not be initialized

  Testing: -drive if=scsi
Failures: 051
Failed 1 of 1 tests

Peter



Yes, this is the bad commit:

commit 75884afd5c6c42e523b08565e289dbe319e17ad9
Author: Andreas Färber afaer...@suse.de
Date:   Tue Jul 30 01:35:08 2013 +0200

virtio-blk: Convert to QOM realize

Signed-off-by: Andreas Färber afaer...@suse.de
Signed-off-by: Paolo Bonzini pbonz...@redhat.com

I guess simply removing the duplicated line in the output file is 
enough. I'll post a patch for it, thanks for the report!


Fam




Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Stefan Hajnoczi
On Sat, Jan 04, 2014 at 07:39:08PM +0100, Peter Lieven wrote:
 ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51
 QEMU  -- ./qemu
 QEMU_IMG  -- ./qemu-img
 QEMU_IO   -- ./qemu-io
 QEMU_NBD  -- /usr/local/bin/qemu-nbd
 IMGFMT-- qcow2 (compat=1.1)
 IMGPROTO  -- file
 PLATFORM  -- Linux/x86_64 lieven-pc 3.2.0-57-generic
 SOCKET_SCM_HELPER --
 
 051 - output mismatch (see 051.out.bad)
 --- 051.out2014-01-04 19:11:31.557812472 +0100
 +++ 051.out.bad2014-01-04 19:38:03.185810819 +0100
 @@ -91,7 +91,6 @@
  QEMU X.Y.Z monitor - type 'help' for more information
  (qemu) QEMU_PROG: -drive if=virtio: Device needs media, but drive is empty
  QEMU_PROG: -drive if=virtio: Device initialization failed.
 -QEMU_PROG: -drive if=virtio: Device initialization failed.
  QEMU_PROG: -drive if=virtio: Device 'virtio-blk-pci' could not be initialized
  
  Testing: -drive if=scsi
 Failures: 051
 Failed 1 of 1 tests

Fixed by:

commit db2f695f1bf68eec38f2d7cc26ba3846c97a3f54
Author: Stefan Hajnoczi stefa...@redhat.com
Date:   Thu Dec 19 16:26:44 2013 +0100

qemu-iotests: drop duplicate virtio-blk initialization failure

It should be in qemu.git/master in a couple of days.



Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Stefan Hajnoczi
On Mon, Jan 06, 2014 at 09:44:30AM +0800, Fam Zheng wrote:
 On 2014年01月05日 02:39, Peter Lieven wrote:
 ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51
 QEMU  -- ./qemu
 QEMU_IMG  -- ./qemu-img
 QEMU_IO   -- ./qemu-io
 QEMU_NBD  -- /usr/local/bin/qemu-nbd
 IMGFMT-- qcow2 (compat=1.1)
 IMGPROTO  -- file
 PLATFORM  -- Linux/x86_64 lieven-pc 3.2.0-57-generic
 SOCKET_SCM_HELPER --
 
 051 - output mismatch (see 051.out.bad)
 --- 051.out2014-01-04 19:11:31.557812472 +0100
 +++ 051.out.bad2014-01-04 19:38:03.185810819 +0100
 @@ -91,7 +91,6 @@
   QEMU X.Y.Z monitor - type 'help' for more information
   (qemu) QEMU_PROG: -drive if=virtio: Device needs media, but drive is empty
   QEMU_PROG: -drive if=virtio: Device initialization failed.
 -QEMU_PROG: -drive if=virtio: Device initialization failed.
   QEMU_PROG: -drive if=virtio: Device 'virtio-blk-pci' could not be 
  initialized
 
   Testing: -drive if=scsi
 Failures: 051
 Failed 1 of 1 tests
 
 Peter
 
 
 Yes, this is the bad commit:
 
 commit 75884afd5c6c42e523b08565e289dbe319e17ad9
 Author: Andreas Färber afaer...@suse.de
 Date:   Tue Jul 30 01:35:08 2013 +0200
 
 virtio-blk: Convert to QOM realize
 
 Signed-off-by: Andreas Färber afaer...@suse.de
 Signed-off-by: Paolo Bonzini pbonz...@redhat.com
 
 I guess simply removing the duplicated line in the output file is
 enough. I'll post a patch for it, thanks for the report!

See my earlier email to this thread.  I already posted a patch.

Stefan



Re: [Qemu-devel] qemu-iotests: test 051 fails

2014-01-05 Thread Fam Zheng

On 2014年01月06日 14:14, Stefan Hajnoczi wrote:

On Mon, Jan 06, 2014 at 09:44:30AM +0800, Fam Zheng wrote:

On 2014年01月05日 02:39, Peter Lieven wrote:

~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51
QEMU  -- ./qemu
QEMU_IMG  -- ./qemu-img
QEMU_IO   -- ./qemu-io
QEMU_NBD  -- /usr/local/bin/qemu-nbd
IMGFMT-- qcow2 (compat=1.1)
IMGPROTO  -- file
PLATFORM  -- Linux/x86_64 lieven-pc 3.2.0-57-generic
SOCKET_SCM_HELPER --

051 - output mismatch (see 051.out.bad)
--- 051.out2014-01-04 19:11:31.557812472 +0100
+++ 051.out.bad2014-01-04 19:38:03.185810819 +0100
@@ -91,7 +91,6 @@
  QEMU X.Y.Z monitor - type 'help' for more information
  (qemu) QEMU_PROG: -drive if=virtio: Device needs media, but drive is empty
  QEMU_PROG: -drive if=virtio: Device initialization failed.
-QEMU_PROG: -drive if=virtio: Device initialization failed.
  QEMU_PROG: -drive if=virtio: Device 'virtio-blk-pci' could not be initialized

  Testing: -drive if=scsi
Failures: 051
Failed 1 of 1 tests

Peter



Yes, this is the bad commit:

commit 75884afd5c6c42e523b08565e289dbe319e17ad9
Author: Andreas Färber afaer...@suse.de
Date:   Tue Jul 30 01:35:08 2013 +0200

 virtio-blk: Convert to QOM realize

 Signed-off-by: Andreas Färber afaer...@suse.de
 Signed-off-by: Paolo Bonzini pbonz...@redhat.com

I guess simply removing the duplicated line in the output file is
enough. I'll post a patch for it, thanks for the report!


See my earlier email to this thread.  I already posted a patch.



That's good, thanks!

Fam