Re: [RFC v4 3/3] virtio-blk: add some trace events for zoned emulation
Philippe Mathieu-Daudé 于2022年11月3日周四 05:21写道： > > Hi, > > On 30/10/22 10:32, Sam Li wrote: > > Signed-off-by: Sam Li > > --- > > hw/block/trace-events | 7 +++ > > hw/block/virtio-blk.c | 12 > > 2 files changed, 19 insertions(+) > > > > diff --git a/hw/block/trace-events b/hw/block/trace-events > > index 2c45a62bd5..f47da6fcd4 100644 > > --- a/hw/block/trace-events > > +++ b/hw/block/trace-events > > @@ -44,9 +44,16 @@ pflash_write_unknown(const char *name, uint8_t cmd) "%s: > > unknown command 0x%02x" > > # virtio-blk.c > > virtio_blk_req_complete(void *vdev, void *req, int status) "vdev %p req > > %p status %d" > > virtio_blk_rw_complete(void *vdev, void *req, int ret) "vdev %p req %p > > ret %d" > > +virtio_blk_zone_report_complete(void *vdev, void *req, unsigned int > > nr_zones, int ret) "vdev %p req %p nr_zones %d ret %d" > > " ... nr_zones %u ..." > > > +virtio_blk_zone_mgmt_complete(void *vdev, void *req, int ret) "vdev %p req > > %p ret %d" > > +virtio_blk_zone_append_complete(void *vdev, void *req, int64_t sector, int > > ret) "vdev %p req %p, append sector 0x%" PRIx64 " ret %d" > > virtio_blk_handle_write(void *vdev, void *req, uint64_t sector, size_t > > nsectors) "vdev %p req %p sector %"PRIu64" nsectors %zu" > > virtio_blk_handle_read(void *vdev, void *req, uint64_t sector, size_t > > nsectors) "vdev %p req %p sector %"PRIu64" nsectors %zu" > > virtio_blk_submit_multireq(void *vdev, void *mrb, int start, int > > num_reqs, uint64_t offset, size_t size, bool is_write) "vdev %p mrb %p > > start %d num_reqs %d offset %"PRIu64" size %zu is_write %d" > > " ... is_write %u" > > > +virtio_blk_handle_zone_report(void *vdev, void *req, int64_t sector, > > unsigned int nr_zones) "vdev %p req %p sector 0x%" PRIx64 " nr_zones %d" > > " ... nr_zones %u" Thanks! > > > +virtio_blk_handle_zone_mgmt(void *vdev, void *req, uint8_t op, int64_t > > sector, int64_t len) "vdev %p req %p op 0x%x sector 0x%" PRIx64 " len 0x%" > > PRIx64 "" > > +virtio_blk_handle_zone_reset_all(void *vdev, void *req, int64_t sector, > > int64_t len) "vdev %p req %p sector 0x%" PRIx64 " cap 0x%" PRIx64 "" > > +virtio_blk_handle_zone_append(void *vdev, void *req, int64_t sector) "vdev > > %p req %p, append sector 0x%" PRIx64 "" > > You can probably drop the trailing "". It is necessary for formatted output as %" PRIx64 ". Sam
Re: [RFC v4 3/3] virtio-blk: add some trace events for zoned emulation
Hi, On 30/10/22 10:32, Sam Li wrote: Signed-off-by: Sam Li --- hw/block/trace-events | 7 +++ hw/block/virtio-blk.c | 12 2 files changed, 19 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index 2c45a62bd5..f47da6fcd4 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -44,9 +44,16 @@ pflash_write_unknown(const char *name, uint8_t cmd) "%s: unknown command 0x%02x" # virtio-blk.c virtio_blk_req_complete(void *vdev, void *req, int status) "vdev %p req %p status %d" virtio_blk_rw_complete(void *vdev, void *req, int ret) "vdev %p req %p ret %d" +virtio_blk_zone_report_complete(void *vdev, void *req, unsigned int nr_zones, int ret) "vdev %p req %p nr_zones %d ret %d" " ... nr_zones %u ..." +virtio_blk_zone_mgmt_complete(void *vdev, void *req, int ret) "vdev %p req %p ret %d" +virtio_blk_zone_append_complete(void *vdev, void *req, int64_t sector, int ret) "vdev %p req %p, append sector 0x%" PRIx64 " ret %d" virtio_blk_handle_write(void *vdev, void *req, uint64_t sector, size_t nsectors) "vdev %p req %p sector %"PRIu64" nsectors %zu" virtio_blk_handle_read(void *vdev, void *req, uint64_t sector, size_t nsectors) "vdev %p req %p sector %"PRIu64" nsectors %zu" virtio_blk_submit_multireq(void *vdev, void *mrb, int start, int num_reqs, uint64_t offset, size_t size, bool is_write) "vdev %p mrb %p start %d num_reqs %d offset %"PRIu64" size %zu is_write %d" " ... is_write %u" +virtio_blk_handle_zone_report(void *vdev, void *req, int64_t sector, unsigned int nr_zones) "vdev %p req %p sector 0x%" PRIx64 " nr_zones %d" " ... nr_zones %u" +virtio_blk_handle_zone_mgmt(void *vdev, void *req, uint8_t op, int64_t sector, int64_t len) "vdev %p req %p op 0x%x sector 0x%" PRIx64 " len 0x%" PRIx64 "" +virtio_blk_handle_zone_reset_all(void *vdev, void *req, int64_t sector, int64_t len) "vdev %p req %p sector 0x%" PRIx64 " cap 0x%" PRIx64 "" +virtio_blk_handle_zone_append(void *vdev, void *req, int64_t sector) "vdev %p req %p, append sector 0x%" PRIx64 "" You can probably drop the trailing "". Regards, Phil.
Re: [RFC v4 3/3] virtio-blk: add some trace events for zoned emulation
On Sun, Oct 30, 2022 at 05:32:42AM -0400, Sam Li wrote: > Signed-off-by: Sam Li > --- > hw/block/trace-events | 7 +++ > hw/block/virtio-blk.c | 12 > 2 files changed, 19 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature
