Re: sh4-linux-user compile failure
On 07/03/2023 23:59, Mark Cave-Ayland wrote: On 07/03/2023 23:52, Philippe Mathieu-Daudé wrote: On 8/3/23 00:46, Mark Cave-Ayland wrote: Hi Richard/Anton, It looks as if a compile failure has crept into sh4-linux-user, most likely related to the recent TARGET_TB_PCREL/CF_PCREL changes: In file included from ../accel/tcg/tb-hash.h:26, from ../accel/tcg/tb-maint.c:28: ../accel/tcg/tb-jmp-cache.h:24:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 24 | #if TARGET_TB_PCREL | ^~~ Your tree seems desync / out of date: $ git grep TARGET_TB_PCREL a2b5f8b8ab $ Hmmm I just did a standard "git pull" and rebuild as normal, although this time I did a full build for all targets for testing. Maybe there's something old left in the build/ directory that's causing a problem? I'll throw everything away and see if that fixes it. Yeah completely removing the build/ directory fixed it, sorry for the noise. ATB, Mark.
Re: sh4-linux-user compile failure
On 07/03/2023 23:52, Philippe Mathieu-Daudé wrote: On 8/3/23 00:46, Mark Cave-Ayland wrote: Hi Richard/Anton, It looks as if a compile failure has crept into sh4-linux-user, most likely related to the recent TARGET_TB_PCREL/CF_PCREL changes: In file included from ../accel/tcg/tb-hash.h:26, from ../accel/tcg/tb-maint.c:28: ../accel/tcg/tb-jmp-cache.h:24:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 24 | #if TARGET_TB_PCREL | ^~~ Your tree seems desync / out of date: $ git grep TARGET_TB_PCREL a2b5f8b8ab $ Hmmm I just did a standard "git pull" and rebuild as normal, although this time I did a full build for all targets for testing. Maybe there's something old left in the build/ directory that's causing a problem? I'll throw everything away and see if that fixes it. ATB, Mark.
Re: sh4-linux-user compile failure
On 8/3/23 00:46, Mark Cave-Ayland wrote: Hi Richard/Anton, It looks as if a compile failure has crept into sh4-linux-user, most likely related to the recent TARGET_TB_PCREL/CF_PCREL changes: In file included from ../accel/tcg/tb-hash.h:26, from ../accel/tcg/tb-maint.c:28: ../accel/tcg/tb-jmp-cache.h:24:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 24 | #if TARGET_TB_PCREL | ^~~ Your tree seems desync / out of date: $ git grep TARGET_TB_PCREL a2b5f8b8ab $
sh4-linux-user compile failure
Hi Richard/Anton, It looks as if a compile failure has crept into sh4-linux-user, most likely related to the recent TARGET_TB_PCREL/CF_PCREL changes: cc -m64 -mcx16 -Ilibqemu-sh4-linux-user.fa.p -I. -I.. -Itarget/sh4 -I../target/sh4 -I../common-user/host/x86_64 -I../linux-user/include/host/x86_64 -I../linux-user/include -Ilinux-user -I../linux-user -Ilinux-user/sh4 -I../linux-user/sh4 -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto -Wall -Winvalid-pch -Werror -std=gnu11 -O2 -g -isystem /home/build/src/qemu/git/qemu/linux-headers -isystem linux-headers -iquote . -iquote /home/build/src/qemu/git/qemu -iquote /home/build/src/qemu/git/qemu/include -iquote /home/build/src/qemu/git/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common -fwrapv -Wundef -Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wmissing-format-attribute -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H '-DCONFIG_TARGET="sh4-linux-user-config-target.h"' '-DCONFIG_DEVICES="sh4-linux-user-config-devices.h"' -MD -MQ libqemu-sh4-linux-user.fa.p/accel_tcg_tb-maint.c.o -MF libqemu-sh4-linux-user.fa.p/accel_tcg_tb-maint.c.o.d -o libqemu-sh4-linux-user.fa.p/accel_tcg_tb-maint.c.o -c ../accel/tcg/tb-maint.c In file included from ../accel/tcg/tb-hash.h:26, from ../accel/tcg/tb-maint.c:28: ../accel/tcg/tb-jmp-cache.h:24:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 24 | #if TARGET_TB_PCREL | ^~~ ../accel/tcg/tb-jmp-cache.h: In function ‘tb_jmp_cache_get_tb’: ../accel/tcg/tb-jmp-cache.h:33:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 33 | #if TARGET_TB_PCREL | ^~~ ../accel/tcg/tb-jmp-cache.h: In function ‘tb_jmp_cache_get_pc’: ../accel/tcg/tb-jmp-cache.h:45:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 45 | #if TARGET_TB_PCREL | ^~~ ../accel/tcg/tb-jmp-cache.h:48:12: error: implicit declaration of function ‘tb_pc’ [-Werror=implicit-function-declaration] 48 | return tb_pc(tb); |^ ../accel/tcg/tb-jmp-cache.h:48:12: error: nested extern declaration of ‘tb_pc’ [-Werror=nested-externs] ../accel/tcg/tb-jmp-cache.h: In function ‘tb_jmp_cache_set’: ../accel/tcg/tb-jmp-cache.h:56:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 56 | #if TARGET_TB_PCREL | ^~~ In file included from ../accel/tcg/tb-maint.c:30: ../accel/tcg/internal.h: In function ‘log_pc’: ../accel/tcg/internal.h:60:5: error: "TARGET_TB_PCREL" is not defined, evaluates to 0 [-Werror=undef] 60 | #if TARGET_TB_PCREL | ^~~ cc1: all warnings being treated as errors ATB, Mark.
