Re: [QGIS-Developer] Bug in the vertex tool when snapping on a segment

2023-07-26 Thread MATTHEWS, David via QGIS-Developer
Guys,

Please can you stop sending me emails.

Thanks very much

Dave



OFFICIAL

From: QGIS-Developer  On Behalf Of Ismo 
Lahtinen via QGIS-Developer
Sent: 26 July 2023 10:44
To: qgis-developer@lists.osgeo.org
Subject: [QGIS-Developer] Bug in the vertex tool when snapping on a segment

CAUTION: This email originated from outside of the organisation. Do not click 
links or open attachments unless you recognise the sender and know the content 
is safe.


Hello!


Our customer reported a bug in the vertex tool when snapping on a segment with 
the geometry precision enabled (https://github.com/qgis/QGIS/issues/49311). 
After some studying, I thought I found the cause and also a smooth fix for it.


So now I have a bug fix and also a test function that fails without my fix. 
Shall I make a pull request or what is the best way to proceed? I decided to 
ask here first because I have never made changes to the source code of QGIS 
earlier. I have quite a long experience with C++ and Qt. I have read the 
developers guide too. (And noticed that it is recommended to report here first 
when fixing the bug but now I wasn't sure at all if I can fix anything.)


Best regards,


Ismo Lahtinen

Software developer

Gispo Oy

https://www.gispo.fi/en/


Confidentiality: This email and its contents and any attachments are intended 
only for the above named. As the email may contain confidential or legally 
privileged information, if you are not the above named person or responsible 
for delivery to the above named, or suspect that you are not an intended 
recipient please delete or destroy the email and any attachments immediately.

Security and Viruses: This note confirms that this email message has been swept 
for the presence of computer viruses. We cannot accept any responsibility for 
any damage or loss caused by software viruses.

Monitoring: The Council undertakes monitoring of both incoming and outgoing 
emails. You should therefore be aware that if you send an email to a person 
within the Council it may be subject to any monitoring deemed necessary by the 
organisation from time to time. The views of the author may not necessarily 
reflect those of the Council.

Access as a public body: The Council may be required to disclose this email (or 
any response to it) under the Freedom of Information Act, 2000, unless the 
information in it is covered by one of the exemptions in the Act.

Legal documents: The Council does not accept service of legal documents by 
email.


To find out how we use your information see our privacy notice.

https://www.cheshireeast.gov.uk/council_and_democracy/council_information/website_information/privacy-notices/privacy-notice.aspx

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer


[QGIS-Developer] Bug in the vertex tool when snapping on a segment

2023-07-26 Thread Ismo Lahtinen via QGIS-Developer
Hello!

Our customer reported a bug in the vertex tool when snapping on a segment
with the geometry precision enabled (
https://github.com/qgis/QGIS/issues/49311). After some studying, I thought
I found the cause and also a smooth fix for it.

So now I have a bug fix and also a test function that fails without my fix.
Shall I make a pull request or what is the best way to proceed? I decided
to ask here first because I have never made changes to the source code of
QGIS earlier. I have quite a long experience with C++ and Qt. I have read
the developers guide too. (And noticed that it is recommended to report
here first when fixing the bug but now I wasn’t sure at all if I can fix
anything.)

Best regards,

Ismo Lahtinen

Software developer

Gispo Oy

https://www.gispo.fi/en/
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer