[Qgis-developer] False failures in the testsuite

2014-12-11 Thread Sandro Santilli
Once again I'm facing testsuite failures from a branch with NOTHING
effectively changed. These are the changes in the branch:

  https://github.com/qgis/QGIS/pull/1729/files

Can you spot a real difference ?

And this is the corresponding travis build:

  https://travis-ci.org/qgis/QGIS/builds/43741928

Before orfeo dash was reset (does it happen daily?)
I could see one-pixel-border-line differences in some
labels test, which I've seen before while working on the
core rotation support.

As once again I cannot see what difference could my change introduce,
can it be that the tests are suffering from some code-independent
glitches making them unstable ? Could it maybe be threading ?
Or unclearn builds from travis ?

--strk; 

 ()  ASCII ribbon campaign  --  Keep it simple !
 /\  http://strk.keybit.net/rants/ascii_mails.txt  
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] False failures in the testsuite

2014-12-11 Thread Even Rouault
 Or unclearn builds from travis ?

Travis starts a fresh snapshot of a VM for each build, so seems impossible.

What about uninitialized memory isssues. Does the test suite run cleanly under 
Valgrind ?

 
 --strk;
 
  ()  ASCII ribbon campaign  --  Keep it simple !
  /\  http://strk.keybit.net/rants/ascii_mails.txt
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] False failures in the testsuite

2014-12-11 Thread Nyall Dawson
On 12 Dec 2014 5:11 am, Sandro Santilli s...@keybit.net wrote:

 Once again I'm facing testsuite failures from a branch with NOTHING
 effectively changed. These are the changes in the branch:

   https://github.com/qgis/QGIS/pull/1729/files


 As once again I cannot see what difference could my change introduce,
 can it be that the tests are suffering from some code-independent
 glitches making them unstable ? Could it maybe be threading ?
 Or unclearn builds from travis ?



Check the Travis build logs. The failure started with 7f8006f. The commit
message explains what is happening - a fix previously introduced was found
to cause some serious issues so was reverted. As a consequence the original
bug the test was designed to detect has stated failing again. It's a
correct failure, and is now waiting on me finding a better fix than the one
that was reverted...

Nyall
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer