Re: [Qgis-developer] Make valid in master
Hi Andrea, On Thu, Jan 16, 2014 at 12:39 AM, Andrea Peri aperi2...@gmail.com wrote: It should be applied only when the test IsValid fail. This should limit the slowness. Also pay attention that something the result of a MakeValid on an Invalid poligon could be a MultiPolygon or also a Collection. So to use it in an automatic manner need to apply also a ST_Multi(CollectionExtract(ST_MakeValid(geometry),3)). To be sure that it is always a geometry of the same kind. Thank you. I was wondering how to do that! I suppose that would be for the QgsGeometry class function(s) to handle, thereby just returning an array of same geom type passed in, or returning whether the fix was actually done and assigning any results to a referenced variable. Regards, Larry A. 2014/1/16 Larry Shaffer lar...@dakotacarto.com Hi Paolo, On Wed, Jan 15, 2014 at 11:35 PM, Paolo Cavallini cavall...@faunalia.itwrote: Hi all. To the best of my knowledge, our make clean command, available through the Processing subplugin: http://plugins.qgis.org/plugins/processinglwgeomprovider/ is the most effective method to clean up invalid geometries. I would therefore suggest to include it in master, in order to have it available straight away for everybody. This depends on lwgeom, available at least on Debian and Windows. I have recently made a Homebrew formula for Mac that allows liblwgeom to be built without Postgres/PostGIS installs (a bit of a hack, actually). So, the standalone lib is now readily available on Mac OS X as well [0]. +1 for this to be included in QgsGeometry or similar class. It would help solve labeling issues where the extents-clipped geometry is invalid. Would slow rendering down, of course, but would be good to have as an option for faster machines and print jobs. Note: the validity fix would be applied to the duplicates of feature geometries, which are used by PAL. [0] https://github.com/Homebrew/homebrew/blob/master/Library/Formula/liblwgeom.rb Larry Opinions? Any blockers? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS PostGIS courses: http://www.faunalia.eu/training.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer -- - Andrea Peri . . . . . . . . . qwerty àèìòù - ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Make valid in master
Hi, including it into processing is better than putting it as a separated plugin, it depends on processing. If there are no objections, please open a new pull request. Regards. Sent from mobile. Sorry for being short. -- Giuseppe Sucameli Il 16/gen/2014 07:36 Paolo Cavallini cavall...@faunalia.it ha scritto: Hi all. To the best of my knowledge, our make clean command, available through the Processing subplugin: http://plugins.qgis.org/plugins/processinglwgeomprovider/ is the most effective method to clean up invalid geometries. I would therefore suggest to include it in master, in order to have it available straight away for everybody. This depends on lwgeom, available at least on Debian and Windows. Opinions? Any blockers? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS PostGIS courses: http://www.faunalia.eu/training.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
[Qgis-developer] Make valid in master
Hi all. To the best of my knowledge, our make clean command, available through the Processing subplugin: http://plugins.qgis.org/plugins/processinglwgeomprovider/ is the most effective method to clean up invalid geometries. I would therefore suggest to include it in master, in order to have it available straight away for everybody. This depends on lwgeom, available at least on Debian and Windows. Opinions? Any blockers? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS PostGIS courses: http://www.faunalia.eu/training.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Make valid in master
last merged pull request allows the provider works on OSX ciao Luigi Pirelli (luigi.pire...@faunalia.it - lui...@gmail.com) On 16 January 2014 07:35, Paolo Cavallini cavall...@faunalia.it wrote: Hi all. To the best of my knowledge, our make clean command, available through the Processing subplugin: http://plugins.qgis.org/plugins/processinglwgeomprovider/ is the most effective method to clean up invalid geometries. I would therefore suggest to include it in master, in order to have it available straight away for everybody. This depends on lwgeom, available at least on Debian and Windows. Opinions? Any blockers? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS PostGIS courses: http://www.faunalia.eu/training.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Make valid in master
Hi Paolo, On Wed, Jan 15, 2014 at 11:35 PM, Paolo Cavallini cavall...@faunalia.itwrote: Hi all. To the best of my knowledge, our make clean command, available through the Processing subplugin: http://plugins.qgis.org/plugins/processinglwgeomprovider/ is the most effective method to clean up invalid geometries. I would therefore suggest to include it in master, in order to have it available straight away for everybody. This depends on lwgeom, available at least on Debian and Windows. I have recently made a Homebrew formula for Mac that allows liblwgeom to be built without Postgres/PostGIS installs (a bit of a hack, actually). So, the standalone lib is now readily available on Mac OS X as well [0]. +1 for this to be included in QgsGeometry or similar class. It would help solve labeling issues where the extents-clipped geometry is invalid. Would slow rendering down, of course, but would be good to have as an option for faster machines and print jobs. Note: the validity fix would be applied to the duplicates of feature geometries, which are used by PAL. [0] https://github.com/Homebrew/homebrew/blob/master/Library/Formula/liblwgeom.rb Larry Opinions? Any blockers? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS PostGIS courses: http://www.faunalia.eu/training.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Make valid in master
It should be applied only when the test IsValid fail. This should limit the slowness. Also pay attention that something the result of a MakeValid on an Invalid poligon could be a MultiPolygon or also a Collection. So to use it in an automatic manner need to apply also a ST_Multi(CollectionExtract(ST_MakeValid(geometry),3)). To be sure that it is always a geometry of the same kind. A. 2014/1/16 Larry Shaffer lar...@dakotacarto.com Hi Paolo, On Wed, Jan 15, 2014 at 11:35 PM, Paolo Cavallini cavall...@faunalia.itwrote: Hi all. To the best of my knowledge, our make clean command, available through the Processing subplugin: http://plugins.qgis.org/plugins/processinglwgeomprovider/ is the most effective method to clean up invalid geometries. I would therefore suggest to include it in master, in order to have it available straight away for everybody. This depends on lwgeom, available at least on Debian and Windows. I have recently made a Homebrew formula for Mac that allows liblwgeom to be built without Postgres/PostGIS installs (a bit of a hack, actually). So, the standalone lib is now readily available on Mac OS X as well [0]. +1 for this to be included in QgsGeometry or similar class. It would help solve labeling issues where the extents-clipped geometry is invalid. Would slow rendering down, of course, but would be good to have as an option for faster machines and print jobs. Note: the validity fix would be applied to the duplicates of feature geometries, which are used by PAL. [0] https://github.com/Homebrew/homebrew/blob/master/Library/Formula/liblwgeom.rb Larry Opinions? Any blockers? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS PostGIS courses: http://www.faunalia.eu/training.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer -- - Andrea Peri . . . . . . . . . qwerty àèìòù - ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
