Re: [Qgis-developer] New GRASS plugin: a test drive

[Alexandre Neto]

Ok, I will do that. Thanks!

Radim Blazek  escreveu no dia segunda, 1/02/2016 às
11:23:

> On Mon, Feb 1, 2016 at 12:05 PM, Alexandre Neto 
> wrote:
> > Ok thanks.
> >
> >  I will update the documentation then. Because right in the beginning
> shows
> > all the icons. I can remove them, right?
>
> The actions are still in the menu. I would suggest to keep them and
> change the text "...provided with the toolbar menu" to "...provided
> with the menu" and add something like "Open GRASS Tools and Display
> Current GRASS Region actions are also available in the toolbar menu".
>
> Thanks
> Radim
>
>
> > Thanks again,
> >
> > Alexandre
> >
> > Radim Blazek  escreveu no dia segunda,
> 1/02/2016 às
> > 09:56:
> >>
> >> On Fri, Jan 29, 2016 at 5:38 PM, Alexandre Neto 
> >> wrote:
> >> > I'm updating the Users Manual Figures. In my current installation of
> >> > QGIS
> >> > master the GRASS Toolbar only features 2 Icons. Is this expected? I
> can
> >> > only
> >> > see Open grass tools and Display current GRASS region Icons. We used
> to
> >> > have
> >> > Open Mapset, Close Mapset, New Mapset and GRASS options as well.
> >>
> >> Yes it is intended. The tools which are not frequently used were
> >> removed from the toolbar to keep UI clean.
> >>
> >> Radim
> >>
> >> > Thanks
> >> >
> >> > Radim Blazek  escreveu no dia terça,
> 15/12/2015
> >> > às
> >> > 11:29:
> >> >>
> >> >> On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
> >> >>  wrote:
> >> >> > Finally, I was wondering if it could be an idea to place all mapset
> >> >> > related buttons (open / close / new / change mapset) at the bottom
> of
> >> >> > the
> >> >> > Modules dialogue and to add a "manage mapset access" button, which
> >> >> > runs the
> >> >> > mapset picker for modifying the search path (g.mapsets -s) there as
> >> >> > well?
> >> >> > One (I if you like) can add g.mapsets with the s-flag as a module
> (I
> >> >> > tested
> >> >> > "g.mapsets -s" in the QGIS-GRASS-plugin and it starts the GRASS
> >> >> > dialogue
> >> >> > successfully), but it is probably better to have this option a bit
> >> >> > more
> >> >> > prominent (as it might come in handy with the new multiple map
> input
> >> >> > option)?
> >> >>
> >> >> I have added "Add/Remove mapset to/from search path" as new browser
> >> >> actions in master. There are now also distinct icons for mapset, open
> >> >> mapset and mapset in search path.
> >> >>
> >> >> Radim
> >> >> ___
> >> >> Qgis-developer mailing list
> >> >> Qgis-developer@lists.osgeo.org
> >> >> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> >> >> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> >> >
> >> > --
> >> > Alexandre Neto
> >> > -
> >> > @AlexNetoGeo
> >> > http://sigsemgrilhetaswordpress.com
> >> > http://gisunchained.wordpress.com
> >
> > --
> > Alexandre Neto
> > -
> > @AlexNetoGeo
> > http://sigsemgrilhetaswordpress.com
> > http://gisunchained.wordpress.com
>
-- 
Alexandre Neto
-
@AlexNetoGeo
http://sigsemgrilhetaswordpress.com
http://gisunchained.wordpress.com
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Feb 1, 2016 at 12:05 PM, Alexandre Neto  wrote:
> Ok thanks.
>
>  I will update the documentation then. Because right in the beginning shows
> all the icons. I can remove them, right?

The actions are still in the menu. I would suggest to keep them and
change the text "...provided with the toolbar menu" to "...provided
with the menu" and add something like "Open GRASS Tools and Display
Current GRASS Region actions are also available in the toolbar menu".

Thanks
Radim


> Thanks again,
>
> Alexandre
>
> Radim Blazek  escreveu no dia segunda, 1/02/2016 às
> 09:56:
>>
>> On Fri, Jan 29, 2016 at 5:38 PM, Alexandre Neto 
>> wrote:
>> > I'm updating the Users Manual Figures. In my current installation of
>> > QGIS
>> > master the GRASS Toolbar only features 2 Icons. Is this expected? I can
>> > only
>> > see Open grass tools and Display current GRASS region Icons. We used to
>> > have
>> > Open Mapset, Close Mapset, New Mapset and GRASS options as well.
>>
>> Yes it is intended. The tools which are not frequently used were
>> removed from the toolbar to keep UI clean.
>>
>> Radim
>>
>> > Thanks
>> >
>> > Radim Blazek  escreveu no dia terça, 15/12/2015
>> > às
>> > 11:29:
>> >>
>> >> On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
>> >>  wrote:
>> >> > Finally, I was wondering if it could be an idea to place all mapset
>> >> > related buttons (open / close / new / change mapset) at the bottom of
>> >> > the
>> >> > Modules dialogue and to add a "manage mapset access" button, which
>> >> > runs the
>> >> > mapset picker for modifying the search path (g.mapsets -s) there as
>> >> > well?
>> >> > One (I if you like) can add g.mapsets with the s-flag as a module (I
>> >> > tested
>> >> > "g.mapsets -s" in the QGIS-GRASS-plugin and it starts the GRASS
>> >> > dialogue
>> >> > successfully), but it is probably better to have this option a bit
>> >> > more
>> >> > prominent (as it might come in handy with the new multiple map input
>> >> > option)?
>> >>
>> >> I have added "Add/Remove mapset to/from search path" as new browser
>> >> actions in master. There are now also distinct icons for mapset, open
>> >> mapset and mapset in search path.
>> >>
>> >> Radim
>> >> ___
>> >> Qgis-developer mailing list
>> >> Qgis-developer@lists.osgeo.org
>> >> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>> >> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>> >
>> > --
>> > Alexandre Neto
>> > -
>> > @AlexNetoGeo
>> > http://sigsemgrilhetaswordpress.com
>> > http://gisunchained.wordpress.com
>
> --
> Alexandre Neto
> -
> @AlexNetoGeo
> http://sigsemgrilhetaswordpress.com
> http://gisunchained.wordpress.com
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Alexandre Neto]

Ok thanks.

 I will update the documentation then. Because right in the beginning shows
all the icons. I can remove them, right?

Thanks again,

Alexandre

Radim Blazek  escreveu no dia segunda, 1/02/2016 às
09:56:

> On Fri, Jan 29, 2016 at 5:38 PM, Alexandre Neto 
> wrote:
> > I'm updating the Users Manual Figures. In my current installation of QGIS
> > master the GRASS Toolbar only features 2 Icons. Is this expected? I can
> only
> > see Open grass tools and Display current GRASS region Icons. We used to
> have
> > Open Mapset, Close Mapset, New Mapset and GRASS options as well.
>
> Yes it is intended. The tools which are not frequently used were
> removed from the toolbar to keep UI clean.
>
> Radim
>
> > Thanks
> >
> > Radim Blazek  escreveu no dia terça, 15/12/2015
> às
> > 11:29:
> >>
> >> On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
> >>  wrote:
> >> > Finally, I was wondering if it could be an idea to place all mapset
> >> > related buttons (open / close / new / change mapset) at the bottom of
> the
> >> > Modules dialogue and to add a "manage mapset access" button, which
> runs the
> >> > mapset picker for modifying the search path (g.mapsets -s) there as
> well?
> >> > One (I if you like) can add g.mapsets with the s-flag as a module (I
> tested
> >> > "g.mapsets -s" in the QGIS-GRASS-plugin and it starts the GRASS
> dialogue
> >> > successfully), but it is probably better to have this option a bit
> more
> >> > prominent (as it might come in handy with the new multiple map input
> >> > option)?
> >>
> >> I have added "Add/Remove mapset to/from search path" as new browser
> >> actions in master. There are now also distinct icons for mapset, open
> >> mapset and mapset in search path.
> >>
> >> Radim
> >> ___
> >> Qgis-developer mailing list
> >> Qgis-developer@lists.osgeo.org
> >> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> >> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> >
> > --
> > Alexandre Neto
> > -
> > @AlexNetoGeo
> > http://sigsemgrilhetaswordpress.com
> > http://gisunchained.wordpress.com
>
-- 
Alexandre Neto
-
@AlexNetoGeo
http://sigsemgrilhetaswordpress.com
http://gisunchained.wordpress.com
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Fri, Jan 29, 2016 at 5:38 PM, Alexandre Neto  wrote:
> I'm updating the Users Manual Figures. In my current installation of QGIS
> master the GRASS Toolbar only features 2 Icons. Is this expected? I can only
> see Open grass tools and Display current GRASS region Icons. We used to have
> Open Mapset, Close Mapset, New Mapset and GRASS options as well.

Yes it is intended. The tools which are not frequently used were
removed from the toolbar to keep UI clean.

Radim

> Thanks
>
> Radim Blazek  escreveu no dia terça, 15/12/2015 às
> 11:29:
>>
>> On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
>>  wrote:
>> > Finally, I was wondering if it could be an idea to place all mapset
>> > related buttons (open / close / new / change mapset) at the bottom of the
>> > Modules dialogue and to add a "manage mapset access" button, which runs the
>> > mapset picker for modifying the search path (g.mapsets -s) there as well?
>> > One (I if you like) can add g.mapsets with the s-flag as a module (I tested
>> > "g.mapsets -s" in the QGIS-GRASS-plugin and it starts the GRASS dialogue
>> > successfully), but it is probably better to have this option a bit more
>> > prominent (as it might come in handy with the new multiple map input
>> > option)?
>>
>> I have added "Add/Remove mapset to/from search path" as new browser
>> actions in master. There are now also distinct icons for mapset, open
>> mapset and mapset in search path.
>>
>> Radim
>> ___
>> Qgis-developer mailing list
>> Qgis-developer@lists.osgeo.org
>> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
> --
> Alexandre Neto
> -
> @AlexNetoGeo
> http://sigsemgrilhetaswordpress.com
> http://gisunchained.wordpress.com
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Alexandre Neto]

I'm updating the Users Manual Figures. In my current installation of QGIS
master the GRASS Toolbar only features 2 Icons. Is this expected? I can
only see Open grass tools and Display current GRASS region Icons. We used
to have Open Mapset, Close Mapset, New Mapset and GRASS options as well.

Thanks

Radim Blazek  escreveu no dia terça, 15/12/2015 às
11:29:

> On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
>  wrote:
> > Finally, I was wondering if it could be an idea to place all mapset
> related buttons (open / close / new / change mapset) at the bottom of the
> Modules dialogue and to add a "manage mapset access" button, which runs the
> mapset picker for modifying the search path (g.mapsets -s) there as well?
> One (I if you like) can add g.mapsets with the s-flag as a module (I tested
> "g.mapsets -s" in the QGIS-GRASS-plugin and it starts the GRASS dialogue
> successfully), but it is probably better to have this option a bit more
> prominent (as it might come in handy with the new multiple map input
> option)?
>
> I have added "Add/Remove mapset to/from search path" as new browser
> actions in master. There are now also distinct icons for mapset, open
> mapset and mapset in search path.
>
> Radim
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

-- 
Alexandre Neto
-
@AlexNetoGeo
http://sigsemgrilhetaswordpress.com
http://gisunchained.wordpress.com
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
 wrote:
> Finally, I was wondering if it could be an idea to place all mapset related 
> buttons (open / close / new / change mapset) at the bottom of the Modules 
> dialogue and to add a "manage mapset access" button, which runs the mapset 
> picker for modifying the search path (g.mapsets -s) there as well? One (I if 
> you like) can add g.mapsets with the s-flag as a module (I tested "g.mapsets 
> -s" in the QGIS-GRASS-plugin and it starts the GRASS dialogue successfully), 
> but it is probably better to have this option a bit more prominent (as it 
> might come in handy with the new multiple map input option)?

I have added "Add/Remove mapset to/from search path" as new browser
actions in master. There are now also distinct icons for mapset, open
mapset and mapset in search path.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,


> Yes, it is now intended for two reasons. First, it could be confusing
> for user if some maps were missing from input list. Second is
> technical, to get list of layers in vector map may be time consuming,
> the info must be read from the map (which was not the case with < 2.11
> where only layers in canvas were listed).
>
> All vector maps are listed in map input widget, but only the types
> specified by typemask will be offered for selection (if there are more
> than one) under the input widget. If selected vector does not contain
> any layer of specified type, a warning dialog opens when module is
> run.
>
>
Right, I think it's ok this way!



> > Another question, I would like to include v.to.3d in QGIS-GRASS. To do
> that,
> > I separated it in three different modules: v.to.3d.fixed (fixed height
> for
> > 3D vector features), v.to.3d.attr (attribute column used for height) and
> > v.to.2d (reverse transformation). Do you think this can be merged now,
> > during feature freeze, since it is nothing that can corrupt anything, or
> > should I make a pull request now and you check and merge after the end of
> > feature freeze?
>
> In general it is new feature, but in this little amount, I think that
> it can be accepted, it cannot break anything, if default.qgm is a
> valid xml. In any case, test well before you create pull request and
> after it gets merged.
>
>

I've tested in several ways, and I think it works:

https://github.com/qgis/QGIS/pull/2393


Thanks again Radim!

Pedro



> Radim
>
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

>> It
> >> is compiled with LFS, which adds -D_LARGEFILE_SOURCE
> >> -D_FILE_OFFSET_BITS=64 compiler flags. Try to add -D_LARGEFILE_SOURCE
> >> -D_FILE_OFFSET_BITS=64 to QGIS cmake CXX_EXTRA_FLAGS
> >
> > With this flags it also works without problems!
>
> I added check for _FILE_OFFSET_BITS in Make/Platform.h, now it should
> compile correctly without manually setting CXX_EXTRA_FLAGS. Configure
> should print:
>
> -- Found GRASS 7: /usr/lib/grass70/ (7.0.2RC1, off_t size = 8)
>
>

It works Radim! Thanks!!
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Wed, Oct 21, 2015 at 10:04 PM, Pedro Venâncio
 wrote:
> Hi again Radim,
>
> I was looking at typemask Option tag, and his definition says "for vector
> input option defines allowed types. Only the layers of one of defined type
> are displayed in input", but at this moment, all types are displayed in the
> input dropdown list. Is this intended, or is just a side effect of show all
> layers of the mapset in dropdown?

Yes, it is now intended for two reasons. First, it could be confusing
for user if some maps were missing from input list. Second is
technical, to get list of layers in vector map may be time consuming,
the info must be read from the map (which was not the case with < 2.11
where only layers in canvas were listed).

All vector maps are listed in map input widget, but only the types
specified by typemask will be offered for selection (if there are more
than one) under the input widget. If selected vector does not contain
any layer of specified type, a warning dialog opens when module is
run.

> Another question, I would like to include v.to.3d in QGIS-GRASS. To do that,
> I separated it in three different modules: v.to.3d.fixed (fixed height for
> 3D vector features), v.to.3d.attr (attribute column used for height) and
> v.to.2d (reverse transformation). Do you think this can be merged now,
> during feature freeze, since it is nothing that can corrupt anything, or
> should I make a pull request now and you check and merge after the end of
> feature freeze?

In general it is new feature, but in this little amount, I think that
it can be accepted, it cannot break anything, if default.qgm is a
valid xml. In any case, test well before you create pull request and
after it gets merged.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Wed, Oct 21, 2015 at 8:33 PM, Pedro Venâncio
 wrote:
>> It
>> is compiled with LFS, which adds -D_LARGEFILE_SOURCE
>> -D_FILE_OFFSET_BITS=64 compiler flags. Try to add -D_LARGEFILE_SOURCE
>> -D_FILE_OFFSET_BITS=64 to QGIS cmake CXX_EXTRA_FLAGS
>
> With this flags it also works without problems!

I added check for _FILE_OFFSET_BITS in Make/Platform.h, now it should
compile correctly without manually setting CXX_EXTRA_FLAGS. Configure
should print:

-- Found GRASS 7: /usr/lib/grass70/ (7.0.2RC1, off_t size = 8)

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi again Radim,

I was looking at typemask Option tag, and his definition says "for vector
input option defines allowed types. Only the layers of one of defined type
are displayed in input", but at this moment, all types are displayed in the
input dropdown list. Is this intended, or is just a side effect of show all
layers of the mapset in dropdown?

Another question, I would like to include v.to.3d in QGIS-GRASS. To do
that, I separated it in three different modules: v.to.3d.fixed (fixed
height for 3D vector features), v.to.3d.attr (attribute column used for
height) and v.to.2d (reverse transformation). Do you think this can be
merged now, during feature freeze, since it is nothing that can corrupt
anything, or should I make a pull request now and you check and merge after
the end of feature freeze?

Thanks!
Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,



You are using 32bits version
> grass7-dev_7.0.2RC1-1~ubuntu14.04.1_i386.deb from
> https://launchpad.net/~grass/+archive/ubuntu/grass-stable, right?


Exactly.




> It
> is compiled with LFS, which adds -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 compiler flags. Try to add -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 to QGIS cmake CXX_EXTRA_FLAGS


With this flags it also works without problems!

Thanks Radim!
Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Wed, Oct 21, 2015 at 12:56 AM, Pedro Venâncio
 wrote:
> I installed GRASS 7.0.2RC today, tested and this is still true:
>>
>> I made this change and with qint64 (typedef qint64 grass_off_t;) QGIS does
>> not crash,
>>
>> With typedef qint32 grass_off_t it still crashes.
>
> Make this change before compiling is very simple to me, but may this become
> a problem when packages for version 2.12 will be released? Or will depend on
> who build these binaries, that needs to make sure QGIS and GRASS are
> compiled with same off_t size?

You are using 32bits version
grass7-dev_7.0.2RC1-1~ubuntu14.04.1_i386.deb from
https://launchpad.net/~grass/+archive/ubuntu/grass-stable, right? It
is compiled with LFS, which adds -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 compiler flags. Try to add -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 to QGIS cmake CXX_EXTRA_FLAGS  instead of
manually changing grass_off_t.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,


3D editing was broken,
> fixed in 295d64b.
> Now it is also possible to edit z coordinates in vertex editor.
>
>
Great, fix confirmed! Thanks again!


I installed GRASS 7.0.2RC today, tested and this is still true:

>
> I made this change and with qint64 (typedef qint64 grass_off_t;) QGIS does
> not crash,
> 
>
> With typedef qint32 grass_off_t it still crashes.
>
>
Make this change before compiling is very simple to me, but may this become
a problem when packages for version 2.12 will be released? Or will depend
on who build these binaries, that needs to make sure QGIS and GRASS are
compiled with same off_t size?


Thanks Radim,
Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Tue, Oct 20, 2015 at 1:16 AM, Pedro Venâncio
 wrote:
> But I think I found a pattern in the problem. Using qint64, it only happens
> with 3d layers. With 2d layers, or converting layers 3d to 2d, it works ok.

Very good analysis of the problem, thanks. 3D editing was broken,
fixed in 295d64b.
Now it is also possible to edit z coordinates in vertex editor.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

> But I think I found a pattern in the problem. Using qint64, it only
> happens with 3d layers. With 2d layers, or converting layers 3d to 2d, it
> works ok.
>
>
I tested with the line with 2 vertices:

ORGANIZATION:
DIGIT DATE:
DIGIT NAME:   pedro
MAP NAME:
MAP DATE: Mon Oct 19 22:50:09 2015
MAP SCALE:1
OTHER INFO:
ZONE: 0
MAP THRESH:   0.00
VERTI:
L  2 1
 24882.53560915 98945.88447038
 61983.02003822 107847.51076796
 1 1


converted to 3d (v.drape):

ORGANIZATION:
DIGIT DATE:
DIGIT NAME:   pedro
MAP NAME:
MAP DATE: Mon Oct 19 22:50:09 2015
MAP SCALE:1
OTHER INFO:
ZONE: 0
MAP THRESH:   0.00
VERTI:
L  2 1
 24882.53560915 98945.88447038 460
 61983.02003822 107847.51076796 473
 1 1


and moving 1 vertex (the line disappears):

ORGANIZATION:
DIGIT DATE:
DIGIT NAME:   pedro
MAP NAME:
MAP DATE: Mon Oct 19 22:50:09 2015
MAP SCALE:1
OTHER INFO:
ZONE: 0
MAP THRESH:   0.00
VERTI:
L  0 1
 1 1


Best regards,
Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,



> If the same happens with GRASS6, the problem is not related to off_t size.
>
> Could you try to:
> - create new line layer
> - digitize line with 2 vertices
> - close editing (save changes)
> - start editing
> - move 1 vertex
> - close editing (save changes)
>

I did this with no crash or problem.




> - run in grass shell: v.out.ascii format=standard input=
>
> and post the output of v.out.ascii here?
>
>
ORGANIZATION:
DIGIT DATE:
DIGIT NAME:   pedro
MAP NAME:
MAP DATE: Mon Oct 19 22:50:09 2015
MAP SCALE:1
OTHER INFO:
ZONE: 0
MAP THRESH:   0.00
VERTI:
L  2 1
 24882.53560915 98945.88447038
 61983.02003822 107847.51076796
 1 1


Same result using GRASS6:

ORGANIZATION:
DIGIT DATE:
DIGIT NAME:   pedro
MAP NAME:
MAP DATE: Mon Oct 19 23:00:08 2015
MAP SCALE:1
OTHER INFO:
ZONE: 0
MAP THRESH:   0.00
VERTI:
L  2 1
 20359.68858131 88549.20415225
 83729.30795848 109464.91349481
 1 1


But I think I found a pattern in the problem. Using qint64, it only happens
with 3d layers. With 2d layers, or converting layers 3d to 2d, it works ok.

Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Sun, Oct 18, 2015 at 6:48 PM, Pedro Venâncio
 wrote:
>> It is most probably the problem with different off_t size in GRASS and
>> QGIS. I have already implemented fix, but the problem is how to get
>> real off_t size from GRASS. On Windows, it is now hard coded 8 bytes.
>> build_off_t_size was added to g.version but it will but available in
>> 7.1. For now, you have to ensure that QGIS and GRASS are compiled with
>> the same off_t size (I am not sure how) or change in
>> qgsgrassprovider.cpp
>>   typedef off_t grass_off_t;
>> to
>>   typedef qint32 grass_off_t;
>> or
>>   typedef qint64 grass_off_t;
>> according to the size used in GRASS.
>>
>
> I made this change and with qint64 (typedef qint64 grass_off_t;) QGIS does
> not crash, but the geometry just disappears after editing. Please see here:
>
> https://dl.dropboxusercontent.com/u/5772257/qgis/grass_node_tool.ogv
>
> The same is happening with GRASS6.

If the same happens with GRASS6, the problem is not related to off_t size.

Could you try to:
- create new line layer
- digitize line with 2 vertices
- close editing (save changes)
- start editing
- move 1 vertex
- close editing (save changes)
- run in grass shell: v.out.ascii format=standard input=

and post the output of v.out.ascii here?

Radim


> With typedef qint32 grass_off_t it still crashes.
>
> I'm using GRASS 7.0.1-2~ubuntu14.04.1 from
> https://launchpad.net/~grass/+archive/ubuntu/grass-stable
> and GRASS 6.4.3-3 from http://packages.ubuntu.com/trusty/grass
> on Xubuntu 14.04 LTS.
>
> Thanks!
> Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,



> It is most probably the problem with different off_t size in GRASS and
> QGIS. I have already implemented fix, but the problem is how to get
> real off_t size from GRASS. On Windows, it is now hard coded 8 bytes.
> build_off_t_size was added to g.version but it will but available in
> 7.1. For now, you have to ensure that QGIS and GRASS are compiled with
> the same off_t size (I am not sure how) or change in
> qgsgrassprovider.cpp
>   typedef off_t grass_off_t;
> to
>   typedef qint32 grass_off_t;
> or
>   typedef qint64 grass_off_t;
> according to the size used in GRASS.
>
>
I made this change and with qint64 (typedef qint64 grass_off_t;) QGIS does
not crash, but the geometry just disappears after editing. Please see here:

https://dl.dropboxusercontent.com/u/5772257/qgis/grass_node_tool.ogv

The same is happening with GRASS6.

With typedef qint32 grass_off_t it still crashes.

I'm using GRASS 7.0.1-2~ubuntu14.04.1 from
https://launchpad.net/~grass/+archive/ubuntu/grass-stable
and GRASS 6.4.3-3 from http://packages.ubuntu.com/trusty/grass
on Xubuntu 14.04 LTS.

Thanks!
Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Sat, Oct 17, 2015 at 8:47 AM, m roy  wrote:
>
>
> Il 15/10/2015 13.25, Radim Blazek ha scritto:
>> On Thu, Oct 15, 2015 at 10:49 AM, m roy  wrote:
>>
>>> After some quick vector digitizing tests: awesome tool
>>> for QGIS !!
>>>
>>> the only (minor) issue i found is that area boundary color does not
>>> match the simbology settings (e.g. green boundary also if it's not
>>> shared by two areas)
>> Green means that both sides are topologically correct. If there is no
>> area outside a ring, it is correct. Try to attach a dangling boundary
>> to the ring and it should become orange.
>> Maybe the name in symbology is not precise.
>>
>> Radim
>
> I think it's better to stick with GRASS symbology convention,
> otherwise it's quite confusing if you use both systems;
>
> e.g. consider the *isle* below
>
> ++o++
> +  *  +
> +  *  +
> ++o++
>
> + area on one side (of the boundary) e.g. orange
>
> * area on both sides, e.g. green

In the meantime, I have divided boundary with area on one side into
two symbols, so that it is possible to show visually which side is
broken. The style is left the same for now, because I am not sure
which is the best (parallel lines with different color, red markers
with offset to broken area...) but user can set his own style. I have
also renamed the symbols:
  * Boundary (topological error on both sides
  * Boundary (topological error on the left side)
  * Boundary (topological error on the right side)
  * Boundary (correct)

I believe that if a boundary is topologically incorrect, even on one
side and even if the chain is broken in another place,  it should be
visualized. Your argument about consistency with GRASS is important,
but in this case, I'll probably resist.

BTW, try this in GRASS:

+++
++
+++o++ +
++  *++
++  *++
+++o++ +
++
+++

Does it still make sense for the boundaries of inner areas?

> there seems to be some problem with the symbology while
> in edit mode, some how all boundaries disappear at some
> point, but if you exit edit mode and save everything is ok

New boundaries digitized in this session or old boundaries which were
present in the map before editing started or both. Are you able to
describe "at some point" with reproducible steps? If it happens again,
try to look into attribute table and check topo_symbol, select a
record and check if it is highlighted in the map and open attribute
form and check topo symbol there.

Thanks
Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Fri, Oct 16, 2015 at 11:47 PM, Blumentrath, Stefan
 wrote:
> Hi Radim,
>
> Another issue:
> The temporal maps are not listed in the input widgets. I assume that a 
> "translation" for GRASS parser options 
> (https://grass.osgeo.org/programming7/parser__standard__options_8c.html) to 
> the QGIS GUI is missing for the temporal modules:
> G_OPT_STDS_INPUT
> G_OPT_STDS_INPUTS
> G_OPT_STDS_OUTPUT ...

Fixed. Unfortunately t.list, which is the only way to get list of
temporal datasets is too slow. I asked in GRASS list:
https://lists.osgeo.org/pipermail/grass-dev/2015-October/076881.html

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Fri, Oct 16, 2015 at 8:49 PM, Pedro Venâncio
 wrote:
> Hi Radim,I've just compile qgis and I'm getting this Segmentation fault,
> when editing a GRASS layer (point, line or polygon) with Node Tool:

It is most probably the problem with different off_t size in GRASS and
QGIS. I have already implemented fix, but the problem is how to get
real off_t size from GRASS. On Windows, it is now hard coded 8 bytes.
build_off_t_size was added to g.version but it will but available in
7.1. For now, you have to ensure that QGIS and GRASS are compiled with
the same off_t size (I am not sure how) or change in
qgsgrassprovider.cpp
  typedef off_t grass_off_t;
to
  typedef qint32 grass_off_t;
or
  typedef qint64 grass_off_t;
according to the size used in GRASS.

Radim

> Program received signal SIGSEGV, Segmentation fault.
> 0xb51e7c4a in _IO_vfprintf_internal (s=s@entry=0xbffa6fd0,
> format=,
> format@entry=0x92c09ea8 "Unable to rewrite feature/offset %lu in vector
> map <%s>", ap=ap@entry=0xbffa88e4 "\001") at vfprintf.c:2047
> 2047vfprintf.c: Ficheiro ou directoria inexistente.
> (gdb) bt
> #0  0xb51e7c4a in _IO_vfprintf_internal (s=s@entry=0xbffa6fd0,
> format=,
> format@entry=0x92c09ea8 "Unable to rewrite feature/offset %lu in vector
> map <%s>", ap=ap@entry=0xbffa88e4 "\001") at vfprintf.c:2047
> #1  0xb529af01 in ___vsprintf_chk (
> s=0xbffa70cc "Unable to rewrite feature/offset 1 in vector map
> , flags=1,
> slen=2000,
> format=0x92c09ea8 "Unable to rewrite feature/offset %lu in vector map
> <%s>", args=0xbffa88e4 "\001") at vsprintf_chk.c:84
> #2  0x92c23812 in ?? () from /usr/lib/grass70/lib/libgrass_gis.so
> #3  0x92c24007 in G_warning () from /usr/lib/grass70/lib/libgrass_gis.so
> #4  0x92bf4db5 in Vect_rewrite_line ()
>from /usr/lib/grass70/lib/libgrass_vector.so
> #5  0x92cb9da5 in QgsGrassProvider::rewriteLine (this=0xcc35bc8, oldLid=1,
> type=2, Points=0xc633520, Cats=0x9bbd0c8)
> at
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 15/10/2015 13.25, Radim Blazek ha scritto:
> On Thu, Oct 15, 2015 at 10:49 AM, m roy  wrote:
>
>> After some quick vector digitizing tests: awesome tool
>> for QGIS !!
>>
>> the only (minor) issue i found is that area boundary color does not
>> match the simbology settings (e.g. green boundary also if it's not
>> shared by two areas)
> Green means that both sides are topologically correct. If there is no
> area outside a ring, it is correct. Try to attach a dangling boundary
> to the ring and it should become orange.
> Maybe the name in symbology is not precise.
>
> Radim

I think it's better to stick with GRASS symbology convention,
otherwise it's quite confusing if you use both systems;

e.g. consider the *isle* below

++o++
+  *  +
+  *  +
++o++

+ area on one side (of the boundary) e.g. orange

* area on both sides, e.g. green


  also
there seems to be some problem with the symbology while
in edit mode, some how all boundaries disappear at some
point, but if you exit edit mode and save everything is ok

Thanks, Roy.

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Blumentrath, Stefan]

Hi Radim,

Another issue:
The temporal maps are not listed in the input widgets. I assume that a 
"translation" for GRASS parser options 
(https://grass.osgeo.org/programming7/parser__standard__options_8c.html) to the 
QGIS GUI is missing for the temporal modules:
G_OPT_STDS_INPUT
G_OPT_STDS_INPUTS
G_OPT_STDS_OUTPUT ...

Not essential, but makes them easier to use...

Kind regards
Stefan


-Original Message-
From: qgis-developer-boun...@lists.osgeo.org 
[mailto:qgis-developer-boun...@lists.osgeo.org] On Behalf Of Radim Blazek
Sent: 6. oktober 2015 13:42
To: Paolo Cavallini 
Cc: qgis-developer 
Subject: Re: [Qgis-developer] New GRASS plugin: a test drive

On Tue, Oct 6, 2015 at 8:12 AM, Paolo Cavallini  wrote:
>>> yes - I tried, but the newly added polygon etc is not displayed once 
>>> digitized. Oh, now I see: the custom grass symbology prevents me 
>>> from seeing it. Once moved to single symbol, it is displayed.
>>
>>> I confirm an issue: I load a layer, activate editing, the layer is 
>>> no longer visible. When editing is deactivated, the layer remains invisible.
>>
>> There was a bug which I introduced on Friday, it was fixed in b09877b.
>> The style must be set (automatically) to GRASS Edit to get 
>> topological symbology.
>
> I still see the issue on current Debian sid package, just upgraded.

Which revision? Please use current master if possible.

Please start with points and lines. When you digitize a point or line, nothing 
is displayed in canvas? Do you see the elements if you switch style to default? 
Do you see the features in attribute table? Are the elements written to the map 
when you close editing?

 Note that QGIS can only display features of one type in a layer, if you add 
point layer and digitize a line, it will no show in point layer after editing 
is closed, a new layer with lines must be added to canvas.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,I've just compile qgis and I'm getting this Segmentation fault,
when editing a GRASS layer (point, line or polygon) with Node Tool:


[New Thread 0x8ccd1b40 (LWP 11639)]
[Thread 0x8ccd1b40 (LWP 11639) exited]

Program received signal SIGSEGV, Segmentation fault.
0xb51e7c4a in _IO_vfprintf_internal (s=s@entry=0xbffa6fd0,
format=,
format@entry=0x92c09ea8 "Unable to rewrite feature/offset %lu in vector
map <%s>", ap=ap@entry=0xbffa88e4 "\001") at vfprintf.c:2047
2047vfprintf.c: Ficheiro ou directoria inexistente.
(gdb) bt
#0  0xb51e7c4a in _IO_vfprintf_internal (s=s@entry=0xbffa6fd0,
format=,
format@entry=0x92c09ea8 "Unable to rewrite feature/offset %lu in vector
map <%s>", ap=ap@entry=0xbffa88e4 "\001") at vfprintf.c:2047
#1  0xb529af01 in ___vsprintf_chk (
s=0xbffa70cc "Unable to rewrite feature/offset 1 in vector map
, flags=1,
slen=2000,
format=0x92c09ea8 "Unable to rewrite feature/offset %lu in vector map
<%s>", args=0xbffa88e4 "\001") at vsprintf_chk.c:84
#2  0x92c23812 in ?? () from /usr/lib/grass70/lib/libgrass_gis.so
#3  0x92c24007 in G_warning () from /usr/lib/grass70/lib/libgrass_gis.so
#4  0x92bf4db5 in Vect_rewrite_line ()
   from /usr/lib/grass70/lib/libgrass_vector.so
#5  0x92cb9da5 in QgsGrassProvider::rewriteLine (this=0xcc35bc8, oldLid=1,
type=2, Points=0xc633520, Cats=0x9bbd0c8)
at
/home/pedro/qgis/QGIS-master/src/providers/grass/qgsgrassprovider.cpp:763
#6  0x92cc204a in QgsGrassProvider::onGeometryChanged (this=0xcc35bc8,
fid=11, geom=...)
at
/home/pedro/qgis/QGIS-master/src/providers/grass/qgsgrassprovider.cpp:1616
#7  0x92ce9698 in QgsGrassProvider::qt_static_metacall (_o=0xcc35bc8,
_c=QMetaObject::InvokeMetaMethod, _id=3, _a=0xbffa8b54)
---Type  to continue, or q  to quit---
at
/home/pedro/qgis/QGIS-master/build-master/src/providers/grass/7/__/moc_qgsgrassprovider.cxx:74
#8  0xb60970f7 in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
#9  0xb6e9e02b in QgsVectorLayerEditBuffer::geometryChanged
(this=0xc5bda68,
_t1=11, _t2=...)
at
/home/pedro/qgis/QGIS-master/build-master/src/core/moc_qgsvectorlayereditbuffer.cxx:163
#10 0xb6d13586 in QgsVectorLayerUndoCommandChangeGeometry::redo (
this=0xc5942b8)
at
/home/pedro/qgis/QGIS-master/src/core/qgsvectorlayerundocommand.cpp:216
#11 0xb5c70ed5 in QUndoStack::push(QUndoCommand*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#12 0xb6cf8373 in QgsVectorLayerEditBuffer::changeGeometry (this=0xc5bda68,
fid=11, geom=0xbffa8c78)
at
/home/pedro/qgis/QGIS-master/src/core/qgsvectorlayereditbuffer.cpp:182
#13 0xb6cfcd8e in QgsVectorLayerEditUtils::moveVertex (this=0xbffa8d2c,
p=...,
atFeatureId=11, atVertex=2)
at /home/pedro/qgis/QGIS-master/src/core/qgsvectorlayereditutils.cpp:82
#14 0xb6cdb232 in QgsVectorLayer::moveVertex (this=0xcc09c40, p=...,
atFeatureId=11, atVertex=2)
at /home/pedro/qgis/QGIS-master/src/core/qgsvectorlayer.cpp:1026
#15 0xb734e8f9 in QgsSelectedFeature::moveSelectedVertexes (this=0xd1f25a8,
---Type  to continue, or q  to quit---
v=...)
at
/home/pedro/qgis/QGIS-master/src/app/nodetool/qgsselectedfeature.cpp:341
#16 0xb734877e in QgsMapToolNodeTool::canvasReleaseEvent (this=0x9e8c900,
e=0xd01ad28)
at
/home/pedro/qgis/QGIS-master/src/app/nodetool/qgsmaptoolnodetool.cpp:396
#17 0xb65a245d in QgsMapCanvas::mouseReleaseEvent (this=0x9c32a58,
e=0xbffa93d4) at
/home/pedro/qgis/QGIS-master/src/gui/qgsmapcanvas.cpp:1315
#18 0xb55e840a in QWidget::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#19 0xb59ee91c in QFrame::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#20 0xb5a7cfd8 in QAbstractScrollArea::viewportEvent(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#21 0xb5c342b7 in QGraphicsView::viewportEvent(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#22 0xb5a7d256 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#23 0xb6081fbe in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
() from /usr/lib/i386-linux-gnu/libQtCore.so.4
#24 0xb558e7d1 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#25 0xb5596ea0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#26 0xb6ac61b9 in QgsApplication::notify (this=0xbffa9b74,
receiver=0x9c45800,
---Type  to continue, or q  to quit---
event=0xbffa93d4)
at /home/pedro/qgis/QGIS-master/src/core/qgsapplication.cpp:269
#27 0xb6081e4a in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtCore.so.4
#28 0xb5594b53 in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#29 0xb56187a8 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#30 0xb5617ef5 in QAppl

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 15, 2015 at 10:49 AM, m roy  wrote:
>>> Vector digitizing: QGIS crash when deleting a line and the layer
>>> is not longer loadable in QGIS because of broken topology,
>> Fixed, it was the different off_t size in GRASS and QGIS on Windows.
>> It should work in the next nightly build 2.11.0-90.
>>
> After some quick vector digitizing tests: awesome tool
> for QGIS !!
>
> the only (minor) issue i found is that area boundary color does not
> match the simbology settings (e.g. green boundary also if it's not
> shared by two areas)

Green means that both sides are topologically correct. If there is no
area outside a ring, it is correct. Try to attach a dangling boundary
to the ring and it should become orange.
Maybe the name in symbology is not precise.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 14/10/2015 19.01, Radim Blazek ha scritto:
> On Thu, Oct 8, 2015 at 1:07 PM, m roy  wrote:
>> Vector digitizing: QGIS crash when deleting a line and the layer
>> is not longer loadable in QGIS because of broken topology,
> Fixed, it was the different off_t size in GRASS and QGIS on Windows.
> It should work in the next nightly build 2.11.0-90.
>
> Radim
After some quick vector digitizing tests: awesome tool
for QGIS !!

the only (minor) issue i found is that area boundary color does not
match the simbology settings (e.g. green boundary also if it's not
shared by two areas)

thanks, Roy.
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 14/10/2015 19.01, Radim Blazek ha scritto:
> On Thu, Oct 8, 2015 at 1:07 PM, m roy  wrote:
>> Vector digitizing: QGIS crash when deleting a line and the layer
>> is not longer loadable in QGIS because of broken topology,
> Fixed, it was the different off_t size in GRASS and QGIS on Windows.
> It should work in the next nightly build 2.11.0-90.
>
> Radim
I tested some rasters, and it works, thanks!
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 14/10/2015 19.01, Radim Blazek ha scritto:
> On Thu, Oct 8, 2015 at 1:07 PM, m roy  wrote:
>> Vector digitizing: QGIS crash when deleting a line and the layer
>> is not longer loadable in QGIS because of broken topology,
> Fixed, it was the different off_t size in GRASS and QGIS on Windows.
> It should work in the next nightly build 2.11.0-90.
>
> Radim
Thanks I'll update tomorrow and test again,
I notices you already changed the symbology now node and vertex
are different very nice !
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 1:07 PM, m roy  wrote:
> Vector digitizing: QGIS crash when deleting a line and the layer
> is not longer loadable in QGIS because of broken topology,

Fixed, it was the different off_t size in GRASS and QGIS on Windows.
It should work in the next nightly build 2.11.0-90.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 4:52 PM, m roy  wrote:
>> Rasters are corrupted on Windows?
> yes on windows, sorry, i forgot to state that clearly;
> I mean the raster is *not really corrupted*, it just looks weird.

Fixed. It was really the text mode output once more, introduced by
bulk WIN32 to Q_OS_WIN update.

It should work in the next nightly build 2.11.0-90.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 12/10/2015 20.51, Pedro Venâncio ha scritto:


2015-10-12 19:15 GMT+01:00 Pedro Venâncio 
mailto:pedrongvenan...@gmail.com>>:
Maybe this was already fixed:

https://github.com/qgis/QGIS/commit/de8b045b2647b6ceb9ca2f34e729c549419d101a

I will compile again and check.



I confirm, this is already fixed.

Well ... that was quick!
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

2015-10-12 19:15 GMT+01:00 Pedro Venâncio :

> Maybe this was already fixed:
>
>
> https://github.com/qgis/QGIS/commit/de8b045b2647b6ceb9ca2f34e729c549419d101a
>
> I will compile again and check.
>
>
>
I confirm, this is already fixed.
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Maybe this was already fixed:

https://github.com/qgis/QGIS/commit/de8b045b2647b6ceb9ca2f34e729c549419d101a

I will compile again and check.



2015-10-12 19:07 GMT+01:00 Pedro Venâncio :

>
>
>
>> > QGIS crashes when you select "Marker line" in symbol layer type right
>> away,
>> > not only with 'GRASS Edit' style also with default style on a
>> shapefile; so
>> > i think it's not related to GRASS plugin...
>>
>
>
> I confirm this seg fault:
>
> Program received signal SIGSEGV, Segmentation fault.
> 0xb6014f0a in QMetaObject::activate(QObject*, QMetaObject const*, int,
> void**)
> () from /usr/lib/i386-linux-gnu/libQtCore.so.4
> (gdb) bt
> #0  0xb6014f0a in QMetaObject::activate(QObject*, QMetaObject const*, int,
> void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
> #1  0xb593fe35 in QComboBox::currentIndexChanged(QString const&) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #2  0xb593fe96 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #3  0xb5940176 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #4  0xb59402c3 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #5  0xb59429fa in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #6  0xb60150f7 in QMetaObject::activate(QObject*, QMetaObject const*, int,
> void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
> #7  0xb5c0a695 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #8  0xb593acf4 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #9  0xb5be in
> QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
> () from /usr/lib/i386-linux-gnu/libQtCore.so.4
> #10 0xb550c7d1 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #11 0xb5514ea0 in QApplication::notify(QObject*, QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #12 0xb6a467b3 in QgsApplication::notify (this=0xbf8cbba4,
> receiver=0xdbcd598,
> event=0xbf8c9a54)
> at /home/pedro/qgis/QGIS-master/src/core/qgsapplication.cpp:265
> #13 0xb5fffe4a in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtCore.so.4
> ---Type  to continue, or q  to quit---
> #14 0xb5512b53 in QApplicationPrivate::sendMouseEvent(QWidget*,
> QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #15 0xb5596bd0 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #16 0xb5595ef5 in QApplication::x11ProcessEvent(_XEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #17 0xb55c1554 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #18 0xb14111e3 in g_main_context_dispatch ()
>from /lib/i386-linux-gnu/libglib-2.0.so.0
> #19 0xb1411468 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
> #20 0xb1411528 in g_main_context_iteration ()
>from /lib/i386-linux-gnu/libglib-2.0.so.0
> #21 0xb602f93b in
> QEventDispatcherGlib::processEvents(QFlags)
> () from /usr/lib/i386-linux-gnu/libQtCore.so.4
> #22 0xb55c160e in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #23 0xb5ffe823 in
> QEventLoop::processEvents(QFlags) () from
> /usr/lib/i386-linux-gnu/libQtCore.so.4
> #24 0xb5ffeb49 in QEventLoop::exec(QFlags)
> ()
>from /usr/lib/i386-linux-gnu/libQtCore.so.4
> #25 0xb5a3d081 in QDialog::exec() () from
> /usr/lib/i386-linux-gnu/libQtGui.so.4
> #26 0xb633127c in
> QgsCategorizedSymbolRendererV2Widget::changeCategorizedSymbol
> (this=0xd28c168)
> at
> /home/pedro/qgis/QGIS-master/src/gui/symbology-ng/qgscategorizedsymbolren---Type
>  to continue, or q  to quit---
> dererv2widget.cpp:570
> #27 0xb65c480e in QgsCategorizedSymbolRendererV2Widget::qt_static_metacall
> (
> _o=0xd28c168, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0xbf8ca128)
> at
> /home/pedro/qgis/QGIS-master/build-master/src/gui/symbology-ng/moc_qgscategorizedsymbolrendererv2widget.cxx:153
> #28 0xb60150f7 in QMetaObject::activate(QObject*, QMetaObject const*, int,
> void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
> #29 0xb5c0926d in QAbstractButton::clicked(bool) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #30 0xb5923c21 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #31 0xb5924fa7 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #32 0xb59250ae in QAbstractButton::mouseReleaseEvent(QMouseEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #33 0xb556640a in QWidget::event(QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #34 0xb59260b2 in QAbstractButton::event(QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #35 0xb59c0c7c in QPushButton::event(QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #36 0xb550c7f4 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> #37 0xb5514ea0 in QApplication::notify(QObject*, QEvent*) ()
>from /usr/lib/i386-linux-gnu/libQtGui.so.4
> ---Type  to continue, or q  to quit---
> #38 0xb6a467b3 in QgsApplication::notify (this=0xbf8cbba4,
>

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

> > QGIS crashes when you select "Marker line" in symbol layer type right
> away,
> > not only with 'GRASS Edit' style also with default style on a shapefile;
> so
> > i think it's not related to GRASS plugin...
>


I confirm this seg fault:

Program received signal SIGSEGV, Segmentation fault.
0xb6014f0a in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**)
() from /usr/lib/i386-linux-gnu/libQtCore.so.4
(gdb) bt
#0  0xb6014f0a in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
#1  0xb593fe35 in QComboBox::currentIndexChanged(QString const&) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#2  0xb593fe96 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#3  0xb5940176 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#4  0xb59402c3 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#5  0xb59429fa in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#6  0xb60150f7 in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
#7  0xb5c0a695 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#8  0xb593acf4 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#9  0xb5be in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
() from /usr/lib/i386-linux-gnu/libQtCore.so.4
#10 0xb550c7d1 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#11 0xb5514ea0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#12 0xb6a467b3 in QgsApplication::notify (this=0xbf8cbba4,
receiver=0xdbcd598,
event=0xbf8c9a54)
at /home/pedro/qgis/QGIS-master/src/core/qgsapplication.cpp:265
#13 0xb5fffe4a in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtCore.so.4
---Type  to continue, or q  to quit---
#14 0xb5512b53 in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#15 0xb5596bd0 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#16 0xb5595ef5 in QApplication::x11ProcessEvent(_XEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#17 0xb55c1554 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#18 0xb14111e3 in g_main_context_dispatch ()
   from /lib/i386-linux-gnu/libglib-2.0.so.0
#19 0xb1411468 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#20 0xb1411528 in g_main_context_iteration ()
   from /lib/i386-linux-gnu/libglib-2.0.so.0
#21 0xb602f93b in
QEventDispatcherGlib::processEvents(QFlags)
() from /usr/lib/i386-linux-gnu/libQtCore.so.4
#22 0xb55c160e in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#23 0xb5ffe823 in
QEventLoop::processEvents(QFlags) () from
/usr/lib/i386-linux-gnu/libQtCore.so.4
#24 0xb5ffeb49 in QEventLoop::exec(QFlags) ()
   from /usr/lib/i386-linux-gnu/libQtCore.so.4
#25 0xb5a3d081 in QDialog::exec() () from
/usr/lib/i386-linux-gnu/libQtGui.so.4
#26 0xb633127c in
QgsCategorizedSymbolRendererV2Widget::changeCategorizedSymbol
(this=0xd28c168)
at
/home/pedro/qgis/QGIS-master/src/gui/symbology-ng/qgscategorizedsymbolren---Type
 to continue, or q  to quit---
dererv2widget.cpp:570
#27 0xb65c480e in QgsCategorizedSymbolRendererV2Widget::qt_static_metacall (
_o=0xd28c168, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0xbf8ca128)
at
/home/pedro/qgis/QGIS-master/build-master/src/gui/symbology-ng/moc_qgscategorizedsymbolrendererv2widget.cxx:153
#28 0xb60150f7 in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
#29 0xb5c0926d in QAbstractButton::clicked(bool) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#30 0xb5923c21 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#31 0xb5924fa7 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#32 0xb59250ae in QAbstractButton::mouseReleaseEvent(QMouseEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#33 0xb556640a in QWidget::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#34 0xb59260b2 in QAbstractButton::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#35 0xb59c0c7c in QPushButton::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#36 0xb550c7f4 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#37 0xb5514ea0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
---Type  to continue, or q  to quit---
#38 0xb6a467b3 in QgsApplication::notify (this=0xbf8cbba4,
receiver=0xd26b4d0,
event=0xbf8ca614)
at /home/pedro/qgis/QGIS-master/src/core/qgsapplication.cpp:265
#39 0xb5fffe4a in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtCore.so.4
#40 0xb5512b53 in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) ()
   from /usr/lib/i386-

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Oct 12, 2015 at 7:45 PM, m roy  wrote:
>
>
> Il 12/10/2015 19.32, Radim Blazek ha scritto:
>> On Mon, Oct 12, 2015 at 6:33 PM, m roy  wrote:
> another issue I discovered while testing QGIS digitizer with GRASS vectors
> is that there is no difference between node and vertex, in GRASS they have
> two different "topological meaning"; as it is now you can't tell
> where to connect with a new boundary because of this.
 I think that the cleanest way to get nodes displayed will be to add
 first/last vertex marker line symbol in boundaries style, which you
 can try immediately if you change 'GRASS Edit' style.
>>> Nice idea, just tried, unfortunately QGIS crashes (on Windows) if i try
>>> to change line
>>> boundary to "Marker line";
>> With 'GRASS Edit' style only? When exactly? When you click Apply on style 
>> tab?
>>
> QGIS crashes when you select "Marker line" in symbol layer type right away,
> not only with 'GRASS Edit' style also with default style on a shapefile; so
> i think it's not related to GRASS plugin...

Please fill a new issue in bug tracker and mark it blocker.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 12/10/2015 19.32, Radim Blazek ha scritto:
> On Mon, Oct 12, 2015 at 6:33 PM, m roy  wrote:
 another issue I discovered while testing QGIS digitizer with GRASS vectors
 is that there is no difference between node and vertex, in GRASS they have
 two different "topological meaning"; as it is now you can't tell
 where to connect with a new boundary because of this.
>>> I think that the cleanest way to get nodes displayed will be to add
>>> first/last vertex marker line symbol in boundaries style, which you
>>> can try immediately if you change 'GRASS Edit' style.
>> Nice idea, just tried, unfortunately QGIS crashes (on Windows) if i try
>> to change line
>> boundary to "Marker line";
> With 'GRASS Edit' style only? When exactly? When you click Apply on style tab?
>
> Radim
QGIS crashes when you select "Marker line" in symbol layer type right away,
not only with 'GRASS Edit' style also with default style on a shapefile; so
i think it's not related to GRASS plugin...


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Oct 12, 2015 at 6:33 PM, m roy  wrote:
>>> another issue I discovered while testing QGIS digitizer with GRASS vectors
>>> is that there is no difference between node and vertex, in GRASS they have
>>> two different "topological meaning"; as it is now you can't tell
>>> where to connect with a new boundary because of this.
>> I think that the cleanest way to get nodes displayed will be to add
>> first/last vertex marker line symbol in boundaries style, which you
>> can try immediately if you change 'GRASS Edit' style.

> Nice idea, just tried, unfortunately QGIS crashes (on Windows) if i try
> to change line
> boundary to "Marker line";

With 'GRASS Edit' style only? When exactly? When you click Apply on style tab?

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 12/10/2015 17.12, Radim Blazek ha scritto:
> I think that the QGIS "Add Area" should be renamed to "Add closed boundary"
> (or something like that) because GRASS has the "Add Area" tool that in fact
> allow you to add boundary and centroid in one go;
> OK, if I don't manage to add centroid placement.

Yes of course :-)

>> another issue I discovered while testing QGIS digitizer with GRASS vectors
>> is that there is no difference between node and vertex, in GRASS they have
>> two different "topological meaning"; as it is now you can't tell
>> where to connect with a new boundary because of this.
> I think that the cleanest way to get nodes displayed will be to add
> first/last vertex marker line symbol in boundaries style, which you
> can try immediately if you change 'GRASS Edit' style.
>
> Radim

Nice idea, just tried, unfortunately QGIS crashes (on Windows) if i try 
to change line
boundary to "Marker line";

BTW is it possible to install different versions of QGIS (e.g QGIS-LTR 
and MASTER)
on Ubuntu without compiling it?
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Oct 12, 2015 at 12:17 PM, m roy  wrote:
> Il 12/10/2015 10.06, Radim Blazek ha scritto:
>> The user must have some minimum knowledge about GRASS topological
>> model. Note that 'Add Area' makes only sense for isolated areas,
>> common boundaries of adjacent areas must be digitized by 'Add
>> Boundary' because the boundary is shared by areas on both sides.
>>
>> Radim
>>
>
> I think that the QGIS "Add Area" should be renamed to "Add closed boundary"
> (or something like that) because GRASS has the "Add Area" tool that in fact
> allow you to add boundary and centroid in one go;

OK, if I don't manage to add centroid placement.

> another issue I discovered while testing QGIS digitizer with GRASS vectors
> is that there is no difference between node and vertex, in GRASS they have
> two different "topological meaning"; as it is now you can't tell
> where to connect with a new boundary because of this.

I think that the cleanest way to get nodes displayed will be to add
first/last vertex marker line symbol in boundaries style, which you
can try immediately if you change 'GRASS Edit' style.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 12/10/2015 10.06, Radim Blazek ha scritto:
> The user must have some minimum knowledge about GRASS topological
> model. Note that 'Add Area' makes only sense for isolated areas,
> common boundaries of adjacent areas must be digitized by 'Add
> Boundary' because the boundary is shared by areas on both sides.
>
> Radim
>

I think that the QGIS "Add Area" should be renamed to "Add closed boundary"
(or something like that) because GRASS has the "Add Area" tool that in fact
allow you to add boundary and centroid in one go;

another issue I discovered while testing QGIS digitizer with GRASS vectors
is that there is no difference between node and vertex, in GRASS they have
two different "topological meaning"; as it is now you can't tell
where to connect with a new boundary because of this.

Thanks, Roy.
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 12/10/2015 10.06, Radim Blazek ha scritto:
> The user must have some minimum knowledge about GRASS topological
> model. Note that 'Add Area' makes only sense for isolated areas,
> common boundaries of adjacent areas must be digitized by 'Add
> Boundary' because the boundary is shared by areas on both sides.
>
> Radim
>

I think that the QGIS "Add Area" should be renamed to "Add closed boundary"
(or something like that) because GRASS has the "Add Area" tool that in fact
allow you to add boundary and centroid in one go;

another issue I discovered while testing QGIS digitizer with GRASS vectors
is that there is no difference between node and vertex, in GRASS they have
two different "topological meaning"; as it is now you can't tell
where to connect with a new boundary because of this.

Thanks, Roy.
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Sun, Oct 11, 2015 at 8:02 PM, Pedro Venâncio
 wrote:
>> > I also found that saving edits with "Save edits" button in the attribute
>> > tabel takes no effect. With other layers (not GRASS layers), it works
>> > well.
>>
>> It should not take any effect, because with GRASS, the data are
>> written immediately to file+table. Are you missing the data somewhere
>> the data are expected to appear after save edit?
>
> You are right, everything is automatically saved. But I think this question
> will certainly be raised by users in the future. Maybe it's something to
> explicitly place in the documentation.

Sure, I'll start the documentation with warning about this. The
documentation is on my TODO but I still prefer fixing bugs over doc.

> Or remove the Save button from attribute table of GRASS layers. Or put this
> button with the same behavior of Save Edits Layer from Digitizing Toolbar.
> In this case, although the data are already saved, the behavior is similar
> to saving other data sources (shapefiles, postgis, etc).

The 'Save Layer Edits' is now hidden from 'Digitizing Toolbar' but
'Save Edits' in attribute table is not currently accessible from
plugins.

>> The tool you used, 'Add Area' is just a shorthand to digitize closed
>> boundary (boundaries are line strings, not closed rings). Place a
>> centroid inside and you should see the polygon when editing is closed.
>
> Precisely, it works perfectly in this way. But it is not very intuitive.

The user must have some minimum knowledge about GRASS topological
model. Note that 'Add Area' makes only sense for isolated areas,
common boundaries of adjacent areas must be digitized by 'Add
Boundary' because the boundary is shared by areas on both sides.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

> Bullseye, fixed in d26765f.
>
>
Fix confirmed! Thanks again Radim!




> BTW, Pedro is supplying me with bug reports off list over a month, thanks
> Pedro.
>
>
Yes, I have been quite boring with you in the last weeks! But your work has
been excellent!




> > I also found that saving edits with "Save edits" button in the attribute
> > tabel takes no effect. With other layers (not GRASS layers), it works
> well.
>
> It should not take any effect, because with GRASS, the data are
> written immediately to file+table. Are you missing the data somewhere
> the data are expected to appear after save edit?
>

You are right, everything is automatically saved. But I think this question
will certainly be raised by users in the future. Maybe it's something to
explicitly place in the documentation.
Or remove the Save button from attribute table of GRASS layers. Or put this
button with the same behavior of Save Edits Layer from Digitizing Toolbar.
In this case, although the data are already saved, the behavior is similar
to saving other data sources (shapefiles, postgis, etc).




> The tool you used, 'Add Area' is just a shorthand to digitize closed
> boundary (boundaries are line strings, not closed rings). Place a
> centroid inside and you should see the polygon when editing is closed.
>

Precisely, it works perfectly in this way. But it is not very intuitive.




> I would like to add also automatic placement of centroid when 'Add
> Area' is used, but I don't know how yet, how to squash it to a single
> undo operation with the boundary.
>
>
That would be perfect! I hope you can come up with this solution!
If it is not possible for now, it may be something for future releases.



Thank you very much for your work Radim!

Best regards,
Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Fri, Oct 9, 2015 at 1:34 AM, Pedro Venâncio
 wrote:
> I'm getting problems with symbology of polygon layers. Please see the
> screencast.
>
> https://dl.dropboxusercontent.com/u/5772257/qgis/grass_edit_polygons.ogv
>
> Note also that attribute form pop-up does not show up after each feature
> creation on polygons.
>
> After this, if I remove that polygon layer from QGIS canvas/toc, and add
> again from browser, then the symbology is ok (but the cat field is gone):
>
> https://dl.dropboxusercontent.com/u/5772257/qgis/grass_edit_polygons_2.ogv
>
> I'm using QGIS master compiled after this commit
> https://github.com/qgis/QGIS/commit/e703fc6044e3119c3b59fe9648f7dcf7edc2b714

Polygons in GRASS are formed by boundaries and identified by centroids
- point like features keeping the attributes. Normally, you digitize
boundaries and then place centroids inside. Boundaries usually do not
have attributes, centroids usually do have attributes. Without placing
a centroid into an area, the area exists (in layer 0), but does not
have attributes and will not appear in currently edited layer (layer 1
in this case).

The tool you used, 'Add Area' is just a shorthand to digitize closed
boundary (boundaries are line strings, not closed rings). Place a
centroid inside and you should see the polygon when editing is closed.
I would like to add also automatic placement of centroid when 'Add
Area' is used, but I don't know how yet, how to squash it to a single
undo operation with the boundary.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Fri, Oct 9, 2015 at 1:11 AM, Pedro Venâncio
 wrote:
> Hi Radim,
>
> I'm getting a Segmentation fault (core dumped):
[...]
> To reproduce:
>
> 1. Open mapset;
> 2. New Point Layer or New Line Layer (I don't get crash with polygon
> layers);
> 3. Digitize some features;
> 4. Save edits;
> 5. Open attribute table;
> 6. New column;
> 7. Add a name;
> 8. Ok. I get the crash and seg fault here. Just with point and line layers.

Bullseye, fixed in d26765f.

BTW, Pedro is supplying me with bug reports off list over a month, thanks Pedro.

> I also found that saving edits with "Save edits" button in the attribute
> tabel takes no effect. With other layers (not GRASS layers), it works well.

It should not take any effect, because with GRASS, the data are
written immediately to file+table. Are you missing the data somewhere
the data are expected to appear after save edit?

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 10:47 PM, Blumentrath, Stefan
 wrote:
> Regarding the tools-widget UI, I noticed that the "Close Mapset" butten takes 
> space from the module tabs. The old "Close mapset" button was much smaller.

Which 'old' button?  I think that the button is the same since it was
added in 2.11.

> Would it be possible to move that to the bottom of the GRASS module UI, where 
> the Debug buttons are located (if debugging is activated)?

It would occupy one more line, debugging bar is usually hidden. I
could remove the text from the button to make it smaller, but I wanted
to express di difference between closing the widget and closing the
mapset.

> BTW, the tabs for the open modules can get pretty wide due to the icons (see 
> e.g. v.db.join). Maybe better to use module names in the tabs?

It is hard to decide, maybe optional?

> Finally, I was wondering if it could be an idea to place all mapset related 
> buttons (open / close / new / change mapset) at the bottom of the Modules 
> dialogue

'New mapset' is rarely used, and for an existing location it is much
easier to create new mapset from browser. 'Open mapset' is something
which I would like to remove completely, once user get used to opening
mapsets from the browser. It is the last old style open dialog (in <
2.10 it was used also for rasters/vectors).

When I was adding the 'Close button', I considered also other places,
like toolbar or menu above the tabs widget, but I think that an
application should not have preferably more menus/toolbars than the
main application-wide.

> and to add a "manage mapset access" button, which runs the mapset picker for 
> modifying the search path (g.mapsets -s) there as well? One (I if you like) 
> can add g.mapsets with the s-flag as a module (I tested "g.mapsets -s" in the 
> QGIS-GRASS-plugin and it starts the GRASS dialogue successfully), but it is 
> probably better to have this option a bit more prominent (as it might come in 
> handy with the new multiple map input option)?

My approach, since the plugin was introduced, is that we do not add a
GRASS modules since we have a decent, dedicated GUI in QGIS. That is
why I never liked things like nviz in QGIS. This approach was
partially overcome by reality and various hacks (IMO) requested by
users. In this case, I would really oppose to open GRASS GUI from
QGIS.

Maybe you manage to write a wrapper GRASS script for g.mapsets in
Python which fills 'mapset' options with existing mapsets and sets
'answer' to the mapsets in search path?

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 08/10/2015 18.23, Radim Blazek ha scritto:
> I have to debug on Windows. Does it happen with all data types (int,
> float, double)?
>
>
I have two raster type:

FCELL (float) : the raster loads but visualization is weird and the 
raster is stretched and broken in two

CELL (int): the raster does not load, the circle keeps spinning and i 
have to close QGIS
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 09/10/2015 09:11, Radim Blazek ha scritto:
> On Thu, Oct 8, 2015 at 7:00 PM, Paolo Cavallini  wrote:

>> https://hub.qgis.org/issues/8220 ?
> 
> Everybody can do it, I don't prevent others from work on browser.

of course, I just thought you were more efficient. I can try, but I
would need some guidance: could you?
Thanks  again.

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 7:00 PM, Paolo Cavallini  wrote:
> Il 08/10/2015 18:58, m roy ha scritto:
>>
>> Il 08/10/2015 18.23, Radim Blazek ha scritto:
>>> IMHO: i find it's confusing, and GRASS 7 default database is SQLite,
>>> i think it could be smoother to expose only GRASS Locations and Mapset
>>> being evident that we're dealing with a GRASS Database, but i can live
>>> with that :-)
>>> You are not the first who is confused. Fix would be easy, so I remove
>>> regular dir if it is recognized as GRASS location?
>
> Hi Radim,
> once you're there, could you please see if it is easy to fix also:
> https://hub.qgis.org/issues/8220 ?

Everybody can do it, I don't prevent others from work on browser.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi again Radim,




> Please start with points and lines. When you digitize a point or line,
> nothing is displayed in canvas? Do you see the elements if you switch
> style to default? Do you see the features in attribute table? Are the
> elements written to the map when you close editing?
>
>  Note that QGIS can only display features of one type in a layer, if
> you add point layer and digitize a line, it will no show in point
> layer after editing is closed, a new layer with lines must be added to
> canvas.
>
>

I'm getting problems with symbology of polygon layers. Please see the
screencast.

https://dl.dropboxusercontent.com/u/5772257/qgis/grass_edit_polygons.ogv

Note also that attribute form pop-up does not show up after each feature
creation on polygons.

After this, if I remove that polygon layer from QGIS canvas/toc, and add
again from browser, then the symbology is ok (but the cat field is gone):

https://dl.dropboxusercontent.com/u/5772257/qgis/grass_edit_polygons_2.ogv

I'm using QGIS master compiled after this commit
https://github.com/qgis/QGIS/commit/e703fc6044e3119c3b59fe9648f7dcf7edc2b714

Thank you very much Radim!

Pedro
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Pedro Venâncio]

Hi Radim,

I'm getting a Segmentation fault (core dumped):

[Thread 0x8b6c3b40 (LWP 8667) exited]
[Thread 0x6c2ffb40 (LWP 8668) exited]

Program received signal SIGSEGV, Segmentation fault.
0x92c2b869 in Vect_cidx_get_cat_by_index ()
   from /usr/lib/grass70/lib/libgrass_vector.so
(gdb) bt
#0  0x92c2b869 in Vect_cidx_get_cat_by_index ()
   from /usr/lib/grass70/lib/libgrass_vector.so
#1  0x92d38357 in QgsGrassVectorMapLayer::insertCats (this=0x14639448,
error=...)
at
/home/pedro/qgis/QGIS-master/src/providers/grass/qgsgrassvectormaplayer.cpp:796
#2  0x92d36265 in QgsGrassVectorMapLayer::createTable (this=0x14639448,
fields=
..., error=...)
at
/home/pedro/qgis/QGIS-master/src/providers/grass/qgsgrassvectormaplayer.cpp:646
#3  0x92d367f8 in QgsGrassVectorMapLayer::addColumn (this=0x14639448,
field=..., error=...)
at
/home/pedro/qgis/QGIS-master/src/providers/grass/qgsgrassvectormaplayer.cpp:666
#4  0x92d221aa in QgsGrassProvider::onAttributeAdded (this=0x11448cb0,
idx=2)
at
/home/pedro/qgis/QGIS-master/src/providers/grass/qgsgrassprovider.cpp:1725
#5  0x92d3e5c3 in QgsGrassProvider::qt_static_metacall (_o=0x11448cb0,
_c=QMetaObject::InvokeMetaMethod, _id=4, _a=0xbfdf2118)
at
/home/pedro/qgis/QGIS-master/build-master/src/providers/grass/7/__/moc_qgsgrassprovider.cxx:72
#6  0xb60d50f7 in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
---Type  to continue, or q  to quit---
#7  0xb6ee1fb0 in QgsVectorLayerEditBuffer::attributeAdded (this=0xc5df620,
_t1=2)
at
/home/pedro/qgis/QGIS-master/build-master/src/core/moc_qgsvectorlayereditbuffer.cxx:177
#8  0xb6d58dbd in QgsVectorLayerUndoCommandAddAttribute::redo
(this=0xcfc1480)
at
/home/pedro/qgis/QGIS-master/src/core/qgsvectorlayerundocommand.cpp:339
#9  0xb5caeed5 in QUndoStack::push(QUndoCommand*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#10 0xb6d3cf70 in QgsVectorLayerEditBuffer::addAttribute (this=0xc5df620,
field=...)
at
/home/pedro/qgis/QGIS-master/src/core/qgsvectorlayereditbuffer.cpp:227
#11 0xb6d27476 in QgsVectorLayer::addAttribute (this=0xad72720, field=...)
at /home/pedro/qgis/QGIS-master/src/core/qgsvectorlayer.cpp:2181
#12 0xb726aae1 in QgsAttributeTableDialog::on_mAddAttribute_clicked (
this=0x14956a48)
at /home/pedro/qgis/QGIS-master/src/app/qgsattributetabledialog.cpp:689
#13 0xb7599a0f in QgsAttributeTableDialog::qt_static_metacall
(_o=0x14956a48,
_c=QMetaObject::InvokeMetaMethod, _id=12, _a=0xbfdf2458)
at
/home/pedro/qgis/QGIS-master/build-master/src/app/moc_qgsattributetabledialog.cxx:131
#14 0xb7599d86 in QgsAttributeTableDialog::qt_metacall (this=0x14956a48,
_c=QMetaObject::InvokeMetaMethod, _id=12, _a=0xbfdf2458)
at
/home/pedro/qgis/QGIS-master/build-master/src/app/moc_qgsattributetabledi---Type
 to continue, or q  to quit---
alog.cxx:194
#15 0xb60c6e85 in QMetaObject::metacall(QObject*, QMetaObject::Call, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
#16 0xb60d540d in QMetaObject::activate(QObject*, QMetaObject const*, int,
void**) () from /usr/lib/i386-linux-gnu/libQtCore.so.4
#17 0xb5cc926d in QAbstractButton::clicked(bool) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#18 0xb59e3c21 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#19 0xb59e4fa7 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#20 0xb59e50ae in QAbstractButton::mouseReleaseEvent(QMouseEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#21 0xb5ab6977 in QToolButton::mouseReleaseEvent(QMouseEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#22 0xb562640a in QWidget::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#23 0xb59e60b2 in QAbstractButton::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#24 0xb5ab6a64 in QToolButton::event(QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#25 0xb55cc7f4 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#26 0xb55d4ea0 in QApplication::notify(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
---Type  to continue, or q  to quit---
#27 0xb6b051c7 in QgsApplication::notify (this=0xbfdf3104,
receiver=0xa901438,
event=0xbfdf2954)
at /home/pedro/qgis/QGIS-master/src/core/qgsapplication.cpp:265
#28 0xb60bfe4a in QCoreApplication::notifyInternal(QObject*, QEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtCore.so.4
#29 0xb55d2b53 in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#30 0xb56567a8 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#31 0xb5655ef5 in QApplication::x11ProcessEvent(_XEvent*) ()
   from /usr/lib/i386-linux-gnu/libQtGui.so.4
#32 0xb5681554 in ?? () from /usr/lib/i386-linux-gnu/libQtGui.so.4
#33 0xb14d11e3 in g_main_context_dispatch ()
   from /lib/i386-linux-gnu/libglib-2.0.so.0
#34 0xb14d1468 in ?? () fr

Re: [Qgis-developer] New GRASS plugin: a test drive

[Blumentrath, Stefan]

>> Testing on windows
 GRASS LOCATION is "duplicated" displayed as a regular file system 
 folder and as GRASS LOCATION with the GRASS icon
>>> That is correct, the regular directory is left there so that is it 
>>> possible to go for example to dbf directory and load dbf files as 
>>> standard QGIS layers.
>>
>> IMHO: i find it's confusing, and GRASS 7 default database is SQLite, i 
>> think it could be smoother to expose only GRASS Locations and Mapset 
>> being evident that we're dealing with a GRASS Database, but i can live 
>> with that :-)
>
>You are not the first who is confused. Fix would be easy, so I remove regular 
>dir if it is recognized as GRASS location?

Indeed having the whole folder browseable might be confusing and users are not 
supposed to move files around in there anyway.
Yet, having the SQLite DB (or dbfs) of a mapset (if existing) available in the 
browser would be nice. That way also related / non-spatial tables in there 
could be easily added to QGIS. Probably even better if a context menu entry 
would allow to add the DB to "DB manager", so one can actually run queries 
without using db.execute or v.db.update...  But that`s for the future...

Regarding the tools-widget UI, I noticed that the "Close Mapset" butten takes 
space from the module tabs. The old "Close mapset" button was much smaller. 
Would it be possible to move that to the bottom of the GRASS module UI, where 
the Debug buttons are located (if debugging is activated)?
BTW, the tabs for the open modules can get pretty wide due to the icons (see 
e.g. v.db.join). Maybe better to use module names in the tabs?

Finally, I was wondering if it could be an idea to place all mapset related 
buttons (open / close / new / change mapset) at the bottom of the Modules 
dialogue and to add a "manage mapset access" button, which runs the mapset 
picker for modifying the search path (g.mapsets -s) there as well? One (I if 
you like) can add g.mapsets with the s-flag as a module (I tested "g.mapsets 
-s" in the QGIS-GRASS-plugin and it starts the GRASS dialogue successfully), 
but it is probably better to have this option a bit more prominent (as it might 
come in handy with the new multiple map input option)?

Anyway, great work you did and do with the plugin upgrade!

Cheers
Stefan 


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 08/10/2015 18:58, m roy ha scritto:
> 
> 
> Il 08/10/2015 18.23, Radim Blazek ha scritto:
>> IMHO: i find it's confusing, and GRASS 7 default database is SQLite,
>> i think it could be smoother to expose only GRASS Locations and Mapset
>> being evident that we're dealing with a GRASS Database, but i can live
>> with that :-)
>> You are not the first who is confused. Fix would be easy, so I remove
>> regular dir if it is recognized as GRASS location?

Hi Radim,
once you're there, could you please see if it is easy to fix also:
https://hub.qgis.org/issues/8220 ?
Thanks.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Il 08/10/2015 18.23, Radim Blazek ha scritto:
> IMHO: i find it's confusing, and GRASS 7 default database is SQLite,
> i think it could be smoother to expose only GRASS Locations and Mapset
> being evident that we're dealing with a GRASS Database, but i can live
> with that :-)
> You are not the first who is confused. Fix would be easy, so I remove
> regular dir if it is recognized as GRASS location?

*If you ask*, my opinion is that it's better to remove the regular dir;
those folder are in fact the GRASS database.
> It is a virtual field keeping topology symbol, it is auto added when
> editing starts and removed when editing is closed. That is the only
> way to get symbology to renderer. User should never try to delete
> that. The values are not editable in form, but there is currently no
> possibility in QGIS to forbid deletion of individual columns (either
> there is delete column capability or not).
>
> Radim

A solution could be (if possible) to hide the topo_symbol column
in the attribute table;
or to state on the manual that the user should not try to delete
the topo_symbol column.


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 4:52 PM, m roy  wrote:
> Testing on windows
>>> GRASS LOCATION is "duplicated" displayed as a regular file system folder
>>> and as GRASS LOCATION with the GRASS icon
>> That is correct, the regular directory is left there so that is it
>> possible to go for example to dbf directory and load dbf files as
>> standard QGIS layers.
>
> IMHO: i find it's confusing, and GRASS 7 default database is SQLite,
> i think it could be smoother to expose only GRASS Locations and Mapset
> being evident that we're dealing with a GRASS Database, but i can live
> with that :-)

You are not the first who is confused. Fix would be easy, so I remove
regular dir if it is recognized as GRASS location?

>> Rasters are corrupted on Windows?
> yes on windows, sorry, i forgot to state that clearly;
> I mean the raster is *not really corrupted*, it just looks weird.

I have to debug on Windows. Does it happen with all data types (int,
float, double)?

>>> Vector digitizing: QGIS crash when deleting a line and the layer
>>> is not longer loadable in QGIS because of broken topology,
>> I am working on test unit for editing, which should ensure that
>> everything is working, because due to complexity of the code, I was
>> still introducing new bugs while fixing others.
>>
>> Thanks for testing.
>>
> I also managed to crash QGIS and 'corrupt' GRASS data working on the
> attribute table
> trying to delete the "topo_symbol" virtual(?) field; reopening the vector
> layer in GRASS the "topo_symbol" column was still there (i know i'm
> heavy-handed while testing!);

It is a virtual field keeping topology symbol, it is auto added when
editing starts and removed when editing is closed. That is the only
way to get symbology to renderer. User should never try to delete
that. The values are not editable in form, but there is currently no
possibility in QGIS to forbid deletion of individual columns (either
there is delete column capability or not).

Radim

> Thank you, Radim, for the great work.
>
>
>
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Testing on windows
>> GRASS LOCATION is "duplicated" displayed as a regular file system folder
>> and as GRASS LOCATION with the GRASS icon
> That is correct, the regular directory is left there so that is it
> possible to go for example to dbf directory and load dbf files as
> standard QGIS layers.

IMHO: i find it's confusing, and GRASS 7 default database is SQLite,
i think it could be smoother to expose only GRASS Locations and Mapset
being evident that we're dealing with a GRASS Database, but i can live 
with that :-)

>
> Rasters are corrupted on Windows?
yes on windows, sorry, i forgot to state that clearly;
I mean the raster is *not really corrupted*, it just looks weird.

>> Vector digitizing: QGIS crash when deleting a line and the layer
>> is not longer loadable in QGIS because of broken topology,
> I am working on test unit for editing, which should ensure that
> everything is working, because due to complexity of the code, I was
> still introducing new bugs while fixing others.
>
> Thanks for testing.
>
> Radim
I also managed to crash QGIS and 'corrupt' GRASS data working on the 
attribute table
trying to delete the "topo_symbol" virtual(?) field; reopening the vector
layer in GRASS the "topo_symbol" column was still there (i know i'm 
heavy-handed while testing!);

Thank you, Radim, for the great work.



___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 1:07 PM, m roy  wrote:
> Vector digitizing: QGIS crash when deleting a line and the layer
> is not longer loadable in QGIS because of broken topology,

That will be the problem with off_t which is different in GRASS
binaries and QGIS (different compilers on Windows), it is discussed
here, but not yet fixed, not easy:
https://lists.osgeo.org/pipermail/grass-dev/2015-September/076338.html

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Thu, Oct 8, 2015 at 1:07 PM, m roy  wrote:
> Testing GRASS Plugin with QGIS 2.11.0 Master 3dcabfb:
>
> with Browser Panel I can navigate to GRASS 7 db folder,
> GRASS LOCATION is "duplicated" displayed as a regular file system folder
> and as GRASS LOCATION with the GRASS icon

That is correct, the regular directory is left there so that is it
possible to go for example to dbf directory and load dbf files as
standard QGIS layers.

> I can load vector layers, GRASS raster layers visualization in QGIS
> is not working as rasters appears corrupted (weird colors, missing parts,
> broken in two)

Rasters are corrupted on Windows? That sounds again like if the module
was sending data in text mode, but I am sure the mode is set to
binary.

> Vector digitizing: QGIS crash when deleting a line and the layer
> is not longer loadable in QGIS because of broken topology,

I am working on test unit for editing, which should ensure that
everything is working, because due to complexity of the code, I was
still introducing new bugs while fixing others.

Thanks for testing.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[m roy]

Testing GRASS Plugin with QGIS 2.11.0 Master 3dcabfb:

with Browser Panel I can navigate to GRASS 7 db folder,
GRASS LOCATION is "duplicated" displayed as a regular file system folder
and as GRASS LOCATION with the GRASS icon

I can load vector layers, GRASS raster layers visualization in QGIS
is not working as rasters appears corrupted (weird colors, missing parts, 
broken in two)

Vector digitizing: QGIS crash when deleting a line and the layer
is not longer loadable in QGIS because of broken topology,

Thanks, Roy.


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Vaclav Petras]

On Tue, Oct 6, 2015 at 7:29 AM, Radim Blazek  wrote:

> On Mon, Oct 5, 2015 at 11:16 PM, Vaclav Petras 
> wrote:
> >
> > On Mon, Oct 5, 2015 at 1:16 PM, Radim Blazek 
> wrote:
> >>
> >> >> There is v.build.all in modules.
> >> >
> >> > yes, but the user has no hint about its necessity; further steps:
> >> > db.connect -d
> >> > v.db.reconnect.all -cd
> >> > are not available among modules (BTW, maybe these options could be
> added
> >> > to existing modules?).
> >>
> >> Building broken topology from browser can be always useful, but I
> >> don't think that browser/plugin must have UI for upgrading GRASS data
> >> from 6 to 7, something which has to be rarely done and which should be
> >> done with understanding (upgrade from dbf to sqlite).
> >
> > Perhaps a special plugin. Do you think it would be a good idea to have
> > plugins based on the GRASS plugin? (They would probably just call modules
> > but in the way GRASS plugin does.)
>
> I have added qgis.v.upgrade.py which runs
>   v.build.all
>   db.connect -d
>   v.db.reconnect.all -cd
>
> but v.db.reconnect.all fails with -d even from GRASS shell:
>
> Reconnecting vector map  (1 of 3)...
>
> 
> Copying table  to target database...
> Traceback (most recent call last):
>   File "grass-7.1.svn/scripts/db.droptable", line 99, in 
> main()
>   File "grass-7.1.svn/scripts/db.droptable", line 77, in main
> used = grass.db.db_table_in_vector(table)
>   File "grass-7.1.svn/etc/python/grass/script/db.py", line 189, in
> db_table_in_vector
> for f in vector_db(vect, stderr=nuldev).itervalues():
>   File "grass-7.1.svn/etc/python/grass/script/vector.py", line 46, in
> vector_db
> **args)
>   File "/grass-7.1.svn/etc/python/grass/script/core.py", line 460, in
> read_command
> return handle_errors(returncode, stdout, args, kwargs)
>   File "grass-7.1.svn/etc/python/grass/script/core.py", line 328, in
> handle_errors
> returncode=returncode)
> grass.exceptions.CalledModuleError: Module run None ['v.db.connect',
> '--q', '-g', 'map=edit@PERMANENT', 'sep=;'] ended with error
> Process ended with non-zero return code 1. See errors in the (error)
> output.
> ERROR: Unable to drop table 


Hi Radim,

it works for me with NC sample Location for G6 [1]. So, the same as for
Paolo [2]. How can I reproduce it? I've tried vector map without a table,
but it also worked well. Tested with latest 7.0 release branch code.

Vaclav

[1] http://grass.osgeo.org/download/sample-data/
[2] https://lists.osgeo.org/pipermail/grass-dev/2015-October/076648.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Hi Radim,

Il 06/10/2015 13:41, Radim Blazek ha scritto:

> Which revision? Please use current master if possible.

I'm currently using Debian packages from our repo. Just upgraded.

> Please start with points and lines. When you digitize a point or line,
> nothing is displayed in canvas? Do you see the elements if you switch
> style to default? Do you see the features in attribute table? Are the
> elements written to the map when you close editing?
> 
>  Note that QGIS can only display features of one type in a layer, if
> you add point layer and digitize a line, it will no show in point
> layer after editing is closed, a new layer with lines must be added to
> canvas.

Thanks for the clarification. I'm currently under stress, I do not think
I'll have time for proper testing during this week, but I can give a
hand. It seems to me that testing is especially important in this phase:
anyone available?
Thanks.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Tue, Oct 6, 2015 at 8:12 AM, Paolo Cavallini  wrote:
>>> yes - I tried, but the newly added polygon etc is not displayed once
>>> digitized. Oh, now I see: the custom grass symbology prevents me from
>>> seeing it. Once moved to single symbol, it is displayed.
>>
>>> I confirm an issue: I load a layer, activate editing, the layer is no
>>> longer visible. When editing is deactivated, the layer remains invisible.
>>
>> There was a bug which I introduced on Friday, it was fixed in b09877b.
>> The style must be set (automatically) to GRASS Edit to get topological
>> symbology.
>
> I still see the issue on current Debian sid package, just upgraded.

Which revision? Please use current master if possible.

Please start with points and lines. When you digitize a point or line,
nothing is displayed in canvas? Do you see the elements if you switch
style to default? Do you see the features in attribute table? Are the
elements written to the map when you close editing?

 Note that QGIS can only display features of one type in a layer, if
you add point layer and digitize a line, it will no show in point
layer after editing is closed, a new layer with lines must be added to
canvas.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 06/10/2015 13:29, Radim Blazek ha scritto:

> I have added qgis.v.upgrade.py which runs

fine, I like that.

> but v.db.reconnect.all fails with -d even from GRASS shell:

here it worked well for a couple of locations.
All the best.

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Oct 5, 2015 at 11:16 PM, Vaclav Petras  wrote:
>
> On Mon, Oct 5, 2015 at 1:16 PM, Radim Blazek  wrote:
>>
>> >> There is v.build.all in modules.
>> >
>> > yes, but the user has no hint about its necessity; further steps:
>> > db.connect -d
>> > v.db.reconnect.all -cd
>> > are not available among modules (BTW, maybe these options could be added
>> > to existing modules?).
>>
>> Building broken topology from browser can be always useful, but I
>> don't think that browser/plugin must have UI for upgrading GRASS data
>> from 6 to 7, something which has to be rarely done and which should be
>> done with understanding (upgrade from dbf to sqlite).
>
> Perhaps a special plugin. Do you think it would be a good idea to have
> plugins based on the GRASS plugin? (They would probably just call modules
> but in the way GRASS plugin does.)

I have added qgis.v.upgrade.py which runs
  v.build.all
  db.connect -d
  v.db.reconnect.all -cd

but v.db.reconnect.all fails with -d even from GRASS shell:

Reconnecting vector map  (1 of 3)...

Copying table  to target database...
Traceback (most recent call last):
  File "grass-7.1.svn/scripts/db.droptable", line 99, in 
main()
  File "grass-7.1.svn/scripts/db.droptable", line 77, in main
used = grass.db.db_table_in_vector(table)
  File "grass-7.1.svn/etc/python/grass/script/db.py", line 189, in
db_table_in_vector
for f in vector_db(vect, stderr=nuldev).itervalues():
  File "grass-7.1.svn/etc/python/grass/script/vector.py", line 46, in vector_db
**args)
  File "/grass-7.1.svn/etc/python/grass/script/core.py", line 460, in
read_command
return handle_errors(returncode, stdout, args, kwargs)
  File "grass-7.1.svn/etc/python/grass/script/core.py", line 328, in
handle_errors
returncode=returncode)
grass.exceptions.CalledModuleError: Module run None ['v.db.connect',
'--q', '-g', 'map=edit@PERMANENT', 'sep=;'] ended with error
Process ended with non-zero return code 1. See errors in the (error) output.
ERROR: Unable to drop table 

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 05/10/2015 17:18, Radim Blazek ha scritto:
> On Mon, Oct 5, 2015 at 2:58 PM, Paolo Cavallini  wrote:

>> yes - I tried, but the newly added polygon etc is not displayed once
>> digitized. Oh, now I see: the custom grass symbology prevents me from
>> seeing it. Once moved to single symbol, it is displayed.
> 
>> I confirm an issue: I load a layer, activate editing, the layer is no
>> longer visible. When editing is deactivated, the layer remains invisible.
> 
> There was a bug which I introduced on Friday, it was fixed in b09877b.
> The style must be set (automatically) to GRASS Edit to get topological
> symbology.

I still see the issue on current Debian sid package, just upgraded.
Futhermore I noticed some warnings in the log:

/home/paolo/grass/world_g7/PERMANENT/cellhd
2015-10-06T08:06:19 1   QFileSystemWatcher: failed to add paths:
/home/paolo/grass/Toscana_corso/a_user/cellhd
2015-10-06T08:07:59 1   QLayout: Attempting to add QLayout "" to QWidget
"dockWidgetContents", which already has a layout
2015-10-06T08:07:59 1   QLayout: Attempting to add QLayout "" to QWidget
"dockWidgetContents", which already has a layout
2015-10-06T08:07:59 1   QLayout: Attempting to add QLayout "" to QWidget
"dockWidgetContents", which already has a layout

All the best.

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 05/10/2015 19:16, Radim Blazek ha scritto:
> On Mon, Oct 5, 2015 at 6:17 PM, Paolo Cavallini  wrote:
>> Il 05/10/2015 17:18, Radim Blazek ha scritto:
>>
>>> OK, but first I have to fix other bugs.
>>
>> sure - should I open a ticket then?
> 
> Yes, thanks.

done: https://hub.qgis.org/issues/13523

> Building broken topology from browser can be always useful, but I
> don't think that browser/plugin must have UI for upgrading GRASS data
> from 6 to 7, something which has to be rarely done and which should be
> done with understanding (upgrade from dbf to sqlite).

Got it. Please see my comments to the ticket.
All the best.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Vaclav Petras]

On Mon, Oct 5, 2015 at 1:16 PM, Radim Blazek  wrote:

> >> There is v.build.all in modules.
> >
> > yes, but the user has no hint about its necessity; further steps:
> > db.connect -d
> > v.db.reconnect.all -cd
> > are not available among modules (BTW, maybe these options could be added
> > to existing modules?).
>
> Building broken topology from browser can be always useful, but I
> don't think that browser/plugin must have UI for upgrading GRASS data
> from 6 to 7, something which has to be rarely done and which should be
> done with understanding (upgrade from dbf to sqlite).


Perhaps a special plugin. Do you think it would be a good idea to have
plugins based on the GRASS plugin? (They would probably just call modules
but in the way GRASS plugin does.)
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Oct 5, 2015 at 6:17 PM, Paolo Cavallini  wrote:
> Il 05/10/2015 17:18, Radim Blazek ha scritto:
>
>> OK, but first I have to fix other bugs.
>
> sure - should I open a ticket then?

Yes, thanks.

>> There is v.build.all in modules.
>
> yes, but the user has no hint about its necessity; further steps:
> db.connect -d
> v.db.reconnect.all -cd
> are not available among modules (BTW, maybe these options could be added
> to existing modules?).

Building broken topology from browser can be always useful, but I
don't think that browser/plugin must have UI for upgrading GRASS data
from 6 to 7, something which has to be rarely done and which should be
done with understanding (upgrade from dbf to sqlite).

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 05/10/2015 17:18, Radim Blazek ha scritto:

> OK, but first I have to fix other bugs.

sure - should I open a ticket then?

> There is v.build.all in modules.

yes, but the user has no hint about its necessity; further steps:
db.connect -d
v.db.reconnect.all -cd
are not available among modules (BTW, maybe these options could be added
to existing modules?).

> There was a bug which I introduced on Friday, it was fixed in b09877b.
> The style must be set (automatically) to GRASS Edit to get topological
> symbology.

OK, thanks, I'll check.

> Documentation is not yet upgraded, but you can write it

I'm not much of a digitizer myself, better leave it to someone more
expert. If no one is available, I can try.

Thanks a lot.

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Mon, Oct 5, 2015 at 2:58 PM, Paolo Cavallini  wrote:
>>> * G6 vectors are shown with a red cross,
>>
>> And the name is followed by "topology version 6", right?
>
> exactly
>
>> What do you suggest? My idea was "Build topology" item in context
>> menu. But we are over feature freeze and if somebody has already G6
>> vectors, he should know that he must rebuild topology in G7. It is
>> described here:
>> https://grasswiki.osgeo.org/wiki/Convert_all_GRASS_6_vector_maps_to_GRASS_7
>
> I think the context menu is fine, and adding it should not be an issue
> now (I could say not being able to readily use my data is a bug, and
> your suggestion fixes it).

OK, but first I have to fix other bugs.

> the procedure described in the wiki works smoothly from the embedded
> GRASS shell, but I guess this is intimidating for many users.

There is v.build.all in modules.

>> Draw features? There should be usual Add Point, Add Line etc. tools in
>> Digitizing Toolbar.
>
> yes - I tried, but the newly added polygon etc is not displayed once
> digitized. Oh, now I see: the custom grass symbology prevents me from
> seeing it. Once moved to single symbol, it is displayed.

> I confirm an issue: I load a layer, activate editing, the layer is no
> longer visible. When editing is deactivated, the layer remains invisible.

There was a bug which I introduced on Friday, it was fixed in b09877b.
The style must be set (automatically) to GRASS Edit to get topological
symbology.

>> Very welcome. There are still issues in editing, that is why I have
>> not announced yet the upgrade to be finished. The implementation of
>> editing became incredibly complex. Basic editing should mostly work
>> however.
>
> I can imagine. Where do I find a guide on how to digitize?

Documentation is not yet upgraded, but you can write it

> I tried adding polygon, then centroid, but I only ended up with an invisible
> geom. I'm certainly missing something here.

It is correct, it should work with current master.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 05/10/2015 14:58, Paolo Cavallini ha scritto:

> I think the context menu is fine, and adding it should not be an issue
> now (I could say not being able to readily use my data is a bug, and
> your suggestion fixes it).

the procedure described in the wiki works smoothly from the embedded
GRASS shell, but I guess this is intimidating for many users.

> yes - I tried, but the newly added polygon etc is not displayed once
> digitized. Oh, now I see: the custom grass symbology prevents me from
> seeing it. Once moved to single symbol, it is displayed.

I confirm an issue: I load a layer, activate editing, the layer is no
longer visible. When editing is deactivated, the layer remains invisible.

All the best.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Il 05/10/2015 14:44, Radim Blazek ha scritto:
> On Sat, Oct 3, 2015 at 8:02 AM, Paolo Cavallini  wrote:

>> * G6 vectors are shown with a red cross,
> 
> And the name is followed by "topology version 6", right?

exactly

> What do you suggest? My idea was "Build topology" item in context
> menu. But we are over feature freeze and if somebody has already G6
> vectors, he should know that he must rebuild topology in G7. It is
> described here:
> https://grasswiki.osgeo.org/wiki/Convert_all_GRASS_6_vector_maps_to_GRASS_7

I think the context menu is fine, and adding it should not be an issue
now (I could say not being able to readily use my data is a bug, and
your suggestion fixes it).

> I fixed the crash and removed new layer menu items from the vector if
> it is not valid.

great, thanks

>> * I created a new polygon layer, but it is unclear to me how to add objects
> 
> Draw features? There should be usual Add Point, Add Line etc. tools in
> Digitizing Toolbar.

yes - I tried, but the newly added polygon etc is not displayed once
digitized. Oh, now I see: the custom grass symbology prevents me from
seeing it. Once moved to single symbol, it is displayed.

>> * if I remove a raster which is already loaded in the canvas, I get a
>> warning (empty, grey dialog) and QGIS is stuck (I had to force close it)
> 
> Fixed, it was trying to show a warning from rendering non GUI thread.

thanks again

>> * loaded rasters display a legend, but not the labels.
> 
> Labels were never supported, you can fill feature request issue.

done: https://hub.qgis.org/issues/13518

>> Otherwise, great stuff!
>> Should I open tickets for all this?
> 
> No, except for color labels. For now, if you find more issues, write
> it here and I'll try to fix immediately.

ok, thanks

> Very welcome. There are still issues in editing, that is why I have
> not announced yet the upgrade to be finished. The implementation of
> editing became incredibly complex. Basic editing should mostly work
> however.

I can imagine. Where do I find a guide on how to digitize? I tried
adding polygon, then centroid, but I only ended up with an invisible
geom. I'm certainly missing something here.

All the best, and thanks again.

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] New GRASS plugin: a test drive

[Radim Blazek]

On Sat, Oct 3, 2015 at 8:02 AM, Paolo Cavallini  wrote:
> Hi all,
>
> some tests of the new plugin:
> * G6 vectors are shown with a red cross,

And the name is followed by "topology version 6", right?

> but there is no clear indication on how to migrate them to G7

What do you suggest? My idea was "Build topology" item in context
menu. But we are over feature freeze and if somebody has already G6
vectors, he should know that he must rebuild topology in G7. It is
described here:
https://grasswiki.osgeo.org/wiki/Convert_all_GRASS_6_vector_maps_to_GRASS_7

> * I got a crash twice by right clicking on the browser > New polygon
> layer; from the third time no crash, I'll try to replicate it.
> * I can reproduce a crash by:
> - right click on a G6 vector from the browser
> - choose New polygon layer
> - got a warning:
> Impossibile aprire il file della topologia per il vettoriale
> 
> - bang!
> src/providers/grass/qgsgrassprovider.cpp: 338: (~QgsGrassProvider) [0ms]
> entered
> src/providers/grass/qgsgrassvectormaplayer.cpp: 330: (close) [0ms] close
> Segfault
> If I do the same from a mapset name, no crash.

I fixed the crash and removed new layer menu items from the vector if
it is not valid.

> * I created a new polygon layer, but it is unclear to me how to add objects

Draw features? There should be usual Add Point, Add Line etc. tools in
Digitizing Toolbar.

> * if I remove a raster which is already loaded in the canvas, I get a
> warning (empty, grey dialog) and QGIS is stuck (I had to force close it)

Fixed, it was trying to show a warning from rendering non GUI thread.

> * loaded rasters display a legend, but not the labels.

Labels were never supported, you can fill feature request issue.

> Otherwise, great stuff!
> Should I open tickets for all this?

No, except for color labels. For now, if you find more issues, write
it here and I'll try to fix immediately.

> I'm available for further testing if useful.

Very welcome. There are still issues in editing, that is why I have
not announced yet the upgrade to be finished. The implementation of
editing became incredibly complex. Basic editing should mostly work
however.

Radim
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

[Qgis-developer] New GRASS plugin: a test drive

[Paolo Cavallini]

Hi all,

some tests of the new plugin:
* G6 vectors are shown with a red cross, but there is no clear
indication on how to migrate them to G7
* I got a crash twice by right clicking on the browser > New polygon
layer; from the third time no crash, I'll try to replicate it.
* I can reproduce a crash by:
- right click on a G6 vector from the browser
- choose New polygon layer
- got a warning:
Impossibile aprire il file della topologia per il vettoriale

- bang!
src/providers/grass/qgsgrassprovider.cpp: 338: (~QgsGrassProvider) [0ms]
entered
src/providers/grass/qgsgrassvectormaplayer.cpp: 330: (close) [0ms] close
Segfault
If I do the same from a mapset name, no crash.
* I created a new polygon layer, but it is unclear to me how to add objects
* if I remove a raster which is already loaded in the canvas, I get a
warning (empty, grey dialog) and QGIS is stuck (I had to force close it)
* loaded rasters display a legend, but not the labels.
Otherwise, great stuff!
Should I open tickets for all this?
I'm available for further testing if useful.

All the best.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer