Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
Hi Sandro, On Wed, 18. Jul 2018 at 11:41:03 +0200, Sandro Santilli wrote: > > -1 this has been standing in my way already - and it'll break the release > > process. > Could release manager(s) be given special powers to circumvent the block? Not specifically - but you can exclude admins - which is what I've done. Jürgen -- Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 Software Engineer D-26506 Norden http://www.norbit.de QGIS release manager (PSC) GermanyIRC: jef on FreeNode signature.asc Description: PGP signature ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
On Wed, Jul 18, 2018 at 10:11:09AM +0200, Jürgen E. Fischer wrote: > Hi Nyall, > > On Tue, 17. Jul 2018 at 15:22:16 +1000, Nyall Dawson wrote: > > I've just enabled this. Let's give it a trial run and see how it works out. > > -1 this has been standing in my way already - and it'll break the release > process. Could release manager(s) be given special powers to circumvent the block ? --strk; ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
Hi Nyall, On Tue, 17. Jul 2018 at 15:22:16 +1000, Nyall Dawson wrote: > I've just enabled this. Let's give it a trial run and see how it works out. -1 this has been standing in my way already - and it'll break the release process. Jürgen -- Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 Software Engineer D-26506 Norden http://www.norbit.de QGIS release manager (PSC) GermanyIRC: jef on FreeNode signature.asc Description: PGP signature ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
Great, thanks Nyall. Il 17 luglio 2018 07:22:16 CEST, Nyall Dawson ha scritto: >On Mon, 16 Jul 2018 at 19:04, Nyall Dawson >wrote: >> >> On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini >wrote: >> > >> > Hi all, >> > >> > Il 16/07/2018 00:20, Nyall Dawson ha scritto: >> > >> > > (Possibly we should consider switching on github branch >protection >> > > here, blocking direct commits and requiring a minimum of 2 or 3 >> > > 'acceptable' reviews from core devs on PRs?) >> > >> > this proposal makes sense to me - do you think it is realistically >> > feasible with our forces? >> >> I think so. There's enough core developers who are active on a near >> daily basis to mean that this should not be a major inconvenience. >And >> I for one am willing to trade some minor inconvenience for a stabler >> LTR. > >I've just enabled this. Let's give it a trial run and see how it works >out. > >Nyall -- Sorry for being short___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
On Mon, 16 Jul 2018 at 19:04, Nyall Dawson wrote: > > On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini wrote: > > > > Hi all, > > > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > > > > > (Possibly we should consider switching on github branch protection > > > here, blocking direct commits and requiring a minimum of 2 or 3 > > > 'acceptable' reviews from core devs on PRs?) > > > > this proposal makes sense to me - do you think it is realistically > > feasible with our forces? > > I think so. There's enough core developers who are active on a near > daily basis to mean that this should not be a major inconvenience. And > I for one am willing to trade some minor inconvenience for a stabler > LTR. I've just enabled this. Let's give it a trial run and see how it works out. Nyall ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
On Mon, Jul 16, 2018 at 12:20 AM, Nyall Dawson wrote: > Hi all, > > This is a gentle request to please please pay very special attention > when backporting fixes to 2.18, and assess carefully whether those > fixes are REALLY necessary in the stable LTR branch. Unfortunately the > last couple of 2.18 patch releases have seen some serious regressions > introduced as a result of backported fixes, which really harms the > reputation of QGIS' stability. > > It's no-ones fault, because we ALL make mistakes and create > regressions... but I think at this stage we should tighten up 2.18 now > to only mission critical, very clearly safe bug fixes, and leave all > "minor" fixes for 3.x only. > > (Possibly we should consider switching on github branch protection > here, blocking direct commits and requiring a minimum of 2 or 3 > 'acceptable' reviews from core devs on PRs?) > > Nyall > +1 As a side note, I believe we should try to involve more community members (I mean users: not developers) in regularly testing development builds between feature freeze and release. -- Alessandro Pasotti w3: www.itopen.it ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
+1. Stable LTR is super important On Mon, Jul 16, 2018 at 7:04 PM Nyall Dawson wrote: > On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini > wrote: > > > > Hi all, > > > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > > > > > (Possibly we should consider switching on github branch protection > > > here, blocking direct commits and requiring a minimum of 2 or 3 > > > 'acceptable' reviews from core devs on PRs?) > > > > this proposal makes sense to me - do you think it is realistically > > feasible with our forces? > > I think so. There's enough core developers who are active on a near > daily basis to mean that this should not be a major inconvenience. And > I for one am willing to trade some minor inconvenience for a stabler > LTR. > > Nyall > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
On Mon, 16 Jul 2018 at 14:52, Paolo Cavallini wrote: > > Hi all, > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > > > (Possibly we should consider switching on github branch protection > > here, blocking direct commits and requiring a minimum of 2 or 3 > > 'acceptable' reviews from core devs on PRs?) > > this proposal makes sense to me - do you think it is realistically > feasible with our forces? I think so. There's enough core developers who are active on a near daily basis to mean that this should not be a major inconvenience. And I for one am willing to trade some minor inconvenience for a stabler LTR. Nyall ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
On 07/16/2018 06:52 AM, Paolo Cavallini wrote: > Hi all, > > Il 16/07/2018 00:20, Nyall Dawson ha scritto: > >> (Possibly we should consider switching on github branch protection >> here, blocking direct commits and requiring a minimum of 2 or 3 >> 'acceptable' reviews from core devs on PRs?) > > this proposal makes sense to me - do you think it is realistically > feasible with our forces? Agreed with Nyall, commit's should only go into 2.18 if 100% safe and reviewed by a couple of core devs. If we don't have the forces for it, we should not port back. Eg. not being able to add a column to a shapefile (currently in 2.18.21), this is not something you want to have failing in an LTR :-( I think for an LTR it is better to have 'known' issues, then introduce unknowns. Regards, Richard Duivenvoorde ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Gentle request: please be careful with 2.18 backports
Hi all, Il 16/07/2018 00:20, Nyall Dawson ha scritto: > (Possibly we should consider switching on github branch protection > here, blocking direct commits and requiring a minimum of 2 or 3 > 'acceptable' reviews from core devs on PRs?) this proposal makes sense to me - do you think it is realistically feasible with our forces? All the best. -- Paolo Cavallini - www.faunalia.eu QGIS & PostGIS courses: http://www.faunalia.eu/training.html https://www.google.com/trends/explore?date=all=IT=qgis,arcgis ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
