Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Paolo Cavallini 
Il 08/05/2018 10:37, Nyall Dawson ha scritto:

> Sorry for the spam: I meant to add - since I'm passionate about both
> cartography and processing, I'd be more than happy to mentor this
> change.

added to ticket:
https://gitlab.com/motlimot/karika/issues/1
thanks!

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Nyall Dawson 
On 8 May 2018 at 18:35, Nyall Dawson  wrote:
> On 8 May 2018 at 16:15, Nyall Dawson  wrote:
>> On 8 May 2018 at 15:59, Paolo Cavallini  wrote:
>>> Hi all,
>>> a plugin[0], quite interesting, contains compiled+src C code[1]. We
>>> generally avoid this, so the question is: what can we suggest to the author?
>>> All the best, and thanks.
>>
>> Looks like a great plugin - at least if the sample results are
>> anything to go by!
>>
>> I've had a quick look over the code and there's nothing too scary
>> there. I'd suggest that we could approach the author of the plugin and
>> see if they are interested in submitting the code to the master
>> branch, so that the code is compiled alongside qgis. This way the
>> binary won't be an issue, and the algorithm will become available
>> out-of-the-box. Seems like a win all round to me.
>
> Another benefit from merging into core: we could use this as an option
> for the live hillshade renderer. Win!

Sorry for the spam: I meant to add - since I'm passionate about both
cartography and processing, I'd be more than happy to mentor this
change.

Nyall

>
> Nyall
>
>>
>> Nyall
>>
>>
>>>
>>>
>>> [0] http://plugins.qgis.org/plugins/karika/
>>> [1] https://gitlab.com/motlimot/karika/tree/master/lib
>>> --
>>> Paolo Cavallini - www.faunalia.eu
>>> QGIS & PostGIS courses: http://www.faunalia.eu/training.html
>>> https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
>>> ___
>>> QGIS-Developer mailing list
>>> QGIS-Developer@lists.osgeo.org
>>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Nyall Dawson 
On 8 May 2018 at 16:15, Nyall Dawson  wrote:
> On 8 May 2018 at 15:59, Paolo Cavallini  wrote:
>> Hi all,
>> a plugin[0], quite interesting, contains compiled+src C code[1]. We
>> generally avoid this, so the question is: what can we suggest to the author?
>> All the best, and thanks.
>
> Looks like a great plugin - at least if the sample results are
> anything to go by!
>
> I've had a quick look over the code and there's nothing too scary
> there. I'd suggest that we could approach the author of the plugin and
> see if they are interested in submitting the code to the master
> branch, so that the code is compiled alongside qgis. This way the
> binary won't be an issue, and the algorithm will become available
> out-of-the-box. Seems like a win all round to me.

Another benefit from merging into core: we could use this as an option
for the live hillshade renderer. Win!

Nyall

>
> Nyall
>
>
>>
>>
>> [0] http://plugins.qgis.org/plugins/karika/
>> [1] https://gitlab.com/motlimot/karika/tree/master/lib
>> --
>> Paolo Cavallini - www.faunalia.eu
>> QGIS & PostGIS courses: http://www.faunalia.eu/training.html
>> https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
>> ___
>> QGIS-Developer mailing list
>> QGIS-Developer@lists.osgeo.org
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Luigi Pirelli 
I agree with nyall, the problem with distributing dll or os we can trust
that they are build against the plugin code.

years ago we almost agreed to ask plugin authors to install dll or .so by
the plugin or manually from a third party repo with the express consensus
of the author. I wouldn't host binaries in the plugin repo.

my 2c

Luigi Pirelli

**
* LinkedIn: https://www.linkedin.com/in/luigipirelli
* Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli
* GitHub: https://github.com/luipir
* Mastering QGIS 2nd Edition:
*
https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition
* Hire me: http://goo.gl/BYRQKg
**

On 8 May 2018 at 08:15, Nyall Dawson  wrote:

> On 8 May 2018 at 15:59, Paolo Cavallini  wrote:
> > Hi all,
> > a plugin[0], quite interesting, contains compiled+src C code[1]. We
> > generally avoid this, so the question is: what can we suggest to the
> author?
> > All the best, and thanks.
>
> Looks like a great plugin - at least if the sample results are
> anything to go by!
>
> I've had a quick look over the code and there's nothing too scary
> there. I'd suggest that we could approach the author of the plugin and
> see if they are interested in submitting the code to the master
> branch, so that the code is compiled alongside qgis. This way the
> binary won't be an issue, and the algorithm will become available
> out-of-the-box. Seems like a win all round to me.
>
> Nyall
>
>
> >
> >
> > [0] http://plugins.qgis.org/plugins/karika/
> > [1] https://gitlab.com/motlimot/karika/tree/master/lib
> > --
> > Paolo Cavallini - www.faunalia.eu
> > QGIS & PostGIS courses: http://www.faunalia.eu/training.html
> > https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
> > ___
> > QGIS-Developer mailing list
> > QGIS-Developer@lists.osgeo.org
> > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Paolo Cavallini 
Il 08/05/2018 08:15, Nyall Dawson ha scritto:

> Looks like a great plugin - at least if the sample results are
> anything to go by!
> 
> I've had a quick look over the code and there's nothing too scary
> there. I'd suggest that we could approach the author of the plugin and
> see if they are interested in submitting the code to the master
> branch, so that the code is compiled alongside qgis. This way the
> binary won't be an issue, and the algorithm will become available
> out-of-the-box. Seems like a win all round to me.

fully agreed, I'm doing it right now.
all the best, and thanks for the review.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Nyall Dawson 
On 8 May 2018 at 15:59, Paolo Cavallini  wrote:
> Hi all,
> a plugin[0], quite interesting, contains compiled+src C code[1]. We
> generally avoid this, so the question is: what can we suggest to the author?
> All the best, and thanks.

Looks like a great plugin - at least if the sample results are
anything to go by!

I've had a quick look over the code and there's nothing too scary
there. I'd suggest that we could approach the author of the plugin and
see if they are interested in submitting the code to the master
branch, so that the code is compiled alongside qgis. This way the
binary won't be an issue, and the algorithm will become available
out-of-the-box. Seems like a win all round to me.

Nyall


>
>
> [0] http://plugins.qgis.org/plugins/karika/
> [1] https://gitlab.com/motlimot/karika/tree/master/lib
> --
> Paolo Cavallini - www.faunalia.eu
> QGIS & PostGIS courses: http://www.faunalia.eu/training.html
> https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Paolo Cavallini 
Il 08/05/2018 08:08, Matthias Kuhn ha scritto:
> Hi Paolo,
> 
> Do we know the license of the code? I don't find any source code in the
> link.

apparently GPL:
https://gitlab.com/motlimot/karika/blob/master/lib/src/lic.c
thanks
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Including compiled code in plugins

2018-05-08 Thread Matthias Kuhn 
Hi Paolo,

Do we know the license of the code? I don't find any source code in the
link.

Matthias

On 08.05.18 07:59, Paolo Cavallini wrote:
> Hi all,
> a plugin[0], quite interesting, contains compiled+src C code[1]. We
> generally avoid this, so the question is: what can we suggest to the author?
> All the best, and thanks.
>
>
> [0] http://plugins.qgis.org/plugins/karika/
> [1] https://gitlab.com/motlimot/karika/tree/master/lib
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer