Re: [QGIS-Developer] Proposal for QGIS Documentation
Great!! Thanks for your help. A qui, 17/01/2019, 13:21, Paolo Cavallini escreveu: > On 17/01/19 13:07, Tom Chadwin wrote: > > Just a quick note to say that, after some discussion with (and help from) > > Matteo, I've started to try to help out with English style and grammar. > I'm > > not an experienced enough QGIS user to create much new documentation, but > > hopefully this will help. Other documentation contributors, please be > > patient with me as I learn the workflow. > Great! Thanks a lot, Tom. > -- > Paolo Cavallini - www.faunalia.eu > QGIS.ORG Chair: > http://planet.qgis.org/planet/user/28/tag/qgis%20board/ > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer -- Alexandre Neto - @AlexNetoGeo http://sigsemgrilhetas.wordpress.com http://gisunchained.wordpress.com ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
On 17/01/19 13:07, Tom Chadwin wrote: > Just a quick note to say that, after some discussion with (and help from) > Matteo, I've started to try to help out with English style and grammar. I'm > not an experienced enough QGIS user to create much new documentation, but > hopefully this will help. Other documentation contributors, please be > patient with me as I learn the workflow. Great! Thanks a lot, Tom. -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi Tom, > Just a quick note to say that, after some discussion with (and help from) > Matteo, I've started to try to help out with English style and grammar. I'm > not an experienced enough QGIS user to create much new documentation, but > hopefully this will help. Other documentation contributors, please be > patient with me as I learn the workflow. having native English speaker is super important for us. Thanks for the availability! P.S. I'll assign the review of my next PR to you ;) Matteo ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Just a quick note to say that, after some discussion with (and help from) Matteo, I've started to try to help out with English style and grammar. I'm not an experienced enough QGIS user to create much new documentation, but hopefully this will help. Other documentation contributors, please be patient with me as I learn the workflow. Tom - Buy Pie Spy: Adventures in British pastry 2010-11 on Amazon -- Sent from: http://osgeo-org.1560.x6.nabble.com/QGIS-Developer-f4099106.html ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Since most seem to agree with the bot implementation, can we do it in a way that: - the PR owner (and other watchers) receive a message warning that the PR is going to be closed with some time to act; - Not automatically merging PRs, but warn the owner (and watchers) that the owner (if with commit rights) can merge the PR because of not having active reviews/comments for a while? Can we also make possible to reactivate a PR once a new comment is done? I am thinking about the new contributers that see their PR being closed and have no way to Open it again. If they know no one, their work may be lost. BTW, how much time of inactivity should trigger the bot? 2 weeks a warning, 3 weeks close? Best regards, Alex Paolo Cavallini escreveu no dia quarta, 16/01/2019 às 08:37: > +1 > In case nobody objects, I'd suggest implementing this soon, during HF at > latest, better before. > All the best. > > On 16/01/19 08:44, Andreas Neumann wrote: > > Hi Matteo, > > > > Your suggestion sounds good to me. > > > > Andreas > > > > Am 16.01.19 um 08:42 schrieb matteo: > >> Hi Anita, > >> > >>> I am not very enthusiast of the automatic merging and closing of > >>> PRs. People have different velocities, and I don't think it's good > >>> to close a someones PR (that put some good work on it) just > because > >>> no one with merge rights was able to review it. It is very > >>> discouraging. > >>> > >>> > >>> I think the suggestion was to automatically accept and merge them if > >>> nobody with merge rights gets around to doing it. > >> nope. What I'm suggesting is to automatic merge PR made by author having > >> commit rights on the repo after a while and to close (or putting into > >> stale) PR made by "external" people if there is not activity for a > while. > >> > >> This could speed up the cue of PR and prevent eventual breaking of docs. > >> > >> Cheers > >> > >> Matteo > >> ___ > >> QGIS-Developer mailing list > >> QGIS-Developer@lists.osgeo.org > >> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > >> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer > > ___ > > QGIS-Developer mailing list > > QGIS-Developer@lists.osgeo.org > > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer > > -- > Paolo Cavallini - www.faunalia.eu > QGIS.ORG Chair: > http://planet.qgis.org/planet/user/28/tag/qgis%20board/ > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer -- Alexandre Neto - @AlexNetoGeo http://sigsemgrilhetas.wordpress.com http://gisunchained.wordpress.com ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
+1 In case nobody objects, I'd suggest implementing this soon, during HF at latest, better before. All the best. On 16/01/19 08:44, Andreas Neumann wrote: > Hi Matteo, > > Your suggestion sounds good to me. > > Andreas > > Am 16.01.19 um 08:42 schrieb matteo: >> Hi Anita, >> >>> I am not very enthusiast of the automatic merging and closing of >>> PRs. People have different velocities, and I don't think it's good >>> to close a someones PR (that put some good work on it) just because >>> no one with merge rights was able to review it. It is very >>> discouraging. >>> >>> >>> I think the suggestion was to automatically accept and merge them if >>> nobody with merge rights gets around to doing it. >> nope. What I'm suggesting is to automatic merge PR made by author having >> commit rights on the repo after a while and to close (or putting into >> stale) PR made by "external" people if there is not activity for a while. >> >> This could speed up the cue of PR and prevent eventual breaking of docs. >> >> Cheers >> >> Matteo >> ___ >> QGIS-Developer mailing list >> QGIS-Developer@lists.osgeo.org >> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer >> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi Matteo, Your suggestion sounds good to me. Andreas Am 16.01.19 um 08:42 schrieb matteo: Hi Anita, I am not very enthusiast of the automatic merging and closing of PRs. People have different velocities, and I don't think it's good to close a someones PR (that put some good work on it) just because no one with merge rights was able to review it. It is very discouraging. I think the suggestion was to automatically accept and merge them if nobody with merge rights gets around to doing it. nope. What I'm suggesting is to automatic merge PR made by author having commit rights on the repo after a while and to close (or putting into stale) PR made by "external" people if there is not activity for a while. This could speed up the cue of PR and prevent eventual breaking of docs. Cheers Matteo ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi Anita, > I am not very enthusiast of the automatic merging and closing of > PRs. People have different velocities, and I don't think it's good > to close a someones PR (that put some good work on it) just because > no one with merge rights was able to review it. It is very discouraging. > > > I think the suggestion was to automatically accept and merge them if > nobody with merge rights gets around to doing it. nope. What I'm suggesting is to automatic merge PR made by author having commit rights on the repo after a while and to close (or putting into stale) PR made by "external" people if there is not activity for a while. This could speed up the cue of PR and prevent eventual breaking of docs. Cheers Matteo ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
No. the proposal was to automatically merge PRs from people with commit rigths and close PR from people that have not. A ter, 15/01/2019, 18:41, Anita Graser escreveu: > > > On Tue, Jan 15, 2019 at 5:02 PM Alexandre Neto > wrote: > >> I am not very enthusiast of the automatic merging and closing of PRs. >> People have different velocities, and I don't think it's good to close a >> someones PR (that put some good work on it) just because no one with merge >> rights was able to review it. It is very discouraging. >> > > I think the suggestion was to automatically accept and merge them if > nobody with merge rights gets around to doing it. > > Regards, > Anita > -- Alexandre Neto - @AlexNetoGeo http://sigsemgrilhetas.wordpress.com http://gisunchained.wordpress.com ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
On Tue, Jan 15, 2019 at 5:02 PM Alexandre Neto wrote: > I am not very enthusiast of the automatic merging and closing of PRs. > People have different velocities, and I don't think it's good to close a > someones PR (that put some good work on it) just because no one with merge > rights was able to review it. It is very discouraging. > I think the suggestion was to automatically accept and merge them if nobody with merge rights gets around to doing it. Regards, Anita ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi Alexandre, thanks for the inputs.. :) > I agree that we have a long time issue with Documentation. To me, it can > only be solved with someone working on it "full-time", Which seems to be > the case if Larissa starts working on it. +0. We already have many many commits and PR each day since a lot of time. Of course people are interested/involved in different topics and anyone contributes in the way he/she thinks is better. Therefore, review is of course not the most interesting part... (at least I prefer to write new doc from scratch than reviewing) > On the other hand, we have the review part, which is something that even > fewer people participate (me included), and it takes forever... +1 We had PR stacked fro months and as I said, merging clean PR (clean = not breaking anything) is better: also new people can fix errors and/or improve the docs with the Fix me button without dealing with git/sphinx/compilation and so on.. > I am not very enthusiast of the automatic merging and closing of PRs. > People have different velocities, and I don't think it's good to close a > someones PR (that put some good work on it) just because no one with > merge rights was able to review it. It is very discouraging. I'm not happy too. But IMHO is worst to have PR with hundreds of comments or PR left there for months. This could be also very discouraging (not only for new people making the first step into the project). > On the other hand, if the person has commit rights, then technically he > can merge it himself , when he feels the work is ready (assuming that, > like Matteo said it's not breaking anything), without the need for a > bot. I still think that a review would be is required... Just like it > happens in the Code side. Maybe Larissa can also review PRs?! That would > speed thing up. > > Now, I believe that we should not have opened tickets forever with > hundreds of comments in it. > > The geoserver team uses the following rule: > > - At least one review is needed (beg it to a friend if needed) > - After addressing all the ISSUES found on the first review, the > committer can merge. He should not wait for a second review to see if > the new changes are ok, and then again and again... > - Any "good to have" observations/comments, should be moved to a new > ticket for future improvements. I'm digging into this github app topic and it seems that setting up one or more bots is more or less straightforward. Some of them allows to mark a PR not mergable if at least one review is made. I don't know what workflow is better to make things NOT complicated AND to speed up the process WITHOUT loosing documentation quality. For sure it is a good chance to discuss in the next HF My 10 cents :) Matteo ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi, I am sorry for the late reply, I have just noticed this discussion. I agree that we have a long time issue with Documentation. To me, it can only be solved with someone working on it "full-time", Which seems to be the case if Larissa starts working on it. On the other hand, we have the review part, which is something that even fewer people participate (me included), and it takes forever... I am not very enthusiast of the automatic merging and closing of PRs. People have different velocities, and I don't think it's good to close a someones PR (that put some good work on it) just because no one with merge rights was able to review it. It is very discouraging. On the other hand, if the person has commit rights, then technically he can merge it himself , when he feels the work is ready (assuming that, like Matteo said it's not breaking anything), without the need for a bot. I still think that a review would be is required... Just like it happens in the Code side. Maybe Larissa can also review PRs?! That would speed thing up. Now, I believe that we should not have opened tickets forever with hundreds of comments in it. The geoserver team uses the following rule: - At least one review is needed (beg it to a friend if needed) - After addressing all the ISSUES found on the first review, the committer can merge. He should not wait for a second review to see if the new changes are ok, and then again and again... - Any "good to have" observations/comments, should be moved to a new ticket for future improvements. My 5 cents, Alex Neto matteo escreveu no dia terça, 15/01/2019 às 12:06: > Hi, > > I found this: > > https://doc.mergify.io/index.html > > seems pretty straightforward to use (I'll make some test on test > repositories). > > Somebody has already experiences on this side? > > Cheers > > Matteo > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer -- Alexandre Neto - @AlexNetoGeo http://sigsemgrilhetas.wordpress.com http://gisunchained.wordpress.com ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi, I found this: https://doc.mergify.io/index.html seems pretty straightforward to use (I'll make some test on test repositories). Somebody has already experiences on this side? Cheers Matteo ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi all, On 15/01/19 12:29, Matteo Ghetta wrote: > * automatic merging if the PR author has write rights on the repo > * merging should consider milestone > * not merging if some activity? > > other comments? it makes sense to me. I'd add making sure the automatic merges are echoed e.g. on qgis-doc ML, to make sure nothing is overlooked. All the best. -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi thanks for the feedback > It could be nice to have some pull requests hanging around for > a longer time. of course when needed :) > Currently there are two documentation pull request that target > version 3.6. They should be kept on hold until 3.4 (LTR) is > branched out. > So an automatic job should consider the milestone. don't know (yet) the technical stuff behind that, but yes > Merging should also be delayed while the pull request is being > discussed, so with a one week (or other) rule, the "timer" > should be restarted when there is input. If for some reasons we want to keep a PR open we can just write a "ping" comment to have some activity rather that a stale So to make a brief summary: * automatic merging if the PR author has write rights on the repo * merging should consider milestone * not merging if some activity? other comments? Cheers Matteo ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
On 11. jan. 2019 09:11, Paolo Cavallini wrote: Hi all, On 10/01/19 19:25, matteo wrote: What I want to propose is a system similar to the coding one: a kind of stale bot that closes PR automatically after a while. Actually I'd like to go a step further: if the PR is made by a person with writing rights than the PR is automatically merged (if the Travis is happy) while if the person has not commit rights, then the PR is closed automatically to prevent really ugly docs (not sure if this is achievable). I agree in accepting PRs, either automatically or manually, after a reasonable delay. A week seems OK for me. All the best. It could be nice to have some pull requests hanging around for a longer time. Currently there are two documentation pull request that target version 3.6. They should be kept on hold until 3.4 (LTR) is branched out. So an automatic job should consider the milestone. Merging should also be delayed while the pull request is being discussed, so with a one week (or other) rule, the "timer" should be restarted when there is input. Håvard -- Håvard Tveite Faculty of Science and Technology, NMBU Drøbakveien 31, POBox 5003, N-1432 Ås, NORWAY Phone: +47 67231548 Web: http://www.nmbu.no ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi all again, really nobody has some feedback to give on doc topic? Cheers Matteo On 1/10/19 7:25 PM, matteo wrote: > Hi all, > > I want to raise some proposal for the documentation process of QGIS. I > think that we can all agree that the documentation is our weak part: no > matters if we have some budget or not, but even with sponsors, docs are > months away to be up to date with the code. We have an endless list of > issues that grows and grows. > > BTW: this is nobody fault, we are just to few doc writers, that's it > > Furthermore there are some PR stacked from months [0] (with and without > reviews). > > What I want to propose is a system similar to the coding one: a kind of > stale bot that closes PR automatically after a while. Actually I'd like > to go a step further: if the PR is made by a person with writing rights > than the PR is automatically merged (if the Travis is happy) while if > the person has not commit rights, then the PR is closed automatically to > prevent really ugly docs (not sure if this is achievable). > > I think we spent a lot of efforts on "appearance" of the docs rather > then contents (again, nobody fault, just me that prefers contents than > appearance). > > Personally I'd prefer to have updated manuals and correct all the rest > in a second moment. With the fix me button on each page and with > Alexandre's features that allows to see images directly on the repo it > is definitely more easy also for not skilled people to correct some > mistake than to add new text from scratch. > > I'm repeating again: this is not an attack on anyone, it is just what > came into my mind: AKA my 2 cents ;) > > Hoping to start a discussion > > Cheers > > Matteo > > > [0] https://github.com/qgis/QGIS-Documentation/pulls > ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Proposal for QGIS Documentation
Hi all, On 10/01/19 19:25, matteo wrote: > What I want to propose is a system similar to the coding one: a kind of > stale bot that closes PR automatically after a while. Actually I'd like > to go a step further: if the PR is made by a person with writing rights > than the PR is automatically merged (if the Travis is happy) while if > the person has not commit rights, then the PR is closed automatically to > prevent really ugly docs (not sure if this is achievable). I agree in accepting PRs, either automatically or manually, after a reasonable delay. A week seems OK for me. All the best. -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
