Re: [Qt-creator] Pretty old changes on gerrit

2015-06-05 Thread André Hartmann
Hi Jochen,

  there are quite a number of very old changes on gerrit's master which
  past the sanity bot review but never got a human review. Would it help
  reviewing those changes starting with the oldest one?

For sure! If the changes are old, it may be better to ask the author 
first if they are still relevant.

  May I add myself as reviewer to changes?

Yes. I do that too, if I have time, I am interested in the change and 
find something to comment on.

  Of course there is the coding style but should a reviewer also run
  tests with the reviewed code?

  Should changes be built with qmake and qbs always?

Please read the following, it's not Qt specific but in general useful:

http://gerrit-training.scmforge.com/target/gerrit-and-code-review-best-practices/

To summarize possible review steps:

1. Read the code and look for style and logic errors
2. Suggest improvements
3. Cherry-pick the change to your local repo,
does it apply without merge conflicts?
4. Compile the change, are there warnings or errors
5. Test the change

As Qt is cross-platform, 4 and 5 may work on one platform, but fail on 
an other. So every tester is welcome.

Best regards,
André

Am 04.06.2015 um 23:37 schrieb Jochen Becher:
 Hello,

 there are quite a number of very old changes on gerrit's master which
 past the sanity bot review but never got a human review. Would it help
 reviewing those changes starting with the oldest one?

 As I hope to publish my ModelEditor plugin in the next days and hope to
 for reviews soon I am willing to help with other reviews of course. May
 I add myself as reviewer to changes?

 I couldn't find documentation about expectations on reviews. Of course
 there is the coding style but should a reviewer also run tests with the
 reviewed code? What about documentation? Is this always reviewed by
 Leena? Should changes be built with qmake and qbs always?

 Regards, Jochen


 ___
 Qt-creator mailing list
 Qt-creator@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/qt-creator



-- 
Best regards / Mit freundlichen Grüßen
André Hartmann, Dipl.-Ing. (FH)
Software Project Manager

iseg Spezialelektronik GmbH |  phone: ++49 (0)351 26996-43
Bautzner Landstr. 23|  fax:   ++49 (0)351 26996-21
D-01454 Radeberg / Rossendorf   |  web:   www.iseg-hv.com

Geschäftsführer / Managing director: Dr. F. Gleisberg, Dr. J. Pöthig
Amtsgericht / Lower district court: Dresden HRB 16250
Ust.-Id.-Nr. / VAT-ID: DE812508942

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte
sofort den Absender und vernichten Sie diese Mail.
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser
Mail ist nicht gestattet.

This e-mail may contain confidential and/or privileged information.
If you are not the intended recipient (or have received this e-mail
in error) please notify the sender immediately and delete this e-mail.
Any unauthorized copying, disclosure or distribution of the material
in this e-mail is strictly forbidden.
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator


Re: [Qt-creator] Which plugins are you working on?

2015-06-05 Thread Typz
Hello all,

I am somewhat working on a unit test plugin, supporting only the crpcut test 
framework at the moment, though the idea is to be more generic. 
It is now in a working state, and I regularly update it to keep compatibility 
with more recent QtC builds. But it really needs some cleanup and refactoring 
before I can possibly try to submit…

On that subject, there seems to be quite a few such plugins already:
  * The enterprise-only qttest plugin.
  * The old GPL qttest plugin: 
https://qt.gitorious.org/qt-creator/qt-creator-qttest, which seems to be 
abandoned? Looks similar to the new qttest plugin, but largely outdated. Is 
there any relation?
  * A google test plugin : https://github.com/OneMoreGres/qtc-gtest
  * and my own plugin

Is there any chance the ‘base’ unit test plugin/framework would be 
open-sourced? This would help solving the various integration issues (e.g. the 
project automatically creates run configurations, but the unit test plugin(s) 
know which arguments need to be given in which situation…)

Best regards,

— 
Francois

 On May 25, 2015, at 7:46 AM, Carel Combrink carel.combr...@gmail.com wrote:
 
 Hi Tobias, list
 
 I am working on a SpellChecker Plugin for Qt Creator to check spelling of 
 comments and string literals in C/C++ files.
 
 I have just (last night) created a new release that adds the option so select 
 C, C++ or both types of comments to be checked. It already has a lot of 
 settings and has a few widgets that integrate into Qt Creator. 
 
 I have compiled plugins for both Windows and Linux(x64) versions of Qt 
 Creator 3.4 that can just be deployed with a few easy steps after 
 downloading. 
 
 Check out the plugin on my GitHub page: 
 https://github.com/CJCombrink/SpellChecker-Plugin 
 https://github.com/CJCombrink/SpellChecker-Plugin
 Releases can be downloaded from: 
 https://github.com/CJCombrink/SpellChecker-Plugin/releases 
 https://github.com/CJCombrink/SpellChecker-Plugin/releases
 The wiki page shows some screenshots: 
 https://github.com/CJCombrink/SpellChecker-Plugin/wiki 
 https://github.com/CJCombrink/SpellChecker-Plugin/wiki
 
 One goal is to try and integrate into Qt Creator but not sure when I will get 
 to doing that and the amount of effort that it will take.
 
 Any comments and feedback will be appreciated. 
 Regards,
 
 On Sat, May 23, 2015 at 7:44 AM, Denis Shienkov denis.shien...@gmail.com 
 mailto:denis.shien...@gmail.com wrote:
 Hi.
 
 Recently I need to make a remote debugging on Win32 target (remote PC). Where 
 it is not possible to use the mouse  keyboard. So, I start to implement the 
 RemoteWindows plugin (similar to RemoteLinux, but withous the SSH), where are 
 used WinRS (to remote startup of process) and netuse (to uploading a files 
 for remote deployment). 
 
 But this work still is not completed and I don't need in it anymore (because 
 a my project already is complete without remote debugging). 
 
 So, if a remote debuging for Win32 it is useful idea, then I can continue the 
 RemoteWindows plugin (this sources is on my PC locally).  :)
 
 BR,
 Denis
 
 23.05.2015 1:06, Hugo Parente Lima пишет:
 Hi,
 
 A plugin to add support for the Ruby language into QtCreator.
 
 I use my own plugin everyday on my daily job and it's nice! at least for my 
 needs :-P
 
 https://github.com/hugopl/RubyCreator https://github.com/hugopl/RubyCreator
 
 On Fri, May 22, 2015 at 5:45 PM, Hunger Tobias 
 tobias.hun...@theqtcompany.com mailto:tobias.hun...@theqtcompany.com 
 wrote:
 Hi Mailing list!
 
 In the NimPlugin thread there were some people implying that they are 
 working on custom Qt Creator plugins. I do know about some of those, but I 
 would be really curious as to what else is out there:-)
 
 So I would like to ask: What kind of plugins do you work on?
 
 What can we do to make things easier for you? Yes, a build service would be 
 nice, but from my perspective I do not see that happening anytime soon:-/ 
 Sorry about that.
 
 Have you ever considered to contribute your plugins? What is keeping you 
 from doing so?
 
 Best Regards,
 Tobias
 
 PS: Please feel free to reply in private. I understand that some of you are 
 not able to discuss their work in public, but I am still awfully curious 
 about the cool stuff that you people are doing with Qt Creator and the 
 extensions you wrote for it :-)
 
 --
 Tobias Hunger, Senior Software Engineer | The Qt Company
 
 The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin
 Geschäftsführer: Mika Pälsi, Juha Varelius, Tuula Haataja Sitz der 
 Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 
 144331 B
 ___
 Qt-creator mailing list
 Qt-creator@qt-project.org mailto:Qt-creator@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/qt-creator 
 http://lists.qt-project.org/mailman/listinfo/qt-creator
 
 
 
 -- 
 Hugo Parente Lima
 
 
 
 ___
 Qt-creator mailing list