Hi all,

as there has been no further comment so far, I'll ask in a more direct way:

Is it Ok to completely replace the Git Branches dialog with a Git Branches side panel?

Regards,
André

Am 07.07.2018 um 13:45 schrieb André Hartmann:
Hi all,

first apologize for breaking the thread, I only had a "digest mail account" till now.

Thanks Orgad for bringing this topic up. I hoped it would raise more interest though...

For my motivation: I dislike the Git branches dialog, as it always gets in the way. Usually, when working with branches you need to see diffs or resolve conflicts, so you need the editor windows too. As we now have the left and right side panel, I thought it would be a good idea to move this dialog to these panels.

The branches window itself is very useful as it allows *a lot* of Git operations to be done, so I think having it visible always is a good option. I'd move it to the right side panel, so it disappers while debugging (you don't need it during debugging).

I don't use the programs mentioned by Michael, but I think we get a lot closes to them with this panel.

The only questions that arises now is: Should it already get a wider scope, i.e. should it not only contain the branches window but also the changed files list, a "fast commit" window, etc.?

What do you think?

One more note: The side panels are a bit more mouse-centric, as many options are in context menus. That is no big problem for me (and I'm already using the keyboard very much!), but may hurt others. Any opinion on this?

A compromise would even be, if the side panels could be un-docked and docked again. But I think we don't have the needed infrastructure for now.

Thanks for reading this long mail. I'm awaiting your opinions :)

Regards,
André

Am 05.07.2018 um 07:58 schrieb qt-creator-requ...@qt-project.org:
Send Qt-creator mailing list submissions to
    qt-creator@qt-project.org

To subscribe or unsubscribe via the World Wide Web, visit
    http://lists.qt-project.org/mailman/listinfo/qt-creator
or, via email, send a message with subject or body 'help' to
    qt-creator-requ...@qt-project.org

You can reach the person managing the list at
    qt-creator-ow...@qt-project.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Qt-creator digest..."


Today's Topics:

    1. Re: Branches side-panel (Michael Jackson)
    2. Re: QtCreator 4.7 RC Feedback (Michael Jackson)
    3. Re: QtCreator 4.7 RC Feedback (Eike Ziller)


----------------------------------------------------------------------

Message: 1
Date: Wed, 04 Jul 2018 22:17:39 -0400
From: Michael Jackson <mike.jack...@bluequartz.net>
To: <qt-creator@qt-project.org>
Subject: Re: [Qt-creator] Branches side-panel
Message-ID: <c41990b5-6354-4200-abca-2ee35817f...@bluequartz.net>
Content-Type: text/plain;    charset="UTF-8"

<dreaming>I would love to see a "workspace" that basically incorporates the functionality of something like SourceTree or GitKraken into QtCreator.</dreaming> I don't actually know what QtCreator has to offer by way of Git functionality because those 2 applications are that good.

--
Mike Jackson

?On 7/4/18, 9:10 AM, "Qt-creator on behalf of Mathias Hasselmann" <qt-creator-bounces+mike.jackson=bluequartz....@qt-project.org on behalf of math...@taschenorakel.de> wrote:

     Hi Orgad,
     I'd totally love to see (much) better git integration in QtCreator and      replacing the branches dialog would with a panel be a great start for a      more natural git experience in QtCreator. I'd really love to see such
     change!
     Thanks,
     Mathias
     Am 02.07.2018 um 19:49 schrieb Orgad Shaneh:
     > Hi,
     >
     > There is a pending change
     > <https://codereview.qt-project.org/217408> by Andr? Hartmann that
     > introduces a Branches side-panel for Git.
     >
     > The current dialog is not modal, which I find a bit confusing, and it      > has many buttons with dynamic enable/disable state. It also hides the
     > main window when open.
     >
     > Before we proceed with it, I'd like to hear your opinions:
     >
     >   * Do you like it as a panel?
     >   * Do you prefer the panel or the current dialog?
     >   * How about removing the dialog and replacing it by the panel?
     >
     > Thanks,
     > - Orgad
     >
     >
     > _______________________________________________
     > Qt-creator mailing list
     > Qt-creator@qt-project.org
     > http://lists.qt-project.org/mailman/listinfo/qt-creator
     >
     _______________________________________________
     Qt-creator mailing list
     Qt-creator@qt-project.org
     http://lists.qt-project.org/mailman/listinfo/qt-creator




------------------------------

Message: 2
Date: Wed, 04 Jul 2018 22:32:40 -0400
From: Michael Jackson <mike.jack...@bluequartz.net>
To: "qt-creator@qt-project.org" <qt-creator@qt-project.org>
Subject: Re: [Qt-creator] QtCreator 4.7 RC Feedback
Message-ID: <49133341-7a34-45b1-8af3-ad9cea9e9...@bluequartz.net>
Content-Type: text/plain; charset="utf-8"

Ok, Good suggestion. I went back and for the QtC 4.6 test the Clang code model was turned off. So I went back and tried again. The Syntax highlighting took about 5 seconds for the particular file that I am using as my benchmark. More Importantly the drop down was populated with the methods of the class in about 2 seconds which is reasonable. At least I can start navigating quickly. By the time I find the method I am interested in, the syntax highlighting is kicking in. With QtC 4.7 it is a different story. The function drop down appears at the same time as I get the highlighting which is about 10 seconds based on my screen captures. Of course I also get the full syntax highlighting at that point also BUT not I have to wait that entire time. I guess I would rather have the function drop down get populated first, then the syntax highlighting/code completion if that takes longer? Of course I could argue it both ways. I got used to the way that Qt4.5 and 4.6 did it so now having   to wait breaks the cadence of opening a file and getting right to work on it.


My system is macOS 10.13.x on a 2013 15? MacBook Pro. I sure hope that Xcode?s libClang is not getting in the way. I would hope that the one from QtC is used. Not sure how I would check that.


I can do some side by side screen recordings showing the differences on my system anyone is interested.


--

Mike Jackson


On 7/4/18, 3:33 PM, "Ivan Donchevskii" <ivan.donchevs...@qt.io> wrote:


Hi!
If the initial parsing time is absolutely crucial for you you can turn ClangCodeModel plugin off (it's turned on be default since 4.7). ClangCodeModel provides more precise results but takes longer to parse files. We did some work to make it faster but the most recent part of it was mostly about code completion.

Also it's important that you use our prebuilt libclang shipped with Qt Creator installer but not the one in your system because it might provide the slowdown.


Hope that my answer helps you

Kind regards
Ivan

From: Qt-creator <qt-creator-bounces+ivan.donchevskii=qt...@qt-project.org> on behalf of Michael Jackson <mike.jack...@bluequartz.net>
Sent: Wednesday, July 4, 2018 6:10:08 PM
To: qt-creator@qt-project.org
Subject: [Qt-creator] QtCreator 4.7 RC Feedback


     Just wanted to throw some feedback while I use the 4.7 Betas and RCs on my macOS systems. For the most part I like what I am seeing but there currently is an issue that is really starting to get in the way. The speed at which a C++ file is parsed so that all the syntax highlighting and coloring becomes available is taking way too long. With QtCreator 4.5 and 4.6 I would open a file and only a second at most would pass and the method drop downs would be populated and I could start navigating. With the 4.7 series (latest I pulled was from July 4th) it takes 10 seconds to get the syntax highlighting and navigating. (I did a side-by-side comparison with a screen recording to verify the times).      I know that QtCreator is still in the RC mode and still being developed but that wait times are making navigating a real issue. My question: Are there still optimizations still being worked on for the final release? I know from a previous post that the code model and clang-tidy were thrown onto separate threads for good reasons but something else is happening to slow down that initial parse/navigation stage.

   Again, thank you for the wonderful IDE that I use and rely on every day. I don't think I could develop C++ codes on macOS without it.

--
Mike Jackson | Owner, President
       BlueQuartz Software
[e] mike.jack...@bluequartz.net
[w] www.bluequartz.net



_______________________________________________
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/qt-creator/attachments/20180704/960eaa7a/attachment-0001.html>

------------------------------

Message: 3
Date: Thu, 5 Jul 2018 05:45:16 +0000
From: Eike Ziller <eike.zil...@qt.io>
To: Michael Jackson <mike.jack...@bluequartz.net>
Cc: "qt-creator@qt-project.org" <qt-creator@qt-project.org>
Subject: Re: [Qt-creator] QtCreator 4.7 RC Feedback
Message-ID: <7a65bf77-0a45-4046-82cb-61e3beee5...@qt.io>
Content-Type: text/plain; charset="utf-8"


On Jul 5, 2018, at 04:32, Michael Jackson <mike.jack...@bluequartz.net> wrote:

Ok, Good suggestion. I went back and for the QtC 4.6 test the Clang code model was turned off. So I went back and tried again. The Syntax highlighting took about 5 seconds for the particular file that I am using as my benchmark. More Importantly the drop down was populated with the methods of the class in about 2 seconds which is reasonable. At least I can start navigating quickly. By the time I find the method I am interested in, the syntax highlighting is kicking in. With QtC 4.7 it is a different story. The function drop down appears at the same time as I get the highlighting which is about 10 seconds based on my screen captures. Of course I also get the full syntax highlighting at that point also BUT not I have to wait that entire time. I guess I would rather have the function drop down get populated first, then the syntax highlighting/code completion if that takes longer? Of course I could argue it both ways. I got used to the way that Qt4.5 and 4.6 did it so now havin
  g to wait breaks the cadence of opening a file and getting right to work on it.
My system is macOS 10.13.x on a 2013 15? MacBook Pro. I sure hope that Xcode?s libClang is not getting in the way. I would hope that the one from QtC is used. Not sure how I would check that.

I doubt that some other libclang gets in the way, but to be sure you can check in Activity Monitor:

- find and select the Qt Creator process
- click the info tool button
- select ?Open Files and Ports?
- search for libclang and check the path

Br, Eike

I can do some side by side screen recordings showing the differences on my system anyone is interested.
--
Mike Jackson
On 7/4/18, 3:33 PM, "Ivan Donchevskii" <ivan.donchevs...@qt.io> wrote:
Hi!
If the initial parsing time is absolutely crucial for you you can turn ClangCodeModel plugin off (it's turned on be default since 4.7). ClangCodeModel provides more precise results but takes longer to parse files. We did some work to make it faster but the most recent part of it was mostly about code completion.

Also it's important that you use our prebuilt libclang shipped with Qt Creator installer but not the one in your system because it might provide the slowdown.


Hope that my answer helps you

Kind regards
Ivan

From: Qt-creator <qt-creator-bounces+ivan.donchevskii=qt...@qt-project.org> on behalf of Michael Jackson <mike.jack...@bluequartz.net>
Sent: Wednesday, July 4, 2018 6:10:08 PM
To: qt-creator@qt-project.org
Subject: [Qt-creator] QtCreator 4.7 RC Feedback
     Just wanted to throw some feedback while I use the 4.7 Betas and RCs on my macOS systems. For the most part I like what I am seeing but there currently is an issue that is really starting to get in the way. The speed at which a C++ file is parsed so that all the syntax highlighting and coloring becomes available is taking way too long. With QtCreator 4.5 and 4.6 I would open a file and only a second at most would pass and the method drop downs would be populated and I could start navigating. With the 4.7 series (latest I pulled was from July 4th) it takes 10 seconds to get the syntax highlighting and navigating. (I did a side-by-side comparison with a screen recording to verify the times).      I know that QtCreator is still in the RC mode and still being developed but that wait times are making navigating a real issue. My question: Are there still optimizations still being worked on for the final release? I know from a previous post that the code model and clang-tidy were thrown onto separate threads for good reasons but something else is happening to slow down that initial parse/navigation stage.

   Again, thank you for the wonderful IDE that I use and rely on every day. I don't think I could develop C++ codes on macOS without it.

--
Mike Jackson | Owner, President
       BlueQuartz Software
[e] mike.jack...@bluequartz.net
[w] www.bluequartz.net



_______________________________________________
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator
_______________________________________________
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator


_______________________________________________
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

_______________________________________________
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Reply via email to