[quagga-dev 15468] CI Testresult: PASSED (Re: [quagga-dev, 15454] pimd: Add ability to safely ignore route-maps)

[cisystem]

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF CI System 

This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1965: http://patchwork.quagga.net/patch/1965
   [quagga-dev,15454] pimd: Add ability to safely ignore route-maps
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-304/


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15466] CI Testresult: PASSED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

[cisystem]

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF CI System 

This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1961: http://patchwork.quagga.net/patch/1961
   [quagga-dev,15450,1/3] pimd: Remove dead code.
  Patchwork 1962: http://patchwork.quagga.net/patch/1962
   [quagga-dev,15451,2/3] pimd: Remove source_new unneeded parameter
  Patchwork 1963: http://patchwork.quagga.net/patch/1963
   [quagga-dev,15452,3/3] pimd: Remove igmp_add_group_by_addr unneeded 
parameter
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-302/


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15465] Re: CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

[Martin Winter]

On 6 Jun 2016, at 18:45, Donald Sharp wrote:


Martin -

Looks like something went wrong with your test system?


Yes. Added some patches and it seems it didn’t come back up all 
correct.


Ignore it - I’ll rerun in a few minutes and will trigger a new email 
at the end.


- Martin



donald

On Mon, Jun 6, 2016 at 9:40 PM,  wrote:


Continous Integration Result: FAILED

See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1961: http://patchwork.quagga.net/patch/1961
   [quagga-dev,15450,1/3] pimd: Remove dead code.
  Patchwork 1962: http://patchwork.quagga.net/patch/1962
   [quagga-dev,15451,2/3] pimd: Remove source_new unneeded 
parameter

  Patchwork 1963: http://patchwork.quagga.net/patch/1963
   [quagga-dev,15452,3/3] pimd: Remove igmp_add_group_by_addr 
unneeded

parameter
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: 
https://ci1.netdef.org/browse/QUAGGA-QPWORK-302/



Get source and apply patch from patchwork: Successful


Building Stage: Successful


Basic Tests: Failed

Static analyzer (clang): Successful


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education
Foundation,
For more information, see www.netdef.org and 
www.opensourcerouting.org

For questions in regards to this CI System, contact Martin Winter,
mwin...@netdef.org



___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15464] Re: [PATCH] bgpd: fix potential crash in community_list_dup_check

[Donald Sharp]

Acked-by: Donald Sharp 

On Mon, Jun 6, 2016 at 4:22 PM, Christian Franke <
ch...@opensourcerouting.org> wrote:

> From: Christian Franke 
>
> extcommunity_list_set may set the ->config for an entry
> to NULL. In this case, the old code in community_list_dup_check
> would cause a NULL pointer dereference.
>
> Adjust the code so it behaves the same in the absence of NULL
> pointers and otherwise checks if both are NULL to determine
> equality.
>
> Signed-off-by: Christian Franke 
> ---
>  bgpd/bgp_clist.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/bgpd/bgp_clist.c b/bgpd/bgp_clist.c
> index bb06028..1f1a4e7 100644
> --- a/bgpd/bgp_clist.c
> +++ b/bgpd/bgp_clist.c
> @@ -644,7 +644,10 @@ community_list_dup_check (struct community_list *list,
>break;
>  case COMMUNITY_LIST_EXPANDED:
>  case EXTCOMMUNITY_LIST_EXPANDED:
> -  if (strcmp (entry->config, new->config) == 0)
> +  if (entry->config && new->config
> +  && strcmp (entry->config, new->config) == 0)
> +return 1;
> +  if (!entry->config && !new->config)
>  return 1;
>break;
>  default:
> --
> 2.8.0
>
>
> ___
> Quagga-dev mailing list
> Quagga-dev@lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15463] CI Testresult: FAILED (Re: [quagga-dev, 15454] pimd: Add ability to safely ignore route-maps)

[cisystem]

Continous Integration Result: FAILED

See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1965: http://patchwork.quagga.net/patch/1965
   [quagga-dev,15454] pimd: Add ability to safely ignore route-maps
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-304/


Get source and apply patch from patchwork: Successful


Building Stage: Successful


Basic Tests: Failed

Ipv6 protocols on ubuntu 14.04: Successful
Static analyzer (clang): Successful


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15462] Re: [PATCH] zebra: make fpm netlink_route_info_fill more robust

[Donald Sharp]

Christian -

How is this possible?  In zfpm_encode_route we set cmd == RTM_DELROUTE if
rib == NULL.

Is this setup for some new code?

donald

On Mon, Jun 6, 2016 at 4:04 PM, Christian Franke <
ch...@opensourcerouting.org> wrote:

> From: Christian Franke 
>
> Having an RTM_ADDROUTE with a rib == NULL would lead
> to a crash due to a NULL pointer dereference.
>
> Since an RTM_ADDROUTE without a rib object doesn't make
> much sense, print a warning and remove the concerned
> route instead.
>
> Signed-off-by: Christian Franke 
> ---
>  zebra/zebra_fpm_netlink.c | 11 ---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/zebra/zebra_fpm_netlink.c b/zebra/zebra_fpm_netlink.c
> index 0173000..e2c6b8b 100644
> --- a/zebra/zebra_fpm_netlink.c
> +++ b/zebra/zebra_fpm_netlink.c
> @@ -251,11 +251,16 @@ netlink_route_info_fill (netlink_route_info_t *ri,
> int cmd,
> * An RTM_DELROUTE need not be accompanied by any nexthops,
> * particularly in our communication with the FPM.
> */
> -  if (cmd == RTM_DELROUTE && !rib)
> +  if (cmd == RTM_DELROUTE)
>  goto skip;
>
> -  if (rib)
> -ri->rtm_protocol = netlink_proto_from_route_type (rib->type);
> +  if (!rib)
> +{
> +  zlog_err("netlink_route_info_fill RTM_ADDROUTE called without rib
> info");
> +  return 0;
> +}
> +
> +  ri->rtm_protocol = netlink_proto_from_route_type (rib->type);
>
>if ((rib->flags & ZEBRA_FLAG_BLACKHOLE) || (rib->flags &
> ZEBRA_FLAG_REJECT))
>  discard = 1;
> --
> 2.8.0
>
>
> ___
> Quagga-dev mailing list
> Quagga-dev@lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15461] CI Testresult: FAILED (Re: [quagga-dev, 15453] pimd: Add support for displaying ip mroute)

[cisystem]

Continous Integration Result: FAILED

See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1964: http://patchwork.quagga.net/patch/1964
   [quagga-dev,15453] pimd: Add support for displaying ip mroute
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-303/


Get source and apply patch from patchwork: Successful


Building Stage: Successful


Basic Tests: Failed

Ipv6 protocols on ubuntu 14.04: Successful
Static analyzer (clang): Successful


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15460] Re: CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

[Donald Sharp]

Martin -

Looks like something went wrong with your test system?

donald

On Mon, Jun 6, 2016 at 9:40 PM,  wrote:

> Continous Integration Result: FAILED
>
> See below for issues.
> This is an EXPERIMENTAL automated CI system.
> For questions and feedback, feel free to email
> Martin Winter .
>
> Patches applied :
>   Patchwork 1961: http://patchwork.quagga.net/patch/1961
>[quagga-dev,15450,1/3] pimd: Remove dead code.
>   Patchwork 1962: http://patchwork.quagga.net/patch/1962
>[quagga-dev,15451,2/3] pimd: Remove source_new unneeded parameter
>   Patchwork 1963: http://patchwork.quagga.net/patch/1963
>[quagga-dev,15452,3/3] pimd: Remove igmp_add_group_by_addr unneeded
> parameter
> Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
> CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-302/
>
>
> Get source and apply patch from patchwork: Successful
> 
>
> Building Stage: Successful
> 
>
> Basic Tests: Failed
> 
> Static analyzer (clang): Successful
>
>
> Regards,
>   NetDEF/OpenSourceRouting Continous Integration (CI) System
>
> ---
> OpenSourceRouting.org is a project of the Network Device Education
> Foundation,
> For more information, see www.netdef.org and www.opensourcerouting.org
> For questions in regards to this CI System, contact Martin Winter,
> mwin...@netdef.org
>
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15459] CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

[cisystem]

Continous Integration Result: FAILED

See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1961: http://patchwork.quagga.net/patch/1961
   [quagga-dev,15450,1/3] pimd: Remove dead code.
  Patchwork 1962: http://patchwork.quagga.net/patch/1962
   [quagga-dev,15451,2/3] pimd: Remove source_new unneeded parameter
  Patchwork 1963: http://patchwork.quagga.net/patch/1963
   [quagga-dev,15452,3/3] pimd: Remove igmp_add_group_by_addr unneeded 
parameter
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-302/


Get source and apply patch from patchwork: Successful


Building Stage: Successful


Basic Tests: Failed

Static analyzer (clang): Successful


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15458] Re: [PATCH] isisd: exit if daemonizing fails

[Donald Sharp]

Acked-by: Donald Sharp 

On Mon, Jun 6, 2016 at 3:13 PM, Christian Franke <
ch...@opensourcerouting.org> wrote:

> From: Christian Franke 
>
> The other daemons in Quagga exit with an error if they cannot fork.
> Change isisd to behave consistently.
>
> Signed-off-by: Christian Franke 
> ---
>  isisd/isis_main.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/isisd/isis_main.c b/isisd/isis_main.c
> index 3a73087..02ea0d7 100644
> --- a/isisd/isis_main.c
> +++ b/isisd/isis_main.c
> @@ -355,8 +355,11 @@ main (int argc, char **argv, char **envp)
>  return(0);
>
>/* demonize */
> -  if (daemon_mode)
> -daemon (0, 0);
> +  if (daemon_mode && daemon (0, 0) < 0)
> +{
> +  zlog_err("IS-IS daemon failed: %s", strerror(errno));
> +  exit (1);
> +}
>
>/* Process ID file creation. */
>if (pid_file[0] != '\0')
> --
> 2.8.0
>
>
> ___
> Quagga-dev mailing list
> Quagga-dev@lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15455] Re: [PATCH] ospf6d: remove unused broken function

[Donald Sharp]

Acked-by: Donald Sharp 

On Mon, Jun 6, 2016 at 3:49 PM, Christian Franke <
ch...@opensourcerouting.org> wrote:

> From: Christian Franke 
>
> ospf6_interface_if_del has not been in use since for quite some
> years and is broken. (Will crash ospf6d if oi->area == NULL)
>
> Since it is not used, just remove it.
>
> Signed-off-by: Christian Franke 
> ---
>  ospf6d/ospf6_interface.c | 23 ---
>  ospf6d/ospf6_interface.h |  1 -
>  ospf6d/ospf6_zebra.c |  7 ---
>  3 files changed, 31 deletions(-)
>
> diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
> index 26f68ac..c31f896 100644
> --- a/ospf6d/ospf6_interface.c
> +++ b/ospf6d/ospf6_interface.c
> @@ -340,29 +340,6 @@ ospf6_interface_if_add (struct interface *ifp)
>  }
>
>  void
> -ospf6_interface_if_del (struct interface *ifp)
> -{
> -  struct ospf6_interface *oi;
> -
> -  oi = (struct ospf6_interface *) ifp->info;
> -  if (oi == NULL)
> -return;
> -
> -  /* interface stop */
> -  if (oi->area)
> -thread_execute (master, interface_down, oi, 0);
> -
> -  listnode_delete (oi->area->if_list, oi);
> -  oi->area = (struct ospf6_area *) NULL;
> -
> -  /* cut link */
> -  oi->interface = NULL;
> -  ifp->info = NULL;
> -
> -  ospf6_interface_delete (oi);
> -}
> -
> -void
>  ospf6_interface_state_update (struct interface *ifp)
>  {
>struct ospf6_interface *oi;
> diff --git a/ospf6d/ospf6_interface.h b/ospf6d/ospf6_interface.h
> index 95a377f..8dffa7c 100644
> --- a/ospf6d/ospf6_interface.h
> +++ b/ospf6d/ospf6_interface.h
> @@ -153,7 +153,6 @@ extern void ospf6_interface_enable (struct
> ospf6_interface *);
>  extern void ospf6_interface_disable (struct ospf6_interface *);
>
>  extern void ospf6_interface_if_add (struct interface *);
> -extern void ospf6_interface_if_del (struct interface *);
>  extern void ospf6_interface_state_update (struct interface *);
>  extern void ospf6_interface_connected_route_update (struct interface *);
>
> diff --git a/ospf6d/ospf6_zebra.c b/ospf6d/ospf6_zebra.c
> index c8f20d8..b8366af 100644
> --- a/ospf6d/ospf6_zebra.c
> +++ b/ospf6d/ospf6_zebra.c
> @@ -120,13 +120,6 @@ ospf6_zebra_if_del (int command, struct zclient
> *zclient, zebra_size_t length,
>  zlog_debug ("Zebra Interface delete: %s index %d mtu %d",
> ifp->name, ifp->ifindex, ifp->mtu6);
>
> -#if 0
> -  /* XXX: ospf6_interface_if_del is not the right way to handle this,
> -   * because among other thinkable issues, it will also clear all
> -   * settings as they are contained in the struct ospf6_interface. */
> -  ospf6_interface_if_del (ifp);
> -#endif /*0*/
> -
>ifp->ifindex = IFINDEX_INTERNAL;
>return 0;
>  }
> --
> 2.8.0
>
>
> ___
> Quagga-dev mailing list
> Quagga-dev@lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15454] [PATCH] pimd: Add ability to safely ignore route-maps

[Donald Sharp]

pim was not parsing route-map code and causing issues
using vtysh because of this.  Add code to safely
ignore the route-map code and set us up for future
expansion into route-maps if neeeded.

Signed-off-by: Donald Sharp 
---
 pimd/Makefile.am|  3 ++-
 pimd/pim_main.c |  4 
 pimd/pim_routemap.c | 32 
 pimd/pimd.h |  2 ++
 4 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 pimd/pim_routemap.c

diff --git a/pimd/Makefile.am b/pimd/Makefile.am
index f57c4c2..d045436 100644
--- a/pimd/Makefile.am
+++ b/pimd/Makefile.am
@@ -52,7 +52,8 @@ libpim_a_SOURCES = \
pim_oil.c pim_zlookup.c pim_pim.c pim_tlv.c pim_neighbor.c \
pim_hello.c pim_ifchannel.c pim_join.c pim_assert.c \
pim_msg.c pim_upstream.c pim_rpf.c pim_macro.c \
-   pim_igmp_join.c pim_ssmpingd.c pim_int.c pim_static.c
+   pim_igmp_join.c pim_ssmpingd.c pim_int.c pim_static.c \
+pim_routemap.c
 
 noinst_HEADERS = \
pimd.h pim_version.h pim_cmd.h pim_signals.h pim_iface.h \
diff --git a/pimd/pim_main.c b/pimd/pim_main.c
index 5f4711e..ea70a8f 100644
--- a/pimd/pim_main.c
+++ b/pimd/pim_main.c
@@ -36,6 +36,8 @@
 #include "vty.h"
 #include "sigevent.h"
 #include "version.h"
+#include "prefix.h"
+#include "plist.h"
 
 #include "pimd.h"
 #include "pim_version.h"
@@ -200,6 +202,8 @@ int main(int argc, char** argv, char** envp) {
   memory_init();
   vrf_init();
   access_list_init();
+  prefix_list_init ();
+  pim_route_map_init ();
   pim_init();
 
   /*
diff --git a/pimd/pim_routemap.c b/pimd/pim_routemap.c
new file mode 100644
index 000..9cc13be
--- /dev/null
+++ b/pimd/pim_routemap.c
@@ -0,0 +1,32 @@
+/* PIM Route-map Code
+ * Copyright (C) 2016 Cumulus Networks 
+ *
+ * This file is part of Quagga
+ *
+ * Quagga is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2, or (at your option) any
+ * later version.
+ *
+ * Quagga is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Quagga; see the file COPYING.  If not, write to the Free
+ * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
+ * 02111-1307, USA.
+ */
+#include 
+
+#include "routemap.h"
+
+#include "pimd.h"
+
+void
+pim_route_map_init (void)
+{
+  route_map_init ();
+  route_map_init_vty ();
+}
diff --git a/pimd/pimd.h b/pimd/pimd.h
index aed26be..9a7e605 100644
--- a/pimd/pimd.h
+++ b/pimd/pimd.h
@@ -159,4 +159,6 @@ struct list  *qpim_static_route_list; /* list 
of routes added static
 void pim_init(void);
 void pim_terminate(void);
 
+extern void pim_route_map_init (void);
+
 #endif /* PIMD_H */
-- 
2.5.5


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15452] [PATCH 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter

[Donald Sharp]

The interface name is already passed in as
part of the 'struct igrmp *group' pointer.
No need to do it twice.

Signed-off-by: Donald Sharp 
---
 pimd/pim_igmp.c   | 13 ++---
 pimd/pim_igmp.h   |  3 +--
 pimd/pim_igmpv3.c | 11 +--
 3 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/pimd/pim_igmp.c b/pimd/pim_igmp.c
index 7baf2e3..0561d70 100644
--- a/pimd/pim_igmp.c
+++ b/pimd/pim_igmp.c
@@ -622,7 +622,7 @@ static int igmp_v2_report(struct igmp_sock *igmp,
   memcpy(_addr, igmp_msg + 4, sizeof(struct in_addr));
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = igmp_add_group_by_addr(igmp, group_addr);
   if (!group) {
 return -1;
   }
@@ -679,7 +679,7 @@ static int igmp_v1_report(struct igmp_sock *igmp,
   memcpy(_addr, igmp_msg + 4, sizeof(struct in_addr));
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = igmp_add_group_by_addr(igmp, group_addr);
   if (!group) {
 return -1;
   }
@@ -1357,8 +1357,7 @@ static struct igmp_group *find_group_by_addr(struct 
igmp_sock *igmp,
 }
 
 struct igmp_group *igmp_add_group_by_addr(struct igmp_sock *igmp,
- struct in_addr group_addr,
- const char *ifname)
+ struct in_addr group_addr)
 {
   struct igmp_group *group;
 
@@ -1396,8 +1395,8 @@ struct igmp_group *igmp_add_group_by_addr(struct 
igmp_sock *igmp,
   }
   group->group_source_list->del = (void (*)(void *)) igmp_source_free;
 
-  group->t_group_timer = 0;
-  group->t_group_query_retransmit_timer= 0;
+  group->t_group_timer = NULL;
+  group->t_group_query_retransmit_timer= NULL;
   group->group_specific_query_retransmit_count = 0;
   group->group_addr= group_addr;
   group->group_igmp_sock   = igmp;
@@ -1414,7 +1413,7 @@ struct igmp_group *igmp_add_group_by_addr(struct 
igmp_sock *igmp,
 char group_str[100];
 pim_inet4_dump("", group->group_addr, group_str, 
sizeof(group_str));
 zlog_debug("Creating new IGMP group %s on socket %d interface %s",
-  group_str, group->group_igmp_sock->fd, ifname);
+  group_str, igmp->fd, igmp->interface->name);
   }
 
   /*
diff --git a/pimd/pim_igmp.h b/pimd/pim_igmp.h
index f8a31cd..ab39615 100644
--- a/pimd/pim_igmp.h
+++ b/pimd/pim_igmp.h
@@ -163,8 +163,7 @@ struct igmp_group {
 };
 
 struct igmp_group *igmp_add_group_by_addr(struct igmp_sock *igmp,
- struct in_addr group_addr,
- const char *ifname);
+ struct in_addr group_addr);
 
 void igmp_group_delete_empty_include(struct igmp_group *group);
 
diff --git a/pimd/pim_igmpv3.c b/pimd/pim_igmpv3.c
index 1a2e936..8a32a32 100644
--- a/pimd/pim_igmpv3.c
+++ b/pimd/pim_igmpv3.c
@@ -542,12 +542,11 @@ static void allow(struct igmp_sock *igmp, struct in_addr 
from,
  struct in_addr group_addr,
  int num_sources, struct in_addr *sources)
 {
-  struct interface *ifp = igmp->interface;
   struct igmp_group *group;
   inti;
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = igmp_add_group_by_addr(igmp, group_addr);
   if (!group) {
 return;
   }
@@ -688,7 +687,7 @@ void igmpv3_report_isex(struct igmp_sock *igmp, struct 
in_addr from,
   ifp, from, group_addr, num_sources, sources);
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = igmp_add_group_by_addr(igmp, group_addr);
   if (!group) {
 return;
   }
@@ -810,7 +809,7 @@ void igmpv3_report_toin(struct igmp_sock *igmp, struct 
in_addr from,
   ifp, from, group_addr, num_sources, sources);
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = igmp_add_group_by_addr(igmp, group_addr);
   if (!group) {
 return;
   }
@@ -960,7 +959,7 @@ void igmpv3_report_toex(struct igmp_sock *igmp, struct 
in_addr from,
   ifp, from, group_addr, num_sources, sources);
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = igmp_add_group_by_addr(igmp, group_addr);
   if (!group) {
 return;
   }
@@ -1481,7 +1480,7 @@ void igmpv3_report_block(struct igmp_sock *igmp, struct 
in_addr from,
   ifp, from, group_addr, num_sources, sources);
 
   /* non-existant group is created as INCLUDE {empty} */
-  group = igmp_add_group_by_addr(igmp, group_addr, ifp->name);
+  group = 

[quagga-dev 15451] [PATCH 2/3] pimd: Remove source_new unneeded parameter

[Donald Sharp]

The interface name is already passed in as
part of the 'struct igmp_group *group' pointer.
No need to do it twice.

Signed-off-by: Donald Sharp 
---
 pimd/pim_igmp.h   |  3 +++
 pimd/pim_igmpv3.c | 40 
 2 files changed, 19 insertions(+), 24 deletions(-)

diff --git a/pimd/pim_igmp.h b/pimd/pim_igmp.h
index d45f223..f8a31cd 100644
--- a/pimd/pim_igmp.h
+++ b/pimd/pim_igmp.h
@@ -173,4 +173,7 @@ void igmp_startup_mode_on(struct igmp_sock *igmp);
 void igmp_group_timer_on(struct igmp_group *group,
 long interval_msec, const char *ifname);
 
+struct igmp_source *
+source_new (struct igmp_group *group,
+   struct in_addr src_addr);
 #endif /* PIM_IGMP_H */
diff --git a/pimd/pim_igmpv3.c b/pimd/pim_igmpv3.c
index 3657f2f..1a2e936 100644
--- a/pimd/pim_igmpv3.c
+++ b/pimd/pim_igmpv3.c
@@ -477,9 +477,9 @@ struct igmp_source *igmp_find_source_by_addr(struct 
igmp_group *group,
   return 0;
 }
 
-static struct igmp_source *source_new(struct igmp_group *group,
- struct in_addr src_addr,
- const char *ifname)
+struct igmp_source *
+source_new (struct igmp_group *group,
+   struct in_addr src_addr)
 {
   struct igmp_source *src;
 
@@ -491,7 +491,7 @@ static struct igmp_source *source_new(struct igmp_group 
*group,
 zlog_debug("Creating new IGMP source %s for group %s on socket %d 
interface %s",
   source_str, group_str,
   group->group_igmp_sock->fd,
-  ifname);
+  group->group_igmp_sock->interface->name);
   }
 
   src = XMALLOC(MTYPE_PIM_IGMP_GROUP_SOURCE, sizeof(*src));
@@ -501,13 +501,13 @@ static struct igmp_source *source_new(struct igmp_group 
*group,
 return 0; /* error, not found, could not create */
   }
   
-  src->t_source_timer= 0;
+  src->t_source_timer= NULL;
   src->source_group  = group; /* back pointer */
   src->source_addr   = src_addr;
   src->source_creation   = pim_time_monotonic_sec();
   src->source_flags  = 0;
   src->source_query_retransmit_count = 0;
-  src->source_channel_oil= 0;
+  src->source_channel_oil= NULL;
 
   listnode_add(group->group_source_list, src);
 
@@ -521,8 +521,7 @@ static struct igmp_source *source_new(struct igmp_group 
*group,
 
 static struct igmp_source *add_source_by_addr(struct igmp_sock *igmp,
  struct igmp_group *group,
- struct in_addr src_addr,
- const char *ifname)
+ struct in_addr src_addr)
 {
   struct igmp_source *src;
 
@@ -531,7 +530,7 @@ static struct igmp_source *add_source_by_addr(struct 
igmp_sock *igmp,
 return src;
   }
 
-  src = source_new(group, src_addr, ifname);
+  src = source_new(group, src_addr);
   if (!src) {
 return 0;
   }
@@ -560,7 +559,7 @@ static void allow(struct igmp_sock *igmp, struct in_addr 
from,
 
 src_addr = sources + i;
 
-source = add_source_by_addr(igmp, group, *src_addr,ifp->name);
+source = add_source_by_addr(igmp, group, *src_addr);
 if (!source) {
   continue;
 }
@@ -616,8 +615,7 @@ static void isex_excl(struct igmp_group *group,
 }
 else {
   /* E.4: if not found, create source with timer=GMI: (A-X-Y) */
-  source = source_new(group, *src_addr,
- group->group_igmp_sock->interface->name);
+  source = source_new(group, *src_addr);
   if (!source) {
/* ugh, internal malloc failure, skip source */
continue;
@@ -659,8 +657,7 @@ static void isex_incl(struct igmp_group *group,
 }
 else {
   /* I.4: if not found, create source with timer=0 (B-A) */
-  source = source_new(group, *src_addr,
- group->group_igmp_sock->interface->name);
+  source = source_new(group, *src_addr);
   if (!source) {
/* ugh, internal malloc failure, skip source */
continue;
@@ -737,8 +734,7 @@ static void toin_incl(struct igmp_group *group,
 }
 else {
   /* If not found, create new source */
-  source = source_new(group, *src_addr,
- group->group_igmp_sock->interface->name);
+  source = source_new(group, *src_addr);
   if (!source) {
/* ugh, internal malloc failure, skip source */
continue;
@@ -783,8 +779,7 @@ static void toin_excl(struct igmp_group *group,
 }
 else {
   /* If not found, create new source */
-  source = source_new(group, *src_addr,
- group->group_igmp_sock->interface->name);
+  source = source_new(group, *src_addr);
   if (!source) {
/* ugh, internal malloc failure, skip source */
continue;
@@ -862,8 +857,7 @@ static void 

[quagga-dev 15449] [PATCH] bgpd: Fix route-map and redistribution

[Donald Sharp]

Commit f3cfc46 introduced this issue.  A route-map
lookup was being done for IPv6, using IPv4 information.

Signed-off-by: Donald Sharp 
---
 bgpd/bgp_routemap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c
index 39fa08c..98d5f1f 100644
--- a/bgpd/bgp_routemap.c
+++ b/bgpd/bgp_routemap.c
@@ -2389,7 +2389,7 @@ bgp_route_map_update (const char *unused)
  route_map_lookup_by_name (bgp->rmap[AFI_IP][i].name);
  if (bgp->rmap[AFI_IP6][i].name)
bgp->rmap[AFI_IP6][i].map =
- route_map_lookup_by_name (bgp->rmap[AFI_IP][i].name);
+ route_map_lookup_by_name (bgp->rmap[AFI_IP6][i].name);
}
 }
 }
-- 
2.5.5


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15448] CI Testresult: PASSED (Re: [quagga-dev, 15443] bgpd: fix potential crash in community_list_dup_check)

[cisystem]

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF CI System 

This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1959: http://patchwork.quagga.net/patch/1959
   [quagga-dev,15443] bgpd: fix potential crash in community_list_dup_check
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-300/


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15444] CI Testresult: PASSED (Re: [quagga-dev, 15437] isisd: exit if daemonizing fails)

[cisystem]

Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF CI System 

This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 1956: http://patchwork.quagga.net/patch/1956
   [quagga-dev,15437] isisd: exit if daemonizing fails
Tested on top of Git : 86c5d2e (as of 20160315.231717 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-297/


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15443] [PATCH] bgpd: fix potential crash in community_list_dup_check

[Christian Franke]

From: Christian Franke 

extcommunity_list_set may set the ->config for an entry
to NULL. In this case, the old code in community_list_dup_check
would cause a NULL pointer dereference.

Adjust the code so it behaves the same in the absence of NULL
pointers and otherwise checks if both are NULL to determine
equality.

Signed-off-by: Christian Franke 
---
 bgpd/bgp_clist.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/bgpd/bgp_clist.c b/bgpd/bgp_clist.c
index bb06028..1f1a4e7 100644
--- a/bgpd/bgp_clist.c
+++ b/bgpd/bgp_clist.c
@@ -644,7 +644,10 @@ community_list_dup_check (struct community_list *list,
   break;
 case COMMUNITY_LIST_EXPANDED:
 case EXTCOMMUNITY_LIST_EXPANDED:
-  if (strcmp (entry->config, new->config) == 0)
+  if (entry->config && new->config
+  && strcmp (entry->config, new->config) == 0)
+return 1;
+  if (!entry->config && !new->config)
 return 1;
   break;
 default:
-- 
2.8.0


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15441] [PATCH] zebra: make fpm netlink_route_info_fill more robust

[Christian Franke]

From: Christian Franke 

Having an RTM_ADDROUTE with a rib == NULL would lead
to a crash due to a NULL pointer dereference.

Since an RTM_ADDROUTE without a rib object doesn't make
much sense, print a warning and remove the concerned
route instead.

Signed-off-by: Christian Franke 
---
 zebra/zebra_fpm_netlink.c | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/zebra/zebra_fpm_netlink.c b/zebra/zebra_fpm_netlink.c
index 0173000..e2c6b8b 100644
--- a/zebra/zebra_fpm_netlink.c
+++ b/zebra/zebra_fpm_netlink.c
@@ -251,11 +251,16 @@ netlink_route_info_fill (netlink_route_info_t *ri, int 
cmd,
* An RTM_DELROUTE need not be accompanied by any nexthops,
* particularly in our communication with the FPM.
*/
-  if (cmd == RTM_DELROUTE && !rib)
+  if (cmd == RTM_DELROUTE)
 goto skip;
 
-  if (rib)
-ri->rtm_protocol = netlink_proto_from_route_type (rib->type);
+  if (!rib)
+{
+  zlog_err("netlink_route_info_fill RTM_ADDROUTE called without rib info");
+  return 0;
+}
+
+  ri->rtm_protocol = netlink_proto_from_route_type (rib->type);
 
   if ((rib->flags & ZEBRA_FLAG_BLACKHOLE) || (rib->flags & ZEBRA_FLAG_REJECT))
 discard = 1;
-- 
2.8.0


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15437] [PATCH] isisd: exit if daemonizing fails

[Christian Franke]

From: Christian Franke 

The other daemons in Quagga exit with an error if they cannot fork.
Change isisd to behave consistently.

Signed-off-by: Christian Franke 
---
 isisd/isis_main.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/isisd/isis_main.c b/isisd/isis_main.c
index 3a73087..02ea0d7 100644
--- a/isisd/isis_main.c
+++ b/isisd/isis_main.c
@@ -355,8 +355,11 @@ main (int argc, char **argv, char **envp)
 return(0);
   
   /* demonize */
-  if (daemon_mode)
-daemon (0, 0);
+  if (daemon_mode && daemon (0, 0) < 0)
+{
+  zlog_err("IS-IS daemon failed: %s", strerror(errno));
+  exit (1);
+}
 
   /* Process ID file creation. */
   if (pid_file[0] != '\0')
-- 
2.8.0


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15438] Re: round 7, can you test?

[Martin Winter]

It’s already tested. At least the basic run.

https://ci1.netdef.org/chain/viewChain.action?planKey=QUAGGA-QMASTER9

(Part of the “Master” Plan - just select the branch on top to see 
different branches. My CI system should automatically pick up any 
proposed/* branches)


I’ll start a full pass of the compliance tests (takes 2 days max)

- Martin

On 6 Jun 2016, at 8:29, Paul Jakma wrote:


Hi,

Not sure why it's been sitting there untouched for so long, but could 
you do some of your smoke-tests on r7? So we can get it into master?


As it was apparently a limited bugfix-only round, it perhaps needs 
only a basic run.


regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
The world is coming to an end.  Please log off.


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15434] Re: Quagga Release Process Meeting Notes

[Jafar Al-Gharaibeh]

On 6/5/2016 9:30 AM, Michael Richardson wrote:

Jafar Al-Gharaibeh  wrote:

Identical releases:
Quagga-CE-1.0-0.0
Quagga-YE-1.0

How would a Quagga-YE-1.0 that has had a security patch applied to it be
numbered?
I thought about this (and yes, we are overthinking it :) ) ... we can 
just append a time stamp at the end.


--Jafar


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15433] Re: Round 8

[Jafar Al-Gharaibeh]

Paul,

   Great to see this long list of patches queued up finally. Good work, 
your effort is appreciated.


Regards,
Jafar


On 6/6/2016 11:09 AM, Paul Jakma wrote:

Hi,

As an FYI.

I've gone through patchwork and gotten most the bulkd of it queued up. 
Bar some issues with conflicts and what not that I've left for later. 
I've got the following patches in local proposed patches - I'll push 
somewhere later or tomorrow.


I'm aware of some reviews already. Next step is to do an initial 
review pass based on any already given reviews and an initial sort and 
linearisation. I'll post that branch + a summary email and we can have 
a final review period and get this done.


Ayan Banerjee  (5):
  zebra: ipv6 multipath support
  bgpd: Enable support for BGP IPV6 multipath.
  ospfd: Ensure deletion is clean
  ospfd: Ensure that OSPF can send out multiple packets per thread
  ospfd: Limit the number of interfaces serviced at one time

Daniel Walton  (29):
  bgpd: don't count a route with an unreachable nexthop in PfxRcd
  bgpd: Improve peer scaling
  ospf6d, ripd, vtysh: Fix "no set metric" for ospf6 and RIP
  bgpd: Make "no redistribute" always remove the redistribute 
statement
  bgpd: iBGP multipath is broken if 'bgp deterministic-med' is 
enabled.

  bgpd: Fix aggregation issues found via ANVL
  bgpd: Add clear command to force a bestpath recalculation and 
re-advertisement of a prefix

  bgpd: crash if attributes alone consume > 4096 bytes
  bgpd: Add [bestpath|multipath] option to 'show ip bgp x.x.x.x'
  ospf6d: We should accept long form of "no redistribute"
  bgpd: Display BGP paths with unreachable nexthops as invalid
  ospfd: Fix no ip ospf hello-interval
  ospfd: "show ip ospf neighbor" header spacing
  zebra: Add internal support for route tags
  bgpd, lib, ospfd, zebra: Add ability to read/write tag value
  bgpd, vtysh: Add support for route tags
  ospfd, vtysh: Add support for Route tags
  ripd, ripngd: add support for route tags
  zebra: add support for route tags
  bgpd: atomic-aggregate is lost when we aggregate another 
aggregate that has atomic-aggregate
  bgpd, ospfd, ospf6d, ripd, ripngd, zebra: 'set metric -12' is 
broken in the parser

  bgpd: Alow gracefull shutdown of peers
  bgpd: Add replace-as option to remove-private-as
  bgpd, lib: Clarify the different permutations of soft clearing a 
peer

  bgpd, isisd, lib, tests: Overhaul BGP debugs
  bgpd: Implement BGP as-override feature
  bgpd: Fix BGP_INFO_ATTR_CHANGED being cleared incorrectly
  bgpd: Correct a few fuzz failures in BGP
  zebra: Fix incorrectly flagged nexthop

Dinesh Dutt  (16):
  bgpd: IPv6 Multipath broken with nexthop global address
  bgpd, doc: Support matching on local preference in route-map
  bgpd, doc: Allow route-map policy modifications to also affect 
route reflectors.

  bgpd, vtysh: Add match interface support to BGP route-map.
  ospfd: Don't wait for state change to Exchange to start LSReq
  lib, vtysh: Add support for marking a file with appropriate end 
of context

  zebra: Suppress displaying default config as part of running config
  bgpd: Test effect of route-map on received/advertised routes
  lib, zebra: Add route-map support for Next Hop Tracking
  bgpd, zebra: Use next hop tracking for connected routes too
  lib, zebra: allow static routes to use NH's from protocols
  zebra: Gather and display detailed info about clients of Zebra
  lib, zebra: Honor setting source via route map and pushing that 
to the kernel.

  lib, ospf6d, zebra: Add ABR support and make ECMP > 4.
  lib, ospfd, ospf6d: ospfv3-stub-area-support.patch
  zebra: Static NHT fixes

Dinesh G Dutt  (3):
  bgpd, tests, vtysh: Fix FSM to handle active/passive connections 
better
  bgpd, lib, vtysh, zebra: Reprocess the trigger points when an 
attached route map changes

  ospfd: Better handle traffic when system is loaded

Donald Sharp  (10):
  bgpd: flag paths for multipath if we RX link-local and global 
nexthops

  vtysh: service integrated-vtysh-config not being written to file
  zebra: Add check to notice when an interface is unnumbered
  lib, ospfd, zebra: Fix up some compile issues on *bsd systems
  ospfd: virtual links fix
  zebra: Fix some warnings found during compile.
  bgpd: Correctly install non LL route into zebra
  ospf6d: Fix double increment of Sequence Number
  ospf6d: Fix Some ANVL test cases 16.6 and partial 16.10
  bgpd: Fix write quanta to a reasonable number.

JR Rivers  (1):
  ospfd: 16.0 rfc2328 compliance

James Li  (3):
  zebra: Dissallow outside programs to delete 

[quagga-dev 15431] Re: [PATCH 00/10] VNC: L3 & L2 VPN application support

[Philippe Guibert]

Hi Lou,

I am looking deeper at EVPN implementation, with patch "VNC; L3 & L2
VPN application support".
To get more familiar with this, I tried to mount a setup based on Mesh
NVA configuration example that can be found on doc/vnc.texi file, and
make a BGP exchange between the two BGP speakers.
At establishment, I got this error message : unsupported AFI/SAFI 0/0.

So , I am wondering if there is a setup issue, or a side effect due to
some mis-configurations ?
I only took 2 BGP Speakers instead of 3 ( I don't think it should
affect the behaviour).
I am based on (HEAD, origin/patches/LabN/R1.0.20160315+vnc/v2) bgpd:
add L3/L2VPN
I compiled with vnc support, and tested on ubuntu14.04 release.
You can find attached the log message obtained on my console, as well
as the bgp configuration used, and the wireshark capture file during
the BGP exchange.

Do you have an idea how I could overcome this issue ?
Thanks in advance,

Best Regards,

Philippe


*error messages i had*
2016/06/06 17:08:33 BGP: %ADJCHANGE: neighbor 10.125.0.1 Up
2016/06/06 17:08:34 BGP: unknown afi/safi (0/0)
2016/06/06 17:08:34 BGP: 10.125.0.1 [Info] UPDATE with unsupported AFI/SAFI 0/0
2016/06/06 17:08:34 BGP: unknown afi/safi (0/0)
2016/06/06 17:08:34 BGP: 10.125.0.1 [Info] UPDATE with unsupported AFI/SAFI 0/0
2016/06/06 17:08:34 BGP: unknown afi/safi (0/0)
2016/06/06 17:08:34 BGP: 10.125.0.1 [Info] UPDATE with unsupported AFI/SAFI 0/0
2016/06/06 17:08:34 BGP: unknown afi/safi (0/0)
2016/06/06 17:08:34 BGP: 10.125.0.1 [Info] UPDATE with unsupported AFI/SAFI 0/0
2016/06/06 17:08:39 BGP: Import timer expired.


*configuration used *

hostname nva1
password zebra
log stdout
service advanced-vty
!
router bgp 64512
 bgp router-id 10.125.0.2
 neighbor 10.125.0.1 remote-as 64512
!
 address-family vpnv4
 neighbor 10.125.0.1 activate
 exit-address-family
 vnc defaults
  rd 64512:1
  response-lifetime 200
  rt both 1000:1 1000:2
  exit-vnc
!

hostname nva2
password zebra
log stdout
service advanced-vty
!
router bgp 64512
 bgp router-id 10.125.0.1
 neighbor 10.125.0.2 remote-as 64512
!
 address-family vpnv4
 neighbor 10.125.0.2 activate
 exit-address-family
 vnc defaults
  rd 64512:1
  response-lifetime 200
  rt both 1000:1 1000:2
  exit-vnc
!
 vnc nve-group group1
  prefix vn 172.16.128.0/17
  rd 64512:1
  rt both 1000:1 1000:2
  exit-vnc
!

On Tue, May 17, 2016 at 1:10 PM, Lou Berger  wrote:
> This patch set adds an L3 & L2 VPN application that makes use of the VPN
> and Encap SAFIs.  This code is currently used to support IETF NVO3 style
> operation.  In NVO3 terminology it provides the Network Virtualization
> Authority (NVA) and the ability to import/export IP prefixes and MAC
> addresses from Network Virtualization Edges (NVEs).  The code supports
> per-NVE tables (VRFs/VSIs).
>
> The NVE-NVA protocol used to communicate routing and Ethernet / Layer 2
> (L2) forwarding information between NVAs and NVEs is referred to as the
> Remote Forwarder Protocol (RFP). OpenFlow is an example RFP.  RFPs are
> integrated with BGP via the RF API contained in the new "rfapi" BGP
> sub-directory.  Currently, only a simple example RFP is included in
> Quagga. Developers may use this example as a starting point to integrate
> Quagga with an RFP of their choosing, e.g., OpenFlow.  The RFAPI code
> also supports the ability to import/export of routing information
> between VNC and customer edge routers (CEs) operating within a virtual
> network. Import/export may take place between BGP views or to the
> default zebra VRF.
>
> BGP, with IP VPNs and Tunnel Encapsulation, is used to distribute VPN
> information between NVAs. BGP based IP VPN support is defined in
> RFC4364, BGP/MPLS IP Virtual Private Networks (VPNs), and RFC4659,
> BGP-MPLS IP Virtual Private Network (VPN) Extension for IPv6 VPN . Use
> of both the Encapsulation Subsequent Address Family Identifier (SAFI)
> and the Tunnel Encapsulation Attribute, RFC5512, The BGP Encapsulation
> Subsequent Address Family Identifier (SAFI) and the BGP Tunnel
> Encapsulation Attribute, are supported. The code is tunnely type
> agnostic. MAC address distribution does not follow any standard BGB
> encoding, although it was inspired by the early IETF EVPN concepts.
> The intent is that the RF API would not need to change with support
> of standards-based EVPN.
>
> The feature is conditionally compiled and disabled by default.
> Use the --enable-bgp-vnc configure option to enable.
>
> Collectively, we refer to this feature as Virtual Network
> Control, or VNC.
>
> The majority of this code was authored by G. Paul Ziemba
> .  This patch set is also available at
> https://github.com/LabNConsulting/quagga-vnc/tree/patches/R1.0.20160315+vnc/v2
>
> The following patches are included in the patch set.
>
> basic rel1.0 cleanup:
>[PATCH 01/10] lib: fix memory leak in zprivs_caps_init
>[PATCH 02/10] lib/vty: 

[quagga-dev 15430] round 7, can you test?

[Paul Jakma]

Hi,

Not sure why it's been sitting there untouched for so long, but could 
you do some of your smoke-tests on r7? So we can get it into master?


As it was apparently a limited bugfix-only round, it perhaps needs only 
a basic run.


regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
The world is coming to an end.  Please log off.

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 15429] Re: Quagga Release Process Meeting Notes

[Lou Berger]

On 6/5/2016 10:34 AM, Michael Richardson wrote:
> Lou Berger  wrote:
>
>> What do you (anyone) think?
> I think we are thinking too much about it.
>
>

Michael,
If I'm not mistaken, you were around since quagga was set up as a
gnu project.  What's your perspective on all this?  What should happen
at this point?

Lou

Ps
https://lists.quagga.net/pipermail/quagga-users/2003-August/000191.html
really feels like something I could be reading on the list today...



___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev