[quagga-dev 16200] Re: Proposed 8 testing Update

2016-10-06 Thread Lou Berger 



On October 6, 2016 11:47:59 AM Paul Jakma  wrote:


On Thu, 6 Oct 2016, Lou Berger wrote:


One outstanding issue for the release is operation of BGP without
zebra. (The NHT change basically introduces a requirement to run BGP
with zebra, while there are route server/reflector configs which are
viable now running only BGP.)



I suggest changing the NHT code to either (a) automatically operate /
adjust to when zebra isn't present or (b) have a bgp config option to
ignore NHT, e.g., 'no bgp nexthop-tracking'.

Do you/anyone have a preference?  -- Mine is (a).


Definitely a.



Great.  You should have the patch.


I (or Paul Z.) can propose a patch for this change.


Cool.

So, that'd be a release blocker, but not a 'ff master' blocker, right?


Agreed!

Lou


regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
I do desire we may be better strangers.
-- William Shakespeare, "As You Like It"





___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16199] Re: Proposed 8 testing Update

2016-10-06 Thread Paul Jakma 

On Thu, 6 Oct 2016, Lou Berger wrote:

One outstanding issue for the release is operation of BGP without 
zebra. (The NHT change basically introduces a requirement to run BGP 
with zebra, while there are route server/reflector configs which are 
viable now running only BGP.)



I suggest changing the NHT code to either (a) automatically operate /
adjust to when zebra isn't present or (b) have a bgp config option to
ignore NHT, e.g., 'no bgp nexthop-tracking'.

Do you/anyone have a preference?  -- Mine is (a).


Definitely a.


I (or Paul Z.) can propose a patch for this change.


Cool.

So, that'd be a release blocker, but not a 'ff master' blocker, right?

regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
I do desire we may be better strangers.
-- William Shakespeare, "As You Like It"

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16198] Re: Proposed 8 testing Update

2016-10-06 Thread Vincent JARDIN 

Le 06/10/2016 à 17:01, Philippe Guibert a écrit :

No.  Please merge to master ASAP.
>

+1

+1

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16195] [PATCH] bgp: ignore NHT when bgpd has never connected zebra

2016-10-06 Thread Lou Berger 
---
 quagga/bgpd/bgp_nht.c   |  3 ++-
 quagga/bgpd/bgp_zebra.c | 11 +++
 quagga/bgpd/bgp_zebra.h |  2 ++
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/quagga/bgpd/bgp_nht.c b/quagga/bgpd/bgp_nht.c
index 591fbf9..c4acb66 100644
--- a/quagga/bgpd/bgp_nht.c
+++ b/quagga/bgpd/bgp_nht.c
@@ -192,7 +192,8 @@ bgp_find_or_add_nexthop (afi_t afi, struct bgp_info *ri, 
struct peer *peer,
   else if (peer)
 bnc->nht_info = (void *)peer; /* NHT peer reference */
 
-  return (CHECK_FLAG(bnc->flags, BGP_NEXTHOP_VALID));
+  return (bgp_zebra_num_connects() == 0 ||
+  CHECK_FLAG(bnc->flags, BGP_NEXTHOP_VALID));
 }
 
 void
diff --git a/quagga/bgpd/bgp_zebra.c b/quagga/bgpd/bgp_zebra.c
index 854d93d..974baed 100644
--- a/quagga/bgpd/bgp_zebra.c
+++ b/quagga/bgpd/bgp_zebra.c
@@ -54,6 +54,8 @@ struct in_addr router_id_zebra;
 struct stream *bgp_nexthop_buf = NULL;
 struct stream *bgp_ifindices_buf = NULL;
 
+int zclient_num_connects;
+
 /* Router-id update message from zebra. */
 static int
 bgp_router_id_update (int command, struct zclient *zclient, zebra_size_t 
length,
@@ -1187,12 +1189,15 @@ bgp_zclient_reset (void)
 static void
 bgp_zebra_connected (struct zclient *zclient)
 {
+  zclient_num_connects++;
   zclient_send_requests (zclient, VRF_DEFAULT);
 }
 
 void
 bgp_zebra_init (struct thread_master *master)
 {
+  zclient_num_connects = 0;
+
   /* Set default values. */
   zclient = zclient_new (master);
   zclient_init (zclient, ZEBRA_ROUTE_BGP);
@@ -1223,3 +1228,9 @@ bgp_zebra_destroy(void)
   zclient_free(zclient);
   zclient = NULL;
 }
+
+int
+bgp_zebra_num_connects(void)
+{
+  return zclient_num_connects;
+}
diff --git a/quagga/bgpd/bgp_zebra.h b/quagga/bgpd/bgp_zebra.h
index 9a592c3..5d4ed62 100644
--- a/quagga/bgpd/bgp_zebra.h
+++ b/quagga/bgpd/bgp_zebra.h
@@ -48,4 +48,6 @@ extern struct interface *if_lookup_by_ipv4_exact (struct 
in_addr *);
 extern struct interface *if_lookup_by_ipv6 (struct in6_addr *);
 extern struct interface *if_lookup_by_ipv6_exact (struct in6_addr *);
 
+extern int bgp_zebra_num_connects(void);
+
 #endif /* _QUAGGA_BGP_ZEBRA_H */
-- 
2.1.3


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16193] Re: Proposed 8 testing Update

2016-10-06 Thread Martin Winter 
I think something to address before a release, but not sure if we should
hold off merging to master because of it.

Lou, are you proposing to fix this before merging to master?

-  Martin

On 6 Oct 2016, at 6:30, Lou Berger wrote:

> Paul,
>
> On October 6, 2016 6:05:14 AM Paul Jakma  wrote:
>
> ...
>>
>> One change from the last release in BGP is ANVL-BGPPLUS-17.1 related to
>> address used for nexthop - NHT related? Is it serious?
>>
>> Looks acceptable generally.
>>
>
> One outstanding issue for the release is operation of BGP without zebra.
>  (The NHT change basically introduces a requirement to run BGP with
> zebra, while there are route server/reflector configs which are viable
> now running only BGP.)
>
> I suggest changing the NHT code to either (a) automatically operate /
> adjust to when zebra isn't present or (b) have a bgp config option to
> ignore NHT, e.g., 'no bgp nexthop-tracking'.
>
> Do you/anyone have a preference?  -- Mine is (a).
>
> I (or Paul Z.) can propose a patch for this change.
>
> Lou
>

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16191] Re: Proposed 8 testing Update

2016-10-06 Thread Lou Berger 
Paul,

On October 6, 2016 6:05:14 AM Paul Jakma  wrote:

...
>
> One change from the last release in BGP is ANVL-BGPPLUS-17.1 related to
> address used for nexthop - NHT related? Is it serious?
>
> Looks acceptable generally.
>

One outstanding issue for the release is operation of BGP without zebra.
 (The NHT change basically introduces a requirement to run BGP with
zebra, while there are route server/reflector configs which are viable
now running only BGP.)

I suggest changing the NHT code to either (a) automatically operate /
adjust to when zebra isn't present or (b) have a bgp config option to
ignore NHT, e.g., 'no bgp nexthop-tracking'.

Do you/anyone have a preference?  -- Mine is (a).

I (or Paul Z.) can propose a patch for this change.

Lou


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16192] Re: Proposed 8 testing Update

2016-10-06 Thread Martin Winter 

There are a few OSPFv3 issues as well

ANVL-OSPFV3-8.5 & 19.11-19.16

I have not looked yet into the failure case (sorry busy this week).
I would vote to address them after the merge to master.

- Martin

On 6 Oct 2016, at 3:02, Paul Jakma wrote:


On Wed, 5 Oct 2016, Martin Winter wrote:


Paul,

Results are updated.

See 
https://drive.google.com/drive/folders/0B8W_T0dxQfwxZFdJd1lPOXo3bHM?usp=sharing


OSPFv2 issues are fixed.
I haven’t looked at all the other protocols, but overall they seem 
to be mostly

ok.


Yeah, mostly unchanged. couple of cases for OSPFv2 where a test that 
generally fails passed with the last (broken) head. Maybe that's a 
consequence of other things failing that made that particular test 
seem to pass though.


One change from the last release in BGP is ANVL-BGPPLUS-17.1 related 
to address used for nexthop - NHT related? Is it serious?


Looks acceptable generally.

regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
The most difficult thing in the world is to know how to do a thing and 
to

watch someone else doing it wrong, without commenting.
-- T.H. White


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16190] Re: Proposed 8 testing Update

2016-10-06 Thread Paul Jakma 

On Wed, 5 Oct 2016, Martin Winter wrote:


Paul,

Results are updated.

See 
https://drive.google.com/drive/folders/0B8W_T0dxQfwxZFdJd1lPOXo3bHM?usp=sharing


OSPFv2 issues are fixed.
I haven’t looked at all the other protocols, but overall they seem to be 
mostly

ok.


Yeah, mostly unchanged. couple of cases for OSPFv2 where a test that 
generally fails passed with the last (broken) head. Maybe that's a 
consequence of other things failing that made that particular test seem 
to pass though.


One change from the last release in BGP is ANVL-BGPPLUS-17.1 related to 
address used for nexthop - NHT related? Is it serious?


Looks acceptable generally.

regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
The most difficult thing in the world is to know how to do a thing and to
watch someone else doing it wrong, without commenting.
-- T.H. White___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16189] Re: Proposed 8 testing Update

2016-10-06 Thread Paul Jakma 

On Wed, 5 Oct 2016, Martin Winter wrote:

OSPFv2 issues are fixed. I haven’t looked at all the other protocols, 
but overall they seem to be mostly ok.


\o/

Let me know if there are any concerns regarding a specific issue and 
I’ll look into it, but might both have much time this week anymore (as 
I’m at a conference)


Great, so I propose master is ff'ed to the

  volatile/patch-tracking/8/proposed/ff-2016100401

head ASAP, and we get a release out based on that.

I'll wait till tomorrow for objections (not aware of any objections bar 
the OSPFv2 issue).


regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
[We] use bad software and bad machines for the wrong things.
-- R.W. Hamming___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16188] CI Testresult: PASSED (Re: [quagga-dev, 16187, v3, 3/3] tests: enhance bgpd testing with label value)

2016-10-06 Thread cisystem 
Continous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF CI System 

This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .

Patches applied :
  Patchwork 2079: http://patchwork.quagga.net/patch/2079
   [quagga-dev,16185,v3,1/3] lib: 3byte stream foo
  Patchwork 2081: http://patchwork.quagga.net/patch/2081
   [quagga-dev,16186,v3,2/3] bgpd: multiple label stack support
  Patchwork 2080: http://patchwork.quagga.net/patch/2080
   [quagga-dev,16187,v3,3/3] tests: enhance bgpd testing with label value
Tested on top of Git : 5f67888 (as of 20160429.234845 UTC)
CI System Testrun URL: https://ci1.netdef.org/browse/QUAGGA-QPWORK-359/


Regards,
  NetDEF/OpenSourceRouting Continous Integration (CI) System

---
OpenSourceRouting.org is a project of the Network Device Education Foundation,
For more information, see www.netdef.org and www.opensourcerouting.org
For questions in regards to this CI System, contact Martin Winter, 
mwin...@netdef.org

___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16186] [PATCH v3 2/3] bgpd: multiple label stack support

2016-10-06 Thread Philippe Guibert 
From: David Lamparter 

Support for multiple label support handling in NLRI messages.
Ability to receive and sent BGP updates with NLRI containing multiple
labels. The commit follows label encoding rules, contained in RFC3107.

Signed-off-by: David Lamparter 
Signed-off-by: Christian Franke 
Signed-off-by: Philippe Guibert 
---
 bgpd/bgp_attr.c|  29 ---
 bgpd/bgp_attr.h|   6 +--
 bgpd/bgp_encap.c   |   4 +-
 bgpd/bgp_mplsvpn.c | 148 +
 bgpd/bgp_mplsvpn.h |   4 +-
 bgpd/bgp_packet.c  |  28 ++
 bgpd/bgp_route.c   | 144 ++-
 bgpd/bgp_route.h   |  15 --
 8 files changed, 246 insertions(+), 132 deletions(-)

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index f34e649332e6..a73babc7d646 100644
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -2474,13 +2474,25 @@ bgp_packet_mpattr_start (struct stream *s, afi_t afi, 
safi_t safi,
 void
 bgp_packet_mpattr_prefix (struct stream *s, afi_t afi, safi_t safi,
  struct prefix *p, struct prefix_rd *prd,
- u_char *tag)
+ uint32_t *labels, size_t nlabels)
 {
   if (safi == SAFI_MPLS_VPN)
 {
-  /* Tag, RD, Prefix write. */
-  stream_putc (s, p->prefixlen + 88);
-  stream_put (s, tag, 3);
+  if (nlabels != 0)
+{
+  size_t i;
+
+  /* Tag, RD, Prefix write. */
+  stream_putc (s, p->prefixlen + 8 * (8 + 3 * nlabels));
+  for (i = 0; i < nlabels; i++)
+stream_put3 (s, labels[i]);
+}
+  else
+{
+  /* Withdraw, put bottom of stack as only label */
+  stream_putc (s, p->prefixlen + 8 * (8 + 3));
+  stream_put3 (s, 0x1);
+}
   stream_put (s, prd->val, 8);
   stream_put (s, >u.prefix, PSIZE (p->prefixlen));
 }
@@ -2596,7 +2608,8 @@ bgp_size_t
 bgp_packet_attribute (struct bgp *bgp, struct peer *peer,
  struct stream *s, struct attr *attr,
  struct prefix *p, afi_t afi, safi_t safi,
- struct peer *from, struct prefix_rd *prd, u_char *tag)
+ struct peer *from, struct prefix_rd *prd,
+ uint32_t *labels, size_t nlabels)
 {
   size_t cp;
   size_t aspath_sizep;
@@ -2615,7 +2628,7 @@ bgp_packet_attribute (struct bgp *bgp, struct peer *peer,
 {
   size_t mpattrlen_pos = 0;
   mpattrlen_pos = bgp_packet_mpattr_start(s, afi, safi, attr);
-  bgp_packet_mpattr_prefix(s, afi, safi, p, prd, tag);
+  bgp_packet_mpattr_prefix(s, afi, safi, p, prd, labels, nlabels);
   bgp_packet_mpattr_end(s, mpattrlen_pos);
 }
 
@@ -2976,9 +2989,9 @@ bgp_packet_mpunreach_start (struct stream *s, afi_t afi, 
safi_t safi)
 void
 bgp_packet_mpunreach_prefix (struct stream *s, struct prefix *p,
 afi_t afi, safi_t safi, struct prefix_rd *prd,
-u_char *tag)
+uint32_t *labels, size_t nlabels)
 {
-  bgp_packet_mpattr_prefix (s, afi, safi, p, prd, tag);
+  bgp_packet_mpattr_prefix (s, afi, safi, p, prd, labels, nlabels);
 }
 
 void
diff --git a/bgpd/bgp_attr.h b/bgpd/bgp_attr.h
index fe6c2a1a11c6..5cb67ec079ed 100644
--- a/bgpd/bgp_attr.h
+++ b/bgpd/bgp_attr.h
@@ -171,7 +171,7 @@ extern bgp_size_t bgp_packet_attribute (struct bgp *bgp, 
struct peer *,
struct stream *, struct attr *,
struct prefix *, afi_t, safi_t,
struct peer *, struct prefix_rd *,
-   u_char *);
+   uint32_t *labels, size_t nlabels);
 extern void bgp_dump_routes_attr (struct stream *, struct attr *,
  struct prefix *);
 extern int attrhash_cmp (const void *, const void *);
@@ -218,7 +218,7 @@ extern size_t bgp_packet_mpattr_start(struct stream *s, 
afi_t afi, safi_t safi,
  struct attr *attr);
 extern void bgp_packet_mpattr_prefix(struct stream *s, afi_t afi, safi_t safi,
 struct prefix *p, struct prefix_rd *prd,
-u_char *tag);
+uint32_t *labels, size_t nlabels);
 extern size_t bgp_packet_mpattr_prefix_size(afi_t afi, safi_t safi,
 struct prefix *p);
 extern void bgp_packet_mpattr_end(struct stream *s, size_t sizep);
@@ -227,7 +227,7 @@ extern size_t bgp_packet_mpunreach_start (struct stream *s, 
afi_t afi,
  safi_t safi);
 extern void bgp_packet_mpunreach_prefix (struct stream *s, struct prefix *p,
 afi_t afi, safi_t safi, struct

[quagga-dev 16185] [PATCH v3 1/3] lib: 3byte stream foo

2016-10-06 Thread Philippe Guibert 
From: David Lamparter 

API enhancement to be able to write and read 3 byte series in
stream structures.

Signed-off-by: David Lamparter 
Signed-off-by: Philippe Guibert 
---
 lib/stream.c | 77 
 lib/stream.h |  4 
 2 files changed, 81 insertions(+)

diff --git a/lib/stream.c b/lib/stream.c
index ca1a40f16898..3df6248b576e 100644
--- a/lib/stream.c
+++ b/lib/stream.c
@@ -379,6 +379,47 @@ stream_getw_from (struct stream *s, size_t from)
   return w;
 }
 
+/* Get next 3-byte from the stream. */
+u_int32_t
+stream_get3_from (struct stream *s, size_t from)
+{
+  u_int32_t l;
+
+  STREAM_VERIFY_SANE(s);
+  
+  if (!GETP_VALID (s, from + 3))
+{
+  STREAM_BOUND_WARN (s, "get 3byte");
+  return 0;
+}
+  
+  l  = s->data[from++] << 16;
+  l |= s->data[from++] << 8;
+  l |= s->data[from];
+  
+  return l;
+}
+
+u_int32_t
+stream_get3 (struct stream *s)
+{
+  u_int32_t l;
+
+  STREAM_VERIFY_SANE(s);
+  
+  if (STREAM_READABLE (s) < 3)
+{
+  STREAM_BOUND_WARN (s, "get 3byte");
+  return 0;
+}
+  
+  l  = s->data[s->getp++] << 16;
+  l |= s->data[s->getp++] << 8;
+  l |= s->data[s->getp++];
+  
+  return l;
+}
+
 /* Get next long word from the stream. */
 u_int32_t
 stream_getl_from (struct stream *s, size_t from)
@@ -559,6 +600,25 @@ stream_putw (struct stream *s, u_int16_t w)
 
 /* Put long word to the stream. */
 int
+stream_put3 (struct stream *s, u_int32_t l)
+{
+  STREAM_VERIFY_SANE (s);
+
+  if (STREAM_WRITEABLE (s) < 3)
+{
+  STREAM_BOUND_WARN (s, "put");
+  return 0;
+}
+  
+  s->data[s->endp++] = (u_char)(l >> 16);
+  s->data[s->endp++] = (u_char)(l >>  8);
+  s->data[s->endp++] = (u_char)l;
+
+  return 3;
+}
+
+/* Put long word to the stream. */
+int
 stream_putl (struct stream *s, u_int32_t l)
 {
   STREAM_VERIFY_SANE (s);
@@ -635,6 +695,23 @@ stream_putw_at (struct stream *s, size_t putp, u_int16_t w)
 }
 
 int
+stream_put3_at (struct stream *s, size_t putp, u_int32_t l)
+{
+  STREAM_VERIFY_SANE(s);
+  
+  if (!PUT_AT_VALID (s, putp + 3))
+{
+  STREAM_BOUND_WARN (s, "put");
+  return 0;
+}
+  s->data[putp] = (u_char)(l >> 16);
+  s->data[putp + 1] = (u_char)(l >>  8);
+  s->data[putp + 2] = (u_char)l;
+  
+  return 3;
+}
+
+int
 stream_putl_at (struct stream *s, size_t putp, u_int32_t l)
 {
   STREAM_VERIFY_SANE(s);
diff --git a/lib/stream.h b/lib/stream.h
index 1fc382d68428..66d0864c94a9 100644
--- a/lib/stream.h
+++ b/lib/stream.h
@@ -167,6 +167,8 @@ extern int stream_putc (struct stream *, u_char);
 extern int stream_putc_at (struct stream *, size_t, u_char);
 extern int stream_putw (struct stream *, u_int16_t);
 extern int stream_putw_at (struct stream *, size_t, u_int16_t);
+extern int stream_put3 (struct stream *, u_int32_t);
+extern int stream_put3_at (struct stream *, size_t, u_int32_t);
 extern int stream_putl (struct stream *, u_int32_t);
 extern int stream_putl_at (struct stream *, size_t, u_int32_t);
 extern int stream_putq (struct stream *, uint64_t);
@@ -180,6 +182,8 @@ extern u_char stream_getc (struct stream *);
 extern u_char stream_getc_from (struct stream *, size_t);
 extern u_int16_t stream_getw (struct stream *);
 extern u_int16_t stream_getw_from (struct stream *, size_t);
+extern u_int32_t stream_get3 (struct stream *);
+extern u_int32_t stream_get3_from (struct stream *, size_t);
 extern u_int32_t stream_getl (struct stream *);
 extern u_int32_t stream_getl_from (struct stream *, size_t);
 extern uint64_t stream_getq (struct stream *);
-- 
2.1.4


___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

[quagga-dev 16187] [PATCH v3 3/3] tests: enhance bgpd testing with label value

2016-10-06 Thread Philippe Guibert 
bgp NLRI has a specific format for label, terminating with bottom
of stack bit. This value is updated in all BGP attribute tests. A
specific test has been added to check for a list of labels contained
in a single NLRI.

Signed-off-by: Philippe Guibert 
---
 tests/bgp_mp_attr_test.c   | 87 ++
 tests/bgpd.tests/testbgpmpattr.exp |  2 +
 2 files changed, 71 insertions(+), 18 deletions(-)

diff --git a/tests/bgp_mp_attr_test.c b/tests/bgp_mp_attr_test.c
index 5400dd17929e..6b7121e7a3bd 100644
--- a/tests/bgp_mp_attr_test.c
+++ b/tests/bgp_mp_attr_test.c
@@ -322,13 +322,13 @@ static struct test_segment {
   /* Nexthop */192, 168,   0,  1, 
   /* SNPA (defunct, MBZ) */0x0,
   /* NLRI tuples */88 + 16,
-  0, 1, 2,   /* tag */
+  0, 1, 1,   /* tag */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_AS */
 0, 2, 0, 0xff, 3, 4, /* AS(2):val(4) */
   10, 1,/* 10.1/16 */
 88 + 17,
-  0xff, 0, 0,   /* tag */
+  2, 43, 1,   /* tag */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_IP */
 192, 168, 0, 1, /* IPv4 */
@@ -365,13 +365,13 @@ static struct test_segment {
   /* Nexthop */192, 168,   0,  1, 
   /* SNPA (defunct, MBZ) */0x0,
   /* NLRI tuples */88 + 1,
-  0, 1, 2,   /* tag */
+  0, 2, 1,   /* tag with BOS bit set */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_AS */
 0, 2, 0, 0xff, 3, 4, /* AS(2):val(4) */
   10, 1,/* 10.1/16 */
 88 + 17,
-  0xff, 0, 0,   /* tag */
+  3, 4, 1,   /* tag with BOS bit set */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_IP */
 192, 168, 0, 1, /* IPv4 */
@@ -391,13 +391,13 @@ static struct test_segment {
   /* Nexthop */192, 168,   0,  1, 
   /* SNPA (defunct, MBZ) */0x0,
   /* NLRI tuples */88 + 32,
-  0, 1, 2,   /* tag */
+  0, 2, 1,   /* tag  with BOS bit */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_AS */
 0, 2, 0, 0xff, 3, 4, /* AS(2):val(4) */
   10, 1,/* 10.1/16 */
 88 + 17,
-  0xff, 0, 0,   /* tag */
+  3, 4, 1,   /* tag with BOS bit set */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_IP */
 192, 168, 0, 1, /* IPv4 */
@@ -417,13 +417,13 @@ static struct test_segment {
   /* Nexthop */192, 168,   0,  1, 
   /* SNPA (defunct, MBZ) */0x0,
   /* NLRI tuples */88 + 16,
-  0, 1, 2,   /* tag */
+  0, 2, 1,   /* tag  with BOS bit */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_AS */
 0, 2, 0, 0xff, 3, 4, /* AS(2):val(4) */
   10, 1,/* 10.1/16 */
 88 + 17,
-  0xff, 0, 0,   /* tag */
+  3, 4, 1,   /* tag with BOS bit set */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_IP */
 192, 168, 0, 1, /* IPv4 */
@@ -444,13 +444,13 @@ static struct test_segment {
   /* Nexthop */192, 168,   0,  1, 
   /* SNPA (defunct, MBZ) */0x0,
   /* NLRI tuples */88 + 16,
-  0, 1, 2,   /* tag */
+  0, 2, 1,   /* tag  with BOS bit */
   /* rd, 8 octets */
 0, 0, /* RD_TYPE_AS */
 0, 2, 0, 0xff, 3, 4, /* AS(2):val(4) */
   10, 1,/* 10.1/16 */
 88 + 2,
-  0xff, 0, 0,   /* tag */
+

[quagga-dev 16183] Re: Proposed 8 testing Update

2016-10-06 Thread Martin Winter 

Paul,

Results are updated.

See 
https://drive.google.com/drive/folders/0B8W_T0dxQfwxZFdJd1lPOXo3bHM?usp=sharing


OSPFv2 issues are fixed.
I haven’t looked at all the other protocols, but overall they seem to 
be mostly

ok.

Let me know if there are any concerns regarding a specific issue and 
I’ll look into it,
but might both have much time this week anymore (as I’m at a 
conference)


- Martin


On 5 Oct 2016, at 2:40, Martin Winter wrote:


On 4 Oct 2016, at 6:42, Paul Jakma wrote:


On Tue, 4 Oct 2016, Paul Jakma wrote:

Ah, never mind. stupid mis-merge, managed to drop one little but 
important hunk on the "ospfd: Don't wait for state change to 
Exchange to start LSReq" patch.


Passes CI. Fingers crossed we really are done on this now. :)


I assume this is now ft-2016100401 (git sha 743dd42) ?

Queuing for the full run next… (Will know in 1..2 days)

- Martin Winter



___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev