On 7/7/2016 12:58 PM, Paul Jakma wrote:
> On Thu, 7 Jul 2016, Lou Berger wrote:
>
>> Looks like this fixes the exit problem. Two issues I see immediately
>> are:
>> ==12640== {
>> <insert_a_suppression_name_here>
>> Memcheck:Leak
>> fun:calloc
>> fun:zcalloc
>> fun:bnc_new
>> fun:bgp_find_or_add_nexthop
>> fun:bgp_start
>> fun:bgp_event
>> fun:bgp_start_timer
>> fun:thread_call
>> fun:main
>> }
>>
>> 2 some new log messages generated every seconds
>> 2016/07/07 09:02:35 BGP: There is already write fd [14]
>> 2016/07/07 09:02:35 BGP: There is already write fd [16]
>> 2016/07/07 09:02:35 BGP: There is already write fd [17]
> Hmm, not sure what those are about. Can be fixed later maybe.
>
>> Updates of the VPN & Encap SAFIs are still not working in an RR
>> config.
> Ah.
>
> The adjacencies issue, I wonder is that e27c516d, the connect timer
> change?
Nope, but dropping this fixes another issue: normal updates are also
taking 1-2 *minutes*.
Also, adjacencies are taking longer than normal to come up
>> ahh, why not just different branches, e.g.,
>> patch-tracking/8/proposed/{v1,v2,v3}/... They are cheap and easy? vN
>> can contain all the changes, V(N=1) is created when rebases are done
>> to clean up the history/log
> Or just use the commit ID? If you want a stable number, the first X
> digits of the commit ID already automatically provide it.
The version approach allows all to see the changes that go in on top of
what was sent to the list. This will certainly facilitate authors
reviewing changes to their submissions -- a good thing IMO - as well as
give you the clean history/logs you are looking for.
Lou
> Can also use 'hidden' branches/refs outside of refs/heads, e.g. in
> refs/patch-tracking instead. They won't be fetched automatically, won't
> appear in gitweb, etc.
>
> regards,
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
