Re: [qubes-devel] [PATCH] Fix qubes-input-sender-mouse@.service failing on boot

2023-07-07 Thread Marek Marczykowski-Górecki
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On Fri, Jun 30, 2023 at 01:41:10AM +, 8h45 via qubes-devel wrote:
> If sys-usb boots up before the user has logged in,
> qubes-input-sender-mouse@.service fails permanently. This patch makes the
> service restart on failure at a reasonable time interval.

If the policy is set to "allow", it should work even before log in. But
with policy "ask", indeed it will fail. But then, there is a post-login
script to restart those services one time. It's called via
/etc/xdg/autostart/qubes-input-trigger.desktop in sys-usb
(/etc/xdg/autostart is processed when starting user's graphical session,
so - just after log-in).
If for some reason it doesn't work for you, the issue is there.

> diff --git a/qubes-rpc/qubes-input-sender-mouse@.service
> b/qubes-rpc/qubes-input-sender-mouse@.service
> index 309f60f..18fbb72 100644
> --- a/qubes-rpc/qubes-input-sender-mouse@.service
> +++ b/qubes-rpc/qubes-input-sender-mouse@.service
> @@ -6,3 +6,5 @@ After=qubes-qrexec-agent.service
>  Environment=TARGET_DOMAIN=dom0
>  EnvironmentFile=-/etc/qubes/input-proxy-target
>  ExecStart=/usr/bin/qubes-input-sender qubes.InputMouse /dev/input/%i
> "$TARGET_DOMAIN"
> +Restart=always
> +RestartSec=1

Restarting the failed service indefinitely, every 1s is a bad idea. The
common case of a failure is (intentional) policy deny, and restarting
every 1s will both waste resources and spam the user with notifications
about the refusal.

- -- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
-BEGIN PGP SIGNATURE-

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmSoHKoACgkQ24/THMrX
1yx2oggAiuA6Pfwqoavx8pgEO2W8xuZZLBi9saBTTifrGEoQgB0FeuhL+NMBZaYS
wcPB2k0Ru8E/QTvZxcm7Ug+0F/s23j46Pr02iKDykIMAuKxaYleuhYjpOrvjCH5c
QWgnlEiN9PfFzYFb8k9JCitwnuB5umYct6e5/NZeXQx4ooewXcQNjbUz63lbmiCk
00dK3ru0xuexl4lgYnIDwjpqNLel0SmkMlsITPIh6gOJ7/7MmkroSx2XUbpO/8a1
7JVoOkTNAV9+0JM/AVHtXtEXVT9hoqrhNEehSYK5VqNcWVNozQQX2rJT0U+XJswO
vdzeEhF6PiAPLiRbYEpMUgjI3hP+hw==
=20O+
-END PGP SIGNATURE-

-- 
You received this message because you are subscribed to the Google Groups 
"qubes-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to qubes-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/qubes-devel/ZKgcqiB/wq5aHqOq%40mail-itl.


[qubes-devel] [PATCH] Fix qubes-input-sender-mouse@.service failing on boot

2023-06-29 Thread 8h45 via qubes-devel
If sys-usb boots up before the user has logged in, 
qubes-input-sender-mouse@.service fails permanently. This patch makes 
the service restart on failure at a reasonable time interval.
diff --git a/qubes-rpc/qubes-input-sender-mouse@.service 
b/qubes-rpc/qubes-input-sender-mouse@.service

index 309f60f..18fbb72 100644
--- a/qubes-rpc/qubes-input-sender-mouse@.service
+++ b/qubes-rpc/qubes-input-sender-mouse@.service
@@ -6,3 +6,5 @@ After=qubes-qrexec-agent.service
 Environment=TARGET_DOMAIN=dom0
 EnvironmentFile=-/etc/qubes/input-proxy-target
 ExecStart=/usr/bin/qubes-input-sender qubes.InputMouse /dev/input/%i 
"$TARGET_DOMAIN"

+Restart=always
+RestartSec=1

--
You received this message because you are subscribed to the Google Groups 
"qubes-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to qubes-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/qubes-devel/2ad16ac416313ecda5c738bef51eba26%40tough.email.