subject:"\[Rd\] CRAN packages maintained by you"

Re: [Rd] CRAN packages maintained by you

2016-09-02 Thread Thomas Petzoldt


Am 02.09.2016 um 16:02 schrieb Dirk Eddelbuettel:


On 2 September 2016 at 14:54, Thomas Petzoldt wrote:
| Hi,
|
| I have the same problem and, at a first look, the issues reported by the
| CRAN checks seemed easy to fix. However, after checking it again locally
| and on http://win-builder.r-project.org it appeared that GCC 4.9.3
| (Windows, Rtools 3.4), same also on win-builder reports even more
| issues, especially legacy Fortran (mainly Roger's #2 and #3), but also
|
| "warning: ISO C forbids conversion of object pointer to function pointer
| type"
|
| The latter results from using pointers returned by R_ExternalPtrAddr()
| for calling user-defined functions in DLLs, cf. the following thread
| from the very beginning:
| https://stat.ethz.ch/pipermail/r-devel/2004-September/030792.html
|
| What is now expected to do?
|
| 1. Is it really the intention to start a complete rewrite of all legacy
| Fortran code?
|
| 2. Is there now a better way for calling user functions than
| R_ExternalPtrAddr()?

See this commit (where I apologize for referring to GitHub as the
non-canonical source, but it presents things in pretty enough manner) by
Brian Ripley just a few days ago:

  
https://github.com/wch/r-source/commit/a528a69b98d3e763c39cfabf9b4a9e398651177c

So R 3.4.0 will have R_MakeExternalPtrFn() and R_ExternalPtrAddrFn().


Thank you very much for this hint, sounds very promising! I was indeed 
looking for something like this in the R docs+sources, but didn't expect 
that it is that hot. Now I found it now also in the canonical svn 
sources ;)


I am little bit concerned, how fast this should be forced by CRAN 
because of back-compatibility, and if compiler derivatives are worth the 
effort for this ...


Remains issue #1 with "Obsolescent features" of legacy Fortran. While 
updating my Fedora test system, it seems that there are many other 
packages around that use this sort of old-style, and well tested (!!!) 
Fortran ...


Thomas

[...]


| Am 28.08.2016 um 23:48 schrieb Roger Koenker:
| > Hi Kurt,
| >
| > I have started to look into this, and I need some guidance about how to
| > prioritize my repairs.  There are basically 4 categories of warnings from
| > gfortran’s pedantic critique of my packages:
| >
| >  1.  Some errant tab characters it doesn’t like,
| >  2.  Too many or too few continue statements
| >  3.  Horrible (and obsolescent) arithmetic and computed gotos
| >  4.  undeclared doubles and dubious conversions
| >
| > The last category seems relatively easy to fix and is potentially
| > important, but the others seem more difficult to fix and altogether
| > less important.  The goto issues are all in code that has been written
| > long ago by others and imported, e.g. Peyton and Ng’s cholesky.f.
| > I’m very reluctant to mess with any of those gotos.  The fact that
| > they were declared obsolete long ago doesn’t mean that gfortran
| > has any intention of not supporting these constructs in the future,
| > does it?
| >
| > Before devoting more time and energy, which is in short supply
| > lately, I like to hear what others are thinking/doing about all this,
| > so I’ll copy this to r-devel.
| >
| > All the best,
| > Roger
| >
| > url:www.econ.uiuc.edu/~rogerRoger Koenker
| > emailrkoen...@uiuc.eduDepartment of Economics
| > vox: 217-333-4558University of Illinois
| > fax:   217-244-6678Urbana, IL 61801
| >
| >
| >> On Aug 28, 2016, at 2:36 AM, Kurt Hornik  wrote:
| >>
| >>
| >> Dear maintainers,
| >>
| >> This concerns the CRAN packages
| >
| > 
| >>
| >> Using gfortran with options -Wall -pedantic to compile your package
| >> Fortran code finds important problems, see your package check pages for
| >> more information.
| >>
| >> Can you please fix these problems as quickly as possible?
| >>
| >> Best
| >> -k
| >
| > __
| > R-devel@r-project.org mailing list
| > https://stat.ethz.ch/mailman/listinfo/r-devel
| >



--
Thomas Petzoldt
thomas.petzo...@tu-dresden.de
http://tu-dresden.de/Members/thomas.petzoldt

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] CRAN packages maintained by you

2016-09-02 Thread Dirk Eddelbuettel


On 2 September 2016 at 14:54, Thomas Petzoldt wrote:
| Hi,
| 
| I have the same problem and, at a first look, the issues reported by the 
| CRAN checks seemed easy to fix. However, after checking it again locally 
| and on http://win-builder.r-project.org it appeared that GCC 4.9.3 
| (Windows, Rtools 3.4), same also on win-builder reports even more 
| issues, especially legacy Fortran (mainly Roger's #2 and #3), but also
| 
| "warning: ISO C forbids conversion of object pointer to function pointer 
| type"
| 
| The latter results from using pointers returned by R_ExternalPtrAddr() 
| for calling user-defined functions in DLLs, cf. the following thread 
| from the very beginning: 
| https://stat.ethz.ch/pipermail/r-devel/2004-September/030792.html
| 
| What is now expected to do?
| 
| 1. Is it really the intention to start a complete rewrite of all legacy 
| Fortran code?
| 
| 2. Is there now a better way for calling user functions than 
| R_ExternalPtrAddr()?

See this commit (where I apologize for referring to GitHub as the
non-canonical source, but it presents things in pretty enough manner) by
Brian Ripley just a few days ago:

  
https://github.com/wch/r-source/commit/a528a69b98d3e763c39cfabf9b4a9e398651177c

So R 3.4.0 will have R_MakeExternalPtrFn() and R_ExternalPtrAddrFn().

(Hat tip to Duncan's very useful NEWS summary robot-blog which I read daily).

Dirk
 
 
| Many thanks for clarification,
| 
| Thomas
| 
| 
| Am 28.08.2016 um 23:48 schrieb Roger Koenker:
| > Hi Kurt,
| >
| > I have started to look into this, and I need some guidance about how to
| > prioritize my repairs.  There are basically 4 categories of warnings from
| > gfortran’s pedantic critique of my packages:
| >
| > 1.  Some errant tab characters it doesn’t like,
| > 2.  Too many or too few continue statements
| > 3.  Horrible (and obsolescent) arithmetic and computed gotos
| > 4.  undeclared doubles and dubious conversions
| >
| > The last category seems relatively easy to fix and is potentially
| > important, but the others seem more difficult to fix and altogether
| > less important.  The goto issues are all in code that has been written
| > long ago by others and imported, e.g. Peyton and Ng’s cholesky.f.
| > I’m very reluctant to mess with any of those gotos.  The fact that
| > they were declared obsolete long ago doesn’t mean that gfortran
| > has any intention of not supporting these constructs in the future,
| > does it?
| >
| > Before devoting more time and energy, which is in short supply
| > lately, I like to hear what others are thinking/doing about all this,
| > so I’ll copy this to r-devel.
| >
| > All the best,
| > Roger
| >
| > url:www.econ.uiuc.edu/~rogerRoger Koenker
| > emailrkoen...@uiuc.eduDepartment of Economics
| > vox: 217-333-4558University of Illinois
| > fax:   217-244-6678Urbana, IL 61801
| >
| >
| >> On Aug 28, 2016, at 2:36 AM, Kurt Hornik  wrote:
| >>
| >>
| >> Dear maintainers,
| >>
| >> This concerns the CRAN packages
| >
| > 
| >>
| >> Using gfortran with options -Wall -pedantic to compile your package
| >> Fortran code finds important problems, see your package check pages for
| >> more information.
| >>
| >> Can you please fix these problems as quickly as possible?
| >>
| >> Best
| >> -k
| >
| > __
| > R-devel@r-project.org mailing list
| > https://stat.ethz.ch/mailman/listinfo/r-devel
| >
| 
| 
| -- 
| Dr. Thomas Petzoldt
| Technische Universitaet Dresden
| Faculty of Environmental Sciences
| Institute of Hydrobiology
| 01062 Dresden, Germany
| 
| Tel.: +49 351 463 34954
| Fax:  +49 351 463 37108
| E-Mail: thomas.petzo...@tu-dresden.de
| http://tu-dresden.de/Members/thomas.petzoldt
| 
| -- limnology and ecological modelling --
| 
| __
| R-devel@r-project.org mailing list
| https://stat.ethz.ch/mailman/listinfo/r-devel
-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] CRAN packages maintained by you

2016-09-02 Thread Thomas Petzoldt


Hi,

I have the same problem and, at a first look, the issues reported by the 
CRAN checks seemed easy to fix. However, after checking it again locally 
and on http://win-builder.r-project.org it appeared that GCC 4.9.3 
(Windows, Rtools 3.4), same also on win-builder reports even more 
issues, especially legacy Fortran (mainly Roger's #2 and #3), but also


"warning: ISO C forbids conversion of object pointer to function pointer 
type"


The latter results from using pointers returned by R_ExternalPtrAddr() 
for calling user-defined functions in DLLs, cf. the following thread 
from the very beginning: 
https://stat.ethz.ch/pipermail/r-devel/2004-September/030792.html


What is now expected to do?

1. Is it really the intention to start a complete rewrite of all legacy 
Fortran code?


2. Is there now a better way for calling user functions than 
R_ExternalPtrAddr()?



Many thanks for clarification,

Thomas


Am 28.08.2016 um 23:48 schrieb Roger Koenker:

Hi Kurt,

I have started to look into this, and I need some guidance about how to
prioritize my repairs.  There are basically 4 categories of warnings from
gfortran’s pedantic critique of my packages:

1.  Some errant tab characters it doesn’t like,
2.  Too many or too few continue statements
3.  Horrible (and obsolescent) arithmetic and computed gotos
4.  undeclared doubles and dubious conversions

The last category seems relatively easy to fix and is potentially
important, but the others seem more difficult to fix and altogether
less important.  The goto issues are all in code that has been written
long ago by others and imported, e.g. Peyton and Ng’s cholesky.f.
I’m very reluctant to mess with any of those gotos.  The fact that
they were declared obsolete long ago doesn’t mean that gfortran
has any intention of not supporting these constructs in the future,
does it?

Before devoting more time and energy, which is in short supply
lately, I like to hear what others are thinking/doing about all this,
so I’ll copy this to r-devel.

All the best,
Roger

url:www.econ.uiuc.edu/~rogerRoger Koenker
emailrkoen...@uiuc.eduDepartment of Economics
vox: 217-333-4558University of Illinois
fax:   217-244-6678Urbana, IL 61801



On Aug 28, 2016, at 2:36 AM, Kurt Hornik  wrote:


Dear maintainers,

This concerns the CRAN packages





Using gfortran with options -Wall -pedantic to compile your package
Fortran code finds important problems, see your package check pages for
more information.

Can you please fix these problems as quickly as possible?

Best
-k


__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel




--
Dr. Thomas Petzoldt
Technische Universitaet Dresden
Faculty of Environmental Sciences
Institute of Hydrobiology
01062 Dresden, Germany

Tel.: +49 351 463 34954
Fax:  +49 351 463 37108
E-Mail: thomas.petzo...@tu-dresden.de
http://tu-dresden.de/Members/thomas.petzoldt

-- limnology and ecological modelling --

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] CRAN packages maintained by you

2016-08-28 Thread Roger Koenker

Hi Kurt,

I have started to look into this, and I need some guidance about how to
prioritize my repairs.  There are basically 4 categories of warnings from
gfortran’s pedantic critique of my packages:

1.  Some errant tab characters it doesn’t like,
2.  Too many or too few continue statements
3.  Horrible (and obsolescent) arithmetic and computed gotos
4.  undeclared doubles and dubious conversions 

The last category seems relatively easy to fix and is potentially
important, but the others seem more difficult to fix and altogether
less important.  The goto issues are all in code that has been written
long ago by others and imported, e.g. Peyton and Ng’s cholesky.f.
I’m very reluctant to mess with any of those gotos.  The fact that
they were declared obsolete long ago doesn’t mean that gfortran 
has any intention of not supporting these constructs in the future,
does it?  

Before devoting more time and energy, which is in short supply
lately, I like to hear what others are thinking/doing about all this,
so I’ll copy this to r-devel.

All the best,
Roger

url:www.econ.uiuc.edu/~rogerRoger Koenker
emailrkoen...@uiuc.eduDepartment of Economics
vox: 217-333-4558University of Illinois
fax:   217-244-6678Urbana, IL 61801

> On Aug 28, 2016, at 2:36 AM, Kurt Hornik  wrote:
> 
> 
> Dear maintainers,
> 
> This concerns the CRAN packages

> 
> Using gfortran with options -Wall -pedantic to compile your package
> Fortran code finds important problems, see your package check pages for
> more information.  
> 
> Can you please fix these problems as quickly as possible?
> 
> Best
> -k

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] CRAN packages maintained by you

2011-08-22 Thread Michael Friendly

It is A Good Thing to regularize Authors and Maintainers of packages, 
particularly for citation()

and toBibTex().

Could I add a suggested TODO item for the maintainer of package.skeleton 
and friends to

help reinforce this for new packages:

- Please add appropriate templates for Author@R in the skeleton 
DESCRIPTION file generated,
indicating the proper format as well as the use of role= to signal the 
creator and

maintainer.

- a comment to see ?person for descriptions of fields wouldn't hurt either

best,
-Michael


On 8/8/2011 9:46 AM, Kurt Hornik wrote:

Dear maintainers,

This concerns the packages

CITAN ENmisc Formula MSBVAR RExcelInstaller RcmdrPlugin.mosaic
Rd2roxygen Rz SGP betareg expectreg fastcluster glmc gptk heplots pxR
sideChannelAttack sp spacetime trapezoid vcd

maintained by one of you.

I see that you have added Author@R fields providing enhanced information
on package authors to your DESCRIPTION files, which since R 2.12.0 is
used for auto-generating citations.

In current r-devel, we have finally added functionality for also
auto-generating package DESCRIPTION Author and Maintainer fields from
the enhanced information if needed [i.e., existing fields will not be
overwritten].

However, in the process of this the field was renamed to 'Authors@R', so
please change your DESCRIPTION files accordingly.

In doing so, pls note that to auto-generate Maintainer fields the
Authors@R fields need to provide authors with a maintainer (cre) role
and an email address.  Currently, packages

CITAN MSBVAR SGP fastcluster glmc gptk heplots sideChannelAttack sp
spacetime trapezoid

do not specify the package maintainer in their Authors@R field.

(Note that to take advantage of the new auto-generation functionality,
you need to rename to Authors@R, remove the DESCRIPTION Author and
Maintainer fields in the package sources, and then run R CMD build from
a current version of r-devel.)

Best
-k



--
Michael Friendly Email: friendly AT yorku DOT ca
Professor, Psychology Dept.
York University  Voice: 416 736-5115 x66249 Fax: 416 736-5814
4700 Keele StreetWeb:   http://www.datavis.ca
Toronto, ONT  M3J 1P3 CANADA

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] CRAN packages maintained by you

2007-04-10 Thread Gavin Simpson

On Sat, 2007-04-07 at 08:40 +0200, Kurt Hornik wrote:
 Dear maintainers of CRAN packages,
 
 This concerns the packages
snip /
 
 And now keep the updates rolling in ...

Dear R Developers,

I was recently emailed by the CRAN maintainers about warnings for my two
packages, analog and cocorresp, that are on CRAN.

I have built both packages (the versions on CRAN plus new,
in-development versions) under R 2.4.1, R 2.5.0-alpha [r41095] and R
2.6.0 (on two separate machines, both of which run FC 5 linux) and
cannot replicate the error message that the Daily Check Summary page
quotes:

checking R files for syntax errors ... WARNING
Warning in Sys.setlocale(category, locale) : 
OS reports request cannot be honored,

Which I get only for the R pre-release (r-prerel) on Linux ix86 and Mac
OS X ix86 versions.

I am actually at a loss as to what the problem might be. My packages
don't use Sys.setlocale() and I am not familiar enough with what this
function does to suggest why it might be causing a problem on the CRAN
servers.

Does anyone have any suggestions as to what might be causing these
warnings or how I might track down the problem?

All the best,

G

 
 Best
 -k
 
 
-- 
%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%
 Gavin Simpson [t] +44 (0)20 7679 0522
 ECRC  ENSIS, UCL Geography,  [f] +44 (0)20 7679 0565
 Pearson Building, [e] gavin.simpsonATNOSPAMucl.ac.uk
 Gower Street, London  [w] http://www.ucl.ac.uk/~ucfagls/cv/
 London, UK. WC1E 6BT. [w] http://www.ucl.ac.uk/~ucfagls/
%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%~%

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] CRAN packages maintained by you

Re: [Rd] CRAN packages maintained by you

Re: [Rd] CRAN packages maintained by you

Re: [Rd] CRAN packages maintained by you

Re: [Rd] CRAN packages maintained by you

Re: [Rd] CRAN packages maintained by you

6 matches

Site Navigation

Mail list logo

Footer information