Re: [Rd] Parts of test in datetime3.R not working

2023-06-16 Thread peter dalgaard
Yep, that is a pretty straightforward blunder. It's "stopifnot <- function(..., 
exprs =", so partial matching does not happen.

Fixed in R-patched and R-devel (a last-minute addition to 4.3.1 during code 
freeze would only happen with truly disastrous bugs).

Peter

> On 15 Jun 2023, at 11:57 , Korpela Mikko  
> wrote:
> 
> In test file datetime3.R, one call to stopifnot() has an argument named 
> "expr" which should probably be "exprs". There are three tests wrapped in 
> braces of which only the last one, "omitted 195 entries", is currently 
> checked.
> 
> Proposed patch:
> 
> --- tests/datetime3.R (revision 84544)
> +++ tests/datetime3.R (working copy)
> @@ -45,7 +45,7 @@
> c2 <- capture.output(print(dt, max = 6))
> writeLines(tail(cc, 4))
> writeLines(c2)
> -stopifnot(expr = {
> +stopifnot(exprs = {
> grepl("omitted 151 entries", tail(cc, 1))
>   !anyDuplicated(tail(cc, 2))
> grepl("omitted 195 entries", tail(c2, 1))
> 
> -- 
> Best regards,
> Mikko
> 
> __
> R-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

-- 
Peter Dalgaard, Professor,
Center for Statistics, Copenhagen Business School
Solbjerg Plads 3, 2000 Frederiksberg, Denmark
Phone: (+45)38153501
Office: A 4.23
Email: pd@cbs.dk  Priv: pda...@gmail.com

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


[Rd] Parts of test in datetime3.R not working

2023-06-15 Thread Korpela Mikko
In test file datetime3.R, one call to stopifnot() has an argument named "expr" 
which should probably be "exprs". There are three tests wrapped in braces of 
which only the last one, "omitted 195 entries", is currently checked.

Proposed patch:

--- tests/datetime3.R   (revision 84544)
+++ tests/datetime3.R   (working copy)
@@ -45,7 +45,7 @@
 c2 <- capture.output(print(dt, max = 6))
 writeLines(tail(cc, 4))
 writeLines(c2)
-stopifnot(expr = {
+stopifnot(exprs = {
 grepl("omitted 151 entries", tail(cc, 1))
   !anyDuplicated(tail(cc, 2))
 grepl("omitted 195 entries", tail(c2, 1))

-- 
Best regards,
Mikko

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel