Re: [Rd] utils::ls.str(): Partial argument name 'digits' to seq() (should be digits.d?)

2017-01-03 Thread Martin Maechler
You are right (though picky).  I have updated it now.

Thank you Henrik!
Martin

> Should utils::ls.str() be updated as:

> svn diff src/library/utils/R/str.R
> Index: src/library/utils/R/str.R
> ===
> --- src/library/utils/R/str.R (revision 71879)
> +++ src/library/utils/R/str.R (working copy)
> @@ -622,7 +622,7 @@
>  args$digits.d <- NULL
>  }
>  strargs <- c(list(max.level = max.level, give.attr = give.attr,
> -  digits = digits), args)
> +  digits.d = digits), args)
>  for(nam in x) {
>   cat(nam, ": ")


[...]

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel


[Rd] utils::ls.str(): Partial argument name 'digits' to seq() (should be digits.d?)

2017-01-02 Thread Henrik Bengtsson
Should utils::ls.str() be updated as:

svn diff src/library/utils/R/str.R
Index: src/library/utils/R/str.R
===
--- src/library/utils/R/str.R (revision 71879)
+++ src/library/utils/R/str.R (working copy)
@@ -622,7 +622,7 @@
 args$digits.d <- NULL
 }
 strargs <- c(list(max.level = max.level, give.attr = give.attr,
-  digits = digits), args)
+  digits.d = digits), args)
 for(nam in x) {
  cat(nam, ": ")
  ## check missingness, e.g. inside debug(.) :

Example:

$ R --quiet --vanilla
> options(warnPartialMatchArgs = TRUE, warn = 2)
> x <- 1
> ls.str()
x : Error in str.default(o, ...) :
  (converted from warning) partial argument match of 'digits' to 'digits.d'
> traceback()
10: doWithOneRestart(return(expr), restart)
9: withOneRestart(expr, restarts[[1L]])
8: withRestarts({
   .Internal(.signalCondition(simpleWarning(msg, call), msg,
   call))
   .Internal(.dfltWarn(msg, call))
   }, muffleWarning = function() NULL)
7: .signalSimpleWarning("partial argument match of 'digits' to 'digits.d'",
   quote(str.default(o, ...)))
6: str.default(o, ...)
5: str(o, ...)
4: (function (...)
   str(o, ...))(max.level = 1, give.attr = FALSE, digits = 3)
3: do.call(strO, strargs, quote = is.call(o) || is.symbol(o))
2: print.ls_str(x)
1: function (x, ...)
   UseMethod("print")(x)

/Henrik

__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel