Re: [R-pkg-devel] CRAN check FAIL due to pragmas in headers and code

2017-12-13 Thread Dirk Eddelbuettel 

On 14 December 2017 at 03:04, brodie gaslam via R-package-devel wrote:
| This leads me to think that it is (maybe) possible that this is an issue with 
the latest version of the check tool?

Which is what I tried to explain to Inaki when he first filed on as an Rcpp
issue ticket: Sometimes you need to put the stress on "devel" when you say
R-devel.

So I suspect these failures are transient.

Dirk

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] CRAN check FAIL due to pragmas in headers and code

2017-12-13 Thread Gábor Csárdi 
These are not check errors, but indeed a bug in the check tool:
https://github.com/wch/r-source/commit/c063350799e2209afe1c5b23915ee7b9a1606652#diff-4882a8c8e173bda109ed98da485e1428R8640

It has been fixed, so next R-devel build should be fine.

Gabor

On Thu, Dec 14, 2017 at 2:04 AM, brodie gaslam via R-package-devel
 wrote:
> __
> R-package-devel@r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-package-devel
>
> -- Forwarded message --
> From: brodie gaslam 
> To: List R-package-devel 
> Cc:
> Bcc:
> Date: Thu, 14 Dec 2017 01:54:04 + (UTC)
> Subject: RE: CRAN check FAIL due to pragmas in headers and code
> I too am seeing the same failure in my package.  It does not contain any 
> #pragma directives, and it doesn't have any dependencies to other compiled 
> packages.
> Poking around through the CRAN checks I've found other packages with C 
> compiled code displaying the same error on the clang and gcc 64 bit debian 
> checks:
> * diffobj: (my package) 
> https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/diffobj-00check.html*
>  xts: 
> https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/xts-00check.html*
>  backports: 
> https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/backports-00check.html
> I'm pretty sure (but not certain) that my package did not throw these errors 
> as of quite recently (I uploaded to CRAN over the weekend).
>
> This leads me to think that it is (maybe) possible that this is an issue with 
> the latest version of the check tool?
> Best,
> Brodie.
>
> [[alternative HTML version deleted]]
>
>

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] CRAN check FAIL due to pragmas in headers and code

2017-12-13 Thread brodie gaslam via R-package-devel 
--- Begin Message ---
I too am seeing the same failure in my package.  It does not contain any 
#pragma directives, and it doesn't have any dependencies to other compiled 
packages.
Poking around through the CRAN checks I've found other packages with C compiled 
code displaying the same error on the clang and gcc 64 bit debian checks:
* diffobj: (my package) 
https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/diffobj-00check.html*
 xts: 
https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/xts-00check.html*
 backports: 
https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/backports-00check.html
I'm pretty sure (but not certain) that my package did not throw these errors as 
of quite recently (I uploaded to CRAN over the weekend).

This leads me to think that it is (maybe) possible that this is an issue with 
the latest version of the check tool?
Best,
Brodie.

[[alternative HTML version deleted]]

--- End Message ---
__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] CRAN check FAIL due to pragmas in headers and code

2017-12-13 Thread Dirk Eddelbuettel 

On 14 December 2017 at 00:58, Iñaki Úcar wrote:
| Hi all,
| 
| Three days ago, Patrick Perry posted the following on R-devel:
| 
| 2017-12-11 16:32 GMT+01:00 Patrick Perry :
| > A recent change to r-devel causes an R CMD check warning when a C file
| > includes a "#pragma GCC diagnostic ignored" pragma:
| > 
https://github.com/wch/r-source/commit/b76c8fd355a0f5b23d42aaf44a879cac0fc31fa4
| > . This causes the CRAN checks for the "corpus" package to emit a warning:
| > 
https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/corpus-00check.html
| 
| I didn't pay much attention, but today I received a couple of emails
| warning about my package failing on r-devel-linux-x86_64-debian (gcc
| and clang) with the following message:
| 
| Check: pragmas in C/C++ headers and code
| Result: FAIL
| 
| My package has no pragmas, but Rcpp, on which it depends, does. So

But for the record (and using ag(1) as a better grep):

  edd@bud:~/git/rcpp(master)$ ag pragma
  inst/include/Rcpp/r/headers.h
  35:# pragma push_macro("major")
  40:# pragma push_macro("minor")
  45:# pragma push_macro("makedev")
  73:# pragma pop_macro("major")
  77:# pragma pop_macro("minor")
  81:# pragma pop_macro("makedev")
  
  inst/include/Rcpp/utils/tinyformat.h
  191:#   pragma warning(push)
  192:#   pragma warning(disable:4244)
  193:#   pragma warning(disable:4267)
  202:#   pragma warning(pop)

  inst/examples/OpenMP/OpenMPandInline.r
  62:#pragma omp parallel for shared(x, n)

  inst/examples/OpenMP/piWithInterrupts.cpp
  88:#pragma omp parallel for \
  edd@bud:~/git/rcpp(master)$

The ones in headers.h are innocent, the ones in tinyformat are #ifdef'ed away
for another OS, and the remaining two are for OpenMP.

So your statement "Rcpp does [have #pragma]" is narrowly correct, but still
totally irrelevant as the CRAN Policy issue (and recent change) is enirely
about _#pragma use to turn compiler diagnostics off_.  Which we don't do here. 

Dirk

| basically Rcpp and all packages depending on Rcpp are failing on that
| flavors. Is this a new requirement for new submissions? Or should I
| ignore these FAILs?
| 
| Regards,
| Iñaki
| 
| __
| R-package-devel@r-project.org mailing list
| https://stat.ethz.ch/mailman/listinfo/r-package-devel
-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

[R-pkg-devel] CRAN check FAIL due to pragmas in headers and code

2017-12-13 Thread Iñaki Úcar 
Hi all,

Three days ago, Patrick Perry posted the following on R-devel:

2017-12-11 16:32 GMT+01:00 Patrick Perry :
> A recent change to r-devel causes an R CMD check warning when a C file
> includes a "#pragma GCC diagnostic ignored" pragma:
> https://github.com/wch/r-source/commit/b76c8fd355a0f5b23d42aaf44a879cac0fc31fa4
> . This causes the CRAN checks for the "corpus" package to emit a warning:
> https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/corpus-00check.html

I didn't pay much attention, but today I received a couple of emails
warning about my package failing on r-devel-linux-x86_64-debian (gcc
and clang) with the following message:

Check: pragmas in C/C++ headers and code
Result: FAIL

My package has no pragmas, but Rcpp, on which it depends, does. So
basically Rcpp and all packages depending on Rcpp are failing on that
flavors. Is this a new requirement for new submissions? Or should I
ignore these FAILs?

Regards,
Iñaki

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel