Re: Possible interference between reiser4 and usb-storage?

[Christian Kujau]

On Sun, 19 Nov 2006, Clemens Eisserer wrote:

am using cryptocompress with the 2.6.19rc4 kernel and after some time
df reports something like:


..."after some time", so right after mkfs df(1) is telling the truth?
Does it drop to 52MB all of a sudden or does it decrease slowly? does it 
happen with other/former kernels too?


/dev/sda1 55068032  32996604  22071428  60% /mnt (1GB flash 
storage)


however sda1 is a 1gb usb storage device!!


What does fdisk say?


Could that be because I compiled the kernel with -O3?


Does it happen without the tweak? Why are you using -O3 anyway, does it 
really make a difference?


Christian.
--
BOFH excuse #400:

We are Microsoft.  What you are experiencing is not a problem; it is an 
undocumented feature.

[PATCH 2.6.19-rc6] reiser: replace kmalloc+memset with kzalloc

[Yan Burman]

Replace kmalloc+memset with kzalloc

Signed-off-by: Yan Burman <[EMAIL PROTECTED]>

diff -rubp linux-2.6.19-rc5_orig/fs/reiserfs/file.c 
linux-2.6.19-rc5_kzalloc/fs/reiserfs/file.c
--- linux-2.6.19-rc5_orig/fs/reiserfs/file.c2006-11-09 12:16:20.0 
+0200
+++ linux-2.6.19-rc5_kzalloc/fs/reiserfs/file.c 2006-11-11 22:44:04.0 
+0200
@@ -316,12 +316,11 @@ static int reiserfs_allocate_blocks_for_
/* area filled with zeroes, to supply as list of zero 
blocknumbers
   We allocate it outside of loop just in case loop 
would spin for
   several iterations. */
-   char *zeros = kmalloc(to_paste * UNFM_P_SIZE, 
GFP_ATOMIC);  // We cannot insert more than MAX_ITEM_LEN bytes anyway.
+   char *zeros = kzalloc(to_paste * UNFM_P_SIZE, 
GFP_ATOMIC);  // We cannot insert more than MAX_ITEM_LEN bytes anyway.
if (!zeros) {
res = -ENOMEM;
goto error_exit_free_blocks;
}
-   memset(zeros, 0, to_paste * UNFM_P_SIZE);
do {
to_paste =
min_t(__u64, hole_size,
diff -rubp linux-2.6.19-rc5_orig/fs/reiserfs/inode.c 
linux-2.6.19-rc5_kzalloc/fs/reiserfs/inode.c
--- linux-2.6.19-rc5_orig/fs/reiserfs/inode.c   2006-11-09 12:16:20.0 
+0200
+++ linux-2.6.19-rc5_kzalloc/fs/reiserfs/inode.c2006-11-11 
22:44:04.0 +0200
@@ -928,15 +928,12 @@ int reiserfs_get_block(struct inode *ino
if (blocks_needed == 1) {
un = &unf_single;
} else {
-   un = kmalloc(min(blocks_needed, max_to_insert) 
* UNFM_P_SIZE, GFP_ATOMIC);  // We need to avoid scheduling.
+   un = kzalloc(min(blocks_needed, max_to_insert) 
* UNFM_P_SIZE, GFP_ATOMIC);  // We need to avoid scheduling.
if (!un) {
un = &unf_single;
blocks_needed = 1;
max_to_insert = 0;
-   } else
-   memset(un, 0,
-  UNFM_P_SIZE * min(blocks_needed,
-
max_to_insert));
+   }
}
if (blocks_needed <= max_to_insert) {
/* we are going to add target block to the 
file. Use allocated
diff -rubp linux-2.6.19-rc5_orig/fs/reiserfs/super.c 
linux-2.6.19-rc5_kzalloc/fs/reiserfs/super.c
--- linux-2.6.19-rc5_orig/fs/reiserfs/super.c   2006-11-09 12:16:20.0 
+0200
+++ linux-2.6.19-rc5_kzalloc/fs/reiserfs/super.c2006-11-11 
22:44:04.0 +0200
@@ -1549,13 +1549,12 @@ static int reiserfs_fill_super(struct su
struct reiserfs_sb_info *sbi;
int errval = -EINVAL;

-   sbi = kmalloc(sizeof(struct reiserfs_sb_info), GFP_KERNEL);
+   sbi = kzalloc(sizeof(struct reiserfs_sb_info), GFP_KERNEL);
if (!sbi) {
errval = -ENOMEM;
goto error;
}
s->s_fs_info = sbi;
-   memset(sbi, 0, sizeof(struct reiserfs_sb_info));
/* Set default values for options: non-aggressive tails, RO on errors */
REISERFS_SB(s)->s_mount_opt |= (1 << REISERFS_SMALLTAIL);
REISERFS_SB(s)->s_mount_opt |= (1 << REISERFS_ERROR_RO);


Regards
Yan Burman