Re: [patch] reiser4-for-2.6.20
On 2007-02-09 23:26, squadra wrote: i m getting lots of errormessages with the 2.6.20 patch, it looks to me like they start when i copy files from a reiser4 partition, to a ext3. Hi, thanks for your report. * Did you use 2.6.19 on that machine before? Any problems with it? * Do you use reiser4 cryptocmpress? I'm running two system using my original 2.6.20-patch. There wasn't a single problem (even under heavy io). I just created an ext3 partition and filled it up with files from reiser4. What did you actually do to trigger the errors? Cryptocompress? Ingo -- Ingo Bormuth, voicebox fax: +49-(0)-12125-10226517 public key 86326EC9, http://ibormuth.efil.de/contact
Re: [patch] reiser4-for-2.6.20
On 2007-02-10 07:47, squadra wrote: diff -puN fs/fs-writeback.c~reiser4-sb_sync_inodes-fix fs/fs-writeback.c --- a/fs/fs-writeback.c~reiser4-sb_sync_inodes-fix +++ a/fs/fs-writeback.c @@ -317,6 +317,8 @@ int generic_sync_sb_inodes(struct super_ const unsigned long start = jiffies;/* livelock avoidance */ int ret = 0; + spin_lock(inode_lock); + if (!wbc-for_kupdate || list_empty(sb-s_io)) list_splice_init(sb-s_dirty, sb-s_io); since i applied this patch ontop of yours, the error didnt accour anymore. Nice to hear that you Problem has gone away. Nevertheless I'm a bit confused. The 'spin_lock(inode_lock);' line is already there (it's part of the official code since reiser4-for-2.6.11). There might have been an other issue... Cheers Ingo -- Ingo Bormuth, voicebox fax: +49-(0)-12125-10226517 public key 86326EC9, http://ibormuth.efil.de/contact
Re: [patch] reiser4-for-2.6.20
Hi i m getting lots of errormessages with the 2.6.20 patch, it looks to me like they start when i copy files from a reiser4 partition, to a ext3. Call Trace: [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 [88094247] :reiser4:save_unix_sd+0x5a/0x69 [88094247] :reiser4:save_unix_sd+0x5a/0x69 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [80293f3e] writeback_inodes+0x6e/0xb8 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [80293f3e] writeback_inodes+0x6e/0xb8 [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [8808772e] :reiser4:write_unix_file+0x413/0x488 [8027a787] vfs_write+0xad/0x156 [8027ad29] sys_write+0x45/0x6e [80209b2e] system_call+0x7e/0x83 [8808772e] :reiser4:write_unix_file+0x413/0x488 Call Trace: [8027a787] vfs_write+0xad/0x156 [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [8027ad29] sys_write+0x45/0x6e [80209b2e] system_call+0x7e/0x83 [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 Call Trace: [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [88094247] :reiser4:save_unix_sd+0x5a/0x69 [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [80293f3e] writeback_inodes+0x6e/0xb8 [88094247] :reiser4:save_unix_sd+0x5a/0x69 [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [80293f3e] writeback_inodes+0x6e/0xb8 [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [8808772e] :reiser4:write_unix_file+0x413/0x488 [8027a787] vfs_write+0xad/0x156 [8027ad29] sys_write+0x45/0x6e [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [80209b2e] system_call+0x7e/0x83 [8808772e] :reiser4:write_unix_file+0x413/0x488 [8027a787] vfs_write+0xad/0x156 [8027ad29] sys_write+0x45/0x6e [80209b2e] system_call+0x7e/0x83 Call Trace: [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 [88094247] :reiser4:save_unix_sd+0x5a/0x69 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [80293f3e] writeback_inodes+0x6e/0xb8 [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [8808772e] :reiser4:write_unix_file+0x413/0x488 [8027a787] vfs_write+0xad/0x156 [8027ad29] sys_write+0x45/0x6e [80209b2e] system_call+0x7e/0x83 Call Trace: [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 [88094247] :reiser4:save_unix_sd+0x5a/0x69 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [80293f3e] writeback_inodes+0x6e/0xb8 [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [8808772e] :reiser4:write_unix_file+0x413/0x488 [8027a787] vfs_write+0xad/0x156 [8027ad29] sys_write+0x45/0x6e [80209b2e] system_call+0x7e/0x83 Call Trace: [8805099f] :ext3:ext3_write_inode+0x22/0x40 [80293594] __writeback_single_inode+0x225/0x3be [88072ff1] :reiser4:flush_some_atom+0x45c/0x483 [88094247] :reiser4:save_unix_sd+0x5a/0x69 [8807e6c4] :reiser4:reiser4_writeout+0xe8/0x171 [80293a92] generic_sync_sb_inodes+0x1dc/0x2ca [80293f3e] writeback_inodes+0x6e/0xb8 [8025bbbe] balance_dirty_pages_ratelimited_nr+0x132/0x221 [8806ebff] :reiser4:reiser4_exit_context+0x70/0x115 [8808772e] :reiser4:write_unix_file+0x413/0x488 [8027a787] vfs_write+0xad/0x156 [8027ad29] sys_write+0x45/0x6e
