Re: Feature freeze break request for Sushi

[Andre Klapper]

On Tue, 2019-08-27 at 17:51 +0300, mcatanz...@gnome.org wrote:
> In that case, approval 1 / 2.

...and the second r-t approval.

andre
--
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: UI freeze break request for g-c-c

[Andre Klapper]

On Tue, 2019-08-27 at 17:50 +0300, mcatanz...@gnome.org wrote:
> Approval 1 / 2

Yes please. r-t approval 2/2.

andre
--
Andre Klapper  |  ak...@gmx.net
https://blogs.gnome.org/aklapper/


___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: UI freeze break request for g-c-c

[mcatanzaro]

Copying the original mail below, because this got stuck in the 
moderation queue:


On Tue, Aug 27, 2019 at 4:17 PM, Gunnar Hjalmarsson 
 wrote:

Hello release team,

I'd like to request a freeze break to allow the merge of:



into 3.34. It completes the fix of



The part in gnome-desktop, including the API which the 
gnome-control-center change depends on, is already in.


The remaining g-c-c change affects the display of certain items in 
the Language widget in Region & Language, meaning that for instance 
the item


Serbian Serbia

which actually refers to the latin locale will instead be shown as

Serbian (Latin) Serbia

to distinguish it from the cyrillic locale which will keep being 
shown as


Serbian Serbia

The g-c-c change does not add any new strings to be translated - that 
has already be taken care of in gnome-desktop.


The merge request has been reviewed and otherwise cleared by Robert 
Ancell.


Thanks for your consideration!

--
Cheers,

Gunnar Hjalmarsson



___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Feature freeze break request for Sushi

[mcatanzaro]

In that case, approval 1 / 2.

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: UI freeze break request for g-c-c

[mcatanzaro]

Approval 1 / 2

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

UI freeze break request for g-c-c

[Gunnar Hjalmarsson]

Hello release team,

I'd like to request a freeze break to allow the merge of:

https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/507

into 3.34. It completes the fix of

https://gitlab.gnome.org/GNOME/gnome-desktop/issues/50

The part in gnome-desktop, including the API which the 
gnome-control-center change depends on, is already in.


The remaining g-c-c change affects the display of certain items in the 
Language widget in Region & Language, meaning that for instance the item


Serbian Serbia

which actually refers to the latin locale will instead be shown as

Serbian (Latin) Serbia

to distinguish it from the cyrillic locale which will keep being shown as

Serbian Serbia

The g-c-c change does not add any new strings to be translated - that 
has already be taken care of in gnome-desktop.


The merge request has been reviewed and otherwise cleared by Robert Ancell.

Thanks for your consideration!

--
Cheers,

Gunnar Hjalmarsson
https://launchpad.net/~gunnarhj
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Feature freeze break request for Sushi

[Cosimo Cecchi via release-team]

On Tue, 2019-08-27 at 14:45 +0300, mcatanz...@gnome.org wrote:
> On Tue, Aug 27, 2019 at 12:45 PM, Cosimo Cecchi via release-team <
> release-team@gnome.org> wrote:
> > The two merge requests ([2] and [3]) have been reviewed by Carlos
> > here
> > at GUADEC and should be ready to go in case the feature freeze
> > break is
> > granted.
> 
> [2] looks OK for a freeze break, but [3] seems extensive. Are you
> really confident that the chances of a regression (e.g. introducing a
> new crash related to the signals) are low? I'm not sure the quality
> improvement from this MR outweighs the chance of regression?

I understand that the numbers of lines changed may be a cause of
concern, but I am pretty confident that this has low chance of
introducing regressions, since most of the new code only runs when the
new feature is activated.

Of course there's still a chance something could have slipped in
unnoticed, but since we're not in hard code freeze yet, we should still
have some time to fix issues if they come up in testing before 3.34.0.

> How sad would you be if I suggest deferring this to 3.36? I'm not
> opposed to approving a freeze break if you think it's important, but
> I do see reason to hesitate.

It wouldn't be the end of the world, and I trust the release team's
judgement, but I'm not sure that deferring it would necessarily
translate to higher quality, since the current set of MRs have been
tested with 3.34.

Also since Sushi got a major rewrite this cycle, this feature is a nice
user-visible improvement to showcase together with it.

Thanks,
Cosimo

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Feature freeze break request for Sushi

[mcatanzaro]

On Tue, Aug 27, 2019 at 12:45 PM, Cosimo Cecchi via release-team 
 wrote:

The two merge requests ([2] and [3]) have been reviewed by Carlos here
at GUADEC and should be ready to go in case the feature freeze break 
is

granted.


[2] looks OK for a freeze break, but [3] seems extensive. Are you 
really confident that the chances of a regression (e.g. introducing a 
new crash related to the signals) are low? I'm not sure the quality 
improvement from this MR outweighs the chance of regression?


How sad would you be if I suggest deferring this to 3.36? I'm not 
opposed to approving a freeze break if you think it's important, but I 
do see reason to hesitate.


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Feature freeze break request for Sushi

[Cosimo Cecchi via release-team]

Hi release team,

I'd like to ask for a feature freeze break in order to merge an
implementation for a long-standing Sushi feature request: updating the
currently previewed file when arrow keys are pressed in the Sushi
window [1].

The feature requires to extend the private DBus interface between
Nautilus and Sushi, and since we just added a v2 interface this cycle
in order to support Wayland, right now would be a great time to do so.

The two merge requests ([2] and [3]) have been reviewed by Carlos here
at GUADEC and should be ready to go in case the feature freeze break is
granted.

In the meantime, please let me know if there's any further information
I can provide.

[1] https://gitlab.gnome.org/GNOME/sushi/issues/5
[2] https://gitlab.gnome.org/GNOME/sushi/merge_requests/8
[3] https://gitlab.gnome.org/GNOME/nautilus/merge_requests/470

Thanks,
Cosimo

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re:Neodymium ring magnets/D14*9*6mm/N52

[Boyce Xiao via release-team]

Dear Manager,

Good morning.

Are you looking for a good and reliable permanent magnet supplier?We have many 
years of experience in producing high performance magnets.

Looking forward to hearing from you.

Best regards,

Ms Zhang___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.