[gnome-contacts] Created branch gnome-3-22
The branch 'gnome-3-22' was created pointing to: 1aaeeb8... Bump version to 3.22.1 for release ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Request string break for GNOME Calendar 3.16.x
On Jun 3, 2015 2:48 AM, "Alexandre Franke" wrote: > > Two questions: > * for the C locale, shouldn't the string be in the order month/date/year? Done and > * I see you pushed the patch to the gnome-3-16 branch, but the string > doesn't appear in master (yet?). Do you plan to push it there too? I > know master is not frozen, it's just easier for us to be consistent in > our translations if we do this kind of things in both branches at the > same time. > Done. Thanks for your suggestions ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Request string break for GNOME Calendar 3.16.x
Hi:
A stated in the bug here [1], Calendar is crashing in some locales. The
proposed fix introduces a new string to be translated, which requires me to
ask for a string break for this branch of calendar.
The main reason for asking the break is that Calendar can not change the
date of a any event in some locales, and crashes, render the application
almost completely useless. This would continue for the entire 3.16.x cycle,
leaving distro like Fedora 22 using a broken version of Calendar.
The proposed patch change is shown below:
--
diff --git a/src/gcal-date-selector.c b/src/gcal-date-selector.c
index 1e90224..2f93512 100644
--- a/src/gcal-date-selector.c
+++ b/src/gcal-date-selector.c
@@ -233,14 +233,26 @@ gcal_date_selector_init (GcalDateSelector *self)
priv->month = 1;
priv->year = 1970;
- priv->mask = nl_langinfo (D_FMT);
+ /* This string represents day/month/year order for each of the differents
+ * languages. It could possibly be default value, %m/%d/%y placing the
month
+ * before, or any ordering according to the translators environment */
+ priv->mask = _("%d/%m/%y");
/**
* Select the day, month and year indexes. This will
* be used later on to map the date entries to the
- * corresponding indexes.
+ * corresponding indexes. I've should add more validations here.
*/
max = strlen (priv->mask);
+ if (max != 6)
+{
+ /* I'll assume an error and bail out with the default values */
+ priv->day_pos = 0;
+ priv->month_pos = 1;
+ priv->year_pos = 2;
+ return;
+}
+
d_index = 0;
for (i = 0; i < max; i++)
--
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1226823
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.
Request string break for GNOME Calendar 3.16.x
Hi:
A stated in the bug here [1], Calendar is crashing in some locales. The
proposed fix introduces a new string to be translated, which requires me to
ask for a string break for this branch of calendar.
The main reason for asking the break is that Calendar can not change the
date of a any event in some locales, and crashes, render the application
almost completely useless. This would continue for the entire 3.16.x cycle,
leaving distro like Fedora 22 using a broken version of Calendar.
The proposed patch change is shown below:
--
diff --git a/src/gcal-date-selector.c b/src/gcal-date-selector.c
index 1e90224..2f93512 100644
--- a/src/gcal-date-selector.c
+++ b/src/gcal-date-selector.c
@@ -233,14 +233,26 @@ gcal_date_selector_init (GcalDateSelector *self)
priv->month = 1;
priv->year = 1970;
- priv->mask = nl_langinfo (D_FMT);
+ /* This string represents day/month/year order for each of the differents
+ * languages. It could possibly be default value, %m/%d/%y placing the
month
+ * before, or any ordering according to the translators environment */
+ priv->mask = _("%d/%m/%y");
/**
* Select the day, month and year indexes. This will
* be used later on to map the date entries to the
- * corresponding indexes.
+ * corresponding indexes. I've should add more validations here.
*/
max = strlen (priv->mask);
+ if (max != 6)
+{
+ /* I'll assume an error and bail out with the default values */
+ priv->day_pos = 0;
+ priv->month_pos = 1;
+ priv->year_pos = 2;
+ return;
+}
+
d_index = 0;
for (i = 0; i < max; i++)
--
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1226823
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.
[gnome-contacts] Created branch gnome-3-16
The branch 'gnome-3-16' was created pointing to: d5bdbc7... Bump version to 3.16.1 for release ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[gnome-contacts] Created branch gnome-3-14
The branch 'gnome-3-14' was created pointing to: 5ce36c9... Bump version to 3.14.1 for release ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Re: Regarding Contacts blocker bug
Did you test both patches or just the one from your bug? On 19/09/2014, Matthias Clasen wrote: > On Fri, Sep 19, 2014 at 12:33 PM, Erick Pérez Castellanos > wrote: >> Hi: >> >> Bug 736147 has been marked as blocker for GNOME 3.14. It would be >> sloppy of me not to fix completely the issue. So bug 685227 should be >> fixed as well. >> >> That second bug has the patch I've made for fixing the issue, it >> contains the implementation of the new (kinda old by now) shell search >> API. It obviously break ABI of Contacts, but being Contacts an user >> application, not a library, that shouldn't be a trouble for anyone. >> >> The patch has gone untested for a while because I have not been able >> to run a session with GNOME 3.13.9x for while (for a bunch of reasons, >> not being lazy, the wayland problem, plus my binary nvidia drivers, >> plus my pc being too old to run nouveau, etc.) I've tested those >> patches as far as I can, but I can't get the dbus connecting part >> working for the reasons explained above. >> >> So the impact of fixing the bug: as the situation is today, you can >> not pass a search from the shell the Contacts, cause it is not >> implemented. So that the main reason of fixing it. And finally, I >> think we should not wait till the next development phase because it is >> already implemented. >> >> So, after all that. It's up to you. > > I just went ahead and tested my patch to rename the search provider > ini file on my system: > > before the change: no search results from contacts > after the change: all my friends show up! > > so, I think we can declare the patch tested and working. > -- Art is the most intense mode of individualism that the world has known Oscar Wilde ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
Regarding Contacts blocker bug
Hi: Bug 736147 has been marked as blocker for GNOME 3.14. It would be sloppy of me not to fix completely the issue. So bug 685227 should be fixed as well. That second bug has the patch I've made for fixing the issue, it contains the implementation of the new (kinda old by now) shell search API. It obviously break ABI of Contacts, but being Contacts an user application, not a library, that shouldn't be a trouble for anyone. The patch has gone untested for a while because I have not been able to run a session with GNOME 3.13.9x for while (for a bunch of reasons, not being lazy, the wayland problem, plus my binary nvidia drivers, plus my pc being too old to run nouveau, etc.) I've tested those patches as far as I can, but I can't get the dbus connecting part working for the reasons explained above. So the impact of fixing the bug: as the situation is today, you can not pass a search from the shell the Contacts, cause it is not implemented. So that the main reason of fixing it. And finally, I think we should not wait till the next development phase because it is already implemented. So, after all that. It's up to you. Blocker bug: https://bugzilla.gnome.org/show_bug.cgi?id=736147 Second bug: https://bugzilla.gnome.org/show_bug.cgi?id=685227 -- Art is the most intense mode of individualism that the world has known Oscar Wilde ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[gnome-contacts] Created branch gnome-3-12
The branch 'gnome-3-12' was created pointing to: 69a28a7... [l10n] Update Catalan translation ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[gnome-contacts] Created branch gnome-3-10
The branch 'gnome-3-10' was created pointing to: d7c5085... Bump version to 3.10 for release ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
[gnome-contacts] Created branch gnome-3-8
The branch 'gnome-3-8' was created pointing to: 0140305... Updated Hungarian translation ___ release-team@gnome.org https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
