Re: Freeze break: fix bug with Mutter and toolkit window positioning

2014-09-19 Thread Frederic Peters
Matthias Clasen wrote:
 On Thu, Sep 18, 2014 at 10:18 PM, Sriram Ramkrishna s...@ramkrishna.me 
 wrote:
  On Thu, Sep 18, 2014 at 3:13 PM, Owen Taylor otay...@redhat.com wrote:
  Would like to push the patches:
 
   https://bugzilla.gnome.org/show_bug.cgi?id=736719
 
  The bug they fix is fairly bad misbehavior with non-GTK+ apps, in 
  particular with Qt apps.
 
  They are pretty straightforward, and basically are reverting back to an 
  earlier version
  of the code and I specifically tested that they also fix the original 
  problem with
  VirtualBox.
 
 
  +1 from me, anything that helps play nice with non-gtk+ apps for this
  release will be good from an engagement perspective.
 
 
 Second +1, with a cautionary note on the dangers of refactoring old
 code like this, in particular when it affects interoperability with
 other toolkits/wms, and we don't have sufficient automatic testing in
 place...

Hum, as Sri is not a release team member, here's a +1 to replace his
:)


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break: fix bug with Mutter and toolkit window positioning

2014-09-18 Thread Matthias Clasen
On Thu, Sep 18, 2014 at 10:18 PM, Sriram Ramkrishna s...@ramkrishna.me wrote:
 On Thu, Sep 18, 2014 at 3:13 PM, Owen Taylor otay...@redhat.com wrote:
 Would like to push the patches:

  https://bugzilla.gnome.org/show_bug.cgi?id=736719

 The bug they fix is fairly bad misbehavior with non-GTK+ apps, in particular 
 with Qt apps.

 They are pretty straightforward, and basically are reverting back to an 
 earlier version
 of the code and I specifically tested that they also fix the original 
 problem with
 VirtualBox.


 +1 from me, anything that helps play nice with non-gtk+ apps for this
 release will be good from an engagement perspective.


Second +1, with a cautionary note on the dangers of refactoring old
code like this, in particular when it affects interoperability with
other toolkits/wms, and we don't have sufficient automatic testing in
place...
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.