Freeze break request for mutter!486

2019-03-08 Thread Carlos Garnacho
Hi!,

I figured better doing this here than over IRC... In the end several
people agreed at #gnome-shell that
https://gitlab.gnome.org/GNOME/mutter/merge_requests/486 may be a
better fix for the swapped colors regression. Also accounting that
there's been other reported issues around xwayland and drivers without
hw accel.

The MR undoes the revert that was meant to be temporary, and removes
the root of the problem without apparent drawbacks. Sounds good to go?

Cheers,
  Carlos
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break request for mutter!486

2019-03-08 Thread mcatanzaro



+1 / 2

This new fix is more code, which triggers my "risky last-minute commit" 
instincts, but I trust you're proposing it because you think it's safer 
than the originally-accepted solution, in light of the "other reported 
issues."


Michael

___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Freeze break request for mutter!486

2019-03-08 Thread Carlos Garnacho
Hey,

On Fri, Mar 8, 2019 at 5:22 PM  wrote:
>
>
> +1 / 2
>
> This new fix is more code, which triggers my "risky last-minute commit"
> instincts, but I trust you're proposing it because you think it's safer
> than the originally-accepted solution, in light of the "other reported
> issues."

Thanks! that makes 2/2 with Emmanuele's :). The fix itself could have
been more self contained, cleaning up the then pointless
vfunc/argument added up a bit.

The previous fix solved animations/screenshots, but didn't help for
these later problems (running "XWAYLAND_NO_GLAMOR=1 mutter --wayland
--nested" and running a x11 app there should reproduce), this one
fixes both.

Cheers,
  Carlos

>
> Michael
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.