Re: Hard code freeze break request for Nautilus

2013-03-22 Thread Cosimo Cecchi
On Fri, Mar 22, 2013 at 5:29 PM, Matthias Clasen
wrote:

> On Fri, Mar 22, 2013 at 5:03 PM, Frederic Peters 
> wrote:
> >
> > Sure; patch looks fine.
>
> Second approval from me.
>

Thanks, I pushed this to master now.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Hard code freeze break request for Nautilus

2013-03-22 Thread Matthias Clasen
On Fri, Mar 22, 2013 at 5:03 PM, Frederic Peters  wrote:
> Cosimo Cecchi wrote:
>
>> that's not the behavior we want, and it's a bug in Evince that has been
>> outstanding for a couple of years now:
>> https://bugzilla.gnome.org/show_bug.cgi?id=634245
>
> Oh, of course I remember this now :/
>
>
>> I don't think we should have it blocking the Nautilus fix, which is correct
>> IMO.
>
> Sure; patch looks fine.

Second approval from me.
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Hard code freeze break request for Nautilus

2013-03-22 Thread Frederic Peters
Cosimo Cecchi wrote:

> that's not the behavior we want, and it's a bug in Evince that has been
> outstanding for a couple of years now:
> https://bugzilla.gnome.org/show_bug.cgi?id=634245

Oh, of course I remember this now :/


> I don't think we should have it blocking the Nautilus fix, which is correct
> IMO.

Sure; patch looks fine.


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Re: Hard code freeze break request for Nautilus

2013-03-22 Thread Cosimo Cecchi
On Fri, Mar 22, 2013 at 1:20 PM, Frederic Peters  wrote:

> In comment 3 you write the fundamental bug lies in shotwell viewer
> desktop file but such a situation would also happen with evince, am
> I right?
>
> Actually I just tried and changed the default PDF viewer and I have
> no way to get it reset. (clicking on Reset remove the selected choice
> but doesn't set evince back); the only fix was to edit
> ~/.local/share/applications/mimeapps.list.
>
> Is this really the behaviour we want ?
>

Hey Fred

that's not the behavior we want, and it's a bug in Evince that has been
outstanding for a couple of years now:
https://bugzilla.gnome.org/show_bug.cgi?id=634245

I don't think we should have it blocking the Nautilus fix, which is correct
IMO.

Thanks,
Cosimo
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Hard code freeze break request for Nautilus

2013-03-22 Thread Frederic Peters
Cosimo Cecchi wrote:
> Hi,
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=696372 fixes an inconsistency in
> how NoDisplay=true applications are handled by Nautilus; they're currently
> displayed in the Open With context menus when they shouldn't.
> The fix is low risk and doesn't impact any translation or documentation.
> OK to commit for 3.8.0?

In comment 3 you write the fundamental bug lies in shotwell viewer
desktop file but such a situation would also happen with evince, am
I right?

Actually I just tried and changed the default PDF viewer and I have
no way to get it reset. (clicking on Reset remove the selected choice
but doesn't set evince back); the only fix was to edit
~/.local/share/applications/mimeapps.list.

Is this really the behaviour we want ?


Fred
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.


Hard code freeze break request for Nautilus

2013-03-22 Thread Cosimo Cecchi
Hi,

https://bugzilla.gnome.org/show_bug.cgi?id=696372 fixes an inconsistency in
how NoDisplay=true applications are handled by Nautilus; they're currently
displayed in the Open With context menus when they shouldn't.
The fix is low risk and doesn't impact any translation or documentation.
OK to commit for 3.8.0?

Thanks!
Cosimo
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.