Re: Request string break for GNOME Calendar 3.16.x

2015-06-03 Thread Erick Pérez Castellanos
On Jun 3, 2015 2:48 AM, "Alexandre Franke" 
wrote:
>
> Two questions:
> * for the C locale, shouldn't the string be in the order month/date/year?

Done and

> * I see you pushed the patch to the gnome-3-16 branch, but the string
> doesn't appear in master (yet?). Do you plan to push it there too? I
> know master is not frozen, it's just easier for us to be consistent in
> our translations if we do this kind of things in both branches at the
> same time.
>

Done.

Thanks for your suggestions
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Request string break for GNOME Calendar 3.16.x

2015-06-02 Thread Alexandre Franke
On Mon, Jun 1, 2015 at 8:16 PM, Erick Pérez Castellanos
 wrote:
> +  priv->mask = _("%d/%m/%y");

Two questions:
* for the C locale, shouldn't the string be in the order month/date/year?
* I see you pushed the patch to the gnome-3-16 branch, but the string
doesn't appear in master (yet?). Do you plan to push it there too? I
know master is not frozen, it's just easier for us to be consistent in
our translations if we do this kind of things in both branches at the
same time.

-- 
Alexandre Franke
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Request string break for GNOME Calendar 3.16.x

2015-06-01 Thread Daniel Mustieles García
2/2 from i18n.

Cheers!

2015-06-01 20:36 GMT+02:00 Alexandre Franke :

> On Mon, Jun 1, 2015 at 8:16 PM, Erick Pérez Castellanos
>  wrote:
> > Hi:
> >
> > A stated in the bug here [1], Calendar is crashing in some locales. The
> > proposed fix introduces a new string to be translated, which requires me
> to
> > ask for a string break for this branch of calendar.
> >
> > The main reason for asking the break is that Calendar can not change the
> > date of a any event in some locales, and crashes, render the application
> > almost completely useless. This would continue for the entire 3.16.x
> cycle,
> > leaving distro like Fedora 22 using a broken version of Calendar.
>
> It seems important enough and it's just one string which is pretty
> trivial, so here's +1 from i18n. Only one more to go.
>
> > +  /* This string represents day/month/year order for each of the
> differents
> > +   * languages. It could possibly be default value, %m/%d/%y placing the
> > month
> > +   * before, or any ordering according to the translators environment */
> > +  priv->mask = _("%d/%m/%y");
>
> If this comment is aimed only at translators, you may want to start
> the comment with "Translators: …" to make it more obvious to them.
>
> --
> Alexandre Franke
> ___
> gnome-i18n mailing list
> gnome-i...@gnome.org
> https://mail.gnome.org/mailman/listinfo/gnome-i18n
>
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Re: Request string break for GNOME Calendar 3.16.x

2015-06-01 Thread Alexandre Franke
On Mon, Jun 1, 2015 at 8:16 PM, Erick Pérez Castellanos
 wrote:
> Hi:
>
> A stated in the bug here [1], Calendar is crashing in some locales. The
> proposed fix introduces a new string to be translated, which requires me to
> ask for a string break for this branch of calendar.
>
> The main reason for asking the break is that Calendar can not change the
> date of a any event in some locales, and crashes, render the application
> almost completely useless. This would continue for the entire 3.16.x cycle,
> leaving distro like Fedora 22 using a broken version of Calendar.

It seems important enough and it's just one string which is pretty
trivial, so here's +1 from i18n. Only one more to go.

> +  /* This string represents day/month/year order for each of the differents
> +   * languages. It could possibly be default value, %m/%d/%y placing the
> month
> +   * before, or any ordering according to the translators environment */
> +  priv->mask = _("%d/%m/%y");

If this comment is aimed only at translators, you may want to start
the comment with "Translators: …" to make it more obvious to them.

-- 
Alexandre Franke
___
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.