Re: KCalc's Future

2007-12-08 Thread Albert Astals Cid
A Dissabte 08 Desembre 2007, Thomas Zander va escriure:
 On Saturday 08 December 2007 20:00:08 Allen Winter wrote:
  Hi Bernd,
 
  You are listed in kdeutils/AUTHORS as the maintainer for KCalc.
 
  Speaking for the KDE 4 Release Team.. I am wondering what
  your plans are for KCalc in KDE4.   There has been a lot of
  mail going on in kde-core-devel discussing some critical
  issues with KCalc

 There have? Can you provide me with a link since I can't find any such
 mails...
 I tried a full-text search on 'kcalc' in kmail.

  and we haven't heard from you.

 There was one thread on this list which grossly overstated problems (none
 actually exist anymore) for the app, I didn't expect any mails from bernd
 myself.

So you mean typing 3 + 3 Enter and getting a 0 is the expected behaviour?

Albert


 So, either I'm missing various mails, and in effect the reason for your
 mail, or this is based on some misunderstandings.

 In my tests kcalc from svn fits the role of a general purpose desktop
 calculator perfectly. So your mail surprises me, I'm not sure there is a
 strong need for a maintainer. Its got well below the average amount of
 bugs (22)

 *confused*


___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: KCalc's Future

2007-12-08 Thread Thomas Zander
On Saturday 08 December 2007 20:59:48 Albert Astals Cid wrote:
 So you mean typing 3 + 3 Enter and getting a 0 is the expected
 behaviour?

Hi Albert,

thanks for one of your always illuminating emails :)

I think that since we have seen various people try to reproduce it and it 
works correctly for most of them that, sure, there is something to 
investigate. But since you made it really clear you don't want to spent 
time on it, and so far you are one of the only developers actually seeing 
this, I fail to see that being significant in any way for kcalcs standing 
in the release.

-- 
Thomas Zander


pgpsTykAsMmlZ.pgp
Description: PGP signature
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: KCalc's Future

2007-12-08 Thread Albert Astals Cid
A Dissabte 08 Desembre 2007, Christian Ehrlicher va escriure:
 Albert Astals Cid schrieb:
  A Dissabte 08 Desembre 2007, Richard Moore va escriure:
  On 12/8/07, Albert Astals Cid [EMAIL PROTECTED] wrote:
  So you mean typing 3 + 3 Enter and getting a 0 is the expected
  behaviour?
 
  As I said in the previous discussion this works fine here. It only
  seems to be an issue for people on 64 bit machines, and I suspect not
  even all of those. If people would get together info about things like
  which version of gmp they're using, which compiler etc. then maybe we
  could make some progress on this issue.
 
  I know it's weird, actually i'm using exactly the same configuration
  (ubuntu version, installed libraries and cpu model) than John Tapsell and
  it works for him.
 
  I've already volunteered givin remove access to my machine to David
  Johnson so he can try fixing the bug but he said it was not necessary.
 
  For the record:
  gmp version: 4.2.1+dfsg-5ubuntu4
  g++ version: g++-4.1 (GCC) 4.1.3 20070929 (prerelease) (Ubuntu
  4.1.2-16ubuntu2)
  machine: AMD Athlon(tm) 64 X2 Dual Core Processor 4200+

 OpenSuSE 10.3 64bit, gcc 4.2.1

 The attached patch fixes the problem (better: avoids the problem).
 After this 3+3 is 6 again on my system. It was ever, but displaying did
 not work correct.

Works here :-)

Albert



 Christian


___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: KCalc's Future

2007-12-08 Thread Andreas Pakulat
On 08.12.07 23:12:16, Christian Ehrlicher wrote:
 _knumfloat::_knumfloat(QString const  num)
 {
   mpf_init(_mpf);
   mpf_set_str(_mpf, num.toAscii(), 10);
 }
 
 I already tried to pass 10,0 without success. Don't know if nan and
 inf is correctly interpreted.

Does gmp create a deep copy of the char*? If not that might be the
reason, toAscii() returns a QByteArray and that will be implicitly
converted to char*. However that returns the QByteArray internal buffer
and thus its gone after the call to mpf_set_str. So either gmp needs to
do a deep copy in set_str or you need to keep the QByteArray around
until its not needed anymore.

Andreas

-- 
Your boss is a few sandwiches short of a picnic.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: KCalc's Future

2007-12-08 Thread Christian Ehrlicher
Andreas Pakulat schrieb:
 On 08.12.07 23:12:16, Christian Ehrlicher wrote:
 _knumfloat::_knumfloat(QString const  num)
 {
   mpf_init(_mpf);
   mpf_set_str(_mpf, num.toAscii(), 10);
 }

 I already tried to pass 10,0 without success. Don't know if nan and
 inf is correctly interpreted.
 
 Does gmp create a deep copy of the char*? If not that might be the
 reason, toAscii() returns a QByteArray and that will be implicitly
 converted to char*. However that returns the QByteArray internal buffer
 and thus its gone after the call to mpf_set_str. So either gmp needs to
 do a deep copy in set_str or you need to keep the QByteArray around
 until its not needed anymore.
 
I hope you're wrong - I would consider this as a design bug in gmp
otherwise :)


Christian
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team