Re: Re: Fwd: Plasma Framework problems

2014-10-12 Thread Martin Gräßlin
On Sunday 12 October 2014 20:48:36 David Edmundson wrote:
> On 12 Oct 2014 18:04, "šumski"  wrote:
> > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote:
> > > > I'll report back when I've confirmed this and then we can work out
> 
> how we
> 
> > > > proceed.
> > > > 
> > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make
> > > 
> > > everything work.
> > > 
> > > Assuming we don't have a time machine our options are:
> > >  - revert this commit and release plasma-framework 5.3.1 really quickly
> > 
> > Please go with this option...

How will this affect Plasma 5.1? Given the review it looks like it was moved 
into workspace - is it a problem to have the code twice?

Anyway if you revert, please deprecate the code, add a TODO KF6 and a comment 
on why it cannot be removed. I find it kind of scary that a change in the 
private implementation detail breaks the released software.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-12 Thread Martin Gräßlin
On Friday 10 October 2014 17:37:02 Rolf Eike Beer wrote:
> Am Freitag, 10. Oktober 2014, 17:14:41 schrieb Martin Graesslin:
> > Hi all,
> > 
> > unfortunately we have an embarrassing bug [1] in KWindowSystem 5.3.0
> > which can crash any application making use of KWindowSystem on the X11
> > Platform. This is fixed with commit [2]. I recommend to either do a 5.3.1
> > release for KWindowSystem with just that commit added or at least that
> > distros ship the patch in their packages.
> > 
> > Sorry about that. I still don't understand how it could pass through the
> > CI
> > system without failing.
> > 
> > Cheers
> > Martin
> > 
> > [1] Apparently I'm not able to count to four, see BUG 339771
> 
> Why not make the static array static in the file instead of the functions
> and then simply do "netAtomCount = sizeof(array)/sizeof(array[0]) - 1;"?
> That way you never have to count again ;)

My intention was to fix the regression first in the most obvious way that I'm 
only fixing the regression. A change to make the code better should only go 
into 5.4 IMHO.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: CHANGELOG keyword

2014-10-12 Thread Michael Pyne
On Sun, October 12, 2014 00:30:43 Albert Astals Cid wrote:
> > once after CHANGELOG:
> I'm not against an empty CHANGELOG: meaning the tool has to use the title,
> but i'd still want to have the possibility to have a separate line, my
> titles are usually "more geeky" and I would not want them in a public
> consumption changelog so i'd have to craft something more user-friendly in
> the CHANGELOG: entry.
> 
> What do others think?

I think allowing CHANGELOG: to have a more descriptive title, while falling 
back to the commit title if CHANGELOG: is left blank, makes perfect sense and 
is a good idea.

Regards,
 - Michael Pyne
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Fwd: Plasma Framework problems

2014-10-12 Thread David Edmundson
On 12 Oct 2014 18:04, "šumski"  wrote:
>
> On Sunday 12 of October 2014 11:58:44 David Edmundson wrote:
> > > I'll report back when I've confirmed this and then we can work out
how we
> > > proceed.
> > >
> > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make
> >
> > everything work.
> >
> > Assuming we don't have a time machine our options are:
> >  - revert this commit and release plasma-framework 5.3.1 really quickly
> Please go with this option...

I need approval from Marco and other David.

David
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Fwd: Plasma Framework problems

2014-10-12 Thread šumski
On Sunday 12 of October 2014 11:58:44 David Edmundson wrote:
> > I'll report back when I've confirmed this and then we can work out how we
> > proceed.
> > 
> > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make
> 
> everything work.
> 
> Assuming we don't have a time machine our options are:
>  - revert this commit and release plasma-framework 5.3.1 really quickly
Please go with this option...

>  - communicate the breakage. Plasma 5.1 is out soon anyway
IMO it is not at all relevant when release of one of p-f's consumers would be 
- unless you really want to move it to Workspace umbrella.


Cheers,
Hrvoje


signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Packagers: Qt 5.4 backport

2014-10-12 Thread David Faure
Packagers,

For the Qt/KDE file dialogs to work with remote URLs, you might want to 
backport this fix to your Qt 5.3 packages:

http://www.davidfaure.fr/2014/1a9701fe81c39450822c0d4b51c11444380a2fe4.diff

This fix is in Qt 5.4 alpha1 but not in Qt 5.3 or earlier.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-12 Thread David Faure
On Sunday 12 October 2014 15:29:37 Albert Astals Cid wrote:
> El Dissabte, 11 d'octubre de 2014, a les 10:53:14, David Faure va escriure:
> > On Friday 10 October 2014 23:03:26 Nicolás Alvarez wrote:
> > > 2014-10-10 19:47 GMT-03:00 David Faure :
> > > > On Friday 10 October 2014 17:14:41 Martin Graesslin wrote:
> > > >> I recommend to either do a 5.3.1
> > > >> release for KWindowSystem with just that commit added
> > > > 
> > > > Done.
> > > > 
> > > > kwindowsystem v5.3.1
> > > > 49f34827a0cbd46320149c7b835abd8431287083
> > > > 80765c897128907307558dbe28d914a31186ff7fd479b6c262a2704a979e20b9
> > > > sources/kwindowsystem-5.3.1.tar.xz
> > > > 
> > > > Uploaded to ~/stable/frameworks/5.3.0/ (I could make a 5.3.1
> > > > directory,
> > > > but it would be a bit lonely in there, I mean one would wonder where
> > > > other frameworks are in that 5.3.1 subdir...)
> > > 
> > > Which makes me wonder if the directory should have been called 5.3
> > > instead :) Of course it's too late now...
> > 
> > Yeah me too.
> > The question is whether we'll ever do a x.y.1 release of "everything".
> > Hmm, I guess not, if that's for hotfixes only.
> > 
> > OK I'll use x.y as the directory name in the future then, unless someone
> > objects.
> 
> Shall we add this whoopsie to the "This is a list of grave bugs and common
> pitfalls surfacing after the release was packaged:" of
> https://www.kde.org/info/kde-frameworks-5.3.0.php ?

Done, thanks for reminding me. I'll add it to the procedure for patchlevel 
releases so I won't forget again.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-12 Thread Albert Astals Cid
El Dissabte, 11 d'octubre de 2014, a les 10:53:14, David Faure va escriure:
> On Friday 10 October 2014 23:03:26 Nicolás Alvarez wrote:
> > 2014-10-10 19:47 GMT-03:00 David Faure :
> > > On Friday 10 October 2014 17:14:41 Martin Graesslin wrote:
> > >> I recommend to either do a 5.3.1
> > >> release for KWindowSystem with just that commit added
> > > 
> > > Done.
> > > 
> > > kwindowsystem v5.3.1
> > > 49f34827a0cbd46320149c7b835abd8431287083
> > > 80765c897128907307558dbe28d914a31186ff7fd479b6c262a2704a979e20b9
> > > sources/kwindowsystem-5.3.1.tar.xz
> > > 
> > > Uploaded to ~/stable/frameworks/5.3.0/ (I could make a 5.3.1 directory,
> > > but it would be a bit lonely in there, I mean one would wonder where
> > > other frameworks are in that 5.3.1 subdir...)
> > 
> > Which makes me wonder if the directory should have been called 5.3
> > instead :) Of course it's too late now...
> 
> Yeah me too.
> The question is whether we'll ever do a x.y.1 release of "everything".
> Hmm, I guess not, if that's for hotfixes only.
> 
> OK I'll use x.y as the directory name in the future then, unless someone
> objects.

Shall we add this whoopsie to the "This is a list of grave bugs and common 
pitfalls surfacing after the release was packaged:" of
https://www.kde.org/info/kde-frameworks-5.3.0.php ?

Cheers,
  Albert
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Fwd: Plasma Framework problems

2014-10-12 Thread David Edmundson
>
>
> I'll report back when I've confirmed this and then we can work out how we
> proceed.
>
> Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make
everything work.

Assuming we don't have a time machine our options are:
 - revert this commit and release plasma-framework 5.3.1 really quickly
 - communicate the breakage. Plasma 5.1 is out soon anyway
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: CMake dependency data now available

2014-10-12 Thread Ben Cooksley
On Sun, Oct 12, 2014 at 9:57 PM, Rolf Eike Beer
 wrote:
> Am Sonntag 12 Oktober 2014, 21:24:51 schrieb Ben Cooksley:
>> Hi all,
>>
>> Not too long ago, sysadmin received a request to have the tool
>> "cmake-dependencies.py" from kde-dev-tools run by the CI system to
>> make packagers jobs easier.
>
> […]
>
>> If anyone has any queries, please let me know.
>
> This is a flat view on the dependencies AFAICT. In other words, you can't tell
> if this is a direct dependency or a "dependency [of a dependency]+", so this
> should not be used directly for a Depends: line IMHO. I was just looking at
> KGpg (what else *g*), and there show up things like Phonon, Cygwin and Perl
> that KGpg does not care in any way about, these things are just dragged in by
> something else.

As far as I am aware, this is correct. I didn't write the script which
generates this data though, so the author of it is probably the best
one to comment on that here.

>
> It's no problem that these things show up if you use this information as "what
> do I need to install to be sure that KGpg builds", but please don't use this
> as "these are the things that KGpg must directly depend on when installed".
>
> Btw, is this line for Perl correct?
>
> {"files": ["FindPerl.cmake"], "version": "5.16.2()", "project": 
> "Perl"},
>
> There are both "null" and "()" as version information for some packages, I
> guess they both mean "no specific version requested"? Should those be merged
> into the same value?

I'm afraid you'd need to ask the script author about that.

>
> Eike

Thanks,
Ben
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: CMake dependency data now available

2014-10-12 Thread Rolf Eike Beer
Am Sonntag 12 Oktober 2014, 21:24:51 schrieb Ben Cooksley:
> Hi all,
> 
> Not too long ago, sysadmin received a request to have the tool
> "cmake-dependencies.py" from kde-dev-tools run by the CI system to
> make packagers jobs easier.

[…]

> If anyone has any queries, please let me know.

This is a flat view on the dependencies AFAICT. In other words, you can't tell 
if this is a direct dependency or a "dependency [of a dependency]+", so this 
should not be used directly for a Depends: line IMHO. I was just looking at 
KGpg (what else *g*), and there show up things like Phonon, Cygwin and Perl 
that KGpg does not care in any way about, these things are just dragged in by 
something else.

It's no problem that these things show up if you use this information as "what 
do I need to install to be sure that KGpg builds", but please don't use this 
as "these are the things that KGpg must directly depend on when installed".

Btw, is this line for Perl correct?

{"files": ["FindPerl.cmake"], "version": "5.16.2()", "project": "Perl"},

There are both "null" and "()" as version information for some packages, I 
guess they both mean "no specific version requested"? Should those be merged 
into the same value?

Eike

signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: kde-gtk-config

2014-10-12 Thread Jonathan Riddell
On Sun, Oct 12, 2014 at 05:51:16AM +1100, Michael Palimaka wrote:
> >> Is this still valid? kde-gtk-config 5.1.0 has appeared too.
> > 
> > Not sure where you got that from, as there is no kde-gtk-config 5.1.0 on 
> > depot.
> 
> I didn't notice that, just saw it on starsky and got confused.

sorry about that I changed the release scripts to delete it but I
guess it made it to the half way stage, just ignore.

Jonathan
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


CMake dependency data now available

2014-10-12 Thread Ben Cooksley
Hi all,

Not too long ago, sysadmin received a request to have the tool
"cmake-dependencies.py" from kde-dev-tools run by the CI system to
make packagers jobs easier.

This has now been done. You can download a tarball of this
information, regenerated once a day, from
http://build.kde.org/userContent/dependency-metadata.tar.xz

Files in this file are named following this convention:
-.json.

For those unfamiliar with branch groups:
- kf5-qt5 represents anything based on Qt 5 and Frameworks 5.
- latest-qt4 represents the most current development for Qt 4.
- stable-qt4 represents the current stable development for Qt 4.

If anyone has any queries, please let me know.

Thanks,
Ben Cooksley
KDE Sysadmin
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team