Re: Review Request 111949: Backup ResourceListGenerator: Do not only count files with tags
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111949/#review37447 --- Ship it! again, not super-familiar with this code, but for what my opinion is worth, it looks good. - Simeon Bird On Aug. 8, 2013, 7:04 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111949/ > --- > > (Updated Aug. 8, 2013, 7:04 p.m.) > > > Review request for Nepomuk and Release Team. > > > Description > --- > > Only files with tags used to be backed up. If a file had only a rating > or a comment then its information would not be backed up. > > > Diffs > - > > autotests/test/backuptests.cpp 7284dd6 > services/storage/backup/resourcelistgenerator.cpp 059bfa7 > > Diff: http://git.reviewboard.kde.org/r/111949/diff/ > > > Testing > --- > > Tested by manually backing up a number of times. > > > Thanks, > > Vishesh Handa > > ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request 111947: Backup Statement Generator: statements without a datatype can be valid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111947/#review37446 --- Ship it! While I am not very familiar with this exact code, it is true that comments don't get backed up without it. The patch looks fine and I can't think of any side-effects. - Simeon Bird On Aug. 8, 2013, 7:05 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111947/ > --- > > (Updated Aug. 8, 2013, 7:05 p.m.) > > > Review request for Nepomuk and Release Team. > > > Description > --- > > Backup Statement Generator: statements without a datatype can be valid > > In Nepomuk the nao:description is stored as an rdfs literal, which means > it doesn't have a datatype, but is supposed to have a language tag. > Since we don't store the language tag, it is just stored as a string. > This used to be considered invalid by the statement generator and > therefore the nao:description (dolphin comments) was never backed up > even though it was requested. > > BUG: 323260 > > It's important to get this into 4.11 otherwise everyone will loose their > comments on installing 4.11 as the migration is done through backup. > > > This addresses bug 323260. > http://bugs.kde.org/show_bug.cgi?id=323260 > > > Diffs > - > > services/storage/backup/statementgenerator.cpp c3b5985 > autotests/test/backuptests.cpp 7284dd6 > > Diff: http://git.reviewboard.kde.org/r/111947/diff/ > > > Testing > --- > > Tested by manually backing up a number of times. > > > Thanks, > > Vishesh Handa > > ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: nepomuk-core KDE/4.10 branch mismerged
If it helps, the last good commit I have in my local clone is aafe2cbc4945d02182dd4055e3e38742a31fecf8, but there might have been some since then. Simeon On 3 May 2013 12:38, Vishesh Handa wrote: > > > > On Fri, May 3, 2013 at 9:27 PM, Torgny Nyblom wrote: >> >> On Friday 03 May 2013 20.51.58 Vishesh Handa wrote: >> > On Fri, May 3, 2013 at 8:26 PM, Torgny Nyblom wrote: >> > > On Friday 03 May 2013 20.26.58 Ben Cooksley wrote: >> > > > Hi all, >> > > > >> > > > Just a quick notice that due to a bad merge made into the KDE/4.10 >> > > > branch of nepomuk-core i've temporarily suspended the ability to >> > > > push >> > > > into this repository. >> > > > >> > > > This also means that we cannot release anything from KDE/4.10 for >> > > > now >> > > > until this is fixed. >> > > > >> > > > @Vishesh/Simeon: Can you please let me know what is the last good >> > > > commit, and the last bad commit so I can force rewind the branch and >> > > > blacklist the bad commit (to prevent it from being re-entered into >> > > > the >> > > > repository). >> > > >> > > Could this please be made available to the sysadmins asap? The 4.10.3 >> > > release >> > > is done except nepomuk-core due to this. >> > >> > I'm slightly confused right now and I'm trying to make sense of this, >> > but >> > if you guys want you can not release nepomuk-core 4.10.3 or just >> > re-release >> > the 4.10.2 version. There are some bug fixes but nothing that important. >> >> I'll wait another day or so but after that we need to release even if that >> means reusing the 4.10.2 tag. > > > We looked into the issue a little and it seems that a commit right after > 4.10.2 was tagged broke it. I think. Again, the history has gotten quite > muddled so I'm not sure. > > If you want you can release it right now, and not wait for another day. I'm > not sure how much I'll get done today. I have some other stuff I need to > take care of as well, and the bugs that were fixed were very minor. > > If there is some git expert over here, could you please look into the issue? > I think this is the offending commit > ad65c0c9a83de3b91dba3445e3c07ab0cb3807c1. You can check if any commits from > master are there if you can see the nepomuk-core/tools folder exists. > >> >> Thanks for looking into the issue. >> >> /Regards >> Torgny > > > > > -- > Vishesh Handa ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Nepomuk-core 4.10.2 needs a respin
> As requested nepomuk-core has been respun. > sha256: 527be7fac81f7dc03af42671d94e559dedd6d0f0fdf0a578c598bcc894caff97 > hash: 3b64b5ac2372b216a25ca41d74b35b2e7bc59f1c > /Regards > Torgny Thanks very much. Simeon ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Nepomuk-core 4.10.2 needs a respin
Hi, Sorry about this - it seems that the last committed fix for nepomuk-core caused problems with kmail: see https://bugs.kde.org/show_bug.cgi?id=317569 . I have reverted the commit, at least until we figure out what is going on, as it is not strictly necessary (there were two possible fixes for bug 305024, so we applied both, but the other one is sufficient). Could you please respin the nepomuk-core v4.10.2 tarball from commit 3b64b5ac2372b216a25ca41d74b35b2e7bc59f1c ? Apologies again, Simeon ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
