Re: Bringing ebn krazy back

2008-01-07 Thread Allen Winter
On Saturday 05 January 2008 20:57:52 Allen Winter wrote:
> On Saturday 05 January 2008 08:14:03 Urs Wolfer wrote:
> > I think it's now time again to enable all krazy checks for trunk.
> >
> > Bye
> > urs
>
> I will do so.  But first I need to add 4.1 apidox to api.kde.org.
>
> Should I enable all Krazy checks in extragear, playground, kdereview
> and koffice too?
>
OK, full-krazyness should run tonight in all supported components, including:
trunk, koffice, extragear, playground, kdereview.

krazy is no longer run at all in the 4.0 branch.

report problems to me.

-Allen

___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2008-01-06 Thread Allen Winter
On Sunday 06 January 2008 16:27:17 Matt Rogers wrote:
> On Jan 6, 2008, at 2:05 PM, Boudewijn Rempt wrote:
> > On Sunday 06 January 2008, Allen Winter wrote:
> >> On Saturday 05 January 2008 08:14:03 Urs Wolfer wrote:
> >>> I think it's now time again to enable all krazy checks for trunk.
> >>>
> >>> Bye
> >>> urs
> >>
> >> I will do so.  But first I need to add 4.1 apidox to api.kde.org.
> >>
> >> Should I enable all Krazy checks in extragear, playground, kdereview
> >> and koffice too?
> >
> > For KOffice, yes, please. Now, what would be really cool would be
> > krazy-kdevelop integration so I could easily fix those issues just by
> > pressing F4 and fixing the code
>
> Noted. Thanks for the suggestion

Mirko asked for something similar a while back.

krazy2 has an option --export=texedit that might come in handy.
Never used it myself.

___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2008-01-06 Thread Matt Rogers
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On Jan 6, 2008, at 2:05 PM, Boudewijn Rempt wrote:

> On Sunday 06 January 2008, Allen Winter wrote:
>> On Saturday 05 January 2008 08:14:03 Urs Wolfer wrote:
>>> I think it's now time again to enable all krazy checks for trunk.
>>>
>>> Bye
>>> urs
>>
>> I will do so.  But first I need to add 4.1 apidox to api.kde.org.
>>
>> Should I enable all Krazy checks in extragear, playground, kdereview
>> and koffice too?
>
> For KOffice, yes, please. Now, what would be really cool would be
> krazy-kdevelop integration so I could easily fix those issues just by
> pressing F4 and fixing the code

Noted. Thanks for the suggestion
- --
Matt


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFHgUe1A6Vv5rghv0cRAsBUAKC3HePNJ7tnODfzLg335VwLz5jJLACfS5eB
HFhB6TkPh/yKukt7Fd7m+iQ=
=hskw
-END PGP SIGNATURE-
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2008-01-06 Thread Boudewijn Rempt
On Sunday 06 January 2008, Allen Winter wrote:
> On Saturday 05 January 2008 08:14:03 Urs Wolfer wrote:
> > I think it's now time again to enable all krazy checks for trunk.
> >
> > Bye
> > urs
>
> I will do so.  But first I need to add 4.1 apidox to api.kde.org.
>
> Should I enable all Krazy checks in extragear, playground, kdereview
> and koffice too?

For KOffice, yes, please. Now, what would be really cool would be 
krazy-kdevelop integration so I could easily fix those issues just by 
pressing F4 and fixing the code
-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2008-01-05 Thread Allen Winter
On Saturday 05 January 2008 08:14:03 Urs Wolfer wrote:
> I think it's now time again to enable all krazy checks for trunk.
>
> Bye
> urs

I will do so.  But first I need to add 4.1 apidox to api.kde.org.

Should I enable all Krazy checks in extragear, playground, kdereview
and koffice too?

___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2008-01-05 Thread Matt Rogers
On Jan 5, 2008, at 7:14 AM, Urs Wolfer wrote:

> I think it's now time again to enable all krazy checks for trunk.
>
> Bye
> urs

Agreed. Now that trunk is open again for all commits, let's go ahead  
and reenable those checks.
--
Matt

___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2008-01-05 Thread Urs Wolfer
I think it's now time again to enable all krazy checks for trunk.

Bye
urs


signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-21 Thread David Faure
On Tuesday 20 November 2007, Dirk Mueller wrote:
> i18ncheckarg: Check validity of i18n calls

This one should probably be enabled, i18n misuse triggers real bugs.
The rest is more cosmetic indeed.

-- 
David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-20 Thread Dirk Mueller
On Friday 16 November 2007, Allen Winter wrote:

> captruefalse: Check for TRUE and FALSE macros
> contractions: Check for contractions in strings
> cpp: Check for cpp macros and usage
> doublequote_chars: Check for single char QStrings better written as a QChar
> emptystrcompare: Check for QString compares to ""
> endswithnewline: Check that file ends with a newline
> explicit: Check for C++ ctors that should be declared 'explicit'
> i18ncheckarg: Check validity of i18n calls
> includes: Check for proper include directives
> inline: Check for inline methods in public classes
> nullstrassign: Check for assignments to QString::null
> nullstrcompare: Check for compares to QString::null
> passbyvalue: Check for inappropriate pass-by-value function args
> qminmax: Check for QMIN and QMAX macros
> qobject: Check for classes that should use the 'Q_OBJECT' macro
> sigsandslots: Check for signals: and slots:
> spelling: Check for spelling errors

I think these should be disabled for now. The rest is fine. 

Greetings,
Dirk
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-18 Thread Matt Rogers
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On Nov 16, 2007, at 11:14 AM, Allen Winter wrote:

> On Monday 12 November 2007 07:51:41 Dirk Mueller wrote:
>> On Sunday 11 November 2007, Albert Astals Cid wrote:
>>
>>> Can we have it back already?
>>
>> I`m not opposed to re-enabling it, as long as the number of checks  
>> that are
>> enabled are important to us (e.g. the licensing check). I do not  
>> want another
>> round of FALSE/TRUE renames and other sort of stuff hitting trunk  
>> right now.
>>
> Enclosed is a list of all the checkers.  Please let me know which  
> ones I should
> exclude from the runs.  I can easily exclude the checks we don't  
> want right now.
>
> ==>Checks for C/C++ source code<==
> captruefalse: Check for TRUE and FALSE macros
> constref: Check for methods that return 'const' refs in public classes
> contractions: Check for contractions in strings
> copyright: Check for an acceptable copyright
> cpp: Check for cpp macros and usage
> doublequote_chars: Check for single char QStrings better written as  
> a QChar
> dpointer: Check public classes with private members or d-pointer  
> issues
> emptystrcompare: Check for QString compares to ""
> endswithnewline: Check that file ends with a newline
> explicit: Check for C++ ctors that should be declared 'explicit'
> i18ncheckarg: Check validity of i18n calls
> includes: Check for proper include directives
> inline: Check for inline methods in public classes
> license: Check for an acceptable license
> nullstrassign: Check for assignments to QString::null
> nullstrcompare: Check for compares to QString::null
> passbyvalue: Check for inappropriate pass-by-value function args
> qclasses: Check for Qt classes that should not be used
> qconnect: Check for invalid SIGNALs and SLOTs passed to connect()
> qminmax: Check for QMIN and QMAX macros
> qobject: Check for classes that should use the 'Q_OBJECT' macro
> sigsandslots: Check for signals: and slots:
> spelling: Check for spelling errors
>

can't decide which of these checks should be turned back on. I think  
we should turn on the ones that correlate to the checks i mention  
below and also enable copyright and license as well.


> ==>Checks for Freedesktop.org desktop files<==
> contractions: Check for contractions in strings
> endswithnewline: Check that file ends with a newline
> spelling: Check for spelling errors
> validate: Validates desktop files using 'desktop-file-validate'

I think all the .desktop file checks can be turned back on.

> ==>Checks for Qt Designer files<==
> contractions: Check for contractions in strings
> endswithnewline: Check that file ends with a newline
> fixuifiles: Check for files that need to be fixed by 'fixuifiles'
> i18ncheckarg: Check validity of i18n calls
> spelling: Check for spelling errors

Same for these

>
> ==>Checks for KConfigXT XML files<==
> contractions: Check for contractions in strings
> endswithnewline: Check that file ends with a newline
> i18ncheckarg: Check validity of i18n calls
> spelling: Check for spelling errors

Here too.
- --
Matt


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFHQFGMA6Vv5rghv0cRAnHKAJ9gapqrDbm1NFSGjnSeFJU9JsnB9QCgnNar
0eFlDtxdJYspekZFfSdH0Ik=
=SlHS
-END PGP SIGNATURE-
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-16 Thread Allen Winter
On Monday 12 November 2007 07:51:41 Dirk Mueller wrote:
> On Sunday 11 November 2007, Albert Astals Cid wrote:
> 
> > Can we have it back already?
> 
> I`m not opposed to re-enabling it, as long as the number of checks that are 
> enabled are important to us (e.g. the licensing check). I do not want another 
> round of FALSE/TRUE renames and other sort of stuff hitting trunk right now. 
> 
Enclosed is a list of all the checkers.  Please let me know which ones I should
exclude from the runs.  I can easily exclude the checks we don't want right now.

==>Checks for C/C++ source code<==
captruefalse: Check for TRUE and FALSE macros
constref: Check for methods that return 'const' refs in public classes
contractions: Check for contractions in strings
copyright: Check for an acceptable copyright
cpp: Check for cpp macros and usage
doublequote_chars: Check for single char QStrings better written as a QChar
dpointer: Check public classes with private members or d-pointer issues
emptystrcompare: Check for QString compares to ""
endswithnewline: Check that file ends with a newline
explicit: Check for C++ ctors that should be declared 'explicit'
i18ncheckarg: Check validity of i18n calls
includes: Check for proper include directives
inline: Check for inline methods in public classes
license: Check for an acceptable license
nullstrassign: Check for assignments to QString::null
nullstrcompare: Check for compares to QString::null
passbyvalue: Check for inappropriate pass-by-value function args
qclasses: Check for Qt classes that should not be used
qconnect: Check for invalid SIGNALs and SLOTs passed to connect()
qminmax: Check for QMIN and QMAX macros
qobject: Check for classes that should use the 'Q_OBJECT' macro
sigsandslots: Check for signals: and slots:
spelling: Check for spelling errors

==>Checks for Freedesktop.org desktop files<==
contractions: Check for contractions in strings
endswithnewline: Check that file ends with a newline
spelling: Check for spelling errors
validate: Validates desktop files using 'desktop-file-validate'

==>Checks for Qt Designer files<==
contractions: Check for contractions in strings
endswithnewline: Check that file ends with a newline
fixuifiles: Check for files that need to be fixed by 'fixuifiles'
i18ncheckarg: Check validity of i18n calls
spelling: Check for spelling errors

==>Checks for KConfigXT XML files<==
contractions: Check for contractions in strings
endswithnewline: Check that file ends with a newline
i18ncheckarg: Check validity of i18n calls
spelling: Check for spelling errors
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-12 Thread Albert Astals Cid
A Dilluns 12 Novembre 2007, Matt Rogers va escriure:
> On Nov 11, 2007, at 1:40 PM, Albert Astals Cid wrote:
> > Can we have it back already?
> >
> > Please?
> >
> > Albert
>
> Please justify why you need it. 

Because it's useful, that's a reason by itself, if you want particular 
examples "I want to check i don't use any of the difficult to translate words 
(like Default, File, etc) without context".

> If you're running out of things to 
> work on, there are plenty of bugs in trunk. :)

Yes, but i first want to polish my apps before going to apps i don't use/know.

Albert
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-12 Thread Dirk Mueller
On Sunday 11 November 2007, Albert Astals Cid wrote:

> Can we have it back already?

I`m not opposed to re-enabling it, as long as the number of checks that are 
enabled are important to us (e.g. the licensing check). I do not want another 
round of FALSE/TRUE renames and other sort of stuff hitting trunk right now. 

BTW, I`m not sure if I`m allowed to leak it yet, but Tom Albers has made a 
licensing webpage, which is pretty nice: 

http://toma.kovoks.nl/kde

I like it and it is much better than the EBN views (at least what I saw last 
time of it). 


Greetings,
Dirk
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Bringing ebn krazy back

2007-11-11 Thread Matt Rogers
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On Nov 11, 2007, at 1:40 PM, Albert Astals Cid wrote:

> Can we have it back already?
>
> Please?
>
> Albert

Please justify why you need it. If you're running out of things to  
work on, there are plenty of bugs in trunk. :)
- --
Matt


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (Darwin)

iD8DBQFHN9g3A6Vv5rghv0cRArZ6AJ9GlaZy1TgfIcePMDYQ4+ACIP0pMACgquzw
OS34mRfAzTvkbhPtkD4Mw7w=
=PU4k
-END PGP SIGNATURE-
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Bringing ebn krazy back

2007-11-11 Thread Albert Astals Cid
Can we have it back already? 

Please?

Albert
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team