Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Saturday, May 14, 2016 12:11:21 AM CEST Luca Giambonini wrote: > In data lunedì, 9 maggio 2016 14:28:16 CEST, laurent Montel ha scritto: > > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > > > > Howdy, > > > > > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > > > the blowfish backend in kwallet broke things. > > > > > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > > > > > A patch can be found attached to that bug, or you can get commit > > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > > > > > There may be more trouble afoot as we debugged a problem in neon today > > > that turned out to be probably caused by > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > > > https://bugs.kde.org/show_bug.cgi?id=362842 > > > > Same for me It was necessary to revert to > > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > Even with last master it doesn't work. > > For me it will better to revert to > > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > and release it until we understand why it's broken with this 2 last > > patchs. > > > > Regards > > > > > HS > > Hi, > the official relese is tomorrow, do we have a proper solution to handle this > issue? From Anke's mail seems that it works by reverting to the old verison > from 5.21 (commit: 0d56c68d7a2204a987a5255096d004d5a696c0e5) > there will be a new package online? It is already there, as I said on Tuesday. -rw-r--r-- 1 ftpadmin ftpadmin24 May 10 07:33 kwallet-5.22.0.tar.xz -rw-r--r-- 1 ftpadmin ftpadmin859110 May 10 07:33 kwallet-5.22.0.zip kwallet v5.22.0-rc2 a581cb8bd390d88d27e2388fad43c1dc0092266d 68a0415364235d38cb58d19accfba5a6e384b269fbb88d3caf3cb6f9c29d40c4 sources/ kwallet-5.22.0.tar.xz This is rc2, with the "fixes" (reverts). Am I missing something? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Sat, May 14, 2016 00:11:21 Luca Giambonini wrote:
> In data lunedì, 9 maggio 2016 14:28:16 CEST, laurent Montel ha scritto:
> > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit :
> > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote:
> > > > Howdy,
> > > >
> > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for
> > > > the blowfish backend in kwallet broke things.
> > > >
> > > > See https://bugs.kde.org/show_bug.cgi?id=362805
> > > >
> > > > A patch can be found attached to that bug, or you can get commit
> > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo.
> > >
> > > There may be more trouble afoot as we debugged a problem in neon today
> > > that turned out to be probably caused by
> > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling
> > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527
> > >
> > > https://bugs.kde.org/show_bug.cgi?id=362842
> >
> > Same for me It was necessary to revert to
> > 15e6febac44810b1ee640ffd73cd3ef7d6360527
> >
> > Even with last master it doesn't work.
> > For me it will better to revert to
> > 15e6febac44810b1ee640ffd73cd3ef7d6360527
> > and release it until we understand why it's broken with this 2 last
> > patchs.
> >
> > Regards
> >
> > > HS
>
> Hi,
> the official relese is tomorrow, do we have a proper solution to handle this
> issue? From Anke's mail seems that it works by reverting to the old verison
> from 5.21 (commit: 0d56c68d7a2204a987a5255096d004d5a696c0e5)
> there will be a new package online?
The new package should already be there according to dfaure's email from
Tuesday:
> Done, with current master (0d56c68d7), as discussed in the Hotfix thread.
>
> New version and tarball info:
>
> kwallet v5.22.0-rc2
> a581cb8bd390d88d27e2388fad43c1dc0092266d
> 68a0415364235d38cb58d19accfba5a6e384b269fbb88d3caf3cb6f9c29d40c4
> sources/kwallet-5.22.0.tar.xz
With that said, I have generated some autotests to verify the Blowfish
functionality against the Blowfish official test vectors. The "broken" code in
0d56c68d7 is actually unintentionally correct (the "shuffle" calls must be
included in little-endian mode but not while in big-endian mode apparently --
though I've only tested on a little-endian machine!). I had sent the autotests
to this list while the KDE mail servers were down -- apparently my sender did
not re-send.
If anyone would like to verify the autotests I have attached them here,
otherwise I'll open an RR for after the 5.22.0 release. Either way I will wait
until after master becomes 5.23 to commit, but may be useful for packagers'
testing.
Regards,
- Michael Pynediff --git a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt
index ef921ee..b06ce47 100644
--- a/autotests/CMakeLists.txt
+++ b/autotests/CMakeLists.txt
@@ -1,2 +1,18 @@
+include(ECMAddTests)
+
+find_package(Qt5Test ${REQUIRED_QT_VERSION} CONFIG QUIET)
+
+if(NOT Qt5Test_FOUND)
+message(STATUS "Qt5Test not found, autotests will not be built.")
+return()
+endif()
+
+ecm_add_tests(
+blowfishtest.cpp
+LINK_LIBRARIES Qt5::Test kwalletbackend5
+)
+
+target_include_directories(blowfishtest PRIVATE ${CMAKE_SOURCE_DIR}/src/runtime/kwalletd
+${CMAKE_BINARY_DIR}/src/runtime/kwalletd/backend)
add_subdirectory(KWallet)
diff --git a/autotests/blowfishtest.cpp b/autotests/blowfishtest.cpp
index e69de29..f37a8d0 100644
--- a/autotests/blowfishtest.cpp
+++ b/autotests/blowfishtest.cpp
@@ -0,0 +1,186 @@
+/* This file is part of the KDE libraries
+ * Copyright (c) 2016 Michael Pyne
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License version 2 as published by the Free Software Foundation.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "backend/blowfish.h"
+
+#include
+#include
+#include
+
+#include
+
+class TestBlowfish : public QObject
+{
+Q_OBJECT
+private Q_SLOTS:
+void testBlowfishCipher();
+};
+
+// Source for test vectors: https://www.schneier.com/code/vectors.txt
+static const char *const keys[] = {
+"",
+"",
+"3000",
+"",
+"0123456789ABCDEF",
+"",
+"",
+"FEDCBA9876543210",
+"7CA110454A1A6E57",
+"0131D9619DC1376E",
+"07A1133E4A0B2686",
+"3849674C2602319E",
+"04B915BA43FEB5B6",
+"0113B970FD34F2CE",
+"0170F175468FB5E6",
+"43297FAD38E373FE",
+"07A7137045DA2A16",
+"04689104C2FD3B2F",
+"37D
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
In data lunedì, 9 maggio 2016 14:28:16 CEST, laurent Montel ha scritto: > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > > > Howdy, > > > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > > the blowfish backend in kwallet broke things. > > > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > > > A patch can be found attached to that bug, or you can get commit > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > > > There may be more trouble afoot as we debugged a problem in neon today > > that turned out to be probably caused by > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > https://bugs.kde.org/show_bug.cgi?id=362842 > > Same for me It was necessary to revert to > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > Even with last master it doesn't work. > For me it will better to revert to 15e6febac44810b1ee640ffd73cd3ef7d6360527 > and release it until we understand why it's broken with this 2 last patchs. > > Regards > > > HS Hi, the official relese is tomorrow, do we have a proper solution to handle this issue? From Anke's mail seems that it works by reverting to the old verison from 5.21 (commit: 0d56c68d7a2204a987a5255096d004d5a696c0e5) there will be a new package online? Thank you, Luca ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Mon, May 9, 2016 at 5:15 PM, Albert Astals Cid wrote: > El dilluns, 9 de maig de 2016, a les 8:43:23 CEST, Anke Boersma va > escriure: > > On Mon, May 9, 2016 at 8:28 AM, laurent Montel wrote: > > > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > > > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter > wrote: > > > > > Howdy, > > > > > > > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 > for > > > > > the blowfish backend in kwallet broke things. > > > > > > > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > > > > > > > A patch can be found attached to that bug, or you can get commit > > > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet > repo. > > > > > > > > There may be more trouble afoot as we debugged a problem in neon > today > > > > that turned out to be probably caused by > > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > > > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > > > > > https://bugs.kde.org/show_bug.cgi?id=362842 > > > > > > Same for me It was necessary to revert to > > > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > > > Even with last master it doesn't work. > > > For me it will better to revert to > > > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > and release it until we understand why it's broken with this 2 last > > > patchs. > > > > > > Regards > > > > > > > HS > > > > ___ > > > > release-team mailing list > > > > release-team@kde.org > > > > https://mail.kde.org/mailman/listinfo/release-team > > > > > > -- > > > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software > Engineer > > > KDAB (France) S.A.S., a KDAB Group company > > > Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr > > > > > > > > > ___ > > > release-team mailing list > > > release-team@kde.org > > > https://mail.kde.org/mailman/listinfo/release-team > > > > If you create a new wallet all works with latest commit, try to go back > > with that new wallet to 15e6febac44810b1ee640ffd73cd3ef7d6360527 (or > > kwallet 5.21.0), same breakage. > > Since your email came almost at the same time as Allen's can you confirm > if it > is with last-last commit or with almost-last commit that you still have > problems? > > Cheers, > Albert > Email was for then last commit 87e774825b779ba846315a8b2ffe6479dd9f9814, all works correctly with that commit, if you create a new wallet. That wallet is then again not compatible with 15e6febac44810b1ee640ffd73cd3ef7d6360527 or now latest 0d56c68d7a2204a987a5255096d004d5a696c0e5 All works correctly with a wallet used in 5.21.0 and before with this last commit 0d56c68d7a2204a987a5255096d004d5a696c0e5 ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
El dilluns, 9 de maig de 2016, a les 8:43:23 CEST, Anke Boersma va escriure: > On Mon, May 9, 2016 at 8:28 AM, laurent Montel wrote: > > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > > > > Howdy, > > > > > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > > > the blowfish backend in kwallet broke things. > > > > > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > > > > > A patch can be found attached to that bug, or you can get commit > > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > > > > > There may be more trouble afoot as we debugged a problem in neon today > > > that turned out to be probably caused by > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > > > https://bugs.kde.org/show_bug.cgi?id=362842 > > > > Same for me It was necessary to revert to > > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > Even with last master it doesn't work. > > For me it will better to revert to > > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > and release it until we understand why it's broken with this 2 last > > patchs. > > > > Regards > > > > > HS > > > ___ > > > release-team mailing list > > > release-team@kde.org > > > https://mail.kde.org/mailman/listinfo/release-team > > > > -- > > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer > > KDAB (France) S.A.S., a KDAB Group company > > Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr > > > > > > ___ > > release-team mailing list > > release-team@kde.org > > https://mail.kde.org/mailman/listinfo/release-team > > If you create a new wallet all works with latest commit, try to go back > with that new wallet to 15e6febac44810b1ee640ffd73cd3ef7d6360527 (or > kwallet 5.21.0), same breakage. Since your email came almost at the same time as Allen's can you confirm if it is with last-last commit or with almost-last commit that you still have problems? Cheers, Albert ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Mon, May 9, 2016 at 8:28 AM, laurent Montel wrote: > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > > > Howdy, > > > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > > the blowfish backend in kwallet broke things. > > > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > > > A patch can be found attached to that bug, or you can get commit > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > > > There may be more trouble afoot as we debugged a problem in neon today > > that turned out to be probably caused by > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > https://bugs.kde.org/show_bug.cgi?id=362842 > > Same for me It was necessary to revert to > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > Even with last master it doesn't work. > For me it will better to revert to 15e6febac44810b1ee640ffd73cd3ef7d6360527 > and release it until we understand why it's broken with this 2 last patchs. > > Regards > > > > > HS > > ___ > > release-team mailing list > > release-team@kde.org > > https://mail.kde.org/mailman/listinfo/release-team > > > -- > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer > KDAB (France) S.A.S., a KDAB Group company > Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr > > > ___ > release-team mailing list > release-team@kde.org > https://mail.kde.org/mailman/listinfo/release-team > If you create a new wallet all works with latest commit, try to go back with that new wallet to 15e6febac44810b1ee640ffd73cd3ef7d6360527 (or kwallet 5.21.0), same breakage. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Monday, May 09, 2016 02:28:16 PM laurent Montel wrote: > Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > > > Howdy, > > > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > > the blowfish backend in kwallet broke things. > > > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > > > A patch can be found attached to that bug, or you can get commit > > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > > > There may be more trouble afoot as we debugged a problem in neon today > > that turned out to be probably caused by > > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > > > https://bugs.kde.org/show_bug.cgi?id=362842 > > Same for me It was necessary to revert to > 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > Even with last master it doesn't work. > For me it will better to revert to 15e6febac44810b1ee640ffd73cd3ef7d6360527 > and release it until we understand why it's broken with this 2 last patchs. > Done. I reverted both in commit 0d56c68d7a2204a987a5255096d004d5a696c0e5 I also added a big comment not to include qglobal.h so we let the compiler do what ever it might do when it encounters an undefined macro.. not good. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
Le lundi 9 mai 2016, 10:59:24 CEST Harald Sitter a écrit : > On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > > Howdy, > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > the blowfish backend in kwallet broke things. > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > A patch can be found attached to that bug, or you can get commit > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > There may be more trouble afoot as we debugged a problem in neon today > that turned out to be probably caused by > 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling > back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 > > https://bugs.kde.org/show_bug.cgi?id=362842 Same for me It was necessary to revert to 15e6febac44810b1ee640ffd73cd3ef7d6360527 Even with last master it doesn't work. For me it will better to revert to 15e6febac44810b1ee640ffd73cd3ef7d6360527 and release it until we understand why it's broken with this 2 last patchs. Regards > > HS > ___ > release-team mailing list > release-team@kde.org > https://mail.kde.org/mailman/listinfo/release-team -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Sun, May 8, 2016 at 11:29 PM, Allen Winter wrote: > Howdy, > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > the blowfish backend in kwallet broke things. > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > A patch can be found attached to that bug, or you can get commit > 87e774825b779ba846315a8b2ffe6479dd9f9814 > from frameworks kwallet repo. There may be more trouble afoot as we debugged a problem in neon today that turned out to be probably caused by 87e774825b779ba846315a8b2ffe6479dd9f9814 and went away when rolling back to a build of 15e6febac44810b1ee640ffd73cd3ef7d6360527 https://bugs.kde.org/show_bug.cgi?id=362842 HS ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
El diumenge, 8 de maig de 2016, a les 17:31:37 CEST, Allen Winter va escriure: > On Sunday, May 08, 2016 05:29:21 PM Allen Winter wrote: > > Howdy, > > > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > > the blowfish backend in kwallet broke things. > > > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > > > A patch can be found attached to that bug, or you can get commit > > 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. > > > > Sorry for the inconvenience but I think this is an important hotfix for > > the 5.22 release. > Also, we could really use some unittests in kwallet. You broke it and fixed it, you're the most qualified to write an autotest ;) Cheers, Albert > > ___ > release-team mailing list > release-team@kde.org > https://mail.kde.org/mailman/listinfo/release-team ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Hotfix for KWallet in the Frameworks 5.22.0 Release
On Sunday, May 08, 2016 05:29:21 PM Allen Winter wrote: > Howdy, > > Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for > the blowfish backend in kwallet broke things. > > See https://bugs.kde.org/show_bug.cgi?id=362805 > > A patch can be found attached to that bug, or you can get commit > 87e774825b779ba846315a8b2ffe6479dd9f9814 > from frameworks kwallet repo. > > Sorry for the inconvenience but I think this is an important hotfix for the > 5.22 release. > Also, we could really use some unittests in kwallet. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Hotfix for KWallet in the Frameworks 5.22.0 Release
Howdy, Unfortunately my commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 for the blowfish backend in kwallet broke things. See https://bugs.kde.org/show_bug.cgi?id=362805 A patch can be found attached to that bug, or you can get commit 87e774825b779ba846315a8b2ffe6479dd9f9814 from frameworks kwallet repo. Sorry for the inconvenience but I think this is an important hotfix for the 5.22 release. -Allen ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
