Re: KDE Applications 17.11.90 (17.12-rc) packages available for packagers

[Antonio Rojas]

El Sat, 02 Dec 2017 21:34:39 +0100, Bernhard Rosenkraenzer escribió:

> And another knotes build failure that happens only with Qt 5.10.0-rc2:
> 
> ../src/configdialog/knotecollectionconfigwidget.cpp:151:24: error: no member 
> named 'setRecursiveFiltering' in 'QSortFilterProxyModel'; did you mean 
> 'setRecursiveFilteringEnabled'?
> mCollectionFilter->setRecursiveFiltering(true);
>^
>setRecursiveFilteringEnabled
> /usr/include/qt5/QtCore/qsortfilterproxymodel.h:112:10: note: 
> 'setRecursiveFilteringEnabled' declared here
> void setRecursiveFilteringEnabled(bool recursive);
>  ^
> 1 error generated.
> 
> 
> Patch attached.

This is already fixed in git, also affects pimcommon, kdepim-runtime, 
kdepim-addons and korganizer.

Re: KDE Applications 17.11.90 (17.12-rc) packages available for packagers

[Bernhard Rosenkraenzer]

And another knotes build failure that happens only with Qt 5.10.0-rc2:

../src/configdialog/knotecollectionconfigwidget.cpp:151:24: error: no member 
named 'setRecursiveFiltering' in 'QSortFilterProxyModel'; did you mean 
'setRecursiveFilteringEnabled'?
mCollectionFilter->setRecursiveFiltering(true);
   ^
   setRecursiveFilteringEnabled
/usr/include/qt5/QtCore/qsortfilterproxymodel.h:112:10: note: 
'setRecursiveFilteringEnabled' declared here
void setRecursiveFilteringEnabled(bool recursive);
 ^
1 error generated.


Patch attached.

ttyl
bero

On Saturday, December 02, 2017 21:28 CET, "Bernhard Rosenkraenzer" 
 wrote:

> Hi,
> build failure in knotes:
>
> ../src/configdialog/knoteconfigdialog.cpp:213:86: error: 'changed' is a 
> protected member of 'KCModule'
> connect(mDefaultTitle, ::textChanged, this, 
> QOverload<>::of(::changed));
>
> ~~^~~
> /usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member 
> using the type of the current context 'KNoteMiscConfig'
> void changed();
>  ^
> ../src/configdialog/knoteconfigdialog.cpp:320:114: error: 'changed' is a 
> protected member of 'KCModule'
> connect(mCollectionConfigWidget, 
> ::emitChanged, this, 
> QOverload<>::of(::changed));
>   
>  ~~^~~
> /usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member 
> using the type of the current context 'KNoteCollectionConfig'
> void changed();
>  ^
> 2 errors generated.
>
> Fix attached.
>
> ttyl
> bero
>
>
> On Friday, December 01, 2017 02:31 CET, Christoph Feck  wrote:
>
> > Hello packagers,
> >
> > *.tar.xz files are available at the usual "unstable" location.
> >
> > Please report issues, release for the RC is planned tomorrow.
> >
> > This time, I have two versions of REVISIONS_AND_HASHES, the first
> > includes all information created by the release script, the second omits
> > the l10n revision numbers, because l10n is no longer released
> > separately, and I wasn't sure if packagers need this information.
> >
> > REVISIONS_AND_HASHES at https://paste.kde.org/pwgjwaohf
> > REVISIONS_AND_HASHES_withOUT_l10n at https://paste.kde.org/pv53ggn9n
> >
> > My public key at
> > http://pgp.mit.edu/pks/lookup?op=get=0xF23275E4BF10AFC1DF6914A6DBD2CE893E2D1C87
> >
> > Thanks,
> > Christoph Feck
--- knotes-17.11.90/src/configdialog/knotecollectionconfigwidget.cpp.omv~	2017-12-02 21:30:09.588503064 +0100
+++ knotes-17.11.90/src/configdialog/knotecollectionconfigwidget.cpp	2017-12-02 21:30:18.433522055 +0100
@@ -148,7 +148,7 @@ KNoteCollectionConfigWidget::KNoteCollec
 mCollectionFilter = new KRecursiveFilterProxyModel(this);
 #else
 mCollectionFilter = new QSortFilterProxyModel(this);
-mCollectionFilter->setRecursiveFiltering(true);
+mCollectionFilter->setRecursiveFilteringEnabled(true);
 #endif
 mCollectionFilter->setSourceModel(mDisplayNotifierProxyModel);
 mCollectionFilter->setDynamicSortFilter(true);

Re: KDE Applications 17.11.90 (17.12-rc) packages available for packagers

[Bernhard Rosenkraenzer]

Hi,
build failure in knotes:

../src/configdialog/knoteconfigdialog.cpp:213:86: error: 'changed' is a 
protected member of 'KCModule'
connect(mDefaultTitle, ::textChanged, this, 
QOverload<>::of(::changed));
   
~~^~~
/usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member using 
the type of the current context 'KNoteMiscConfig'
void changed();
 ^
../src/configdialog/knoteconfigdialog.cpp:320:114: error: 'changed' is a 
protected member of 'KCModule'
connect(mCollectionConfigWidget, ::emitChanged, 
this, QOverload<>::of(::changed));

   ~~^~~
/usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member using 
the type of the current context 'KNoteCollectionConfig'
void changed();
 ^
2 errors generated.

Fix attached.

ttyl
bero


On Friday, December 01, 2017 02:31 CET, Christoph Feck  wrote:

> Hello packagers,
>
> *.tar.xz files are available at the usual "unstable" location.
>
> Please report issues, release for the RC is planned tomorrow.
>
> This time, I have two versions of REVISIONS_AND_HASHES, the first
> includes all information created by the release script, the second omits
> the l10n revision numbers, because l10n is no longer released
> separately, and I wasn't sure if packagers need this information.
>
> REVISIONS_AND_HASHES at https://paste.kde.org/pwgjwaohf
> REVISIONS_AND_HASHES_withOUT_l10n at https://paste.kde.org/pv53ggn9n
>
> My public key at
> http://pgp.mit.edu/pks/lookup?op=get=0xF23275E4BF10AFC1DF6914A6DBD2CE893E2D1C87
>
> Thanks,
> Christoph Feck
--- knotes-17.11.90/src/configdialog/knoteconfigdialog.cpp.omv~	2017-12-02 20:35:45.818678460 +0100
+++ knotes-17.11.90/src/configdialog/knoteconfigdialog.cpp	2017-12-02 20:36:11.846720640 +0100
@@ -210,7 +210,7 @@ KNoteMiscConfig::KNoteMiscConfig(QWidget
 howItWorks->setContextMenuPolicy(Qt::NoContextMenu);
 lay->addStretch();
 load();
-connect(mDefaultTitle, ::textChanged, this, QOverload<>::of(::changed));
+connect(mDefaultTitle, ::textChanged, this, QOverload<>::of(::changed));
 }
 
 void KNoteMiscConfig::load()
@@ -317,7 +317,7 @@ KNoteCollectionConfig::KNoteCollectionCo
 QHBoxLayout *lay = new QHBoxLayout(this);
 mCollectionConfigWidget = new KNoteCollectionConfigWidget;
 lay->addWidget(mCollectionConfigWidget);
-connect(mCollectionConfigWidget, ::emitChanged, this, QOverload<>::of(::changed));
+connect(mCollectionConfigWidget, ::emitChanged, this, QOverload<>::of(::changed));
 load();
 }
 

Re: KDE Applications 17.11.90 (17.12-rc) packages available for packagers

[Michael Pyne]

On Sat, Dec 02, 2017 at 12:47:42PM +0100, Bernhard Rosenkraenzer wrote:
> Hi,
> 17.11.90 looks good for the most part.
> One problem detected while upgrading OpenMandriva packages:
> juk fails to compile if libtunepimp headers are installed.
> 
> The bits using it are still using KDE4 APIs, but the cmake files still try to 
> build those files if libtunepimp headers are found.
> 
> "Fixed" it by uninstalling libtunepimp (seems pretty useless these days 
> anyway) -- but the proper fix is fixing CMakeLists.txt to not build broken 
> bits even if the dependencies are there...
> 
> ttyl
> bero

bero,

Thanks for the report.  I've modified CMakeLists.txt for now in the
Applications/17.12 branch at commit 741957e01c7a0e5bfe9e14f86a66ee87e0da609d.

I've verified it builds on my end, hopefully I've caught it in time to
make RC but either way it in the 17.12 branch so should make release.

In the meantime I will forward port to master and either remove the
whole thing or fix it to use the modern libs musicbrainz now recommends.

Regards,
 - Michael Pyne

Re: KDE Applications 17.11.90 (17.12-rc) packages available for packagers

[Bernhard Rosenkraenzer]

Hi,
17.11.90 looks good for the most part.
One problem detected while upgrading OpenMandriva packages:
juk fails to compile if libtunepimp headers are installed.

The bits using it are still using KDE4 APIs, but the cmake files still try to 
build those files if libtunepimp headers are found.

"Fixed" it by uninstalling libtunepimp (seems pretty useless these days anyway) 
-- but the proper fix is fixing CMakeLists.txt to not build broken bits even if 
the dependencies are there...

ttyl
bero

On Friday, December 01, 2017 02:31 CET, Christoph Feck  wrote:

> Hello packagers,
>
> *.tar.xz files are available at the usual "unstable" location.
>
> Please report issues, release for the RC is planned tomorrow.
>
> This time, I have two versions of REVISIONS_AND_HASHES, the first
> includes all information created by the release script, the second omits
> the l10n revision numbers, because l10n is no longer released
> separately, and I wasn't sure if packagers need this information.
>
> REVISIONS_AND_HASHES at https://paste.kde.org/pwgjwaohf
> REVISIONS_AND_HASHES_withOUT_l10n at https://paste.kde.org/pv53ggn9n
>
> My public key at
> http://pgp.mit.edu/pks/lookup?op=get=0xF23275E4BF10AFC1DF6914A6DBD2CE893E2D1C87
>
> Thanks,
> Christoph Feck

KDE Applications 17.11.90 (17.12-rc) packages available for packagers

[Christoph Feck]

Hello packagers,

*.tar.xz files are available at the usual "unstable" location.

Please report issues, release for the RC is planned tomorrow.

This time, I have two versions of REVISIONS_AND_HASHES, the first 
includes all information created by the release script, the second omits 
the l10n revision numbers, because l10n is no longer released 
separately, and I wasn't sure if packagers need this information.


REVISIONS_AND_HASHES at https://paste.kde.org/pwgjwaohf
REVISIONS_AND_HASHES_withOUT_l10n at https://paste.kde.org/pv53ggn9n

My public key at 
http://pgp.mit.edu/pks/lookup?op=get=0xF23275E4BF10AFC1DF6914A6DBD2CE893E2D1C87


Thanks,
Christoph Feck