Re: KDE Frameworks 5.56.0
I would request a plasma-frameworks 5.56.2 release for this fix to a significant bug with Qt 5.12.2 https://cgit.kde.org/plasma-framework.git/commit/?id=3aba8a7e10e509d4a321adb0b7540a73be023c10 Some distro build systems cannot handle applying such a binary patch by default. Thanks
Re: KDE Frameworks 5.56.0
On mercredi 13 mars 2019 11:39:41 CET Luca Beltrame wrote: > Il giorno Mon, 11 Mar 2019 18:18:24 +0100 > > Antonio Rojas ha scritto: > > I had to backport 4bf1d0e8 too for it to apply on top of 5.56. Would > > be good if some kirigami dev could confirm whether it's OK to > > backport just those 2 commits > > I talked this over with notmart on IRC: > > [11:32] hmm, not much understanding why 4bf1d0e8 is needed > [11:32] notmart: backporting one introduces conflicts > [11:32] i tought the fix for the kcm freeze was done before > tagging, meh > [11:32] right > [11:33] so yeah, the other one is mostly harmless > [11:33] i guess is better to backport those two instead of > making another one ad hoc? > [11:33] I would say so > > tl;dr: It should be harmless. Can we get a kirigami 5.56.1 with those > two commits in? Done: kirigami v5.56.1 31ad1cb62c9944f90bc2aea0bb81b6c7b5464113 c809cb550264389ad37911755b9b4123c5a234660f965da9d76d72aa6731f85a sources/kirigami2-5.56.1.tar.xz > While we're here we might want a plasma-framework 5.56.1 with > ebae2d63033647950cf0f9d97410723a8c7db1f3 applied (which fixes a crash). Right. plasma-framework v5.56.1 5499213bc8f35c8412d450979257f64ceaec42d5 dc3c756cd0a91fa8a343c994606cceb5024615232d48fc7ebeecbfec98c0c772 sources/plasma-framework-5.56.1.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: KDE Frameworks 5.56.0
Il giorno Mon, 11 Mar 2019 18:18:24 +0100 Antonio Rojas ha scritto: > I had to backport 4bf1d0e8 too for it to apply on top of 5.56. Would > be good if some kirigami dev could confirm whether it's OK to > backport just those 2 commits I talked this over with notmart on IRC: [11:32] hmm, not much understanding why 4bf1d0e8 is needed [11:32] notmart: backporting one introduces conflicts [11:32] i tought the fix for the kcm freeze was done before tagging, meh [11:32] right [11:33] so yeah, the other one is mostly harmless [11:33] i guess is better to backport those two instead of making another one ad hoc? [11:33] I would say so tl;dr: It should be harmless. Can we get a kirigami 5.56.1 with those two commits in? While we're here we might want a plasma-framework 5.56.1 with ebae2d63033647950cf0f9d97410723a8c7db1f3 applied (which fixes a crash). pgpPIjl_2pXlo.pgp Description: Firma digitale OpenPGP
Re: KDE Frameworks 5.56.0
El sábado, 9 de marzo de 2019 21:44:19 (CET) David Faure escribió: > error: could not apply 58d9ecd... avoid parenting OverlaySheet to ColumnView > hint: after resolving the conflicts, mark the corrected paths > hint: with 'git add ' or 'git rm ' > hint: and commit the result with 'git commit' > > Can you put a tested commit into a branch created from the v5.56.0 tag? I had to backport 4bf1d0e8 too for it to apply on top of 5.56. Would be good if some kirigami dev could confirm whether it's OK to backport just those 2 commits
Re: KDE Frameworks 5.56.0
On samedi 9 mars 2019 18:37:52 CET Antonio Rojas wrote: > kirigami 5.56 is affected by bug 405001, that makes some systemsettings > modules freeze. This is fixed in commit 58d9ecd3, and IMO it is serious > enough to warrant a 5.56.1 release. error: could not apply 58d9ecd... avoid parenting OverlaySheet to ColumnView hint: after resolving the conflicts, mark the corrected paths hint: with 'git add ' or 'git rm ' hint: and commit the result with 'git commit' Changes to be committed: modified: src/columnview.cpp modified: src/controls/templates/OverlaySheet.qml Unmerged paths: (use "git add ..." to mark resolution) both modified: src/controls/PageRow.qml Can you put a tested commit into a branch created from the v5.56.0 tag? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: KDE Frameworks 5.56.0
kirigami 5.56 is affected by bug 405001, that makes some systemsettings modules freeze. This is fixed in commit 58d9ecd3, and IMO it is serious enough to warrant a 5.56.1 release.
Re: KDE Frameworks 5.56.0
On jeudi 7 mars 2019 09:56:05 CET Dr.-Ing. Christoph Cullmann wrote:
> Hi,
>
> > On mercredi 6 mars 2019 13:31:13 CET Andreas Sturmlechner wrote:
> >> On Sat, 2 Mar 2019 at 16:48, David Faure wrote:
> >> > Dear packagers,
> >> >
> >> > KDE Frameworks 5.56.0 has been uploaded to the usual place.
> >>
> >> syntax-highlighting should be respun to include commit 84d78a05
> >> ("guard target link libraries for older CMake version")
> >
> > OK, done.
> >
> > syntax-highlighting v5.56.0-rc2
> > 0ec4b4c84c2ed04b3eda629ec0386f74f74c3355
> > 700439e5052e4fd6b681b8cff177b39e92edb418f055c31a91700ebf58b3d956
> > sources/syntax-highlighting-5.56.0.tar.xz
> >
> > It's surprising to me that with older cmake we just skip linking to
> > something (one would think it leads to undefined symbols), but I just
> > tested compilation with
> > cmake 3.10 and it worked.
>
> The linking is only needed to get the right includes/defines for the
> namespaced compilation, otherwise this is a nop for that object lib.
>
> Unfortunately my fix was not good enough, see:
>
> https://phabricator.kde.org/D19581
OK, rc3 is up:
syntax-highlighting v5.56.0-rc3
0a83b0c4697267769461399dd3ad680dafeb6004
14c1832e268c8053cc0ef9ff00415794801e518f9c103328eca661a657d8803e
sources/syntax-highlighting-5.56.0.tar.xz
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
Re: KDE Frameworks 5.56.0
Hi,
> On mercredi 6 mars 2019 13:31:13 CET Andreas Sturmlechner wrote:
>> On Sat, 2 Mar 2019 at 16:48, David Faure wrote:
>> > Dear packagers,
>> >
>> > KDE Frameworks 5.56.0 has been uploaded to the usual place.
>>
>> syntax-highlighting should be respun to include commit 84d78a05
>> ("guard target link libraries for older CMake version")
>
> OK, done.
>
> syntax-highlighting v5.56.0-rc2
> 0ec4b4c84c2ed04b3eda629ec0386f74f74c3355
> 700439e5052e4fd6b681b8cff177b39e92edb418f055c31a91700ebf58b3d956
> sources/syntax-highlighting-5.56.0.tar.xz
>
> It's surprising to me that with older cmake we just skip linking to something
> (one would think it leads to undefined symbols), but I just tested compilation
> with
> cmake 3.10 and it worked.
The linking is only needed to get the right includes/defines for the namespaced
compilation, otherwise this is a nop for that object lib.
Unfortunately my fix was not good enough, see:
https://phabricator.kde.org/D19581
Greetings
Christoph
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
--
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com
Science Park 1 Tel: +49-681-38360-22
66123 Saarbrücken Fax: +49-681-38360-20
GERMANYWWW: http://www.AbsInt.com
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: KDE Frameworks 5.56.0
Am Donnerstag, 7. März 2019, 09:16:55 schrieb Wolfgang Bauer: > I uploaded a fix to phabricator: > https://phabricator.kde.org/D19581 It has been pushed with commit a08e2ebd589fc3faaa4b79f48fc7ff964e13cad3 . Can we have another respin please? Thank you. Kind Regards, Wolfgang
Re: KDE Frameworks 5.56.0
Am Mittwoch, 6. März 2019, 22:41:57 schrieb David Faure:
> On mercredi 6 mars 2019 13:31:13 CET Andreas Sturmlechner wrote:
> > On Sat, 2 Mar 2019 at 16:48, David Faure wrote:
> > > Dear packagers,
> > >
> > > KDE Frameworks 5.56.0 has been uploaded to the usual place.
> >
> > syntax-highlighting should be respun to include commit 84d78a05
> > ("guard target link libraries for older CMake version")
>
> OK, done.
>
> syntax-highlighting v5.56.0-rc2
> 0ec4b4c84c2ed04b3eda629ec0386f74f74c3355
> 700439e5052e4fd6b681b8cff177b39e92edb418f055c31a91700ebf58b3d956
> sources/syntax-highlighting-5.56.0.tar.xz
This doesn't work with cmake 3.5 and 3.6 though, because VERSION_GREATER_EQUAL
only exists since 3.7:
CMake Error at data/CMakeLists.txt:69 (if):
if given arguments:
"3.5.2" "VERSION_GREATER_EQUAL" "3.13.0"
Unknown arguments specified
I uploaded a fix to phabricator:
https://phabricator.kde.org/D19581
Kind Regards,
Wolfgang
Re: KDE Frameworks 5.56.0
On mercredi 6 mars 2019 13:31:13 CET Andreas Sturmlechner wrote:
> On Sat, 2 Mar 2019 at 16:48, David Faure wrote:
> > Dear packagers,
> >
> > KDE Frameworks 5.56.0 has been uploaded to the usual place.
>
> syntax-highlighting should be respun to include commit 84d78a05
> ("guard target link libraries for older CMake version")
OK, done.
syntax-highlighting v5.56.0-rc2
0ec4b4c84c2ed04b3eda629ec0386f74f74c3355
700439e5052e4fd6b681b8cff177b39e92edb418f055c31a91700ebf58b3d956
sources/syntax-highlighting-5.56.0.tar.xz
It's surprising to me that with older cmake we just skip linking to something
(one would think it leads to undefined symbols), but I just tested compilation
with
cmake 3.10 and it worked.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
Re: KDE Frameworks 5.56.0
On Sat, 2 Mar 2019 at 16:48, David Faure wrote:
> Dear packagers,
>
> KDE Frameworks 5.56.0 has been uploaded to the usual place.
syntax-highlighting should be respun to include commit 84d78a05
("guard target link libraries for older CMake version")
Regards,
Andreas
KDE Frameworks 5.56.0
Dear packagers, KDE Frameworks 5.56.0 has been uploaded to the usual place. New frameworks: none this time. Public release next Saturday. Thanks for the packaging work! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 attica v5.56.0-rc1 14fcec2246827bed863f2bf77bb6c21ce8492bb5 abbaeed8ec027735d6504d31387e4115400457e14b8983a780debd769e4766c5 sources/attica-5.56.0.tar.xz baloo v5.56.0-rc1 e6f9db342450444b0c1d66a0999eb918f66425de 9ed5ba80305815cde3ebe1fe707c35661cedba39539645e815d408fe28a41212 sources/baloo-5.56.0.tar.xz bluez-qt v5.56.0-rc1 cf269ffa2301587e2a46a5824a42251ce516bfd7 d592b84dd52aeaa0a5453949aced2fa7b160830d7325382f1616e92a338017de sources/bluez-qt-5.56.0.tar.xz breeze-icons v5.56.0-rc1 2d9b56ac7c6d04c20f5ad6129457bb9613d2 7d98d6be0795cc5dd7468e3d8093541726dcc10586a91477c02879f5eb8fcf58 sources/breeze-icons-5.56.0.tar.xz extra-cmake-modules v5.56.0-rc1 028bf45ef2196bb104f08c3f3be427e6a6345ea5 913ce70cd64c5a35586f1ecdac5d6417cb128a9d3829ded7bb95e602d0ecb528 sources/extra-cmake-modules-5.56.0.tar.xz frameworkintegration v5.56.0-rc1 905d0956234eb7132a3b639de040c0730df7c9fa ee8d46b629a95e49fda80e50ba8863504a6c463fec887f83370b7e7977db80f5 sources/frameworkintegration-5.56.0.tar.xz kactivities v5.56.0-rc1 bc17a4d603dd42ae8d1cde534050b3f51b9ba87f e76a4d44ca6e7ce2273d8c3b133fdd12e32367aeffd66098ec46e7b28c491750 sources/kactivities-5.56.0.tar.xz kactivities-stats v5.56.0-rc1 fea4984dc583ba303e87cdbd2cc2598cad8296c6 6ed0f91dd1dee3db2b0ac8e9a344eb32a881cf243dbf34c0d95888955b7277ec sources/kactivities-stats-5.56.0.tar.xz kapidox v5.56.0-rc1 24156e79897551a0aba13e9571338f2e55082378 971f56ce21dcd745a90166def317398c1a3ebd24a81b41668b23b84fb6c61866 sources/kapidox-5.56.0.tar.xz karchive v5.56.0-rc1 79e6bab0e1f021ea76c6a6d253161e3092469d31 281a6cea68d19d56f8506e839e450d6652604e49ab70b540e29828b50adbcad6 sources/karchive-5.56.0.tar.xz kauth v5.56.0-rc1 e68ce4650e3dc5f7dfeebb2320a28938e35cdd07 cbcca13064b112dff26d1f78b1e77c8ad263cb663aab6329bc6e0a6505f4613d sources/kauth-5.56.0.tar.xz kbookmarks v5.56.0-rc1 d1cd7ef1da0ed0ce885da2b4ff57273722556b63 02011a370959e9fe91db499ba8b12284f2274471760b1bd466587aa9c0c1953b sources/kbookmarks-5.56.0.tar.xz kcmutils v5.56.0-rc1 d4c9426adb666897b0ac211588d6a6e88dc865f9 7cf6a81818745852c38558160e3888bdd2a9bcce135aee53c3df99e939633ab8 sources/kcmutils-5.56.0.tar.xz kcodecs v5.56.0-rc1 07a7ab4f4da8ccb5fb062e8696a4d6d4a373b304 e7234cddea70d4fa61dd66272dd43da401cc2543e40a6e9bb3a3655263419c82 sources/kcodecs-5.56.0.tar.xz kcompletion v5.56.0-rc1 b01983ba8c5ed18794d09f1f5cecfe23d3894c51 49dbfda63c64724ecff40032c1631a7c7b84a8c551401a7547fa12e100cdbafb sources/kcompletion-5.56.0.tar.xz kconfig v5.56.0-rc1 e7ed3c1a7c5d051b5208fd6d2be0082c5a76b9ea 2a970733da16b90ecc317e8ac77f08530650eb2e98dc93834e09e156ec353172 sources/kconfig-5.56.0.tar.xz kconfigwidgets v5.56.0-rc1 efa780da6118f1b3f8da5abb8f4af58c2af33fb1 c5cfcd8ba356563d83c11a2ebe78d163336df2ef3f97faed0f487ddc5f67a503 sources/kconfigwidgets-5.56.0.tar.xz kcoreaddons v5.56.0-rc1 b4b720d1ae6d21d31451199c7a5d210592667755 9f41039f1bd453087ff784e9e95d4f09624ff893fe0298d3c986a6a554b37b9e sources/kcoreaddons-5.56.0.tar.xz kcrash v5.56.0-rc1 1b81b6b6928ec83ed9799f20d19035a647b6b8b1 581e8215212a584886e8d4b6d5c1aac277590bcb343697d8b3653e1c22f6b1e0 sources/kcrash-5.56.0.tar.xz kdbusaddons v5.56.0-rc1 19c8a189b0dc68da219113c1620c58dcd595ac4d b930918ccece1d80aaf0eb770d4e17e5926d7da3a97d1f8506f28829d267b972 sources/kdbusaddons-5.56.0.tar.xz kdeclarative v5.56.0-rc1 0e17bf23c30ae54871f6c3c123b01ce9c888455c 799c21af97dfbd25d844ff4839461a7ce29bd7e8ec04e00edf43c8bc3eee906a sources/kdeclarative-5.56.0.tar.xz kded v5.56.0-rc1 20e29155682b9fa47848495cbd33933108b6f580 ff2a105edaec825bc9d964df8e181c0f4910432bbfbf2238d61acb17b3bebf39 sources/kded-5.56.0.tar.xz kdelibs4support v5.56.0-rc1 5fdb3772135926db37135f4b87fa8b965ac9fefc edcc14715699f247c57303d7418014202bd0ed3b06cf9752ddd156fefeb60efa sources/portingAids/kdelibs4support-5.56.0.tar.xz kdesignerplugin v5.56.0-rc1 049fd8a98e417bf26fde0f234f3d5c53a4af8c33 9bf43498f631dbf1c2bc15af7f6e6494d979223cf2a34ec9f95f58a7be57d816 sources/kdesignerplugin-5.56.0.tar.xz kdesu v5.56.0-rc1 b4b7ab3b99f35c1c528f5cc259029743b117ce1c 949a23837de945131042e795daaa8a1abc4d9e03cf149cc9cea78636573e8739 sources/kdesu-5.56.0.tar.xz kdewebkit v5.56.0-rc1 4f184525658ce8009c215427e4f04d979d7b69d7 822dc687eec418646132219d98834cbe3c992555bc83bb7ca751a00086ee35b0 sources/kdewebkit-5.56.0.tar.xz kdnssd v5.56.0-rc1 b3942fea2ee28cfe5c69b8cdaf319c09ae1bb67d 7e1383580f97248d8bfb6522bd230657bd002d3eb0e74a178bccc8a511e353bf sources/kdnssd-5.56.0.tar.xz kdoctools v5.56.0-rc1 6bcc21e6be1398ae1df60377929ace05b17b84c8 e4f83bfaeca9ef89711577b756a3c359eb8d45b60a180934ba82431b5c36c007 sources/kdoctools-5.56.0.tar.xz kemoticons v5.56.0-rc1 eb466876b7122b014f42d82024fc09e0a9e7ad49 82eeb425a0b4eebd60c743433e09bb6aadcb512dce27c5dbd7ce73fb12680b02 sources
