Re: Perl version in KDELibs
[Raphael Kubo da Costa - Montag, 6. Juni 2011 11:18:48] > Michael Pyne writes: > > > On Sunday, June 05, 2011 22:07:25 Raphael Kubo da Costa wrote: > >> Frederik Schwarzer writes: > >> > So I changed the affected script and let it require Perl 5.10. > >> > > >> > Now I wanted to backport the change to 4.6 but I am not sure if that is > >> > OK due to the version bump and the with it changed dependency. So I > >> > looked at kdelibs' CMakeLists.txt and found out that it does not state > >> > a version. > >> > > >> > Does that mean it would also be satisfied by Perl 5.4 or something? > >> > >> Yes. > >> > >> > Should we set a minimum version there? > >> > >> Well, we use CMake's FindPerl.cmake, which does not check Perl's version > >> at all. If that's really needed, we could add a FindPerl.cmake to > >> kdelibs, but the kde-buildsystem mailing list is a better place to > >> discuss that. > > > > AFAICS CMake's FindPerl supports requesting a minimum version just fine, we > > just were not setting a minimum version to look for. > > I'm using CMake 2.8.4 here, and its FindPerl.cmake only looks for an > executable called "perl", without any version checking. > > FindPerlLibs.cmake, on the other hand, does that version check if > required. Perhaps we could use that instead of FindPerl > (FindPerlLibs.cmake does `include(FindPerl)')? I think it is a different thing. While FindPerl looks for the executable, FindPerlLibs looks for the library. Yes, the Lib check includes the check for the executable but also adds another dependency ... at least in Debian the Lib is a different package. But yes, this would be a discussion for buildsystem. I would like to concentrate on the "can I backport a change that raises the required version for Perl from 5.8 to 5.10" on this list. :) Regards ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Perl version in KDELibs
Michael Pyne writes: > On Sunday, June 05, 2011 22:07:25 Raphael Kubo da Costa wrote: >> Frederik Schwarzer writes: >> > So I changed the affected script and let it require Perl 5.10. >> > >> > Now I wanted to backport the change to 4.6 but I am not sure if that is >> > OK due to the version bump and the with it changed dependency. So I >> > looked at kdelibs' CMakeLists.txt and found out that it does not state >> > a version. >> > >> > Does that mean it would also be satisfied by Perl 5.4 or something? >> >> Yes. >> >> > Should we set a minimum version there? >> >> Well, we use CMake's FindPerl.cmake, which does not check Perl's version >> at all. If that's really needed, we could add a FindPerl.cmake to >> kdelibs, but the kde-buildsystem mailing list is a better place to >> discuss that. > > AFAICS CMake's FindPerl supports requesting a minimum version just fine, we > just were not setting a minimum version to look for. I'm using CMake 2.8.4 here, and its FindPerl.cmake only looks for an executable called "perl", without any version checking. FindPerlLibs.cmake, on the other hand, does that version check if required. Perhaps we could use that instead of FindPerl (FindPerlLibs.cmake does `include(FindPerl)')? ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Perl version in KDELibs
[Michael Pyne - Montag, 6. Juni 2011 03:14:14] > On Sunday, June 05, 2011 22:07:25 Raphael Kubo da Costa wrote: > > Frederik Schwarzer writes: > > > So I changed the affected script and let it require Perl 5.10. > > > > > > Now I wanted to backport the change to 4.6 but I am not sure if that is > > > OK due to the version bump and the with it changed dependency. So I > > > looked at kdelibs' CMakeLists.txt and found out that it does not state > > > a version. > > > > > > Does that mean it would also be satisfied by Perl 5.4 or something? > > > > Yes. > > > > > Should we set a minimum version there? > > > > Well, we use CMake's FindPerl.cmake, which does not check Perl's version > > at all. If that's really needed, we could add a FindPerl.cmake to > > kdelibs, but the kde-buildsystem mailing list is a better place to > > discuss that. > > AFAICS CMake's FindPerl supports requesting a minimum version just fine, we > just were not setting a minimum version to look for. Where do you see that? The cmake file does not look like it is checking a version and using a high number in the macro in kdesdk/kioslaves gives me: -- Found Perl: /usr/bin/perl (Required is at least version "6.10") See the difference of wording e.g. to: -- Found SharedMimeInfo: /usr/bin/update-mime-database (found version "0.90", required is "0.40") where it actually states the version that was found. So maybe FindPerl does not support version checks after all. Strange though that it does Every version of Perl deprecates and drops (or rather replaces) some things so it might make sence to enable FindPerl to check for specific versions. > Both Perl 5.8 and 5.10 are unsupported by Perl upstream, so it doesn't make > sense for us to depend on those or anything earlier. I think the important bit is what we actually use. If we use features introduced in 5.10 (as in kdesdk/kioslaves/perldoc/pod2html.pl), we should set 5.10 as the minimum required version and make sure the script works with 5.12 and 5.14 as well. 5.10 might be unsupported by upstream but not necessarily by distros. MfG ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Perl version in KDELibs
On Sunday, June 05, 2011 22:07:25 Raphael Kubo da Costa wrote: > Frederik Schwarzer writes: > > So I changed the affected script and let it require Perl 5.10. > > > > Now I wanted to backport the change to 4.6 but I am not sure if that is > > OK due to the version bump and the with it changed dependency. So I > > looked at kdelibs' CMakeLists.txt and found out that it does not state > > a version. > > > > Does that mean it would also be satisfied by Perl 5.4 or something? > > Yes. > > > Should we set a minimum version there? > > Well, we use CMake's FindPerl.cmake, which does not check Perl's version > at all. If that's really needed, we could add a FindPerl.cmake to > kdelibs, but the kde-buildsystem mailing list is a better place to > discuss that. AFAICS CMake's FindPerl supports requesting a minimum version just fine, we just were not setting a minimum version to look for. > As for backporting, my opinion is that if we did not previously state a > minimum dependency version before we are not really breaking any > dependency version promise (other release-team members might disagree). Both Perl 5.8 and 5.10 are unsupported by Perl upstream, so it doesn't make sense for us to depend on those or anything earlier. 5.10 *was* supported when 4.6 was released, so I think it makes sense to say that 5.10 at least is required from 4.6 on, at least in the case of the affected script for backporting purposes. As far as kdelibs is concerned, we should probably pick a minimum version. It doesn't have to be based on what's supported by Perl (i.e. can be based on what features we actually need) but "any version" is at least probably incorrect. I would recommend 5.10 due to the quantum leap it had over 5.8 but I'm interested in hearing other opinions. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Perl version in KDELibs
Frederik Schwarzer writes: > So I changed the affected script and let it require Perl 5.10. > > Now I wanted to backport the change to 4.6 but I am not sure if that is OK > due to the version bump and the with it changed dependency. So I looked at > kdelibs' CMakeLists.txt and found out that it does not state a version. > > Does that mean it would also be satisfied by Perl 5.4 or something? Yes. > Should we set a minimum version there? Well, we use CMake's FindPerl.cmake, which does not check Perl's version at all. If that's really needed, we could add a FindPerl.cmake to kdelibs, but the kde-buildsystem mailing list is a better place to discuss that. As for backporting, my opinion is that if we did not previously state a minimum dependency version before we are not really breaking any dependency version promise (other release-team members might disagree). ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Perl version in KDELibs
Hi, there was a report asking for a change in kdesdk's use of Perls given/when feature. Before 5.10 there was a rather experimental "backported" implementation in the Switch module, which was replaced by a proper one in 5.10. The old Switch was deprecated in 5.12 and now dropped in 5.14. So I changed the affected script and let it require Perl 5.10. Now I wanted to backport the change to 4.6 but I am not sure if that is OK due to the version bump and the with it changed dependency. So I looked at kdelibs' CMakeLists.txt and found out that it does not state a version. Does that mean it would also be satisfied by Perl 5.4 or something? Should we set a minimum version there? Regards ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
