Re: Removing kregexpedit and kcalc
A Dilluns 26 Novembre 2007, Richard Moore va escriure: I've just tested trunk and if I remove the kcalc 16x16 svgz that is causing a crash on startup in QSvgRenderer then kcalc can add fine. Have you actually tested any of the problems in this report or do I need to go through them one by one? As i said, it enters and endless loop on start, so i did not test anything. KNumber::operator quint64(void) const seems to call itself if you are on a 64 bit machine like i am. Albert Rich. On 11/25/07, Richard Moore [EMAIL PROTECTED] wrote: On 11/25/07, Albert Astals Cid [EMAIL PROTECTED] wrote: A Diumenge 25 Novembre 2007, Richard Moore va escriure: Removing kcalc seems daft to me. It's pretty much essential for a sane desktop. Are you saying there are some problems with it that need fixing or just playing jobsworth? Problem i have: * I can't not start it, it ends up in an inifite loop I'm getting a segfault on startup here, but that seems to be a kiconloader issue. Problem other people has: * It doesn't know how to add http://bugs.kde.org/show_bug.cgi?id=152713 The problems in that bug seem to be more display related. Real problem: * No maintainer No playing here, i'm just not in mood. I'm not playing either, I think we need a calculator. I'll try to look into what's broken it. Rich, ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On Monday 26 November 2007, Albert Astals Cid wrote: As i said, it enters and endless loop on start, so i did not test anything. KNumber::operator quint64(void) const seems to call itself if you are on a 64 bit machine like i am. So, how about debugging and fixing that issue? I don`t like to drop kcalc now. For 4.1 we can decide for something else if there is an alternative. A (IMHO) better solution would be to get rid of KNumber and use the C++ library for big numbers. Also fixes a license problem (because GMP is GPLv3, so legally its impossible to ship KCalc at the moment). Dirk ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On Monday 26 November 2007, Dirk Mueller wrote:
As i said, it enters and endless loop on start, so i did not test
anything.
KNumber::operator quint64(void) const seems to call itself if you
are on a 64 bit machine like i am.
So, how about debugging and fixing that issue?
Attached patch makes it work for me, but I have no idea if this is the
right way to do it or not.
Andras
--
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
Index: kcalcdisplay.cpp
===
--- kcalcdisplay.cpp (revision 741923)
+++ kcalcdisplay.cpp (working copy)
@@ -38,6 +38,7 @@
#include kcalcdisplay.h
#include kcalcdisplay.moc
+
KCalcDisplay::KCalcDisplay(QWidget *parent)
:QLabel(parent), _beep(false), _groupdigits(false), _button(0), _lit(false),
_num_base(NB_DECIMAL), _precision(9),
@@ -303,7 +304,7 @@
being set with setAmount). Return value is the new base. */
int KCalcDisplay::setBase(NumBase new_base)
{
- CALCAMNT tmp_val = static_castquint64(getAmount());
+ CALCAMNT tmp_val = getAmount();
switch(new_base)
{
signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
A Dilluns 26 Novembre 2007, vàreu escriure: On Monday 26 November 2007, Albert Astals Cid wrote: As i said, it enters and endless loop on start, so i did not test anything. KNumber::operator quint64(void) const seems to call itself if you are on a 64 bit machine like i am. So, how about debugging and fixing that issue? My mood is past the line of trying to debug and fix programs i don't know and i don't care, sorry about that. Albert I don`t like to drop kcalc now. For 4.1 we can decide for something else if there is an alternative. A (IMHO) better solution would be to get rid of KNumber and use the C++ library for big numbers. Also fixes a license problem (because GMP is GPLv3, so legally its impossible to ship KCalc at the moment). Dirk ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Removing kregexpedit and kcalc
Both don't work at all, and there's no maintainer. I vote for them to be removed of KDE. Albert ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
kcalc will be replaced with speedcrunch or something? ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On Sunday 25 November 2007 17:21:08 Albert Astals Cid wrote: Both don't work at all, and there's no maintainer. I vote for them to be removed of KDE. Try posting a blog first to ask if someone will step up to do the work. -- Thomas Zander pgpjb8rG1WlFp.pgp Description: PGP signature ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
Removing kcalc seems daft to me. It's pretty much essential for a sane desktop. Are you saying there are some problems with it that need fixing or just playing jobsworth? Cheers Rich. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On Sunday 25 November 2007 17:38:20 Thomas Zander wrote: On Sunday 25 November 2007 17:21:08 Albert Astals Cid wrote: Both don't work at all, and there's no maintainer. I vote for them to be removed of KDE. Try posting a blog first to ask if someone will step up to do the work. That's 4.1 timeframe. Finding a maintainer and having the code fixed does not sounds like reality to me with our current timeframe. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
A Diumenge 25 Novembre 2007, Richard Moore va escriure: Removing kcalc seems daft to me. It's pretty much essential for a sane desktop. Are you saying there are some problems with it that need fixing or just playing jobsworth? Problem i have: * I can't not start it, it ends up in an inifite loop Problem other people has: * It doesn't know how to add http://bugs.kde.org/show_bug.cgi?id=152713 Real problem: * No maintainer No playing here, i'm just not in mood. Albert Cheers Rich. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On Sunday 25 November 2007, Sebastian Kuegler wrote: On Sunday 25 November 2007 17:38:20 Thomas Zander wrote: On Sunday 25 November 2007 17:21:08 Albert Astals Cid wrote: Both don't work at all, and there's no maintainer. I vote for them to be removed of KDE. Try posting a blog first to ask if someone will step up to do the work. That's 4.1 timeframe. Finding a maintainer and having the code fixed does not sounds like reality to me with our current timeframe. I agree with Richard, a sane desktop needs a calculator. So is it too late to replace kcalc by speedcrunch ? (Speedcrunch is allready using Qt4, it's better than kcalc anyway) Or just leave to distribution to install Speedcrunch ? -- Cyrille Berger ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On Sunday 25 November 2007 19:46:52 Cyrille Berger wrote: On Sunday 25 November 2007, Sebastian Kuegler wrote: On Sunday 25 November 2007 17:38:20 Thomas Zander wrote: On Sunday 25 November 2007 17:21:08 Albert Astals Cid wrote: Both don't work at all, and there's no maintainer. I vote for them to be removed of KDE. Try posting a blog first to ask if someone will step up to do the work. That's 4.1 timeframe. Finding a maintainer and having the code fixed does not sounds like reality to me with our current timeframe. I agree with Richard, a sane desktop needs a calculator. So is it too late to replace kcalc by speedcrunch ? (Speedcrunch is allready using Qt4, it's better than kcalc anyway) Or just leave to distribution to install Speedcrunch ? For 4.0, it is too late. For 4.1, speedcrunch is probably a good option. There's a calculator plasmoid that might help in the meantime, though it's not in kdebase. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
On 11/25/07, Albert Astals Cid [EMAIL PROTECTED] wrote: A Diumenge 25 Novembre 2007, Richard Moore va escriure: Removing kcalc seems daft to me. It's pretty much essential for a sane desktop. Are you saying there are some problems with it that need fixing or just playing jobsworth? Problem i have: * I can't not start it, it ends up in an inifite loop I'm getting a segfault on startup here, but that seems to be a kiconloader issue. Problem other people has: * It doesn't know how to add http://bugs.kde.org/show_bug.cgi?id=152713 The problems in that bug seem to be more display related. Real problem: * No maintainer No playing here, i'm just not in mood. I'm not playing either, I think we need a calculator. I'll try to look into what's broken it. Rich, ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Removing kregexpedit and kcalc
I've just tested trunk and if I remove the kcalc 16x16 svgz that is causing a crash on startup in QSvgRenderer then kcalc can add fine. Have you actually tested any of the problems in this report or do I need to go through them one by one? Rich. On 11/25/07, Richard Moore [EMAIL PROTECTED] wrote: On 11/25/07, Albert Astals Cid [EMAIL PROTECTED] wrote: A Diumenge 25 Novembre 2007, Richard Moore va escriure: Removing kcalc seems daft to me. It's pretty much essential for a sane desktop. Are you saying there are some problems with it that need fixing or just playing jobsworth? Problem i have: * I can't not start it, it ends up in an inifite loop I'm getting a segfault on startup here, but that seems to be a kiconloader issue. Problem other people has: * It doesn't know how to add http://bugs.kde.org/show_bug.cgi?id=152713 The problems in that bug seem to be more display related. Real problem: * No maintainer No playing here, i'm just not in mood. I'm not playing either, I think we need a calculator. I'll try to look into what's broken it. Rich, ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
