Re: Review Request: only remove old parent nodes' pointer when add new parent
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105601/#review16726 --- Can you guys please remove the release-team group so it does not show up in our "todo queue"? - Albert Astals Cid On July 17, 2012, 4:23 p.m., Wagner de Melo Reck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105601/ > --- > > (Updated July 17, 2012, 4:23 p.m.) > > > Review request for Release Team and Andreas Cord-Landwehr. > > > Description > --- > > Do not remove child pointers in rooted tree if addeding the parent. It's part > of 303570 bug's fix > > > This addresses bug 303570. > http://bugs.kde.org/show_bug.cgi?id=303570 > > > Diffs > - > > src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb > > Diff: http://git.reviewboard.kde.org/r/105601/diff/ > > > Testing > --- > > > Thanks, > > Wagner de Melo Reck > > ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request: only remove old parent nodes' pointer when add new parent
> On July 17, 2012, 4:50 p.m., Albert Astals Cid wrote: > > We are not in a freeze at the moment, so the release team opinion is > > irrelevant. > > > > Cheers, > > Albert > > Wagner de Melo Reck wrote: > Aren't we at RC 2? This patch is also to be applied in the branch 4.9. > > greetings, > > Wagner Due to http://techbase.kde.org/Schedules/KDE4/4.9_Release_Schedule, only during the tagging freezes or if you are adding a new dependency in dependency freeze you have to add release team as reviewer. For this patch at this time it is enough to set the kde-edu group as reviewer. Greetings, Andreas - Andreas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105601/#review16014 --- On July 17, 2012, 4:23 p.m., Wagner de Melo Reck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105601/ > --- > > (Updated July 17, 2012, 4:23 p.m.) > > > Review request for Release Team and Andreas Cord-Landwehr. > > > Description > --- > > Do not remove child pointers in rooted tree if addeding the parent. It's part > of 303570 bug's fix > > > This addresses bug 303570. > http://bugs.kde.org/show_bug.cgi?id=303570 > > > Diffs > - > > src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb > > Diff: http://git.reviewboard.kde.org/r/105601/diff/ > > > Testing > --- > > > Thanks, > > Wagner de Melo Reck > > ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request: only remove old parent nodes' pointer when add new parent
> On July 17, 2012, 4:50 p.m., Albert Astals Cid wrote: > > We are not in a freeze at the moment, so the release team opinion is > > irrelevant. > > > > Cheers, > > Albert Aren't we at RC 2? This patch is also to be applied in the branch 4.9. greetings, Wagner - Wagner de Melo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105601/#review16014 --- On July 17, 2012, 4:23 p.m., Wagner de Melo Reck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105601/ > --- > > (Updated July 17, 2012, 4:23 p.m.) > > > Review request for Release Team and Andreas Cord-Landwehr. > > > Description > --- > > Do not remove child pointers in rooted tree if addeding the parent. It's part > of 303570 bug's fix > > > This addresses bug 303570. > http://bugs.kde.org/show_bug.cgi?id=303570 > > > Diffs > - > > src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb > > Diff: http://git.reviewboard.kde.org/r/105601/diff/ > > > Testing > --- > > > Thanks, > > Wagner de Melo Reck > > ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Re: Review Request: only remove old parent nodes' pointer when add new parent
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105601/#review16014 --- We are not in a freeze at the moment, so the release team opinion is irrelevant. Cheers, Albert - Albert Astals Cid On July 17, 2012, 4:23 p.m., Wagner de Melo Reck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105601/ > --- > > (Updated July 17, 2012, 4:23 p.m.) > > > Review request for Release Team and Andreas Cord-Landwehr. > > > Description > --- > > Do not remove child pointers in rooted tree if addeding the parent. It's part > of 303570 bug's fix > > > This addresses bug 303570. > http://bugs.kde.org/show_bug.cgi?id=303570 > > > Diffs > - > > src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb > > Diff: http://git.reviewboard.kde.org/r/105601/diff/ > > > Testing > --- > > > Thanks, > > Wagner de Melo Reck > > ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
Review Request: only remove old parent nodes' pointer when add new parent
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105601/ --- Review request for Release Team and Andreas Cord-Landwehr. Description --- Do not remove child pointers in rooted tree if addeding the parent. It's part of 303570 bug's fix This addresses bug 303570. http://bugs.kde.org/show_bug.cgi?id=303570 Diffs - src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb Diff: http://git.reviewboard.kde.org/r/105601/diff/ Testing --- Thanks, Wagner de Melo Reck ___ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team
