Re: new showstopper in kdegames

2007-11-28 Thread Mauricio Piacentini
The click bug in lskat is fixed in revision 74772, no need to revert. 
Apaku, thanks for finding it.

Which reminds me: we (kdegames) really need to do a through check of all 
applications. A topic for our next meeting, this Saturday.

Regards,
Mauricio Piacentini
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Mauricio Piacentini
Andreas Pakulat wrote:
 > > > I'd like to add a new showstopper to the 4.0 release goals. lskat 
from
 > > > kdegames is completely unusable since revision 731909.

Well, how about posting to kde-games-devel? Or contacting the 
maintainer? I think this would produce the best results, namely getting 
the application fixed. Posting to the release list without contacting 
Martin (directly or via the kdegames list) creates unnecessary distress 
imo.

And the fix is probably trivial, we can just revert the drawing code 
that changed.

I did not want to get into this mood, but really... Come on people.
The goal is to get closer to a release, right?

Regards,
Mauricio Piacentini
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Andreas Pakulat
On 28.11.07 12:56:32, Rex Dieter wrote:
> Andreas Pakulat wrote:
> > On 28.11.07 12:13:44, Rex Dieter wrote:
> >> Andreas Pakulat wrote:
> >>
> >>> I'd like to add a new showstopper to the 4.0 release goals. lskat from
> >>> kdegames is completely unusable since revision 731909. 
> >> Maybe I'm dense or naive or missing something, but an unusable *game* 
> >> being a release showstopper?
> > 
> > Hmm, I guess it could as well just be disabled. But an application that
> > can't be used, but is installed by default is a showstopper IMHO.
> 
> Fair enough.
> 
> I was just uncertain whether disabling individual broken apps was 
> something that the release-team even needed to be involved with (unless 
> module maintainers/developers are tardy/absent).

Hmm, right. Sorry seems I was a bit hasty to post this here, should've
gone to the games-list first. 

Andreas

-- 
Tomorrow, you can be anywhere.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Rex Dieter
Andreas Pakulat wrote:
> On 28.11.07 12:13:44, Rex Dieter wrote:
>> Andreas Pakulat wrote:
>>
>>> I'd like to add a new showstopper to the 4.0 release goals. lskat from
>>> kdegames is completely unusable since revision 731909. 
>> Maybe I'm dense or naive or missing something, but an unusable *game* 
>> being a release showstopper?
> 
> Hmm, I guess it could as well just be disabled. But an application that
> can't be used, but is installed by default is a showstopper IMHO.

Fair enough.

I was just uncertain whether disabling individual broken apps was 
something that the release-team even needed to be involved with (unless 
module maintainers/developers are tardy/absent).

Apps that don't work shouldn't be shipped.  Is that something that even 
needs to be explicitly documented as a showstopper?  I had hoped not, 
but if doing so helps the process and clears any confusion, then let it 
be so.

-- Rex
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Andreas Pakulat
On 28.11.07 12:13:44, Rex Dieter wrote:
> Andreas Pakulat wrote:
> 
> > I'd like to add a new showstopper to the 4.0 release goals. lskat from
> > kdegames is completely unusable since revision 731909. 
> 
> Maybe I'm dense or naive or missing something, but an unusable *game* 
> being a release showstopper?  Seriously?

Hmm, I guess it could as well just be disabled. But an application that
can't be used, but is installed by default is a showstopper IMHO. Else
we could ship KDevelop with KDE4.0 as well, or quanta. Or anything in
playground.

Andreas

-- 
Stay away from hurricanes for a while.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Luciano Montanaro
Il Wednesday 28 November 2007 19:13:44 Rex Dieter ha scritto:
> Andreas Pakulat wrote:
> > I'd like to add a new showstopper to the 4.0 release goals. lskat from
> > kdegames is completely unusable since revision 731909.
>
> Maybe I'm dense or naive or missing something, but an unusable *game*
> being a release showstopper?  Seriously?

It can be a stopper for the release of said game, at least.

Luciano
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Rex Dieter
Andreas Pakulat wrote:

> I'd like to add a new showstopper to the 4.0 release goals. lskat from
> kdegames is completely unusable since revision 731909. 

Maybe I'm dense or naive or missing something, but an unusable *game* 
being a release showstopper?  Seriously?

-- Rex
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Andreas Pakulat
On 28.11.07 18:56:57, Thomas Zander wrote:
> On Wednesday 28. November 2007 18:37:13 Andreas Pakulat wrote:
> > I'd like to add a new showstopper to the 4.0 release goals. lskat from
> > kdegames is completely unusable since revision 731909.
> 
> Can you revert the bad change?

I could, but I'm not the maintainer of that app and I'm in no way
involved with kdegames (I just happen to play them). So I'd rather wait
for a few days to see if its being fixed, lets say until the weekend?

And btw, the second issue I reported (the hidden-cards not visible) is a
separate bug, introduced a few revisions earlier. And that one has quite
some unrelated changes with it, so I'd like to not just revert that
whole commit. (Bugreport: http://bugs.kde.org/show_bug.cgi?id=153076)

Andreas

-- 
Tomorrow, you can be anywhere.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: new showstopper in kdegames

2007-11-28 Thread Thomas Zander
On Wednesday 28. November 2007 18:37:13 Andreas Pakulat wrote:
> I'd like to add a new showstopper to the 4.0 release goals. lskat from
> kdegames is completely unusable since revision 731909.

Can you revert the bad change?

-- 
Thomas Zander


signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


new showstopper in kdegames

2007-11-28 Thread Andreas Pakulat
Hi,

I'd like to add a new showstopper to the 4.0 release goals. lskat from
kdegames is completely unusable since revision 731909. The graphics
drawing code was changed to center the cards, but the code that finds
the right positions for clicks is still the old. Also the drawing of the
covered cards is not done anymore.

Bugreport: https://bugs.kde.org/show_bug.cgi?id=153072

I wasn't sure wether I should just add it to the wiki or ask here first.

Andreas

-- 
It was all so different before everything changed.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team