Re: Bug#855282: debsign: support .buildinfo files
On Mon, Mar 06, 2017 at 11:45:20PM -0500, James McCoy wrote: > On Thu, Feb 16, 2017 at 05:23:00PM +, Ximin Luo wrote: > > I've done an initial implementation here: > > > > https://anonscm.debian.org/cgit/collab-maint/devscripts.git/log/?h=pu/debsign-buildinfo > > > > Please review! > > This was merged and uploaded in 2.17.2. However, now I see that > buildinfo files may be arch-qualified even with a _source.changes (e.g., > by using "sbuild -A --source-only-changes"). That's not currently > handled properly since "debsign foo_ver_source.changes" expects > "foo_ver_source.buildinfo" to exist. > > Should debsign be deriving the path for the buildinfo from the contents > of the changes file? I've changed all of the "child file" handling to use this approach in 4a4238dbf1e789e998cf047ea0f006e982fba56b. That seems cleaner than debsign replicating logic to determine the names of related files. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: Bug#855282: debsign: support .buildinfo files
On Thu, Feb 16, 2017 at 05:23:00PM +, Ximin Luo wrote: > I've done an initial implementation here: > > https://anonscm.debian.org/cgit/collab-maint/devscripts.git/log/?h=pu/debsign-buildinfo > > Please review! This was merged and uploaded in 2.17.2. However, now I see that buildinfo files may be arch-qualified even with a _source.changes (e.g., by using "sbuild -A --source-only-changes"). That's not currently handled properly since "debsign foo_ver_source.changes" expects "foo_ver_source.buildinfo" to exist. Should debsign be deriving the path for the buildinfo from the contents of the changes file? Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: Bug#855282: debsign: support .buildinfo files
On Wed, Mar 01, 2017 at 02:58:29AM +0100, Guillem Jover wrote: > Hi! > > On Fri, 2017-02-17 at 06:08:25 +0100, Guillem Jover wrote: > > On Thu, 2017-02-16 at 17:23:00 +, Ximin Luo wrote: > > > Control: tags + patch > > > > > I've done an initial implementation here: > > > > > > https://anonscm.debian.org/cgit/collab-maint/devscripts.git/log/?h=pu/debsign-buildinfo > > > > > > Please review! > > > > I think something like the attached patch on top of your branch HEAD > > is also needed. > > Here's another patch to support the finalized format 1.0 sitting now > in dpkg's git master, pending upload to unstable. Merged. Thanks! Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Re: Moving towards a deb-buildinfo(5) Format 1.0
On Sun, Feb 19, 2017 at 06:52:16PM +0100, Guillem Jover wrote: > Hi! > > On Sat, 2016-11-12 at 19:04:53 +0100, Guillem Jover wrote: > > As I've mentioned elsewhere, I've noticed several things with the > > current .buildinfo format, even after the cleanup pre-merge, that > > I'd like to fix or change so that we can hopefully reach Format 1.0. > > Ok, let's see what's the current status: > > > Some of the issues, that bother me: > > > > * .buildinfo files are not currently signed > > Fixed. Pending debsign (from devscipts) doing the same. Merged this tonight, but still need to get release team approval to make it into Stretch. Additional changes would be necessary if the declared Format changes, since debsign takes precautions about acting on a newer Format than it is known to grok. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
