[request-sponsor] Sponsor for Bug ID 6593960 - toupper() bug in /usr/xpg4/bin/awk
This bug is already fixed in Nevada.
~Kini
On Fri, 4 Jan 2008 17:48 -, arjun vasudev wrote:
}
}Hi I would like to work on bug ID 6593960 Synopsis ::toupper() bug in
/usr/xpg4/bin/awk
}Category:Subcategory utility:text
}
}Brief Description The following awk script behaves differently on SPARC vs
x86. We believethe x86 implementation is buggy.$ uname -srp && echo "1.abc" \
| /usr/xpg4/bin/awk '$1 == toupper($1) { print $1 }'SunOS 5.10 i3861.abc$$
uname -srp && echo "1.abc" \ | /usr/xpg4/bin/awk '$1 == toupper($1) { print $1
}'SunOS 5.10 sparc
}
}
} I don't have the fix ready yet.I'm working on it and hope to
}get the fix done in a
week.http://bugs.opensolaris.org/view_bug.do?bug_id=6593960 My SCA number is
OS0146Thanks & RegardsArjun.VAmrita University1st Year Computer Science
Engineering
}_
}Tried the new MSN Messenger? It?s cool! Download now.
}http://messenger.msn.com/Download/Default.aspx?mkt=en-in
}
--
Sun Microsystems - India Engineering Centre
http://blogs.sun.com/jkini
[request-sponsor] Fix for bug - 6604652
I'll sponsor this fix.
Ceri is correct about the current status of the fix.
Ceri Davies wrote:
> On Tue, Jan 29, 2008 at 11:50:12AM +0530, Abhilash wrote:
>
>> Sir,
>>
>> Me Abhilash T.g and Arjun Asok have a fix for the bug 6604652. We are the
>> students of amrita university.
>>
>> Abhilash oso183
>> Arjun oso211
>>
>> the synopsis is
>>
>>
>>
>> See the following log:
>>
>> bash-3.00# mount installtest:/export /mnt
>> bash-3.00# share /mnt
>> NFS: Cannot share filesystems in non-global zones: /mnt
>> Could not share: /mnt: operation not supported
>> bash-3.00# zonename
>> global
>>
>> The "non-global zone" error message was incorrect. The correct one
>> should be something like "Cannot share remote filesystem: /mnt".
>>
>> This seems to be caused by a copy-and-paste typo in the following
>> code in nfs_enable_share():
>>
>> case EREMOTE:
>> (void) printf(dgettext(TEXT_DOMAIN,
>> "NFS: Cannot share filesystems "
>> "in non-global zones: %s\n"), path);
>>err = SA_NOT_SUPPORTED;
>> break;
>>
>>
>> We are attaching the diff file
>>
>> Abhilash
>> Arjun
>>
>
>
>> --- libshare_nfs.c.orig Tue Oct 2 19:44:24 2007
>> +++ libshare_nfs.c Tue Jan 29 12:00:05 2008
>> @@ -1803,7 +1803,7 @@
>> switch (errno) {
>> case EREMOTE:
>> (void) printf(dgettext(TEXT_DOMAIN,
>> -"NFS: Cannot share filesystems "
>> +"NFS: Cannot share remote filesystems "
>> "in non-global zones: %s\n"), path);
>>
>
> This error message is still incorrect. The example above is a global
> zone.
>
> Ceri
>
>
>
> ___
> request-sponsor mailing list
> request-sponsor at opensolaris.org
>
[request-sponsor] sponsorship of "6650096 resync scp(1) with OpenSSH"
hi, I mistakenly deleted the request for sponsorship so I would like to state that I can sponsor Visakh (OS0192) for this RFE. thanks, Jan. -- Jan Pechanec
[request-sponsor] Fwd: Bug fix
- Forwarded Message - From: "Abhilash" To: "Jayakara Kini" Sent: Monday, January 28, 2008 6:48:35 PM (GMT+0530) Asia/Calcutta Subject: Bug fix Sir, Me and arjun has fixed a bug. The diff file os attached. Just see it. Pls do reply if correct. Abhilash Arjun -- next part -- An embedded and charset-unspecified text was scrubbed... Name: diff_ftpd.c.txt URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/7df0080f/attachment.txt>
[request-sponsor] Bug 6604652 sharemgr: incorrect error message when sharing a remote filesystem
Hi. I am Rishi M Nair from Amrita Vishwa Vidyapeetham. me (Rishi M Nair) (OS0148 - rishios) and jazarine (just applied for a SCA) are interested in working on bugid 6604652 Bug ID -6604652 Synopsis - sharemgr: incorrect error message when sharing a remote filesystem Category:Subcategory -utility:filesystem -- Thanks & Regards Rishi M Nair -- next part -- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/e88a64e0/attachment.html>
[request-sponsor] bug 6579865 zone_rctl_name incorrectly used like a char * in libzonecfg.c
Hi. I am Rishi M Nair from Amrita Vishwa Vidyapeetham. me (Rishi M Nair) (OS0148 - rishios) and jazarine (just applied for a SCA) are interested in working on bugid 6579865 Bug ID -6579865 Synopsis - zone_rctl_name incorrectly used like a char * in libzonecfg.c Category:Subcategory -utility:zones -- Thanks & Regards Rishi M Nair -- next part -- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/0074d3b9/attachment.html>
[request-sponsor] Request Sponsor for 6613349
>> My personal stance on this one is that it'd be a good idea to report the
>> mountpoint instead of the device major/minor. What did you have in mind ?
>
>Here's what I was thinking:
>
>--- a/usr/src/uts/common/os/exec.c Mon Oct 08 20:24:50 2007 -0700
>+++ b/usr/src/uts/common/os/exec.c Fri Oct 05 17:02:44 2007 -0600
>@@ -604,8 +604,12 @@ gexec(
>if ((vp->v_vfsp->vfs_flag & VFS_NOSETUID) &&
>(vattr.va_mode & (VSUID|VSGID))) {
>cmn_err(CE_NOTE,
>- "!%s, uid %d: setuid execution not allowed, dev=%lx",
>- exec_file, cred->cr_uid, vp->v_vfsp->vfs_dev);
>+ "zone: %s, uid %d: setuid execution not allowed, "
>+ "file=%s",
>+ cred->cr_zone->zone_name, cred->cr_uid,
>args->pathname);
>
>I wasn't sure what things in the vnode might be valid for use in this
>context (i.e. would vp->v_vfsp->vfs_mntpt be safe to deference),
>however the args struct from all appearances seems to be safe. For
>me, I'm more interested in knowing what was being run (or attempted at
>least). exec_file appears (if I'm understanding the code correctly)
>to be the unresolved path, while args->pathname appears to be the
>resolved pathname.
Note that args->pathname may be an simple relative pathname.
Why have you removed the initial '!' from the message?
It has special meaning to cmn_err.
>I was also wondering if perhaps instead of cmn_err, if it should be
>zcmn_err instead -- seems like it should go to the zone's console
>where the suid violation occurred instead of always to the global zone
>(or perhaps both).
>
>If you have any suggestions on that, please let me know (though I'm
>guessing it'd be better to move the discussion to a different list if
>more discussion is needed). If not, I'll try to get you a build log
>from that sometime in the next few days.
May I suggest opensolaris-code?
Casper
[request-sponsor] Fix for bug-6440628
On Tue, Jan 29, 2008 at 12:16:12PM +0530, Abhilash wrote:
> Sir,
>
> I Abhilash T.G and Arjun Asok of Amrita University Abhilash oso183 and
> Arjun oso211 have a fix for the bug 6440628 .
> we are attaching the diff.
Hmm. I am about to sound quite negative, but I aim to help; please
don't be disheartened.
> --- ipseckey.c.orig Tue Oct 2 19:45:09 2007
> +++ ipseckey.cTue Jan 29 12:30:53 2008
> @@ -3053,7 +3053,11 @@
>
> if (argc == 0)
> return;
> - cmd = parsecmd(*argv++);
> + if (fopen(*(argv+1)){
> + cmd = parsecmd(*argv++);}
> + else{
> + ERROR(ep, ebuf, gettext("This is not a valid file name"));
> + }
Firstly, your style is rather strange. Please add whitespace where it
would help for readability. Also, the indentation makes it difficult to
see where blocks begin and end and you should try to mimic the style of
the file that you are modifying. Your change would be much more
readable as:
if (fopen(*(argv+1)) {
cmd = parsecmd(*argv++);
} else {
ERROR(ep, ebuf, gettext("This is not a valid file name"));
}
Secondly, your code doesn't compile. In the first case, a closing
parenthesis is missing from the "if (fopen..." line. In the second,
fopen() takes two arguments.
Thirdly, the ERROR() macro doesn't cease execution and the FATAL() macro
would be a better choice.
Fourthly, I don't like the message "This is not a valid file name".
The error message should be both exact and precise - it should include
the filename concerned and state exactly what the error was.
Finally, this check should take place during argument parsing in main().
Ceri
--
That must be wonderful! I don't understand it at all.
-- Moliere
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/edd50b6c/attachment.bin>
[request-sponsor] Fix for bug-6440628
Sir, I Abhilash T.G and Arjun Asok of Amrita University Abhilash oso183 and Arjun oso211 have a fix for the bug 6440628 . we are attaching the diff. the synopsis is A student in my class today made a typo like this: # ipseckey -f /etc/inet/secret ipseckeys ipseckey: Unknown command (?). ipseckey: Parse error on line 1. ipseckey is apparently trying to parse a directory. Abhilash Arjun -- next part -- An embedded and charset-unspecified text was scrubbed... Name: diff_ipseckey.txt URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/07425065/attachment.txt>
[request-sponsor] request for bug-6440628
Sir, I Abhilash T.G and Arjun Asok of Amrita University Abhilash oso183 and Arjun oso211 would like towork on te bug 6440628 . the synopsis is A student in my class today made a typo like this: # ipseckey -f /etc/inet/secret ipseckeys ipseckey: Unknown command (?). ipseckey: Parse error on line 1. ipseckey is apparently trying to parse a directory. Abhilash Arjun
[request-sponsor] Fix for bug - 6604652
Sir, Me Abhilash T.g and Arjun Asok have a fix for the bug 6604652. We are the students of amrita university. Abhilash oso183 Arjun oso211 the synopsis is See the following log: bash-3.00# mount installtest:/export /mnt bash-3.00# share /mnt NFS: Cannot share filesystems in non-global zones: /mnt Could not share: /mnt: operation not supported bash-3.00# zonename global The "non-global zone" error message was incorrect. The correct one should be something like "Cannot share remote filesystem: /mnt". This seems to be caused by a copy-and-paste typo in the following code in nfs_enable_share(): case EREMOTE: (void) printf(dgettext(TEXT_DOMAIN, "NFS: Cannot share filesystems " "in non-global zones: %s\n"), path); err = SA_NOT_SUPPORTED; break; We are attaching the diff file Abhilash Arjun -- next part -- An embedded and charset-unspecified text was scrubbed... Name: diff_libshare_nfs.c URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/cc576a8d/attachment.c>
[request-sponsor] Fix for bug -6636679
Sir, Here is the fix for bug 6636679. We are the students of amrita university. Our sca numbers are Abhilash oso183 Arjun oso211 The bug synopsis is. ahl 12.3.2007] The error message for EZFS_ISCSISVCUNAVAIL is as follows: iscsitgt service need to be enabled by a privileged user s/need/needs/; The diff file is attached. Abhilash Arjun -- next part -- An embedded and charset-unspecified text was scrubbed... Name: diff_libzfs_util.c URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/09f6bf98/attachment.c>
[request-sponsor] Request for bug-6561465
Sir, I abhilash and arjun, Students of amrita university would lioke to work on the bug 6561465 . My sca number is oso183 and arjuns is oso211. The synopsis is The file /usr/lib/help/auths/locale/C/SmfAutofsStates.html has a typo. The text says "Authorizations Include" and should say "Authorizations Included". Looking at file in smc and the reason is obvious. Abhilash Arjun
[request-sponsor] Request for bug-6604652
Sir, I abhilash and arjun, Students of amrita university would lioke to work on the bug 6604652. My sca number is oso183 and arjuns is oso211. The synopsis is See the following log: bash-3.00# mount installtest:/export /mnt bash-3.00# share /mnt NFS: Cannot share filesystems in non-global zones: /mnt Could not share: /mnt: operation not supported bash-3.00# zonename global The "non-global zone" error message was incorrect. The correct one should be something like "Cannot share remote filesystem: /mnt". This seems to be caused by a copy-and-paste typo in the following code in nfs_enable_share(): case EREMOTE: (void) printf(dgettext(TEXT_DOMAIN, "NFS: Cannot share filesystems " "in non-global zones: %s\n"), path); err = SA_NOT_SUPPORTED; break; Abhilash Arjun
[request-sponsor] Bug 6604652 sharemgr: incorrect error message when sharing a remote filesystem
Someone else already submitted a patch for this a few hours ago. Ceri On Tue, Jan 29, 2008 at 04:29:25PM +0530, Rishi M Nair wrote: > Hi. > I am Rishi M Nair from Amrita Vishwa Vidyapeetham. > me (Rishi M Nair) (OS0148 - rishios) and jazarine (just applied for a SCA) > are > interested in working on bugid 6604652 > > Bug ID -6604652 > Synopsis - sharemgr: incorrect error message when sharing a remote > filesystem > Category:Subcategory -utility:filesystem > > > > -- > Thanks & Regards > Rishi M Nair > ___ > request-sponsor mailing list > request-sponsor at opensolaris.org -- That must be wonderful! I don't understand it at all. -- Moliere -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/84b558bc/attachment.bin>
[request-sponsor] Fix for bug - 6604652
On Tue, Jan 29, 2008 at 11:50:12AM +0530, Abhilash wrote:
> Sir,
>
> Me Abhilash T.g and Arjun Asok have a fix for the bug 6604652. We are the
> students of amrita university.
>
> Abhilash oso183
> Arjun oso211
>
> the synopsis is
>
>
>
> See the following log:
>
> bash-3.00# mount installtest:/export /mnt
> bash-3.00# share /mnt
> NFS: Cannot share filesystems in non-global zones: /mnt
> Could not share: /mnt: operation not supported
> bash-3.00# zonename
> global
>
> The "non-global zone" error message was incorrect. The correct one
> should be something like "Cannot share remote filesystem: /mnt".
>
> This seems to be caused by a copy-and-paste typo in the following
> code in nfs_enable_share():
>
> case EREMOTE:
> (void) printf(dgettext(TEXT_DOMAIN,
> "NFS: Cannot share filesystems "
> "in non-global zones: %s\n"), path);
>err = SA_NOT_SUPPORTED;
> break;
>
>
> We are attaching the diff file
>
> Abhilash
> Arjun
> --- libshare_nfs.c.orig Tue Oct 2 19:44:24 2007
> +++ libshare_nfs.cTue Jan 29 12:00:05 2008
> @@ -1803,7 +1803,7 @@
> switch (errno) {
> case EREMOTE:
> (void) printf(dgettext(TEXT_DOMAIN,
> - "NFS: Cannot share filesystems "
> + "NFS: Cannot share remote filesystems "
> "in non-global zones: %s\n"), path);
This error message is still incorrect. The example above is a global
zone.
Ceri
--
That must be wonderful! I don't understand it at all.
-- Moliere
-- next part ------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/request-sponsor/attachments/20080129/797345cf/attachment.bin>
[request-sponsor] Fix for bug-6440628
Ceri Davies writes:
> > - cmd = parsecmd(*argv++);
> > + if (fopen(*(argv+1)){
[...]
> Finally, this check should take place during argument parsing in main().
More comments:
- Why "*(argv+1)"? What's wrong with the equivalent but clearer
argv[1]?
- Won't this change -- if it could be made to compile -- just dump
core? The previous code dereferenced argv *first*, and *then*
incremented the pointer. You've changed that to skip over the
first argument, and then (with the "+1") dereference the second,
and to leave argv still pointing at the first argument.
- The return value from fopen is discarded after being checked
(implicitly against NULL). Besides the usual ON rule that
pointers aren't booleans and shouldn't be tested that way, this
call leaks the file handle returned by fopen. Are you sure you
wanted to open the file at all?
Don't expect your code reviewers or sponsor or random contributors on
request-sponsor to make your code compile or fix the design. Please
make it right _first_, and then seek a review.
--
James Carlson, Solaris Networking
Sun Microsystems / 35 Network Drive71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
[request-sponsor] Request Sponsor for 6613349
On Jan 28, 2008 6:11 AM, wrote:
> On Fri, 25 Jan 2008, Jason King wrote:
>
>
> > I'm going to try again...
> >
> > I'd like to request a sponsor for 6613349
> > My contributor # is 0137
>
>
> Hi Jason,
>
> has anyone offered to sponsor you on that one yet ?
Not yet
>
> If not I'd be willing to do it. Have you got diffs + build logs already ?
I seem to have cleaned out my build logs when I originally did this
(I'll try to rebuild sometime in the next few days)
>
> My personal stance on this one is that it'd be a good idea to report the
> mountpoint instead of the device major/minor. What did you have in mind ?
Here's what I was thinking:
--- a/usr/src/uts/common/os/exec.c Mon Oct 08 20:24:50 2007 -0700
+++ b/usr/src/uts/common/os/exec.c Fri Oct 05 17:02:44 2007 -0600
@@ -604,8 +604,12 @@ gexec(
if ((vp->v_vfsp->vfs_flag & VFS_NOSETUID) &&
(vattr.va_mode & (VSUID|VSGID))) {
cmn_err(CE_NOTE,
- "!%s, uid %d: setuid execution not allowed, dev=%lx",
- exec_file, cred->cr_uid, vp->v_vfsp->vfs_dev);
+ "zone: %s, uid %d: setuid execution not allowed, "
+ "file=%s",
+ cred->cr_zone->zone_name, cred->cr_uid, args->pathname);
I wasn't sure what things in the vnode might be valid for use in this
context (i.e. would vp->v_vfsp->vfs_mntpt be safe to deference),
however the args struct from all appearances seems to be safe. For
me, I'm more interested in knowing what was being run (or attempted at
least). exec_file appears (if I'm understanding the code correctly)
to be the unresolved path, while args->pathname appears to be the
resolved pathname.
I was also wondering if perhaps instead of cmn_err, if it should be
zcmn_err instead -- seems like it should go to the zone's console
where the suid violation occurred instead of always to the global zone
(or perhaps both).
If you have any suggestions on that, please let me know (though I'm
guessing it'd be better to move the discussion to a different list if
more discussion is needed). If not, I'll try to get you a build log
from that sometime in the next few days.
>
> Thx,
> FrankH.
>
[request-sponsor] Bug: 6280513
Avinash, I'll sponsor you for this bug. Let's take further discussion out of the list. Antonello Avinash Joshi wrote: > Can someone please help me out with this bug?? > > I got the souce making the function call scf_instance_add_pg at: > usr/src/cmd/init/init.c: line 3379 > > and also the function definition of scf_instance_add_pg at > usr/src/lib/libscf/common/lowlevel.c: line 2695 > This returns a value(probably an error value) using the function call ( > datael_add_pg ) whose definition is at: usr/src/lib/libscf/common/lowlevel.c: > line 1907 > > I was trying to link 'em all but was not able to figure out how the process > in the init.c goes :( > > PS: I am still awaiting a sponsor for this bug > > Thanks & Regards, > Avinash Joshi > > > This message posted from opensolaris.org > ___ > request-sponsor mailing list > request-sponsor at opensolaris.org
[request-sponsor] bug 6579865 zone_rctl_name incorrectly used like a char * in libzonecfg.c
Rishi M Nair wrote: > Hi. > I am Rishi M Nair from Amrita Vishwa Vidyapeetham. > me (Rishi M Nair) (OS0148 - rishios) and jazarine (just applied for a SCA) > are > interested in working on bugid 6579865 > > Bug ID -6579865 > Synopsis - zone_rctl_name incorrectly used like a char * in libzonecfg.c > Category:Subcategory -utility:zones Somebody else already submitted a request to work on this last Saturday. Jerry
[request-sponsor] bug 6527047 zonecfg shouldn't use two different boolean types
Rishi M Nair wrote: > Hi. > I am Rishi M Nair from Amrita Vishwa Vidyapeetham. > me (Rishi M Nair) (OS0148 - rishios) and jazarine (just applied for a SCA) > are > interested in working on bugid 6527047 > > Bug ID -6527047 > Synopsis - zonecfg shouldn't use two different boolean types > Category:Subcategory -utility:zones I will sponsor this one. Jerry
[request-sponsor] Request Sponsor for bug:6579865
Deepthj Devaki wrote: > Hi, > > We are Deepthi Devaki A R (SCA No OS0172) and R Vidya Lakshmi(SCA No OS0171) > from Amrita University. > > We are working on the bug id :6579865 > We have fixed the bug. > > Bug ID 6579865 > Synopsis zone_rctl_name incorrectly used like a char * in libzonecfg.c > Category:Subcategory utility:zones > > Thanks and regards > Deepthi Devaki A R > R Vidya Lakshmi I will sponsor this. Jerry
[request-sponsor] Bug: 6280513
Can someone please help me out with this bug?? I got the souce making the function call scf_instance_add_pg at: usr/src/cmd/init/init.c: line 3379 and also the function definition of scf_instance_add_pg at usr/src/lib/libscf/common/lowlevel.c: line 2695 This returns a value(probably an error value) using the function call ( datael_add_pg ) whose definition is at: usr/src/lib/libscf/common/lowlevel.c: line 1907 I was trying to link 'em all but was not able to figure out how the process in the init.c goes :( PS: I am still awaiting a sponsor for this bug Thanks & Regards, Avinash Joshi This message posted from opensolaris.org
