Re: Upgraded from beta to 1.0 I am getting cache issues.

2009-06-23 Thread Sebastien Douche

On Tue, Jun 23, 2009 at 15:26, Mohamed Mansour m0.interact...@gmail.com wrote:

 Hello, I have updated codereview using rbsite but I am having refresh
 issues. For example, when I press refresh button on the site I see 1.0
 beta many times and sometimes I see 1.0 with the icon (non beta). It
 isn't my browsing cookies or client cache cause It is still happening.
 I really don't know what is wrong. The only thing that comes into mind
 is memcached, I tried restarting it and it still alternates between
 1.0beta and 1.0/

Restart (stop / start) Apache and memcached, erase browser cache data,
remove old eggs.
What's happen?



--
Sebastien Douche sdou...@gmail.com

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Upgraded from beta to 1.0 I am getting cache issues.

2009-06-23 Thread Mohamed Mansour

I will just use the pserver then, local didn't work for me so I am
just using:
:pserver:user:p...@192.168.0.100:/cvs

I don't understand why :local:/var/cvs didn't work.

Thanks!

On Jun 23, 10:22 am, Mohamed Mansour m0.interact...@gmail.com wrote:
 Hello,  restarting apache worked, now after upgrades my cvs root
 doesn't work anymore (somehow, it removed my db info for repositories,
 so I readded it) My cvs is is local located in /var/cvs/

 But I always get the following with the following :local:/var/cvs
 cvs checkout: cannot open /var/mmansour/.cvsignore: Permission denied
 cvs [checkout aborted]: Absolute module reference invalid: `/cvs/
 mercury/client/src/Test.java'

 Why does it look into /var/mmansour ? I am really getting confused.
 Note: mmansour is my username.

 On Jun 23, 10:07 am, Sebastien Douche sdou...@gmail.com wrote:



  On Tue, Jun 23, 2009 at 15:26, Mohamed Mansour m0.interact...@gmail.com 
  wrote:

   Hello, I have updated codereview using rbsite but I am having refresh
   issues. For example, when I press refresh button on the site I see 1.0
   beta many times and sometimes I see 1.0 with the icon (non beta). It
   isn't my browsing cookies or client cache cause It is still happening.
   I really don't know what is wrong. The only thing that comes into mind
   is memcached, I tried restarting it and it still alternates between
   1.0beta and 1.0/

  Restart (stop / start) Apache and memcached, erase browser cache data,
  remove old eggs.
  What's happen?

  --
  Sebastien Douche sdou...@gmail.com
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Problem after installing RB 1.0 - Images and CSSs not working

2009-06-23 Thread angeliti

Hi Christian,

Thanks for the fast answer.

I used the configuration file generated by rb-site, but changed

Directory c:/www/reviewboard/htdocs
AllowOverride All
/Directory

to

Directory c:/www/reviewboard/htdocs
Options Indexes FollowSymLinks
AllowOverride None
Order allow,deny
Allow from all
/Directory

because I was getting Access Denied errors.


The Apache error log says nothing, but the access.log file says this:

23/Jun/2009:18:08:06 -0700] GET /reviewboard/account/login/ HTTP/1.1
200 1238
127.0.0.1 - - [23/Jun/2009:18:08:07 -0700] GET /reviewboard/media/rb/
css/common.css?1245801653 HTTP/1.1 404 2653
127.0.0.1 - - [23/Jun/2009:18:08:07 -0700] GET /reviewboard/media/rb/
images/logo.png?1245801653 HTTP/1.1 404 2654


If I go to MYSITE/media I get:

* Log in
* - Register
* - Documentation
* - Bugs
* - Report bug

Review Board
1.0

* All review requests
* Groups
* Submitters

The page you were looking for does not exist.

If you're pretty sure this page does exist, try logging in and trying
again.


Thank you!!
Angel.-


On Jun 23, 6:04 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi,

 Did you use the configuration files generated by rb-site as a basis, or did
 you use and modify the one from the website? They're probably mostly the
 same, but it'll be good to know.

 Do your Apache error logs say anything about /media pointing to the wrong
 place? What do you see if you go to YOURSITE/media in your browser?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Tue, Jun 23, 2009 at 5:55 PM, angeliti angel...@gmail.com wrote:

  Hello!

  I'm trying to set up Review Board on Windows7 using the instructions
  in this webpage:
 http://waveydavey.wordpress.com/home/computing/installing-review-boar...

  Everything goes smoothly during the installation, but when I open my
  browser to access Review Board, all its web pages are displayed
  without images or format, that is, just plain text. It looks like
  there is some kind of problem loading CSSs and images...

  I'm using Apache, MySQL and modpython. I've installed Review Board in
  C:\www\reviewboard and the end of my httpd.conf file is this:

  VirtualHost *:8082
         ServerName AALEGRE-TEST1
         DocumentRoot c:/www/reviewboard/htdocs

         # Error handlers
         ErrorDocument 500 /errordocs/500.html

         # Serve django pages
         Location /
                 PythonPath ['c:/www/reviewboard/conf'] + sys.path
                 SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings
                 SetEnv PYTHON_EGG_CACHE c:/www/reviewboard/tmp/egg_cache
                 SetHandler mod_python
                 PythonHandler django.core.handlers.modpython
                 PythonAutoReload Off
                 PythonDebug Off
                 # Used to run multiple mod_python sites in the same apache
                 PythonInterpreter reviewboard_reviewboard
         /Location

         # Serve static media without running it through mod_python
         # (overrides the above)
         Location /media
                 SetHandler None
         /Location
         Location /errordocs
                 SetHandler None
         /Location

         Directory c:/www/reviewboard/htdocs
             Options Indexes FollowSymLinks
             AllowOverride None
             Order allow,deny
             Allow from all
         /Directory

         # Alias static media requests to filesystem
         Alias /media c:/www/reviewboard/htdocs/media
         Alias /errordocs c:/www/reviewboard/htdocs/errordocs
  /VirtualHost

  Review Board itself is working, it's only that it looks very very ugly
  without format or images!

  Thank you very much!
  Angel.-

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Problem after installing RB 1.0 - Images and CSSs not working

2009-06-23 Thread Christian Hammond
Everything looks sane as far as I can tell. I wonder if this is something
odd with Windows 7 (permissions somehow?)

Can you also attach your entire httpd.conf (or e-mail it to me directly if
you feel more comfortable).

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Tue, Jun 23, 2009 at 6:14 PM, angeliti angel...@gmail.com wrote:


 Hi Christian,

 Thanks for the fast answer.

 I used the configuration file generated by rb-site, but changed

 Directory c:/www/reviewboard/htdocs
 AllowOverride All
 /Directory

 to

 Directory c:/www/reviewboard/htdocs
Options Indexes FollowSymLinks
AllowOverride None
Order allow,deny
Allow from all
/Directory

 because I was getting Access Denied errors.


 The Apache error log says nothing, but the access.log file says this:

 23/Jun/2009:18:08:06 -0700] GET /reviewboard/account/login/ HTTP/1.1
 200 1238
 127.0.0.1 - - [23/Jun/2009:18:08:07 -0700] GET /reviewboard/media/rb/
 css/common.css?1245801653 HTTP/1.1 404 2653
 127.0.0.1 - - [23/Jun/2009:18:08:07 -0700] GET /reviewboard/media/rb/
 images/logo.png?1245801653 HTTP/1.1 404 2654


 If I go to MYSITE/media I get:

* Log in
* - Register
* - Documentation
* - Bugs
* - Report bug

 Review Board
 1.0

* All review requests
* Groups
* Submitters

 The page you were looking for does not exist.

 If you're pretty sure this page does exist, try logging in and trying
 again.


 Thank you!!
 Angel.-


 On Jun 23, 6:04 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi,
 
  Did you use the configuration files generated by rb-site as a basis, or
 did
  you use and modify the one from the website? They're probably mostly the
  same, but it'll be good to know.
 
  Do your Apache error logs say anything about /media pointing to the wrong
  place? What do you see if you go to YOURSITE/media in your browser?
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Tue, Jun 23, 2009 at 5:55 PM, angeliti angel...@gmail.com wrote:
 
   Hello!
 
   I'm trying to set up Review Board on Windows7 using the instructions
   in this webpage:
  http://waveydavey.wordpress.com/home/computing/installing-review-boar.
 ..
 
   Everything goes smoothly during the installation, but when I open my
   browser to access Review Board, all its web pages are displayed
   without images or format, that is, just plain text. It looks like
   there is some kind of problem loading CSSs and images...
 
   I'm using Apache, MySQL and modpython. I've installed Review Board in
   C:\www\reviewboard and the end of my httpd.conf file is this:
 
   VirtualHost *:8082
  ServerName AALEGRE-TEST1
  DocumentRoot c:/www/reviewboard/htdocs
 
  # Error handlers
  ErrorDocument 500 /errordocs/500.html
 
  # Serve django pages
  Location /
  PythonPath ['c:/www/reviewboard/conf'] + sys.path
  SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings
  SetEnv PYTHON_EGG_CACHE
 c:/www/reviewboard/tmp/egg_cache
  SetHandler mod_python
  PythonHandler django.core.handlers.modpython
  PythonAutoReload Off
  PythonDebug Off
  # Used to run multiple mod_python sites in the same
 apache
  PythonInterpreter reviewboard_reviewboard
  /Location
 
  # Serve static media without running it through mod_python
  # (overrides the above)
  Location /media
  SetHandler None
  /Location
  Location /errordocs
  SetHandler None
  /Location
 
  Directory c:/www/reviewboard/htdocs
  Options Indexes FollowSymLinks
  AllowOverride None
  Order allow,deny
  Allow from all
  /Directory
 
  # Alias static media requests to filesystem
  Alias /media c:/www/reviewboard/htdocs/media
  Alias /errordocs c:/www/reviewboard/htdocs/errordocs
   /VirtualHost
 
   Review Board itself is working, it's only that it looks very very ugly
   without format or images!
 
   Thank you very much!
   Angel.-

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2009-06-23 Thread codesite-noreply


Comment #5 on issue 658 by chipx86: Error : The patch to 'filepath'  
didn't apply cleanly.
http://code.google.com/p/reviewboard/issues/detail?id=658

This usually indicates that the revision is wrong. How was the diff  
generated, and
what repository type?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2009-06-23 Thread codesite-noreply


Comment #6 on issue 658 by manjunath.shiva: Error : The patch  
to 'filepath' didn't apply cleanly.
http://code.google.com/p/reviewboard/issues/detail?id=658

diff is generated on UNIX and copied from screen to windows and that was the
problem. Now he tried did an ftp and it worked. With the Review Baord 1.0  
facing
some problem for new request in two places. I am opening a new ticket  
shortly.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2009-06-23 Thread codesite-noreply


Comment #7 on issue 658 by chipx86: Error : The patch to 'filepath'  
didn't apply cleanly.
http://code.google.com/p/reviewboard/issues/detail?id=658

But how was the diff generated? What tool, parameters?

Copying from screen to windows will break things. I assume you mean  
copy/paste. That
won't necessarily get the right control characters (tabs, same type of  
newlines,
etc). You will need to transfer the file directly.

You also should look into using post-review, which will make life a lot  
easier.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2009-06-23 Thread codesite-noreply


Comment #8 on issue 658 by manjunath.shiva: Error : The patch  
to 'filepath' didn't apply cleanly.
http://code.google.com/p/reviewboard/issues/detail?id=658

diff was generated using cvs diff -u amuoci.c  amuoci.diff on UNIX. Here  
use made a
mistake of copy/paste from UNIX shell to Windows. Now it worked after ftp.
Sure, I will take a look into post-review and propose to our team hear.  
Thanks for
the tip!

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2009-06-23 Thread codesite-noreply


Comment #9 on issue 658 by manjunath.shiva: Error : The patch  
to 'filepath' didn't apply cleanly.
http://code.google.com/p/reviewboard/issues/detail?id=658

I tried with latest post-review version 0.8. The problem is we do have post-
review.exe so we need to use UWIN / MKS / Cigwin to run this script on  
Windows. It
would have been good if we have a post-review.exe stand alone application  
so user
can use it here. I have no problem of using without exe but others are not
comfortable.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2009-06-23 Thread codesite-noreply


Comment #10 on issue 658 by chipx86: Error : The patch to 'filepath'  
didn't apply cleanly.
http://code.google.com/p/reviewboard/issues/detail?id=658

Ah yeah, that's a potential problem for now. However, I do plan to get a
post-review.exe into the next release.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1181 in reviewboard: Wrong content of search-cron.conf after installation

2009-06-23 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1181 by msu...@redhat.com: Wrong content of search-cron.conf  
after installation
http://code.google.com/p/reviewboard/issues/detail?id=1181

What version are you running?
ReviewBoard-1.0

What's the URL of the page containing the problem?
installation

What steps will reproduce the problem?
1. install ReviewBoard (RB) on Linux
2. create new sit in /www/spacewalk-reviewboard and url will  be
/spacewalk/reviews
3. check /www/spacewalk-reviewboard/conf/search-cron.conf

What is the expected output? What do you see instead?
Actuall content:
# Incremental indices every 10 minutes
0,10,20,30,40,50 * * * *
/usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/cmdline/rbsite.pyc
manage /www/spacewalk-reviewboard index

# Do a full index once a week on Sunday at 2am
* 2 * * 0
/usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/cmdline/rbsite.pyc
manage /www/spacewalk-reviewboard index -- --full

Expected content:
# Incremental indices every 10 minutes
0,10,20,30,40,50 * * * * python
/usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/cmdline/rbsite.py
manage /www/spacewalk-reviewboard index

# Do a full index once a week on Sunday at 2am
* 2 * * 0 python
/usr/lib/python2.4/site-packages/ReviewBoard-1.0-py2.4.egg/reviewboard/cmdline/rbsite.py
manage /www/spacewalk-reviewboard index -- --full

What operating system are you using? What browser?
Debian

Please provide any additional information below.
Please note missing  on first line. Pyc is not runnable by default.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1182 in reviewboard: Apache configuration file is misconfigured, if RB do not goes to root.

2009-06-23 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1182 by msu...@redhat.com: Apache configuration file is  
misconfigured, if RB do not goes to root.
http://code.google.com/p/reviewboard/issues/detail?id=1182

What version are you running?
1.5

What's the URL of the page containing the problem?
installation

What steps will reproduce the problem?
1. install ReviewBoard (RB) on Linux
2. create new sit in /www/spacewalk-reviewboard and url will  be
/spacewalk/reviews
3.  check /www/spacewalk-reviewboard/conf/apache-modpython.conf

What is the expected output? What do you see instead?
Location and Alias directives use /, whereas there obviously should be
/spacewalk/reviews

What operating system are you using? What browser?
Debian



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1182 in reviewboard: Apache configuration file is misconfigured, if RB do not goes to root.

2009-06-23 Thread codesite-noreply

Updates:
Status: NotABug

Comment #1 on issue 1182 by chipx86: Apache configuration file is  
misconfigured, if RB do not goes to root.
http://code.google.com/p/reviewboard/issues/detail?id=1182

This is actually by design in order to support some existing setups and  
older
versions of Django. We may move away from this at some point, but for now,  
it's
intentional.

The default configuration of Review Board expects to own the subdomain, and  
then the
site root is calculated at runtime. You're always free to modify the  
generated
configuration files.

The reason for this is that before, Django was unable to work in subdomains  
without
some hacks. We put some stuff in place to allow working in subdomains, and  
changing
our way of doing it now would break existing installs that rely on our  
workarounds.
Moving away from that is going to be a larger effort.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache

2009-06-23 Thread codesite-noreply

Updates:
Status: NeedInfo

Comment #1 on issue 1183 by chipx86: Viewing diff in review request causes  
traceback involving memcache
http://code.google.com/p/reviewboard/issues/detail?id=1183

Definitely never seen that before. Any chance you can provide us with a  
diff that
reproduces this problem for our unit tests?

Ideally, provide a dummy repository with some files, and a diff against  
that, so we
can bundle it and make sure this doesn't happen again. If it even is in our  
control.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---