Re: ClearCase and Reviewboard setup Continues...
I've only deployed RB with Clearcase for local testing, but the base path should just point to the server's view. It doesn't matter locally that that drive may or may not exist. Clearcase doesn't really fit into the model of the other supported scms where you can query it to find out the 'remote' repository. We could add an option to post- review to accept this path on the command line so it doesn't need to be hard-coded. I don't know if there's any way it could actually be stored as metadata in your view, like we do with other scms, though. Another thought -- maybe you could fill in the 'mirror path' in your configuration with a bogus name that's more user-friendly than 'y:/', like 'cc_vob_foo' and then specify that with post-review instead of 'y:/'. Dan On Jul 23, 1:47 am, Karthik karthikeyan1...@gmail.com wrote: Hi Dan, We have given the view drive (Y:/) as a base path directory in the post-review script and in the review board admin location. Does it hold good if we are going to run the common centralized review board server which will be used by group of people? What is the base path we can give in that situation? Because the drive letter is just the mapping or mounting of the view for a single user. Please let me know if you have any thoughts on this. Thanks, Karthik On Jul 23, 10:43 am, Karthik karthikeyan1...@gmail.com wrote: ( I was not able to post it in the same thread, it always error encountered). Hi, I could post the diff into the review board server. It is no more hanging after considering Dan's suggestion(Changing the repository path to the drive). I was facing another issue after this. When I click to see the view-diff in the review request, I was getting following error. [Errno 2] No such file or directory: 'd:\\temp\\reviewboard.7px08a\ \tmpgjsi_l-new' Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 131, in patch f = open(newfile, r) IOError: [Errno 2] No such file or directory: 'd:\\temp\\reviewboard. 7px08a\\tmpgjsi_l-ne I had to install the GNU-Patch.exe and put it under apache webserver bin path to solve this issue. As of now, everything seems to be going fine till now!! :) Thanks, Karthik --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: About post-review and mercurial
On Jul 20, 12:59 pm, Dan Savilonis d...@n-cube.org wrote:
Friendly reminder: please don't post passwords or other sensitive
information on the mailing list.
Thanks, but is just a test server and an inutile pass, strong? yes,
seem that my finger can't type a weak pass :)
What's happening is that it's falling through mercurial detection into
clearcase, and it fails to detect any vcs. It will test for a
mercurial-svn repository first, so you should expect that to fail
before it tries to detect a pure mercurial repo.
One thing to check:
run hg svn info
Does the response start with 'abort:'? If not, the script is looking
for this, and will assume it IS an hg-svn repo otherwise. This
actually looks like the only codepath that is possible (that I see)
given the debug trace you provided.
Dan
I'm don't know what happened and don't understand to much what you
said. I really want uses a mercurial extension(http://bitbucket.org/
ccaughie/mercurial-reviewboard/wiki/Home) instead of this review board
command, cause is more smooth. I'm reply this message because I'm
pretty sure that the solution(http://groups.google.com/group/
mercurial_general/t/b53558ae8182ba8c) that fix my problem using the
extension is the same that can be solve this problem and alway can
someone have the same problem:
In resume, I think that review board don't handle api request on an
installation with a root path different to '/' cause I reinstall
review board without any root path, I mean using '/' root path and all
work fine.
Thanks a lot for your reply Dan
Frank Abel
On Jul 20, 7:34 am, frankabel frank.abel...@gmail.com wrote:
Hi Christian!
First at all thanks for your reply.
Here the command with --debug and yes, hg is in my path, I type hg
and all if fine(I have hg installed using distro binaries, ubuntu 9.04
in my case), I even type hg root and all is fine, but what I see is
that svn(see below) isn't a hg command and not have idea of what is
cleartool pwv -short.
revision-range=35:38 hg root
hg svn info
cleartool pwv -short
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Cheers
Frank Abel
On Jul 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote:
Hi Frank,
It seems the line numbers have changed quite a bit between that version
and
SVN HEAD, but the first thing to check is that hg is in your path.
If you run with --debug, you'll get more information about what command
it's
trying to execute.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Jul 19, 2009 at 12:07 PM, frankabel frank.abel...@gmail.com
wrote:
Hi all,
Here what I get while trying uses post-review command inside a
mercurial repo:
$ post-review --server=https://frankabel.cujae.edu.cu/reviewboard/
reviewboard/
https://frankabel.cujae.edu.cu/reviewboard/%0Areviewboard/--username=frankabel
--password=PpMeOv606 --revision-
range=35:38
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File
Problems to configure Reviewboard with svn+ssh
Hello, Does somebody know how to configure Reviewboard to make it work with svn+ssh? I'm getting the error: Connection closed unexpected every time I try to create a New Review request. I'm using pre-commit reviews. Thanks in advance --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: About post-review and mercurial
Hmm, well the original debug output you posted indicated that it never
even got far enough to try to contact the server. If the mercurial
extension is now working, that's great, but it would be good to know
the post-review script is working as well.
Dan
On Jul 23, 3:20 pm, frankabel frank.abel...@gmail.com wrote:
On Jul 20, 12:59 pm, Dan Savilonis d...@n-cube.org wrote:
Friendly reminder: please don't post passwords or other sensitive
information on the mailing list.
Thanks, but is just a test server and an inutile pass, strong? yes,
seem that my finger can't type a weak pass :)
What's happening is that it's falling through mercurial detection into
clearcase, and it fails to detect any vcs. It will test for a
mercurial-svn repository first, so you should expect that to fail
before it tries to detect a pure mercurial repo.
One thing to check:
run hg svn info
Does the response start with 'abort:'? If not, the script is looking
for this, and will assume it IS an hg-svn repo otherwise. This
actually looks like the only codepath that is possible (that I see)
given the debug trace you provided.
Dan
I'm don't know what happened and don't understand to much what you
said. I really want uses a mercurial extension(http://bitbucket.org/
ccaughie/mercurial-reviewboard/wiki/Home) instead of this review board
command, cause is more smooth. I'm reply this message because I'm
pretty sure that the solution(http://groups.google.com/group/
mercurial_general/t/b53558ae8182ba8c) that fix my problem using the
extension is the same that can be solve this problem and alway can
someone have the same problem:
In resume, I think that review board don't handle api request on an
installation with a root path different to '/' cause I reinstall
review board without any root path, I mean using '/' root path and all
work fine.
Thanks a lot for your reply Dan
Frank Abel
On Jul 20, 7:34 am, frankabel frank.abel...@gmail.com wrote:
Hi Christian!
First at all thanks for your reply.
Here the command with --debug and yes, hg is in my path, I type hg
and all if fine(I have hg installed using distro binaries, ubuntu 9.04
in my case), I even type hg root and all is fine, but what I see is
that svn(see below) isn't a hg command and not have idea of what is
cleartool pwv -short.
revision-range=35:38 hg root
hg svn info
cleartool pwv -short
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Cheers
Frank Abel
On Jul 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote:
Hi Frank,
It seems the line numbers have changed quite a bit between that version
and
SVN HEAD, but the first thing to check is that hg is in your path.
If you run with --debug, you'll get more information about what command
it's
trying to execute.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Jul 19, 2009 at 12:07 PM, frankabel frank.abel...@gmail.com
wrote:
Hi all,
Here what I get while trying uses post-review command inside a
mercurial repo:
$ post-review --server=https://frankabel.cujae.edu.cu/reviewboard/
reviewboard/
https://frankabel.cujae.edu.cu/reviewboard/%0Areviewboard/--username=frankabel
--password=PpMeOv606 --revision-
range=35:38
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File
Issue 1229 in reviewboard: post-review could support git format-patch submission instead of diff submision
Comment #1 on issue 1229 by daniel.savilonis: post-review could support git format-patch submission instead of diff submision http://code.google.com/p/reviewboard/issues/detail?id=1229 At the time when I added pure git support to post-review, RB would hang if you sent a patch :) Sounds like someone fixed the diff parser to accept this. I'll look into this. It is preferable to send a patch, though the other half of this is actually using the commit numbers instead of file revisions on the server side. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1229 in reviewboard: post-review could support git format-patch submission instead of diff submision
Comment #2 on issue 1229 by d...@n-cube.org: post-review could support git format-patch submission instead of diff submision http://code.google.com/p/reviewboard/issues/detail?id=1229 At the time when I added pure git support to post-review, RB would hang if you sent a patch :) Sounds like someone fixed the diff parser to accept this. I'll look into this. It is preferable to send a patch, though the other half of this is actually using the commit numbers instead of file revisions on the server side. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
