Re: View Diff shows blank screen

[Christian Hammond]

Does the JavaScript console show any errors for the page?

Is this with Firefox? Installing the Firebug plugin may provide some more
useful information.

Also, is there any content on the page at all? If you view the source, is it
empty?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Aug 6, 2009 at 4:58 AM, Geetanjali  wrote:

>
> Hi,
>
> I have installed RB on linux for a project using subversion.
> After creating a review request, on clicking View Diff, I get a blank
> screen. The URL points to - http:///r/5/diff/
> #index_header
>
> There are no error messages in the logs. I have installed pysvn 1.6.3
> Can you please suggest any pointers to solve this issue.
>
> Thanks a lot.
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: post-review No JSON object could be decoded

[Christian Hammond]

It's possible the server is pushing gzip'd data, but for whatever reason
it's not being decoded. The only thing I can think of off-hand is that the
headers notifying that the content is encoded are dropped. Are you going
through a Proxy server at all?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Aug 7, 2009 at 9:59 AM, chihangid  wrote:

>
> One more thing, does this mean something wrong with the client side or
> the server side? I have 2 clients and they behave the same.
>
> On Aug 7, 9:38 am, chihangid  wrote:
> > Hi Christian,
> >
> > after I add the debig(data), it's printing some characters that
> > doesn't make sense. Looks like reading some binary file.
> >
> > Here is what I did:
> > def process_json(self, data):
> > """
> > Loads in aJSONfile and returns the data if successful. On
> > failure,
> > APIError is raised.
> > """
> > debug(data)
> > rsp = simplejson.loads(data)
> >
> > if rsp['stat'] == 'fail':
> > raise APIError, rsp
> >
> > return rsp
> >
> > Thanks,
> > Steven
> >
> > On Aug 6, 4:53 pm, Christian Hammond  wrote:
> >
> > > Well.. That's new.
> >
> > > We need more debugging information in order to figure this out. This
> will
> > > require manually editing the post-review script.
> >
> > > First, you'll need to locate the post-review.py file you installed (I
> assume
> > > you installed via easy_install RBTools, in which case it's in going to
> be in
> > > a site-packages/RBTools-*/scripts directory somewhere).
> >
> > > Then locate the process_json function (def process_json(self, data):).
> >
> > > Before the "rsp =json.loads(data)" function, add:
> >
> > > debug(data)
> >
> > > Make sure to use spaces for indentation.
> >
> > > Then try again, and there should be more debugging information.
> >
> > > Christian
> >
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.review-board.org
> > > VMware, Inc. -http://www.vmware.com
> >
> > > On Thu, Aug 6, 2009 at 3:42 PM, chihangid  wrote:
> >
> > > > I am using post-review to create a review. I did not change anything
> > > > on the server and it suddenly stops working.
> >
> > > > Here is the log with --debug on, I am using perforce. Any idea what
> > > > went wrong?
> >
> > > > C:\singe\depot>python post-review 36074 --debug
> > > > >>> p4 info
> > > > >>> repository info: Path: :1666, Base path: None, Supports
> changesets:
> > > > True
> > > > >>> p4 counters
> > > > >>> Generating diff for changenum 36074
> > > > >>> p4 describe -s 36074
> > > > >>> Processing edit of //depot/wcm/dev/releng/1
> > > > >>> Writing "//depot/wcm/dev/releng/1#25" to
> > > > "c:\docume~1\\locals~1\temp\tmpeuzeqx"
> > > > >>> p4 print -q //depot/wcm/dev/releng/1#25
> > > > >>> p4 where //depot/wcm/dev/releng/1
> > > > >>> diff -urNp c:\docume~1\\locals~1\temp\tmpeuzeqx
> > > > c:\singe\depot\wcm\dev\releng\1
> > > > >>> Looking for 'pfwebal01 /' cookie in C:\Documents and
> > > > Settings\\Local Settings\Application
> Data\.post-review-cookies.txt
> > > > >>> Cookie file loaded, but no cookie for this server
> > > > ==> Review Board Login Required
> > > > Enter username and password for Review Board athttp:///
> > > > Username: 
> > > > Password:
> > > > >>> Logging in with username ""
> > > > >>> HTTP POSTing tohttp:///api/json/accounts/login/:{'username':
> > > > , 'password': '**'}
> > > > >>> Logged in.
> > > > >>> Attempting to create review request for 36074
> > > > >>> HTTP POSTing tohttp:///api/json/reviewrequests/new/:
> > > > {'repository_path': :1666', 'ch
> > > > angenum': '36074'}
> > > > Traceback (most recent call last):
> > > >  File "post-review", line 5, in 
> > > >pkg_resources.run_script('rbtools==0.2beta1', 'post-review')
> > > >  File "C:\Python25\Lib\site-packages\pkg_resources.py", line 448, in
> > > > run_script
> > > >self.require(requires)[0].run_script(script_name, ns)
> > > >  File "C:\Python25\Lib\site-packages\pkg_resources.py", line 1173, in
> > > > run_script
> > > >exec script_code in namespace, namespace
> > > >  File "C:\singe\depot\post-review", line 2313, in 
> >
> > > >  File "C:\singe\depot\post-review", line 2295, in main
> >
> > > >  File "C:\singe\depot\post-review", line 1965, in tempt_fate
> >
> > > >  File "C:\singe\depot\post-review", line 372, in new_review_request
> >
> > > >  File "C:\singe\depot\post-review", line 569, in api_post
> >
> > > >  File "C:\singe\depot\post-review", line 480, in process_json
> >
> > > >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > > > \simplejson\__init__.py", line 307, in loads
> > > >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > > > \simplejson\decoder.py", line 335, in decode
> > > >  File "C:\Python25\lib\site-packages\simplejson-2

Re: How to connect comments and changes?

[Christian Hammond]

Hi Philipp,

All the discussion on a series of changes takes place on the review
request's page. You shouldn't really use the diff viewer for this. Migrating
comments across revisions of a diff is incredibly hard and impossible to do
successfully, consistently. You can't guarantee the lines will match up in
any way, and you could end up dropping comments or moving them onto the
wrong lines. They also might just be irrelevant.

We don't have any plans at all to even attempt something like this, as
that's really what the review request page is for. You can see a timeline of
all the reviews, the affected code, and you can always click on the header
for the block of code to jump to the right place in the diff.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Aug 7, 2009 at 6:29 AM, Philipp Henkel wrote:

>
> Hello,
>
> I'm new to Review Board and I would like to use it in combination with
> Perforce and post-review.
>
> There seems to be no strong connection of comments and code changes.
> In Diff View comments seem to be bound to single diffs. When you add a
> new diff it is difficult to match old comments and new changes because
> you don't see the previous comments. Questions like "Is every issue
> addressed?" or "What is the reason for that change?" cannot be
> answered immediately. You always have to go back to one of the
> previous diffs and search for the discussion.
>
> Our current review work flow is like this:
> 1. Create new request: add a large diff using post-review (might be a
> complete new feature)
> 2. Reviewer and Coder add comments to this diff
> 3. Coder applies changes and adds an updated diff using post-review
> 4. Reviewer is satisfied -> go to 5   or  next iteration is started ->
> go to 2.
> 5. Review done
>
> I know that RB is optimized for pre-commits and I assume that those
> pre-commits reviews tend to be much smaller than post-commits ones.
> However, perhaps there is a simple solution to my problem if I
> slightly change the work flow. Did I overlook something? Is it
> possible to show older comments in the latest diff? Would this be a
> nice feature?
>
> Best regards,
> Philipp
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Perforce server security level error when post a review

[Christian Hammond]

Hi Philipp,

We'd definitely take a patch that supports both methods.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Aug 7, 2009 at 5:18 AM, Philipp Henkel wrote:

>
> Hi,
>
> p4.run_login() is working for me if I set the user and password before
> each p4 login again. P4 seems to loose the values set in __init__
>
>def _connect(self):
>if not self.p4.connected():
>self.p4.connect()
>self.p4.user = self.user
>self.p4.password  = self.password
>self.p4.run_login()
>
> Furthermore I had to disable the usage of passwords in  method
> get_file to get RB fully working with Perforce:
>#if self.p4.password:
>#cmdline.extend(['-P', self.p4.password])
>
> Wouldn't it be a good idea to support both Perforce access approaches
> right from the scratch? If someone is interested in this I'm willing
> to help.
>
> Best regards,
> Philipp
>
>
> On Jul 21, 1:13 am, Yongqiang Li  wrote:
> > Thansk, Tom.
> >
> > Just as what you said, I need to modify the perforce.py and add
> run_login()
> > just behind self.p4.connect() in function _connect().
> >
> > I tried the p4.run_login() but it didn't work.
> > So I wrote my own run_login() as:
> > ===
> > def run_login(self):
> > os.popen('echo %s | p4 -p %s -u %s login -a' % (self.p4.password,
> > self.p4.port, self.p4.user))
> > ===
> >
> > Then everything is OK! RB is great!
> > Hope it's useful for other guys who have the same problem.
> >
> > Regards,
> > Yongqiang
> >
> > On Mon, Jun 29, 2009 at 8:34 AM, Tom Sakkos  wrote:
> > > I wouldn't know where to put this in ReviewBoard, but it's probably
> > > necessary to run "run_login()" on the p4 object immediately after
> running
> > > "connect()."
> >
> > > -Tom
> >
> > > On Mon, Jun 29, 2009 at 2:13 AM, Jason Lee 
> wrote:
> >
> > >> Hi guys,
> >
> > >> I met another problem when post a perforce review.
> >
> > >> I install the RB on Windows.
> > >> The command is : post-review.py -d 118527
> > >> And then I met a perforce exception.
> >
> > >> The logs are below:
> > >> 
> > >> P4Exception at /api/json/reviewrequests/new/
> >
> > >> [P4#run] Errors during command execution( "p4 describe -s 118527" )
> >
> > >>[Error]: Password not allowed at this server security level,
> use
> > >> 'p4
> > >> login'.
> >
> > >> Request Method: POST
> > >> Request URL:http://127.0.0.1:80/api/json/reviewrequests/new/
> > >> Exception Type: P4Exception
> > >> Exception Value:
> >
> > >> [P4#run] Errors during command execution( "p4 describe -s 118527" )
> >
> > >>[Error]: Password not allowed at this server security level,
> use
> > >> 'p4
> > >> login'.
> >
> > >> Exception Location: C:\Python25\lib\site-packages\P4.py in run,
> line
> > >> 284
> > >> Python Executable:  D:\Program Files\Apache Software Foundation
> > >> \Apache2.2\bin\httpd.exe
> > >> Python Version: 2.5.4
> > >> Python Path:
> > >> Server time:Fri, 26 Jun 2009 17:56:01 +0800
> > >> ===
> >
> > >> I think that's because of the higher P4 server security level. Because
> > >> when I use my own perforce server with default security level, I can
> > >> post the review successfully.
> >
> > >> Anyone knows how to fix this problem?
> > >> Thanks.
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard Reports

[Christian Hammond]

Hi Scott,

It's certainly possible that we're not catching those exceptions. I know
some are not caught and should be. However, if a failure to send an e-mail
appeared as an exception, the user should see it. So far the missing e-mail
reports suggest that nobody's seen any errors.

The e-mail code has moved into notifications/email.py in SVN, so if you're
working against a released version, you'll probably want to switch to SVN
for development before you do any more work.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Aug 7, 2009 at 7:19 AM, Scott Quesnelle
wrote:

> Christian,
>
> I thought it was a little hidden, like the iphone interface. Will get the
> changes together and post them in the next week or two.
>
> Also, there have been talks of the emails not being sent. I am currently
> debugging an issue like this, and noticed that because of the way that the
> message.send() is being done, none of the exceptions would be dealt with
> from the smtplib, or maybe I am just misreading the code.
>
> Scott
>
>
> On Thu, Aug 6, 2009 at 7:56 PM, Christian Hammond wrote:
>
>> Hi Scott,
>>
>> The reports feature was never fully completed, which is why it's sort of
>> hidden. We're probably going to make it a downloadable extension in 1.5 or
>> 2.0 and make it more public. For the time-being, though, if you have
>> patches, we'll certainly take a look and see about getting them into the
>> next release. Go ahead and post them to http://reviews.review-board.organd 
>> we'll look.
>>
>> Thanks!
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.review-board.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>>
>> On Thu, Aug 6, 2009 at 3:17 PM, Scott Quesnelle <
>> scott.quesne...@gmail.com> wrote:
>>
>>> Hello,
>>>
>>> Is anyone using the reports feature of reviewboard?
>>>
>>> I have noticed that there are a few things missing in it, and have done
>>> tidying up.
>>>
>>> I have added the period that the report covers to the title line, and
>>> also modified the template to properly deal with quotes and such. Both are
>>> minor changes, but not sure if its worth contributing the diffs back for
>>> mainline inclusion.
>>>
>>> Scott
>>>
>>>
>>>
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: TFS Support Anytime soon

[Christian Hammond]

Hi Jim,

Yes. If we have the ability to do that, then a tool can certainly be
written. Review Board doesn't need a whole lot generally in order to
interface with a server, but ths is hte one main requirement. I don't know
enough about TFS to know if this exists today. Being able to do it with a
remote repository would also be helpful, as opposed to requiring a local one
(though there are exceptions, such as Git, which doesn't let you look up a
file with a revision remotely).

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Aug 7, 2009 at 11:44 AM, Jim Deville  wrote:

> So are you looking for a tool similar to git show? So that you can ask the
> tool what   file x looked like at revision y?
>
>
>
> JD
>
>
>
> …there is no try
>
> http://blog.jredville.com
>
>
>
> *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
> *On Behalf Of *Christian Hammond
> *Sent:* Thursday, August 06, 2009 8:06 PM
>
> *To:* reviewboard@googlegroups.com
> *Subject:* Re: TFS Support Anytime soon
>
>
>
> Hi Jim,
>
> This is one thing that came up when I was discussing this with someone
> else. I think what I'd like to see is a tool that Review Board can use (much
> like it uses svn/cvs/etc) for the file lookups. That could be written in
> IronPython, C#, whatever. As long as it can be installed and Review Board
> can call it. I don't to deal with making sure Review Board stays compatible
> with IronPython, though, as it just increases are maintenance and support
> burden.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
> On Thu, Aug 6, 2009 at 5:50 PM, Jim Deville 
> wrote:
>
> What about using Codeplex to develop against and using IronPython to take
> advantage of the .NET API’s
>
>
>
> JD
>
>
>
> …there is no try
>
> http://blog.jredville.com
>
>
>
> *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
> *On Behalf Of *Christian Hammond
> *Sent:* Thursday, August 06, 2009 4:46 PM
> *To:* reviewboard@googlegroups.com
> *Subject:* Re: TFS Support Anytime soon
>
>
>
> Hi Bryan,
>
> People have talked about writing support for TFS, but so far nobody's
> committed to it. We've briefly looked into what it would take, and it seems
> somewhat complicated as there are no APIs we can use from Python. We also
> don't have access to a TFS server to develop against, which makes it
> difficult. If someone wants to step up and figure out TFS support, we'll be
> glad to work on getting it incorporated into Review Board, but until someone
> does, we can't commit to including it in any release.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
> On Thu, Aug 6, 2009 at 6:36 AM, Bryan  wrote:
>
>
> We are looking to use reviewboard on a project with source control in
> Team Foundation Server.  Are there any plans or any beta versions that
> include support for TFS as a code repository?
>
> -Bryan
>
>
>
>
>
>
>
>
>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

RE: TFS Support Anytime soon

[Jim Deville]

So are you looking for a tool similar to git show? So that you can ask the tool 
what   file x looked like at revision y?

JD

…there is no try
http://blog.jredville.com

From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On 
Behalf Of Christian Hammond
Sent: Thursday, August 06, 2009 8:06 PM
To: reviewboard@googlegroups.com
Subject: Re: TFS Support Anytime soon

Hi Jim,

This is one thing that came up when I was discussing this with someone else. I 
think what I'd like to see is a tool that Review Board can use (much like it 
uses svn/cvs/etc) for the file lookups. That could be written in IronPython, 
C#, whatever. As long as it can be installed and Review Board can call it. I 
don't to deal with making sure Review Board stays compatible with IronPython, 
though, as it just increases are maintenance and support burden.

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

On Thu, Aug 6, 2009 at 5:50 PM, Jim Deville 
mailto:jdevi...@microsoft.com>> wrote:

What about using Codeplex to develop against and using IronPython to take 
advantage of the .NET API’s



JD



…there is no try

http://blog.jredville.com



From: reviewboard@googlegroups.com 
[mailto:reviewboard@googlegroups.com] On 
Behalf Of Christian Hammond
Sent: Thursday, August 06, 2009 4:46 PM
To: reviewboard@googlegroups.com
Subject: Re: TFS Support Anytime soon



Hi Bryan,

People have talked about writing support for TFS, but so far nobody's committed 
to it. We've briefly looked into what it would take, and it seems somewhat 
complicated as there are no APIs we can use from Python. We also don't have 
access to a TFS server to develop against, which makes it difficult. If someone 
wants to step up and figure out TFS support, we'll be glad to work on getting 
it incorporated into Review Board, but until someone does, we can't commit to 
including it in any release.

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

On Thu, Aug 6, 2009 at 6:36 AM, Bryan 
mailto:rowe.br...@gmail.com>> wrote:

We are looking to use reviewboard on a project with source control in
Team Foundation Server.  Are there any plans or any beta versions that
include support for TFS as a code repository?

-Bryan







--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: post-review No JSON object could be decoded

[chihangid]

One more thing, does this mean something wrong with the client side or
the server side? I have 2 clients and they behave the same.

On Aug 7, 9:38 am, chihangid  wrote:
> Hi Christian,
>
> after I add the debig(data), it's printing some characters that
> doesn't make sense. Looks like reading some binary file.
>
> Here is what I did:
>     def process_json(self, data):
>         """
>         Loads in aJSONfile and returns the data if successful. On
> failure,
>         APIError is raised.
>         """
>         debug(data)
>         rsp = simplejson.loads(data)
>
>         if rsp['stat'] == 'fail':
>             raise APIError, rsp
>
>         return rsp
>
> Thanks,
> Steven
>
> On Aug 6, 4:53 pm, Christian Hammond  wrote:
>
> > Well.. That's new.
>
> > We need more debugging information in order to figure this out. This will
> > require manually editing the post-review script.
>
> > First, you'll need to locate the post-review.py file you installed (I assume
> > you installed via easy_install RBTools, in which case it's in going to be in
> > a site-packages/RBTools-*/scripts directory somewhere).
>
> > Then locate the process_json function (def process_json(self, data):).
>
> > Before the "rsp =json.loads(data)" function, add:
>
> >         debug(data)
>
> > Make sure to use spaces for indentation.
>
> > Then try again, and there should be more debugging information.
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Thu, Aug 6, 2009 at 3:42 PM, chihangid  wrote:
>
> > > I am using post-review to create a review. I did not change anything
> > > on the server and it suddenly stops working.
>
> > > Here is the log with --debug on, I am using perforce. Any idea what
> > > went wrong?
>
> > > C:\singe\depot>python post-review 36074 --debug
> > > >>> p4 info
> > > >>> repository info: Path: :1666, Base path: None, Supports 
> > > >>> changesets:
> > > True
> > > >>> p4 counters
> > > >>> Generating diff for changenum 36074
> > > >>> p4 describe -s 36074
> > > >>> Processing edit of //depot/wcm/dev/releng/1
> > > >>> Writing "//depot/wcm/dev/releng/1#25" to
> > > "c:\docume~1\\locals~1\temp\tmpeuzeqx"
> > > >>> p4 print -q //depot/wcm/dev/releng/1#25
> > > >>> p4 where //depot/wcm/dev/releng/1
> > > >>> diff -urNp c:\docume~1\\locals~1\temp\tmpeuzeqx
> > > c:\singe\depot\wcm\dev\releng\1
> > > >>> Looking for 'pfwebal01 /' cookie in C:\Documents and
> > > Settings\\Local Settings\Application Data\.post-review-cookies.txt
> > > >>> Cookie file loaded, but no cookie for this server
> > > ==> Review Board Login Required
> > > Enter username and password for Review Board athttp:///
> > > Username: 
> > > Password:
> > > >>> Logging in with username ""
> > > >>> HTTP POSTing tohttp:///api/json/accounts/login/:{'username':
> > > , 'password': '**'}
> > > >>> Logged in.
> > > >>> Attempting to create review request for 36074
> > > >>> HTTP POSTing tohttp:///api/json/reviewrequests/new/:
> > > {'repository_path': :1666', 'ch
> > > angenum': '36074'}
> > > Traceback (most recent call last):
> > >  File "post-review", line 5, in 
> > >    pkg_resources.run_script('rbtools==0.2beta1', 'post-review')
> > >  File "C:\Python25\Lib\site-packages\pkg_resources.py", line 448, in
> > > run_script
> > >    self.require(requires)[0].run_script(script_name, ns)
> > >  File "C:\Python25\Lib\site-packages\pkg_resources.py", line 1173, in
> > > run_script
> > >    exec script_code in namespace, namespace
> > >  File "C:\singe\depot\post-review", line 2313, in 
>
> > >  File "C:\singe\depot\post-review", line 2295, in main
>
> > >  File "C:\singe\depot\post-review", line 1965, in tempt_fate
>
> > >  File "C:\singe\depot\post-review", line 372, in new_review_request
>
> > >  File "C:\singe\depot\post-review", line 569, in api_post
>
> > >  File "C:\singe\depot\post-review", line 480, in process_json
>
> > >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > > \simplejson\__init__.py", line 307, in loads
> > >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > > \simplejson\decoder.py", line 335, in decode
> > >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > > \simplejson\decoder.py", line 353, in raw_decode
> > > ValueError: NoJSONobject could be decoded
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: post-review No JSON object could be decoded

[chihangid]

Hi Christian,

after I add the debig(data), it's printing some characters that
doesn't make sense. Looks like reading some binary file.

Here is what I did:
def process_json(self, data):
"""
Loads in a JSON file and returns the data if successful. On
failure,
APIError is raised.
"""
debug(data)
rsp = simplejson.loads(data)

if rsp['stat'] == 'fail':
raise APIError, rsp

return rsp

Thanks,
Steven



On Aug 6, 4:53 pm, Christian Hammond  wrote:
> Well.. That's new.
>
> We need more debugging information in order to figure this out. This will
> require manually editing the post-review script.
>
> First, you'll need to locate the post-review.py file you installed (I assume
> you installed via easy_install RBTools, in which case it's in going to be in
> a site-packages/RBTools-*/scripts directory somewhere).
>
> Then locate the process_json function (def process_json(self, data):).
>
> Before the "rsp = json.loads(data)" function, add:
>
>         debug(data)
>
> Make sure to use spaces for indentation.
>
> Then try again, and there should be more debugging information.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Thu, Aug 6, 2009 at 3:42 PM, chihangid  wrote:
>
> > I am using post-review to create a review. I did not change anything
> > on the server and it suddenly stops working.
>
> > Here is the log with --debug on, I am using perforce. Any idea what
> > went wrong?
>
> > C:\singe\depot>python post-review 36074 --debug
> > >>> p4 info
> > >>> repository info: Path: :1666, Base path: None, Supports changesets:
> > True
> > >>> p4 counters
> > >>> Generating diff for changenum 36074
> > >>> p4 describe -s 36074
> > >>> Processing edit of //depot/wcm/dev/releng/1
> > >>> Writing "//depot/wcm/dev/releng/1#25" to
> > "c:\docume~1\\locals~1\temp\tmpeuzeqx"
> > >>> p4 print -q //depot/wcm/dev/releng/1#25
> > >>> p4 where //depot/wcm/dev/releng/1
> > >>> diff -urNp c:\docume~1\\locals~1\temp\tmpeuzeqx
> > c:\singe\depot\wcm\dev\releng\1
> > >>> Looking for 'pfwebal01 /' cookie in C:\Documents and
> > Settings\\Local Settings\Application Data\.post-review-cookies.txt
> > >>> Cookie file loaded, but no cookie for this server
> > ==> Review Board Login Required
> > Enter username and password for Review Board athttp:///
> > Username: 
> > Password:
> > >>> Logging in with username ""
> > >>> HTTP POSTing tohttp:///api/json/accounts/login/:{'username':
> > , 'password': '**'}
> > >>> Logged in.
> > >>> Attempting to create review request for 36074
> > >>> HTTP POSTing tohttp:///api/json/reviewrequests/new/:
> > {'repository_path': :1666', 'ch
> > angenum': '36074'}
> > Traceback (most recent call last):
> >  File "post-review", line 5, in 
> >    pkg_resources.run_script('rbtools==0.2beta1', 'post-review')
> >  File "C:\Python25\Lib\site-packages\pkg_resources.py", line 448, in
> > run_script
> >    self.require(requires)[0].run_script(script_name, ns)
> >  File "C:\Python25\Lib\site-packages\pkg_resources.py", line 1173, in
> > run_script
> >    exec script_code in namespace, namespace
> >  File "C:\singe\depot\post-review", line 2313, in 
>
> >  File "C:\singe\depot\post-review", line 2295, in main
>
> >  File "C:\singe\depot\post-review", line 1965, in tempt_fate
>
> >  File "C:\singe\depot\post-review", line 372, in new_review_request
>
> >  File "C:\singe\depot\post-review", line 569, in api_post
>
> >  File "C:\singe\depot\post-review", line 480, in process_json
>
> >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > \simplejson\__init__.py", line 307, in loads
> >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > \simplejson\decoder.py", line 335, in decode
> >  File "C:\Python25\lib\site-packages\simplejson-2.0.9-py2.5-win32.egg
> > \simplejson\decoder.py", line 353, in raw_decode
> > ValueError: No JSON object could be decoded
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: "substring not found"

[Dan Savilonis]

Could you explain your workaround?

Are you using a snapshot view for post-review, the server, or both?
I've found that snapshot views don't work correctly with post-review,
and haven't tested with a snapshot view on the server side.

Dan

On Aug 6, 12:49 pm, MiZhKa  wrote:
> 3) WA was found and now request is created.
> Diff:
>
> --- c:\\vobs\Component_Name\source\org\buba\myjava.java   2002-02-21
> 23:30:39.942229878 -0800
> +++ c:\\vobs\Component_Name\source\org\buba\myjava.java   2002-02-21
> 23:30:50.442260588 -0800
> @@ -26,6 +26,7 @@
>                         throws RemoteException, CreateException,
> ServiceProvisioningException
>         {
>                 //TODO: may be isn't use
> +               // My face comment
>         }
>
>         @Override
>
> Michael
>
> On Aug 6, 7:50 pm, MiZhKa  wrote:
>
> > I've tried. Patch is useful. But I have several problems with snapshot
> > views:
> > 1) To create diff CHECKEDOUT file should be copied to temp folder
> > 2) I've set temp folder to C:\temp because error was occurred with C:
> > \Documents and Settings\\Temp
> > 3) Now I have problem with uploading of file to server. Server
> > invalidates diff with error:
> > cat: /mnt/ftpit/Stream_Name/Component_name/@@/main/0//
> > @@..myfile.java@@/@@/main/Stream_name/8: No such file or directory\n
>
> > I am diving deeper.
>
> > On Aug 5, 3:27 am, Dan Savilonis  wrote:
>
> > > Clearcase support only officially works through post-review since it
> > > needs to do some tricks to generate the diff. How did you create this
> > > fake diff? Can you try following the steps I provided in this thread
> > > and see if you are able to get it to 
> > > work?http://groups.google.com/group/reviewboard/browse_thread/thread/1a612...
>
> > > Dan
>
> > > On Aug 4, 4:07 pm, Christian Hammond  wrote:
>
> > > > Can you provide more information? I need to see the full error log.
>
> > > > Christian
>
> > > > --
> > > > Christian Hammond - chip...@chipx86.com
> > > > Review Board -http://www.review-board.org
> > > > VMware, Inc. -http://www.vmware.com
>
> > > > On Tue, Aug 4, 2009 at 9:34 AM, MiZhKa  wrote:
>
> > > > > Hi,
>
> > > > > I've installed Review Board 1.0.1 and added ClearCase repository. To
> > > > > test Review Board, I've prepared fake diff file:
>
> > > > > Index: configurations/demo/toolbox.jsp
> > > > > ===
> > > > > --- configurations/demo/toolbox.jsp     (label )
> > > > > +++ configurations/demo/toolbox.jsp     (label copy)
> > > > > @@ -4,6 +4,7 @@
>
> > > > > org.buba.ejb.session.custom.CustomXMLizerHome,
> > > > >                                 
> > > > > org.buba.ejb.session.custom.CustomXMLizer,
> > > > >                                 org.buba.ejb.framework.*,
> > > > > +                                java.math.BigInteger,
> > > > >                                 
> > > > > org.buba.ejb.session.common.CommonService,
>
> > > > > org.buba.ejb.session.common.CommonServiceHome,
> > > > >                                 java.util.Collection,
>
> > > > > As result the following error occurred: "substring not found".
> > > > > What can I do to resolve this problem?
>
>
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: ReviewBoard Reports

[Scott Quesnelle]

Christian,

I thought it was a little hidden, like the iphone interface. Will get the
changes together and post them in the next week or two.

Also, there have been talks of the emails not being sent. I am currently
debugging an issue like this, and noticed that because of the way that the
message.send() is being done, none of the exceptions would be dealt with
from the smtplib, or maybe I am just misreading the code.

Scott

On Thu, Aug 6, 2009 at 7:56 PM, Christian Hammond wrote:

> Hi Scott,
>
> The reports feature was never fully completed, which is why it's sort of
> hidden. We're probably going to make it a downloadable extension in 1.5 or
> 2.0 and make it more public. For the time-being, though, if you have
> patches, we'll certainly take a look and see about getting them into the
> next release. Go ahead and post them to http://reviews.review-board.organd 
> we'll look.
>
> Thanks!
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
>
>
> On Thu, Aug 6, 2009 at 3:17 PM, Scott Quesnelle  > wrote:
>
>> Hello,
>>
>> Is anyone using the reports feature of reviewboard?
>>
>> I have noticed that there are a few things missing in it, and have done
>> tidying up.
>>
>> I have added the period that the report covers to the title line, and also
>> modified the template to properly deal with quotes and such. Both are minor
>> changes, but not sure if its worth contributing the diffs back for mainline
>> inclusion.
>>
>> Scott
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

How to connect comments and changes?

[Philipp Henkel]

Hello,

I'm new to Review Board and I would like to use it in combination with
Perforce and post-review.

There seems to be no strong connection of comments and code changes.
In Diff View comments seem to be bound to single diffs. When you add a
new diff it is difficult to match old comments and new changes because
you don't see the previous comments. Questions like "Is every issue
addressed?" or "What is the reason for that change?" cannot be
answered immediately. You always have to go back to one of the
previous diffs and search for the discussion.

Our current review work flow is like this:
1. Create new request: add a large diff using post-review (might be a
complete new feature)
2. Reviewer and Coder add comments to this diff
3. Coder applies changes and adds an updated diff using post-review
4. Reviewer is satisfied -> go to 5   or  next iteration is started ->
go to 2.
5. Review done

I know that RB is optimized for pre-commits and I assume that those
pre-commits reviews tend to be much smaller than post-commits ones.
However, perhaps there is a simple solution to my problem if I
slightly change the work flow. Did I overlook something? Is it
possible to show older comments in the latest diff? Would this be a
nice feature?

Best regards,
Philipp
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Perforce server security level error when post a review

[Philipp Henkel]

Hi,

p4.run_login() is working for me if I set the user and password before
each p4 login again. P4 seems to loose the values set in __init__

def _connect(self):
if not self.p4.connected():
self.p4.connect()
self.p4.user = self.user
self.p4.password  = self.password
self.p4.run_login()

Furthermore I had to disable the usage of passwords in  method
get_file to get RB fully working with Perforce:
#if self.p4.password:
#cmdline.extend(['-P', self.p4.password])

Wouldn't it be a good idea to support both Perforce access approaches
right from the scratch? If someone is interested in this I'm willing
to help.

Best regards,
Philipp


On Jul 21, 1:13 am, Yongqiang Li  wrote:
> Thansk, Tom.
>
> Just as what you said, I need to modify the perforce.py and add run_login()
> just behind self.p4.connect() in function _connect().
>
> I tried the p4.run_login() but it didn't work.
> So I wrote my own run_login() as:
> ===
> def run_login(self):
>         os.popen('echo %s | p4 -p %s -u %s login -a' % (self.p4.password,
> self.p4.port, self.p4.user))
> ===
>
> Then everything is OK! RB is great!
> Hope it's useful for other guys who have the same problem.
>
> Regards,
> Yongqiang
>
> On Mon, Jun 29, 2009 at 8:34 AM, Tom Sakkos  wrote:
> > I wouldn't know where to put this in ReviewBoard, but it's probably
> > necessary to run "run_login()" on the p4 object immediately after running
> > "connect()."
>
> > -Tom
>
> > On Mon, Jun 29, 2009 at 2:13 AM, Jason Lee  wrote:
>
> >> Hi guys,
>
> >> I met another problem when post a perforce review.
>
> >> I install the RB on Windows.
> >> The command is : post-review.py -d 118527
> >> And then I met a perforce exception.
>
> >> The logs are below:
> >> 
> >> P4Exception at /api/json/reviewrequests/new/
>
> >> [P4#run] Errors during command execution( "p4 describe -s 118527" )
>
> >>        [Error]: Password not allowed at this server security level, use
> >> 'p4
> >> login'.
>
> >> Request Method:         POST
> >> Request URL:    http://127.0.0.1:80/api/json/reviewrequests/new/
> >> Exception Type:         P4Exception
> >> Exception Value:
>
> >> [P4#run] Errors during command execution( "p4 describe -s 118527" )
>
> >>        [Error]: Password not allowed at this server security level, use
> >> 'p4
> >> login'.
>
> >> Exception Location:     C:\Python25\lib\site-packages\P4.py in run, line
> >> 284
> >> Python Executable:      D:\Program Files\Apache Software Foundation
> >> \Apache2.2\bin\httpd.exe
> >> Python Version:         2.5.4
> >> Python Path:    
> >> Server time:    Fri, 26 Jun 2009 17:56:01 +0800
> >> ===
>
> >> I think that's because of the higher P4 server security level. Because
> >> when I use my own perforce server with default security level, I can
> >> post the review successfully.
>
> >> Anyone knows how to fix this problem?
> >> Thanks.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---