Re: ReviewBoard on Windows 7
Hi Jan, Thanks for the info. It'd be nice to find out if an upcoming memcached is going to work as a service on Windows 7. Hopefully they're working on it. As for post-review, remind me, are you using the nightlies or the last release? I thought we had fixed this in the nightlies. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Feb 13, 2010 at 3:48 AM, Jan Koprowski wrote: > Hi ! > > I was after installing process on Windows 7. Two advices: > > 1) I can't run *memcached -d install* > > c:\memcached>memcached.exe -d install > failed to install service or service already installed > > Only advice is tu run memcached on command line using standard > "memcached" session run in console window. > > 2) When You use post-review You must manually create *C:\Users\Username > \Local Settings\Application Data* because this directory doesn't > exists on Windows 7 > > Greetings from Poland! > -- > Jan Koprowski > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ReviewBoard on Windows 7
Hi ! I was after installing process on Windows 7. Two advices: 1) I can't run *memcached -d install* c:\memcached>memcached.exe -d install failed to install service or service already installed Only advice is tu run memcached on command line using standard "memcached" session run in console window. 2) When You use post-review You must manually create *C:\Users\Username \Local Settings\Application Data* because this directory doesn't exists on Windows 7 Greetings from Poland! -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Fields error on windows with svn
Ok :)
I test it on Windows using ReviewBoard 1.1 and all is right! Error
bellow occur only when we try to upload empty diff.
Greetings from Poland!
On Feb 2, 7:21 am, Jan Koprowski wrote:
> Hi Christian!
>
> I use Reviewboard 1.0.5.1. I can check it on ReviewBoard 1.1.
> I looked to both this files when I get this error with ClearCase (I
> don't check clearcase on linux yet but on windows they generate
> identical error).
> So the problem was in diffviewer/forms.py in
>
> class UploadDiffForm(forms.Form):
> basedir = forms.CharField(
> label=_("Base directory"),
> help_text=_("The absolute path in the repository the diff was "
> "generated in."))
> path = forms.FileField(
> label=_("Diff"),
> help_text=_("The new diff to upload."))
> parent_diff_path = forms.FileField(
> label=_("Parent diff"),
> help_text=_("An optional diff that the main diff is based on. "
> "This is usually used for distributed revision
> control "
> "systems (Git, Mercurial, etc.)."),
> required=False)
>
> # Extensions used for intelligent sorting of header files
> # before implementation files.
> HEADER_EXTENSIONS = ["h", "H", "hh", "hpp", "hxx", "h++"]
> IMPL_EXTENSIONS = ["c", "C", "cc", "cpp", "cxx", "c++", "m",
> "mm", "M"]
>
> def __init__(self, repository, *args, **kwargs):
> forms.Form.__init__(self, *args, **kwargs) <--- HERE IS THE
> PROBLEM
>
> Problem is *args is string but path and parent_diff_path is Django
> Uploaded file objects and I don't know how I can investigate this
> files. Before this line there wasn't any error, after it I get:
>
> > Error uploading diff:Oneormorefieldshaderrors(105)
> {'fields': {'path': ['diff']}, 'stat': 'fail', 'err': {'msg':
> 'Oneormorefieldshaderrors', 'code': 105}}
>
> so Django Form mechanism check somehow content of diff and aver it is
> wrong but I don't know what else I can check.
>
> On Feb 2, 6:31 am, Christian Hammond wrote:
>
>
>
> > Hmm.. Very hard to say. They certainly look identical.
>
> > What version of Review Board is this? I believe the 1.1 nightlies have some
> > additional server-side logging for theseerrors, but either way, it might be
> > worth instrumenting the server to find out where exactly it's failing. Take
> > a look at the new_diff function in reviewboard/webapi/json.py. Add some
> > logging to the various exception handlers. In the 1.1 nightlies at least,
> > this has been added to the generic Exception handle:
>
> > logging.error("Error uploading new diff: %s", e, exc_info=1)
>
> > If not there, then in the UploadDiffForm in reviewboard/reviews/forms.py and
> > reviewboard/diffviewer/forms.py.
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Mon, Feb 1, 2010 at 4:41 AM, Jan Koprowski
> > wrote:
>
> > > I made experiment. I create very simple svn repository on linux and
> > > try use post-review for it on Windows and on Linux. What I get:
>
> > > On Linux:
>
> > > >>> HTTP POSTing to
> > >http://192.168.56.2/api/json/reviewrequests/11/diff/new/:{'basedir': '/'}
> > > --127.0.1.1.1000.2795.1265030375.375.2
> > > Content-Disposition: form-data; name="basedir"
>
> > > /
> > > --127.0.1.1.1000.2795.1265030375.375.2
> > > Content-Disposition: form-data; name="path"; filename="diff"
>
> > > Index: /b
> > > ===
> > > --- /b (revision 0)
> > > +++ /b (revision 0)
> > > @@ -0,0 +1 @@
> > > +b
>
> > > --127.0.1.1.1000.2795.1265030375.375.2--
>
> > > {'path': {'content': 'Index: /b
> > > \n===
> > > \n--- /b\t(revision 0)\n+++ /b\t(revision 0)\n@@ -0,0 +1 @@\n+b\n',
> > > 'filename': 'diff'}}
> > > Review request #11 posted.
>
> > >http://192.168.56.2/r/11
>
> > > On Windows:
>
> > > >>> HTTP POSTing tohttp://localhost/api/json/reviewrequests/55/diff/new/:
> > > {'basedir': '/'}
> > > --172.28.38.102.1.6644.1265026662.057.3
> > > Content-Disposition: form-data; name="basedir"
>
> > > /
> > > --172.28.38.102.1.6644.1265026662.057.3
> > > Content-Disposition: form-data; name="path"; filename="diff"
>
> > > Index: /b
> > > ===
> > > --- /b (revision 0)
> > > +++ /b (revision 0)
> > > @@ -0,0 +1 @@
> > > +b
>
> > > --172.28.38.102.1.6644.1265026662.057.3--
>
> > > {'path': {'content': 'Index: /b
> > > \n===
> > > \n--- /b\t(revision 0)\n+++ /b\t(revision 0)\n@@ -0,0 +1 @@\n+b\n',
> > > 'filename': 'diff'}}
> > > Error uploading diff:Oneormorefieldshaderrors(105)
> > > >>> {'fields': {'path': ['diff']}, 'stat': 'fail', 'err': {'msg': 'Oneor
> > >morefieldshaderrors', 'code': 105}}
> > > Your review request still exists, but the diff is not att
Re: reviewboard and clearcase problem
I guess You are using 1.0.x ReviewBoard. I had similar problem last
time but my version was 1.1.x alpha which return additional
informations. My error while uploading diff looks like:
>>> {'fields': {'path': ['The diff file is empty']}, 'stat': 'fail', 'err':
>>> {'msg': 'One or more fields had errors', 'code': 105, 'error': 'Permission
>>> Denied'}}
It is really not important how message looks like but i get that
additional information permission or access denied. I don't have
enough time to back to this issue but I guess that ReviewBoard from
the server side try "read" (or something) from repository and they
don't have enough privileges. Probably Apache / Lighttpd user doesn't
have permissions to read dynamic views. This is only my assumption -
that this is the problem which could happen.
On Feb 12, 10:18 pm, Christian Hammond wrote:
> You can use post-review --output-diff to generate the diff without pushing
> it to the server.
>
> What version is running on the server? You may be able to find some data in
> the log files, if you turn logging on.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Fri, Feb 12, 2010 at 4:19 AM, eeiths wrote:
> > I'm trying the post-review tool on windows env but i get the following
> > error ...wondering is this a clearcase issue or reviewboard.
>
> > is the a command to create the diff in isolation ..so I can see or
> > upload it via the GUI.
> > How can i debug the server side ..?
>
> > Any help appreciated .
>
> > C:\python25\Scripts>cleartool lsco -me -cview -recurse -short X:\ |
> > sed s/\\/\//g | xargs post-review -d
> > --server=http://ev001f29a331be/
> > >>> cleartool pwv -short
> > >>> repository info: Path: X:/, Base path: X:/, Supports changesets: False
> > >>> cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
> > >>> cleartool desc -fmt %Vn X:\
> > >>> cleartool desc -fmt %Vn X:\wran_cm_cms
> > :
> > :
>
> > >>> cleartool get -to
> > c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
> > X:\wran_cm_cms\PlannedAreaUpdator.java@
> > @\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
> > >>> Looking for 'ev001f29a331be /reviews/' cookie in C:\Users\etomhar\Local
> > Settings\Application Data\.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> Attempting to create review request for None
> > >>> HTTP POSTing to
> >http://ev001f29a331be/reviews/api/json/reviewrequests/new/:
> > {'repository_path': 'X:/'}
> > >>> Review request created
> > >>> Attempting to set field 'description' to '** NONE **
> > VIEWTYPE: dynamic
> > ' for review request '6'
> > >>> HTTP POSTing to
> >http://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:
> > {'description': '** NONE **\nVIEWTYPE: dynamic\n'}
> > >>> HTTP POSTing to
> >http://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
> > >>> Review request draft saved
> > >>> Uploading diff, size: 29
> > >>> HTTP POSTing to
> >http://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:
> > {'basedir': 'X:/'}
> > Error uploading diff: One or more fields had errors (105)
> > >>> {'fields': {'path': ['The diff file is empty']}, 'stat': 'fail', 'err':
> > {'msg': 'One or more fields had errors', 'code': 105}}
> > Your review request still exists, but the diff is not attached.
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com > oups.com>
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
