Re: post-review diff upload error on windows XP
Guys
In the current error msg the file path it is taking to process for the
clearcase file is wrong
Processed path: M:/etan.d_RB_Integration_int/RB_CVOB/
Actual path: M:/chetan.d_RB_Integration_int/RB_CVOB/
Below is the error msg can someone help to get this rectified.
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 45, in get_file
return self.client.cat_file(self.adjust_path(path), revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 151, in cat_file
raise SCMError(errmsg)
SCMError: cat: M:/etan.d_RB_Integration_int/RB_CVOB/@@/main/
RB_Integration_main/2/Documents/@@/main/RB_Integration_main/2/
Doc1.txt@@/@@/main/RB_Integration_main/2: No such file or directory
As I am not into python coding i am not sure what to change in
clearcase.py script to handle this issue.
Any help appreciated
On Aug 23, 9:01 am, Chetan chetan@gmail.com wrote:
Below are my RB and ClearCase configurations.
RB is setup on Ubuntu
post-review and clearcase is on windows XP client from wer i am
generating the request.
Thnks for the info i will do few trail and errors and see if i can get
it working.
On Aug 19, 2:01 am, Dan Savilonis d...@n-cube.org wrote:
Is your server running Linux? I've only tested Clearcase support using
a Windows RB server. Take a look at line 83 of
clearcase.py:http://github.com/reviewboard/reviewboard/blob/master/reviewboard/scm...
You're likely going to need to do some editing here. I don't know
anything about how Clearcase works on Linux, but I'm guessing the
assumption that all vobs are mounted under vobs/ might not be true...
Dan
On Aug 10, 6:47 am, Chetan chetan@gmail.com wrote:
As suggested by you i enabled logging to debug clearcase error. I
given the log information when i execute post-review for clearcase
below.
###
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 1070
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-08-10 03:39:32,065 - ERROR - Error uploading new diff: substring
not found
Traceback (most recent call last):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/reviews/forms.py, line 234, in create
history)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 149, in _process
_files
not tool.file_exists(filename, revision))):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 45, in get_fil
e
return self.client.cat_file(self.adjust_path(path), revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 83, in adjust_
path
elem_path = elem_path[elem_path.rindex(vobs/)+5:]
ValueError: substring not found
###
On Aug 10, 11:15 am, Chetan chetan@gmail.com wrote:
I wanted execute svn diff recursively but found could not generate
one. But now I found if i run svn diff from the svn root directory it
handles all changes recursively.
On Aug 9, 12:24 pm, Christian Hammond chip...@chipx86.com wrote:
I'm not sure what you mean exactly. Is it not generating a diff with
all
files recursively, or is there some reason why doing it recursively
isn't
good enough?...
read more »
Are you using the post-review tool?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 9, 2010 at 12:21 AM, Chetan chetan@gmail.com wrote:
I got reviewboard working for subversion including https.
In svn diff we cannot generate recursive diff coz of which we may
have
to generate folder specific diffs. Is there a way around this?
Thanks for the support.
On Aug 5, 11:55 am,
Re: Facing problem installing in Windows!
I install ubuntu.. installed Review Board... it is working now !! On Aug 20, 6:16 pm, Timothy Pinet tim.pi...@gmail.com wrote: That is good to hear! When in doubt on Windows, reboot :) Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
post-review tool: How to post only *.c and *.h files
I am first timer for Review Board.. trying to figure out how to post code into review board for review.. and how to initiate review etc... Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Cheers Sakthi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review error with svn and gnu diffutils (new review with an added binary file)
Thanks for the suggestion. I downloaded rbtools 0.2 stable from http://github.com/reviewboard/rbtools, made my changes to postreview.py, and reinstalled the package using python setup.py install at the rbtool root. In postreview.py I changed the svn diff --diff-cmd=diff to svn diff --diff-cmd=C:\\diffForceText.bat and recompiled. I create the wrapper script diffForceText.bat to simply include: @echo off diff %* --text Which forwards all calls into GNU diff but forces the --text param. This overcomes my binary file being text diffed and returning exit code 2 to SVN diff. I now have a fully working ReviewBoard + Windows + TFS repo solution for my org and it is blowing minds and melting faces. I will post how I got TFS to work as it was not very straight forward. Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
New install/config: SVN repository is not visible
Hi,
I'm a newbie setting up a reviewboard v1.5 rc1 server on RHEL5 to
review code from a remote Subversion repository.
However, when I add a repository, the visible flag is set to false and
I can't create a review since there is no repository. Adding other
repositories has the same result. Visible = false.
I enabled logging and the only svn repository message looks like a
good one:
2010-08-23 10:53:32,153 - DEBUG - SVN: Got repository
information for http://svnserver/svn/dev: [('dev', PysvnInfo '')]
I've done some searching in this group and didn't see the same issue.
If I missed one, can you please forward the link?
I've read and re-read the admin docs. The trouble is, it appears to be
configured OK.
I'd really like to use this tool with my group but am blocked. Any
info would be greatly appreciated!
Thanks,
-JulieT
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Never mind about the SVN repository... found the attribute to make it visible.
My apologies. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review tool: How to post only *.c and *.h files
sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is required? Let me pose a question to you ;-) How are you going to submit just *.c and *.h files to subversion when you come to commit? There is no reviewboard involved at that stage. Postreview will accept the same filenames on command line that subversion will take at submit time. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Triggers
Scott, Very nice, thanks for the tip! John On Fri, Aug 20, 2010 at 6:55 AM, Scott Quesnelle scott.quesne...@gmail.comwrote: I modified the base code for reviewboard. Its one small change in the webapi code to trigger a generate_summary call when the close-submitted action is done. Then a new file which contains the generate_summary code and its appropriate template. The email code was used as the inspiration, and subtle modifications were made to suit the layout I thought best for the summary. This file is then written to the local disk and I have separate automation which pushes it into our bugtracking system. Scott On Fri, Aug 20, 2010 at 12:48 AM, J Arrizza cppge...@gmail.com wrote: Scott, Sorry for taking so long to back to you, got tied up on other stuff. Very nice. You modified the base code in some spot or is the review summary generation already a part of RB 1.07? John On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle scott.quesne...@gmail.com wrote: John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the review summary in a standardized enclosure. This is currently running on RB 1.0. Scott -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- John blog: http://arrizza.blogspot.com/ web: http://www.arrizza.com/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
keeping track of large number of files
Hi, When initial code is put into RB or a large change is put in, there can be many files (say 50). Can't really review that in one sitting so there needs to be a way for a reviewer to keep track of which files he's finished with (e.g. ok with file xyz.cpp). I see that an issue was raised for this already (by Ben Hollis) Issue 1772 http://code.google.com/p/reviewboard/issues/detail?id=1772:Allow reviewers to check off files they've looked at In the meantime, has any one come up with a good workaround? I've thought of just putting a comment that says OK, but that could get messy especially with email notifications... John -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review diff upload error on windows XP
I did few trials on line 83 of clearcase.py. IF i change the vobs/
to M:/ it gives the element path in the error which otherwise would
state substring not found.
I am not sure what exactly shud i do after this.can you guys
suggest me some ways to figure out this.
when its is vobs/ in clearcase.py script.
Uploading diff, size: 907
HTTP POSTing to
http://172.24.1.107/reviewboard_lgsi/api/json/reviewrequests/176/diff/new/:
{'basedir': 'M:/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'substring not found']}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields
had errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
When its is changes to M:/:
Uploading diff, size: 907
HTTP POSTing to
http://172.24.1.107/reviewboard_lgsi/api/json/reviewrequests/175/diff/new/:
{'basedir': 'M:/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'cat:
M:/chetan.d_RB_Integration_int/RB_CVOB/@@/main/RB_Integration_main/2/Docum
ents/@@/main/RB_Integration_main/2/Doc1.txt@@/@@/main/
RB_Integration_main/2: No such file or directory\n']}, u'stat': u'
fail', u'err': {u'msg': u'One or more fields had errors', u'code':
105}, u'deprecated': {u'in_version': u'1.5'}}
On Aug 23, 9:01 am, Chetan chetan@gmail.com wrote:
Below are my RB and ClearCase configurations.
RB is setup on Ubuntu
post-review and clearcase is on windows XP client from wer i am
generating the request.
Thnks for the info i will do few trail and errors and see if i can get
it working.
On Aug 19, 2:01 am, Dan Savilonis d...@n-cube.org wrote:
Is your server running Linux? I've only tested Clearcase support using
a Windows RB server. Take a look at line 83 of
clearcase.py:http://github.com/reviewboard/reviewboard/blob/master/reviewboard/scm...
You're likely going to need to do some editing here. I don't know
anything about how Clearcase works on Linux, but I'm guessing the
assumption that all vobs are mounted under vobs/ might not be true...
Dan
On Aug 10, 6:47 am, Chetan chetan@gmail.com wrote:
As suggested by you i enabled logging to debug clearcase error. I
given the log information when i execute post-review for clearcase
below.
###
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 1070
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-08-10 03:39:32,065 - ERROR - Error uploading new diff: substring
not found
Traceback (most recent call last):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/reviews/forms.py, line 234, in create
history)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 149, in _process
_files
not tool.file_exists(filename, revision))):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 45, in get_fil
e
return self.client.cat_file(self.adjust_path(path), revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 83, in adjust_
path
elem_path = elem_path[elem_path.rindex(vobs/)+5:]
ValueError: substring not found
###
On Aug 10, 11:15 am, Chetan chetan@gmail.com wrote:
I wanted execute svn diff recursively but found could not generate
one. But now I found if i run svn diff from the svn root directory it
handles all changes recursively.
On Aug 9, 12:24 pm, Christian Hammond chip...@chipx86.com wrote:
I'm not sure what you mean exactly. Is it not generating a diff with
all
files recursively, or is there some reason why doing it recursively
isn't
good enough?...
read more »
Are you using the post-review tool?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 9, 2010 at 12:21 AM, Chetan chetan@gmail.com wrote:
I got reviewboard working for subversion including https.
Re: Issue 719 in reviewboard: Ldap auth not working with AD
Comment #17 on issue 719 by mdfakkeer: Ldap auth not working with AD http://code.google.com/p/reviewboard/issues/detail?id=719 it also works for me. But i want to authenticate only particy=ular group members instead of all members in my domain. If any body know how to configure LDAP with Group. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1783 in reviewboard: how to configure LDAP with group authentication
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1783 by mdfakkeer: how to configure LDAP with group authentication http://code.google.com/p/reviewboard/issues/detail?id=1783 *NOTE: Do not post confidential information in this bug report.* What version are you running? Ubuntu 10.04 What's the URL of the page containing the problem? What steps will reproduce the problem? 1.i want to authenticate only particular group members using LDAP. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1784 in reviewboard: user setting for plaintext emails
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1784 by latchkey: user setting for plaintext emails http://code.google.com/p/reviewboard/issues/detail?id=1784 What version are you running? 1.5rc1 It would be nice if there was a user level setting that enabled said person to receive plaintext emails vs. html emails. I guess the html emails don't show up in Evolution 2.28 very well because it isn't properly handling the wrapping of text inside the pre tags. I see in the source of the html that you've done most of the work to get pre tags properly wrapping, but maybe look in the comments on this page: http://www.longren.org/2006/09/27/wrapping-text-inside-pre-tags/ for some additional html to throw in there. (Maybe this part should be refiled as a separate issue) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
