Re: How to specify repository with post-review
@Jan I tried "--repository-url", but it looks like it's only meant
for post-committed reviews, since it requires "--revision-range". =(
@Christian Here's my output from running "post-review --debug"
1 c:\Development\workspace\picayune\rails\mobile\trunk>post-review --
debug
2 >>> svn info
3 >>> svn info app/models/category.rb
4 >>> diff --version
5 >>> repository info: Path: http://192.168.1.112:6060/rails/mobile,
Base path: /trunk, Supports changesets: False
6 >>> Looking for 'reviewboard /' cookie in C:\Users\Tin\AppData
\Roaming\.post-review-cookies.txt
7 >>> Cookie file loaded, but no cookie for this server
8 ==> Review Board Login Required
9 Enter username and password for Review Board at http://reviewboard:4040/
10 Username: tin
11 Password:
12 >>> Logging in with username "tin"
13 >>> HTTP POSTing to http://reviewboard:4040/api/json/accounts/login/:
{'username': 'tin','password': '**'}
14 >>> Logged in.
15 >>> HTTP GETting /api/json/repositories/
16 >>> HTTP GETting /api/json/repositories/1/info/
17 >>> repository info: Path: http://192.168.1.112:6060/repos, Base
path: /trunk, Supports changesets: False
18 >>> Attempting to create review request on http://192.168.1.112:6060/repos
for None
19 >>> HTTP POSTing to http://reviewboard:4040/api/json/reviewrequests/new/:
{'repository_path': u'http://192.168.1.112:6060/repos'}
20 >>> Review request created
21 >>> Uploading diff, size: 10989
22 >>> HTTP POSTing to
http://reviewboard:4040/api/json/reviewrequests/17/diff/new/:
{'basedir': '/trunk'}
23 >>> Got API Error 207 (HTTP code 200): The file was not found in
the repository
24 >>> Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat':
u'fail', u'file': u'/trunk/app/models/category.rb', u'err': {u'msg':
u'The 25 file was not found in the repository',u'code': 207},
u'revision': u'55'}
26 Error uploading diff
27 Your review request still exists, but the diff is not attached.
On line 5, it detects the correct svn repository (http://
192.168.1.112:6060/rails/mobile), but after logging in, line 18 shows
that it thinks the repository is http://192.168.1.112:6060/repos,
which leads to the error.
Here's my output from running "svn info", which shows the correct
repository:
c:\Development\workspace\picayune\rails\mobile\trunk>svn info
Path: .
URL: http://192.168.1.112:6060/rails/mobile/trunk
Repository Root: http://192.168.1.112:6060/rails/mobile
Repository UUID: 767f2b9c-365f-4c87-b140-339854ac5c81
Revision: 55
Node Kind: directory
Schedule: normal
Last Changed Author: root
Last Changed Rev: 55
Last Changed Date: 2010-10-26 15:32:57 -0700 (Tue, 26 Oct 2010)
Thanks for the help!
On Oct 30, 1:09 pm, Christian Hammond wrote:
> I'm confused about your setup. You're in a source directory, but svn info is
> giving you information on a different repository? How? Can you describe the
> directory hierarchy, what you should be seeing, and what you're instead
> seeing, and where that's coming from?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Fri, Oct 29, 2010 at 2:12 PM, WhoDatSaint wrote:
> > Hi,
>
> > My environment has multiple svn repositories. When I cd into my
> > project directory and run post-review, --debug shows that my
> > repository info path is wrong. It always default to one particular
> > repository.
>
> > Is there a way to specify which repository to use with post-review? I
> > am able to do this when creating a new review request through the
> > web. There's a drop-down list.
>
> > Currently, my workaround is to create an empty review request through
> > the web, so I can choose the svn repository. And, then run post-
> > review to attach the diff to the named review request id. This works,
> > but it's a pain.
>
> > Is there a better way?
>
> > Thanks!
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -
>
> - Show quoted text -
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard under Gunicorn + nginx ?
Gunicorn adds os.getcwd() to sys.path in site-packages/gunicorn/app/
djangoapp.py. This is where DJANGO_SETTINGS_MODULE is set to
'settings' too.
On Oct 28, 4:13 pm, Hank wrote:
> Hi All.
>
> I've just started trying to set up a ReviewBoard instance. Since
> Gunicorn has the nicest Django deployment story I've seen (http://
> gunicorn.org/run.html#gunicorn-django), I thought I'd set up
> ReviewBoard using Gunicorn. I know it's not officially supported, but
> I thought it would make for an interesting experiment.
>
> Everything has gone smoothly up until the point where I actually try
> to serve the app. Whenever I make a request, I get the following
> error:
>
> Unable to read settings_local.py.
>
> Please seehttp://www.reviewboard.org/docs/manual/dev/admin/
> for help setting up Review Board.
>
> Naturally, I looked into settings.py to see how it was trying to find
> settings_local and found:
>
> # Load local settings. This can override anything in here, but at the
> very
> # least it needs to define database connectivity.
> try:
> import settings_local
> from settings_local import *
> except ImportError:
> dependency_error('Unable to read settings_local.py.')
>
> Since settings_local.py is in the conf subdirectory of the site
> directory generated by rb-site install and not in my site-packages
> like the settings.py is, I assume that there is some manipulation
> going on somewhere else to put it on my PYTHONPATH. Here's the output
> from a test I ran to make sure it really wasn't on my PYTHONPATH:
>
> $ python
> Python 2.6.6 (r266:84292, Oct 27 2010, 15:04:49)
> [GCC 4.2.1 20070719 [FreeBSD]] on freebsd8
> Type "help", "copyright", "credits" or "license" for more information.>>>
> import sys
> >>> sys.path
>
> ['', '/usr/home/reviewboard/reviewboard/lib/python2.6/site-packages/
> distribute-0.6.14-py2.6.egg', '/usr/home/reviewboard/reviewboard/lib/
> python2.6/site-packages/pip-0.8.1-py2.6.egg', '/usr/home/reviewboard/
> reviewboard/lib/python26.zip', '/usr/home/reviewboard/reviewboard/lib/
> python2.6', '/usr/home/reviewboard/reviewboard/lib/python2.6/plat-
> freebsd8', '/usr/home/reviewboard/reviewboard/lib/python2.6/lib-tk', '/
> usr/home/reviewboard/reviewboard/lib/python2.6/lib-old', '/usr/home/
> reviewboard/reviewboard/lib/python2.6/lib-dynload', '/usr/local/lib/
> python2.6', '/usr/local/lib/python2.6/plat-freebsd8', '/usr/local/lib/
> python2.6/lib-tk', '/usr/home/reviewboard/reviewboard/lib/python2.6/
> site-packages', '/usr/home/reviewboard/reviewboard/lib/python2.6/site-
> packages/PIL']
>
> Since Gunicorn works with WSGI, I chose Apache + WSGI during the rb-
> site install process. If I look in apache-wsgi.conf, I can't see any
> PYTHONPATH manipuation going on. On the other hand, if I choose Apache
> + mod_python and look at the mod_python config script, I immediately
> notice the following line:
>
> PythonPath "['/usr/home/reviewboard/reviewboard/argle/conf'] +
> sys.path"
>
> How does the Apache + WSGI option accomplish this? Once I understand
> that, I think it will be straightforward to apply the same idea to
> Gunicorn.
>
> Thanks,
>
> Hank
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard 1.5 under Apache: IOError when posting review from command line post-review tool
Thank you very much for the reference and tips. I'll give that a
try.
On Oct 29, 11:54 am, Dennis wrote:
> Rob, have you seen this?
>
> http://bugs.python.org/issue1731717
>
> Implementing the proposed workaround in the latest entry of that
> thread fixed a lot of the [Errno 10] problems for me--all of the ones
> from the diff viewer, in fact.
>
> I may have fixed the remaining ones from that 'uname -p' function call
> in platform.py that you're seeing, by inserting the return string from
> 'uname -o' on my system to the output value of syscmd_uname.
>
> It looks to me like the intent was to use 'uname -o' in the first
> place, since that returns the operating system name, while uname -p
> returns the processor type. Somehow, this function ends up calling
> uname -p.
>
> I assigned 'GNU/Linux' to the output of syscmd_uname in platform.py,
> and so far I've not seen the [Errno 10] in 3 consecutive post-review
> submissions.
>
> I'm not certain that it's fixed completely, but it looks good so far.
>
> Dennis
>
> On Oct 13, 12:30 pm, Rob wrote:
>
>
>
>
>
>
>
> > Starting in ReviewBoard 1.5 (Python 2.5.1 linux64 compiled
> > mod_python.so) the changes to use Paramiko result in this exception
> > when posting a review changelist (from Perforce) via the commandline
> > post-review tool.
>
> > HTTP POSTing tohttp://sw-web3.altera.com/review/api/json/accounts/login/:
> > {'username': 'rromano', 'password': '**'}
>
> > Traceback (most recent call last):
>
> > File "/tools/python/2.5.1/linux64/lib/python2.5/site-packages/
> > mod_python/importer.py", line 1537, in HandlerDispatch
> > default=default_handler, arg=req, silent=hlist.silent)
>
> > File "/tools/python/2.5.1/linux64/lib/python2.5/site-packages/
> > mod_python/importer.py", line 1229, in _process_target
> > result = _execute_target(config, req, object, arg)
>
> > File "/tools/python/2.5.1/linux64/lib/python2.5/site-packages/
> > mod_python/importer.py", line 1128, in _execute_target
> > result = object(arg)
>
> > File "/tools/django/trunk/1.2.3/django/core/handlers/modpython.py",
> > line 228, in handler
> > return ModPythonHandler()(req)
>
> > File "/tools/django/trunk/1.2.3/django/core/handlers/modpython.py",
> > line 191, in __call__
> > self.load_middleware()
>
> > File "/tools/django/trunk/1.2.3/django/core/handlers/base.py", line
> > 40, in load_middleware
> > mod = import_module(mw_module)
>
> > File "/tools/django/trunk/1.2.3/django/utils/importlib.py", line 35,
> > in import_module
> > __import__(name)
>
> > File "/usr/local/altera/django/reviewboard/admin/middleware.py",
> > line 13, in
> > from reviewboard.webapi.json import service_not_configured
>
> > File "/usr/local/altera/django/reviewboard/webapi/json.py", line 29,
> > in
> > from reviewboard.diffviewer.forms import EmptyDiffError
>
> > File "/usr/local/altera/django/reviewboard/diffviewer/forms.py",
> > line 7, in
> > from reviewboard.diffviewer.diffutils import
> > DEFAULT_DIFF_COMPAT_VERSION
>
> > File "/usr/local/altera/django/reviewboard/diffviewer/diffutils.py",
> > line 29, in
> > from reviewboard.scmtools.core import PRE_CREATION, HEAD
>
> > File "/usr/local/altera/django/reviewboard/scmtools/core.py", line
> > 5, in
> > from reviewboard.scmtools import sshutils
>
> > File "/usr/local/altera/django/reviewboard/scmtools/sshutils.py",
> > line 5, in
> > import paramiko
>
> > File "/usr/local/altera/django/reviewboard/paramiko/__init__.py",
> > line 69, in
> > from transport import randpool, SecurityOptions, Transport
>
> > File "/usr/local/altera/django/reviewboard/paramiko/transport.py",
> > line 32, in
> > from paramiko import util
>
> > File "/usr/local/altera/django/reviewboard/paramiko/util.py", line
> > 32, in
> > from paramiko.common import *
>
> > File "/usr/local/altera/django/reviewboard/paramiko/common.py", line
> > 98, in
> > from rng import StrongLockingRandomPool
>
> > File "/usr/local/altera/django/reviewboard/paramiko/rng.py", line
> > 44, in
> > if ((platform is not None and platform.system().lower() ==
> > 'windows') or
>
> > File "/tools/python/2.5.1/linux64/lib/python2.5/platform.py", line
> > 1042, in system
> > return uname()[0]
>
> > File "/tools/python/2.5.1/linux64/lib/python2.5/platform.py", line
> > 1014, in uname
> > processor = _syscmd_uname('-p','')
>
> > File "/tools/python/2.5.1/linux64/lib/python2.5/platform.py", line
> > 801, in _syscmd_uname
> > rc = f.close()
>
> > IOError: [Errno 10] No child processes
>
> > This looks very fundamental. Python's platform.uname() fn does a
> > subprocess call to `uname` and it's not liked.
>
> > Incidentally, under ReviewBoard 1.0.x, I had similar issues in
> > ReviewBoard's own code using subprocess.POpen to extract diffs from
> > `p4`. I simply changed the code to use os.s
Re: problems installing
Hey I am not sure why that made a difference but after deleting the repo and git cloning it, it worked. so hello. I am back. off to the next bug and thanks for the help Cheers, Cristian On Sat, Oct 30, 2010 at 9:58 PM, Christian Hammond wrote: > Can you show the exact text it found? I think it's fine not to have > fixtures in the dev server. Running evolve --execute shouldn't do anything > either, since that's only for an existing database. I think at this point, > you're ready to go. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Sat, Oct 30, 2010 at 1:55 AM, Cristian Mircea Messel > wrote: > >> Hi >> >> I am new to python and django so I might be missing something. In the end >> I finally managed to get all dependencies installed for reviewboard >> development (I think) but I still can't run it. >> >> ./contrib/internal/devserver.py works just fine >> >> but when I go to localhost:8080 it says that db schema has changed since >> last update. It tells me to run >> >> ./manage.py syncb >> >> but that said no fixtures found. >> >> ./manage.py evolve --execute doesn't do anything either. >> >> I am not sure what I should try. Help? >> >> Cheers, >> Cristian >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: code review observations classification.
Goal of Review Board's design is avoid states and workflows as long as it possible. This goal make Review Board simple and easy to maintain. But maybe two thinks give You an hope: 1) Mike Conley still improving Review Board issue tracking: http://mikeconley.ca/blog/2010/10/21/review-board-issue-tracking-a-sneak-peek/ 2) In the future Review Board will have extensions - maybe then one of them provide such feature. On Sat, Oct 30, 2010 at 2:53 PM, rv_saraswathi wrote: > Is there any feature, that lets me classify code review observations > as major, medium, minor, enhancements etc.? Earlier, I was using > codestriker, which I could tweak to provide this info. > > thanx > RV > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- ><> Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
