Re: Customizing Submitters page
I'm a bit confused by this. Can you show me what the code you're adding looks like? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Jun 12, 2011 at 7:59 PM, Daryl darylnebr...@gmail.com wrote: Mercy. Ok, I've been able to add it and it works with a 2nd account. But initially I added sortable=True to to fullname, pending_count and last_login. It didn't like that. So I removed sortable from fullname and pending_count. And now it works with the 2nd account. But it seems like something is cached with the first account since I keep getting the 500 - something broke error with the below trace. I assumed something was cached, but I've tried: - Restarting apache - Restarting memcache - Clearing memcache using echo flush_all | nc localhost 11211 - Restarting sqld - rb-site manage upgrade . - Clearing browser cache It's my normal review account that I was first testing the changes that keep giving me the error. With the admin account Last Login shows up and I can sort by it. Frustrating .. any thoughts? Thanks, Daryl Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/accounts/decorators.py, line 25, in _check return login_required(view_func)(*args, **kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/reviews/views.py, line 504, in submitter_list return grid.render_to_response(template_name) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 699, in render_to_response self.load_state() File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 534, in load_state self.precompute_objects() File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 631, in precompute_objects self.rows = [ File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 210, in render_cell rendered_data = self.render_data(obj) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 253, in render_data if id_field in obj.__dict__: AttributeError: 'NoneType' object has no attribute '__dict__' On Jun 12, 1:59 am, Christian Hammond chip...@chipx86.com wrote: Hi Daryl, The Submitters page has been around since basically month 2 of Review Board, but probably isn't that frequently used. I'd be happy to accept a patch for showing the last login time. The code for this is in reviewboard/reviews/datagrids.py. You'll add a new field to SubmitterDataGrid, named the same as the field containing this information in the model. Feel free to play with it, and then submit it for review athttp://reviews.reviewboard.org/ Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sat, Jun 11, 2011 at 9:53 PM, Daryl darylnebr...@gmail.com wrote: I'm running 1.6 beta 2 now and I like the changes a lot. Not sure if the Submitters button is new, I don't remember seeing it before. I like being able to see a list of all users and the number of pending reviews. It would also be nice to see the last time someone logged in on the summary page but it's not an option for customization. It does show up if you click an individual user. I suppose this is a feature request. Any chance there's a way I can add it without much difficulty? I suppose I could start digging around. Maybe a pointer or two in the right direction.. Thanks, Daryl -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at
RE: Help required - Clearcase and ReviewBoard integration on Windows
Hi Jan, I tried mapping the drive letter (M:\) and tried it with M:\as well and that did not work either. We have UCM streams in clearcase, where there are more than one VOB in a UCM view. Is there a way to debug the code? I have spent almost a week on this and not making any progress. Please help. -pady -Original Message- From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Jan Koprowski Sent: Tuesday, May 31, 2011 7:29 PM To: reviewboard@googlegroups.com Subject: Re: Help required - Clearcase and ReviewBoard integration on Windows Paddy, I'm pretty sure UCN paths are not supported because when I wrote the configuration I even did not think anyone can need this. Please try map this share to drive under windows and try with the drive. Greetings from Shannon, Jan On Tue, May 31, 2011 at 6:55 AM, paddy padmanab...@gmail.com wrote: I tried \\bhat-xp.ter.teradyne.com\views \pady_J750_high_site_cnt_bhatxp\J750AT, where J750AT is the name of the VOB without any luck. I am using a .reviewboardrc file in the client J750VOB directory, which looks like - REVIEWBOARD_URL = http://bhat-xp.ter.teradyne.com; REPOSITORY = 'IGXL J750ATVob' Any suggestions? How do I debug the issue? On May 30, 8:19 pm, Jan Koprowski jan.koprow...@gmail.com wrote: Paddy, One for sure: in new implementation there should be a VOB name in PATH. Change it and try again. Greetings from Poland! -- Jan On Mon, May 30, 2011 at 11:38 AM, paddy padmanab...@gmail.com wrote: Thanks Jan. Please find attached the requested screen shot. -Paddy -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
gitorious repository
We've been using Review Board with Gitorioius for awhile now without any problems using a URL mask as illustrated below. Recently we've had problems with the patch getting applied to older reviews that were previously successful. The error is similar to http://code.google.com/p/reviewboard/issues/detail?id=1873. In my random testing I noticed that using a locally sync'd repository versus using the URL mask seems to work although haven't done thorough testing nor investigation into the source code. Is this a known issue? Is it better to use a local sync than using the URL Mask with Gitoriious. URL Mask: http://repo/blobs/raw/revision/filename -- Michael D. Milbrath E-mail: m.milbr...@gmail.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Customizing Submitters page
The only changes I've made are to SubmitterDataGrid. I added a column for last_login and added that column to the self.default_columns below. Disclaimer - the only other python code I've written is a tab- space patch for RB. :) So I'm in the dark. I searched through the code and found template/reviews/user_page.html using user.last_login so I guessed at the line below where I set field_name=last_login. Now what I recall is I added sortable=True to fullname and pending_count, tested, and got an error. I then removed those but left sortable=True for last_login. It still failed for my normal account. But when I logged in as admin it works. I now just logged in as another non-admin account, and the Submitter page comes up ok. Now I do remember also putting an expand=True (or maybe it was shrink=True) on the new last_login line. I don't know what they mean so I removed them. But I did do a test with it in there. Perhaps adjusting the column width? Anyhow, if need be I can put in those changes again and try to view it with one of the working accounts to see if it reproduces it. But perhaps I'll wait for you to reply on if what I have below is just wrong. Daryl username = Column(_(Username), link=True, sortable=True) fullname = Column(_(Full Name), field_name=get_full_name, link=True, expand=True) pending_count = PendingCountColumn(_(Pending Reviews), field_name=directed_review_requests, shrink=True) last_login = Column(_(Last Login), field_name=last_login, sortable=True) snip self.default_columns = [ username, fullname, pending_count, last_login ] On Jun 13, 2:40 am, Christian Hammond chip...@chipx86.com wrote: I'm a bit confused by this. Can you show me what the code you're adding looks like? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 7:59 PM, Daryl darylnebr...@gmail.com wrote: Mercy. Ok, I've been able to add it and it works with a 2nd account. But initially I added sortable=True to to fullname, pending_count and last_login. It didn't like that. So I removed sortable from fullname and pending_count. And now it works with the 2nd account. But it seems like something is cached with the first account since I keep getting the 500 - something broke error with the below trace. I assumed something was cached, but I've tried: - Restarting apache - Restarting memcache - Clearing memcache using echo flush_all | nc localhost 11211 - Restarting sqld - rb-site manage upgrade . - Clearing browser cache It's my normal review account that I was first testing the changes that keep giving me the error. With the admin account Last Login shows up and I can sort by it. Frustrating .. any thoughts? Thanks, Daryl Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/accounts/decorators.py, line 25, in _check return login_required(view_func)(*args, **kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/reviews/views.py, line 504, in submitter_list return grid.render_to_response(template_name) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 699, in render_to_response self.load_state() File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 534, in load_state self.precompute_objects() File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 631, in precompute_objects self.rows = [ File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 210, in render_cell rendered_data = self.render_data(obj) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 253, in render_data if id_field in obj.__dict__: AttributeError: 'NoneType' object has no attribute '__dict__' On Jun 12, 1:59 am, Christian Hammond chip...@chipx86.com wrote: Hi Daryl, The Submitters page has been around since basically month 2 of Review Board, but probably isn't that frequently used. I'd be happy to accept a patch for showing the last login time. The code for this is in reviewboard/reviews/datagrids.py. You'll add a new field to SubmitterDataGrid, named the same as the field containing this information
Re: Error in adding cvs repository
Did anybody face the similar issue in integrating CVS into ReviewBoard ? Thanks, Rohan. On Jun 12, 4:41 pm, ROAAN rohan.raiza...@gmail.com wrote: Name: pact-cvs-tree Hosting service: Custom Repository type: CVS Path: :pserver:my_usern...@pact-cvs.pact.cs.cmu.edu:/usr0/local/ cvsroot Username : my_username Password: my_password I am not sure if there is a info argument which is accepted by the cvs. Let me know if I am missing something or you need some additional info. Rohan. On Jun 12, 4:33 pm, Christian Hammond chip...@chipx86.com wrote: Can you show us what you tried? And the repository info from 'cvs info' on that repository? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 1:25 PM, ROAAN rohan.raiza...@gmail.com wrote: Hi, Finally I upgraded my system and was able to install the ReviewBoard. However when I am trying to add the cvs repo. I always seem to be getting the error: A repository was not found at the specified path. I have tried different combinations of specifying the repo. There is no log being generated as well. Any help on how to set up the cvs repo would be appreciated. Thanks, Rohan. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error in adding cvs repository
Hi Rohan, See http://groups.google.com/group/reviewboard/browse_thread/thread/9f14cc242a9ef367 for the issues I had. Regards, Rob On Mon, 13 Jun 2011 08:53:08 -0700 (PDT), ROAAN wrote: Did anybody face the similar issue in integrating CVS into ReviewBoard ? Thanks, Rohan. On Jun 12, 4:41 pm, ROAAN wrote: Name: pact-cvs-tree Hosting service: Custom Repository type: CVS Path: :pserver:my_usern...@pact-cvs.pact.cs.cmu.edu:/usr0/local/ cvsroot Username : my_username Password: my_password I am not sure if there is a info argument which is accepted by the cvs. Let me know if I am missing something or you need some additional info. Rohan. On Jun 12, 4:33 pm, Christian Hammond wrote: Can you show us what you tried? And the repository info from 'cvs info' on that repository? Christian viewboard.org VMware, Inc. -http://www.vmware.com [1] On Sun, Jun 12, 2011 at 1:25 PM, ROAAN wrote: Finally I upgraded my system and was able to install the ReviewBoard. However when I am trying to add the cvs repo. I always seem to be getting the error: A repository was not found at the specified path. 010ff 2px solid; margin-left:5px; width:100%I have tried different combinations of specifying the repo. There is no log being generated as well. Any help on how to set up the cvs repo ft:#1010ff 2px solid; margin-left:5px; width:100%Thanks, Roha ote -- Want to help the Review Board project? Donate to us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com [2] For more options, visit this group a ttp://groups.google.com/group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ [3] Happy user? Let us know at http://www.reviewboard.org/users/ [4] -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com [5] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en [6] Links: -- [1] http://www.vmware.com [2] mailto:reviewboard+unsubscr...@googlegroups.com [3] http://www.reviewboard.org/donate/ [4] http://www.reviewboard.org/users/ [5] mailto:reviewboard+unsubscr...@googlegroups.com [6] http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error in adding cvs repository
I know it's funky, but try changing the path to pact-cvs.pact.cs.cmu.edu:/usr0/local/. If you don't, it'll ignore the username and password fields. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Jun 12, 2011 at 1:41 PM, ROAAN rohan.raiza...@gmail.com wrote: Name: pact-cvs-tree Hosting service: Custom Repository type: CVS Path: :pserver:my_usern...@pact-cvs.pact.cs.cmu.edu:/usr0/local/ cvsroot Username : my_username Password: my_password I am not sure if there is a info argument which is accepted by the cvs. Let me know if I am missing something or you need some additional info. Rohan. On Jun 12, 4:33 pm, Christian Hammond chip...@chipx86.com wrote: Can you show us what you tried? And the repository info from 'cvs info' on that repository? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 1:25 PM, ROAAN rohan.raiza...@gmail.com wrote: Hi, Finally I upgraded my system and was able to install the ReviewBoard. However when I am trying to add the cvs repo. I always seem to be getting the error: A repository was not found at the specified path. I have tried different combinations of specifying the repo. There is no log being generated as well. Any help on how to set up the cvs repo would be appreciated. Thanks, Rohan. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: gitorious repository
Using Gitorious should be fine. These are patches that used to work with Gitorious and no longer do? Are they full SHA1s or short SHA1s? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jun 13, 2011 at 4:42 AM, Michael Milbrath m.milbr...@gmail.comwrote: We've been using Review Board with Gitorioius for awhile now without any problems using a URL mask as illustrated below. Recently we've had problems with the patch getting applied to older reviews that were previously successful. The error is similar to http://code.google.com/p/reviewboard/issues/detail?id=1873. In my random testing I noticed that using a locally sync'd repository versus using the URL mask seems to work although haven't done thorough testing nor investigation into the source code. Is this a known issue? Is it better to use a local sync than using the URL Mask with Gitoriious. URL Mask: http://repo/blobs/raw/revision/filename -- Michael D. Milbrath E-mail: m.milbr...@gmail.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Customizing Submitters page
Hi Daryl, The sortable flag only works for fields that are actually in the database. For the full name, we're actually just calling a function that pieces together a couple strings from the database, so we can't really sort on it. It should work for last_login though. I'm guessing there was just some odd caching problem when trying to change it back, or the server wasn't reloaded. Having it on last_login should be fine. As for expand, that's to control whether it takes up as much space as possible, width-wise. The summary column is expanded, for example. You wouldn't want it here. Are you testing with the dev server, or an install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jun 13, 2011 at 5:26 AM, Daryl darylnebr...@gmail.com wrote: The only changes I've made are to SubmitterDataGrid. I added a column for last_login and added that column to the self.default_columns below. Disclaimer - the only other python code I've written is a tab- space patch for RB. :) So I'm in the dark. I searched through the code and found template/reviews/user_page.html using user.last_login so I guessed at the line below where I set field_name=last_login. Now what I recall is I added sortable=True to fullname and pending_count, tested, and got an error. I then removed those but left sortable=True for last_login. It still failed for my normal account. But when I logged in as admin it works. I now just logged in as another non-admin account, and the Submitter page comes up ok. Now I do remember also putting an expand=True (or maybe it was shrink=True) on the new last_login line. I don't know what they mean so I removed them. But I did do a test with it in there. Perhaps adjusting the column width? Anyhow, if need be I can put in those changes again and try to view it with one of the working accounts to see if it reproduces it. But perhaps I'll wait for you to reply on if what I have below is just wrong. Daryl username = Column(_(Username), link=True, sortable=True) fullname = Column(_(Full Name), field_name=get_full_name, link=True, expand=True) pending_count = PendingCountColumn(_(Pending Reviews), field_name=directed_review_requests, shrink=True) last_login = Column(_(Last Login), field_name=last_login, sortable=True) snip self.default_columns = [ username, fullname, pending_count, last_login ] On Jun 13, 2:40 am, Christian Hammond chip...@chipx86.com wrote: I'm a bit confused by this. Can you show me what the code you're adding looks like? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 7:59 PM, Daryl darylnebr...@gmail.com wrote: Mercy. Ok, I've been able to add it and it works with a 2nd account. But initially I added sortable=True to to fullname, pending_count and last_login. It didn't like that. So I removed sortable from fullname and pending_count. And now it works with the 2nd account. But it seems like something is cached with the first account since I keep getting the 500 - something broke error with the below trace. I assumed something was cached, but I've tried: - Restarting apache - Restarting memcache - Clearing memcache using echo flush_all | nc localhost 11211 - Restarting sqld - rb-site manage upgrade . - Clearing browser cache It's my normal review account that I was first testing the changes that keep giving me the error. With the admin account Last Login shows up and I can sort by it. Frustrating .. any thoughts? Thanks, Daryl Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/accounts/decorators.py, line 25, in _check return login_required(view_func)(*args, **kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/reviews/views.py, line 504, in submitter_list return grid.render_to_response(template_name) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 699, in render_to_response self.load_state() File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/datagrid/grids.py, line 534, in load_state self.precompute_objects() File
Re: Error in adding cvs repository
I tried that as well, but to no avail. I am using version 1.5 for RB. Should I try the beta version? Thanks, Rohan. On Jun 13, 3:53 pm, Christian Hammond chip...@chipx86.com wrote: I know it's funky, but try changing the path to pact-cvs.pact.cs.cmu.edu:/usr0/local/. If you don't, it'll ignore the username and password fields. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 1:41 PM, ROAAN rohan.raiza...@gmail.com wrote: Name: pact-cvs-tree Hosting service: Custom Repository type: CVS Path: :pserver:my_usern...@pact-cvs.pact.cs.cmu.edu:/usr0/local/ cvsroot Username : my_username Password: my_password I am not sure if there is a info argument which is accepted by the cvs. Let me know if I am missing something or you need some additional info. Rohan. On Jun 12, 4:33 pm, Christian Hammond chip...@chipx86.com wrote: Can you show us what you tried? And the repository info from 'cvs info' on that repository? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 1:25 PM, ROAAN rohan.raiza...@gmail.com wrote: Hi, Finally I upgraded my system and was able to install the ReviewBoard. However when I am trying to add the cvs repo. I always seem to be getting the error: A repository was not found at the specified path. I have tried different combinations of specifying the repo. There is no log being generated as well. Any help on how to set up the cvs repo would be appreciated. Thanks, Rohan. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: gitorious repository
Correct. The patches were successful but are no longer working. I believe I have the issue pinned down to the URL mask. We are currently using mask similar to http://server/blobs/raw/revision/file But this returns the HEAD version and not the correct revision specified. Comparing this to the local GIT mechanism using 'cat-file' which does return the correct version. Returning the HEAD version ends up causing the patch call to fail because it appears changes have already been applied. Not sure how they configured Gitorious on the back end and still investigating that but I believe the following commands should return identical contents but for some reason they are not. $ git cat-file blob 175314a22f19aa44c0f074917601f912be2f84d4 $ wget http://server/blobs/raw/175314a22f19aa44c0f074917601f912be2f84d4/core/util-client/.classpath Could be that we just never noticed that it was pulling the HEAD or if they recently updated the backend and something is now broke. Thanks --Michael On Mon, Jun 13, 2011 at 3:55 PM, Christian Hammond chip...@chipx86.com wrote: Using Gitorious should be fine. These are patches that used to work with Gitorious and no longer do? Are they full SHA1s or short SHA1s? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jun 13, 2011 at 4:42 AM, Michael Milbrath m.milbr...@gmail.com wrote: We've been using Review Board with Gitorioius for awhile now without any problems using a URL mask as illustrated below. Recently we've had problems with the patch getting applied to older reviews that were previously successful. The error is similar to http://code.google.com/p/reviewboard/issues/detail?id=1873. In my random testing I noticed that using a locally sync'd repository versus using the URL mask seems to work although haven't done thorough testing nor investigation into the source code. Is this a known issue? Is it better to use a local sync than using the URL Mask with Gitoriious. URL Mask: http://repo/blobs/raw/revision/filename -- Michael D. Milbrath E-mail: m.milbr...@gmail.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Michael D. Milbrath E-mail: m.milbr...@gmail.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Customizing Submitters page
Hey Christian, From an install. It does seem cache related and I cleared everything I can think of (see above). I've already moved everyone to the new server so I can't revert the database. Not sure what else to clear/ reset. Daryl On Jun 13, 3:58 pm, Christian Hammond chip...@chipx86.com wrote: Hi Daryl, The sortable flag only works for fields that are actually in the database. For the full name, we're actually just calling a function that pieces together a couple strings from the database, so we can't really sort on it. It should work for last_login though. I'm guessing there was just some odd caching problem when trying to change it back, or the server wasn't reloaded. Having it on last_login should be fine. As for expand, that's to control whether it takes up as much space as possible, width-wise. The summary column is expanded, for example. You wouldn't want it here. Are you testing with the dev server, or an install? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jun 13, 2011 at 5:26 AM, Daryl darylnebr...@gmail.com wrote: The only changes I've made are to SubmitterDataGrid. I added a column for last_login and added that column to the self.default_columns below. Disclaimer - the only other python code I've written is a tab- space patch for RB. :) So I'm in the dark. I searched through the code and found template/reviews/user_page.html using user.last_login so I guessed at the line below where I set field_name=last_login. Now what I recall is I added sortable=True to fullname and pending_count, tested, and got an error. I then removed those but left sortable=True for last_login. It still failed for my normal account. But when I logged in as admin it works. I now just logged in as another non-admin account, and the Submitter page comes up ok. Now I do remember also putting an expand=True (or maybe it was shrink=True) on the new last_login line. I don't know what they mean so I removed them. But I did do a test with it in there. Perhaps adjusting the column width? Anyhow, if need be I can put in those changes again and try to view it with one of the working accounts to see if it reproduces it. But perhaps I'll wait for you to reply on if what I have below is just wrong. Daryl username = Column(_(Username), link=True, sortable=True) fullname = Column(_(Full Name), field_name=get_full_name, link=True, expand=True) pending_count = PendingCountColumn(_(Pending Reviews), field_name=directed_review_requests, shrink=True) last_login = Column(_(Last Login), field_name=last_login, sortable=True) snip self.default_columns = [ username, fullname, pending_count, last_login ] On Jun 13, 2:40 am, Christian Hammond chip...@chipx86.com wrote: I'm a bit confused by this. Can you show me what the code you're adding looks like? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 7:59 PM, Daryl darylnebr...@gmail.com wrote: Mercy. Ok, I've been able to add it and it works with a 2nd account. But initially I added sortable=True to to fullname, pending_count and last_login. It didn't like that. So I removed sortable from fullname and pending_count. And now it works with the 2nd account. But it seems like something is cached with the first account since I keep getting the 500 - something broke error with the below trace. I assumed something was cached, but I've tried: - Restarting apache - Restarting memcache - Clearing memcache using echo flush_all | nc localhost 11211 - Restarting sqld - rb-site manage upgrade . - Clearing browser cache It's my normal review account that I was first testing the changes that keep giving me the error. With the admin account Last Login shows up and I can sort by it. Frustrating .. any thoughts? Thanks, Daryl Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/ core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/accounts/decorators.py, line 25, in _check return login_required(view_func)(*args, **kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/ djblets/auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.6beta2.1- py2.4.egg/reviewboard/reviews/views.py, line 504, in submitter_list return
1.6 beta 2 - IE vs Firefox
Hi, Now that I deployed the new server, people are actually using it with IE. 2 issues have been reported - 1. When posting a new diff through the web site, there are 2 fields present on IE that aren't there on firefox. Parent diff and Changeset. After clicking the Create new request button the draft review page comes up but none of the text boxes can be edited and there's no pencil icon. 2. When viewing the diff of an existing review, only the first file loads. The icons keep spinning and it never loads more than the first file. All of this works fine in firefox. Daryl -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: 1.6 beta 2 - IE vs Firefox
There's a bug filed on beta 2 right now where the JavaScript doesn't parse on Firefox, causing bits and pieces to not work. It'll be fixed in the next release. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jun 13, 2011 at 4:42 PM, Daryl darylnebr...@gmail.com wrote: Hi, Now that I deployed the new server, people are actually using it with IE. 2 issues have been reported - 1. When posting a new diff through the web site, there are 2 fields present on IE that aren't there on firefox. Parent diff and Changeset. After clicking the Create new request button the draft review page comes up but none of the text boxes can be edited and there's no pencil icon. 2. When viewing the diff of an existing review, only the first file loads. The icons keep spinning and it never loads more than the first file. All of this works fine in firefox. Daryl -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Customizing Submitters page
If you were modifying code and not restarting/reloading your web server, you'd hit things like this. It's not like PHP where you can modify a file and it's live. Any existing processes that have loaded in the Python modules for Review Board will keep them in memory for the next request. If you hit that process, you'll see the old version. Hit a new process, and you'll see the new one (since it'll do a fresh load of the modules). That can make testing on a live install a bit weird. Development is best done on a development install, so you don't have any downtime or stale code issues like this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jun 13, 2011 at 4:38 PM, Daryl darylnebr...@gmail.com wrote: Hey Christian, From an install. It does seem cache related and I cleared everything I can think of (see above). I've already moved everyone to the new server so I can't revert the database. Not sure what else to clear/ reset. Daryl On Jun 13, 3:58 pm, Christian Hammond chip...@chipx86.com wrote: Hi Daryl, The sortable flag only works for fields that are actually in the database. For the full name, we're actually just calling a function that pieces together a couple strings from the database, so we can't really sort on it. It should work for last_login though. I'm guessing there was just some odd caching problem when trying to change it back, or the server wasn't reloaded. Having it on last_login should be fine. As for expand, that's to control whether it takes up as much space as possible, width-wise. The summary column is expanded, for example. You wouldn't want it here. Are you testing with the dev server, or an install? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jun 13, 2011 at 5:26 AM, Daryl darylnebr...@gmail.com wrote: The only changes I've made are to SubmitterDataGrid. I added a column for last_login and added that column to the self.default_columns below. Disclaimer - the only other python code I've written is a tab- space patch for RB. :) So I'm in the dark. I searched through the code and found template/reviews/user_page.html using user.last_login so I guessed at the line below where I set field_name=last_login. Now what I recall is I added sortable=True to fullname and pending_count, tested, and got an error. I then removed those but left sortable=True for last_login. It still failed for my normal account. But when I logged in as admin it works. I now just logged in as another non-admin account, and the Submitter page comes up ok. Now I do remember also putting an expand=True (or maybe it was shrink=True) on the new last_login line. I don't know what they mean so I removed them. But I did do a test with it in there. Perhaps adjusting the column width? Anyhow, if need be I can put in those changes again and try to view it with one of the working accounts to see if it reproduces it. But perhaps I'll wait for you to reply on if what I have below is just wrong. Daryl username = Column(_(Username), link=True, sortable=True) fullname = Column(_(Full Name), field_name=get_full_name, link=True, expand=True) pending_count = PendingCountColumn(_(Pending Reviews), field_name=directed_review_requests, shrink=True) last_login = Column(_(Last Login), field_name=last_login, sortable=True) snip self.default_columns = [ username, fullname, pending_count, last_login ] On Jun 13, 2:40 am, Christian Hammond chip...@chipx86.com wrote: I'm a bit confused by this. Can you show me what the code you're adding looks like? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 7:59 PM, Daryl darylnebr...@gmail.com wrote: Mercy. Ok, I've been able to add it and it works with a 2nd account. But initially I added sortable=True to to fullname, pending_count and last_login. It didn't like that. So I removed sortable from fullname and pending_count. And now it works with the 2nd account. But it seems like something is cached with the first account since I keep getting the 500 - something broke error with the below trace. I assumed something was cached, but I've tried: - Restarting apache - Restarting memcache - Clearing memcache using echo flush_all | nc localhost 11211 - Restarting sqld - rb-site manage upgrade . - Clearing browser cache It's my normal review account that I was first testing the changes that keep
Re: Error in adding cvs repository
Hi, Finally i got it to work. It seems that the SELinux settings were disabling the httpd server to make any outgoing network connection. I changed the setting to allow the network connections and it seems to be up and running. Thanks for bearing with me and helping me on the way. Thanks, Rohan. On Jun 13, 4:01 pm, ROAAN rohan.raiza...@gmail.com wrote: I tried that as well, but to no avail. I am using version 1.5 for RB. Should I try the beta version? Thanks, Rohan. On Jun 13, 3:53 pm, Christian Hammond chip...@chipx86.com wrote: I know it's funky, but try changing the path to pact-cvs.pact.cs.cmu.edu:/usr0/local/. If you don't, it'll ignore the username and password fields. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 1:41 PM, ROAAN rohan.raiza...@gmail.com wrote: Name: pact-cvs-tree Hosting service: Custom Repository type: CVS Path: :pserver:my_usern...@pact-cvs.pact.cs.cmu.edu:/usr0/local/ cvsroot Username : my_username Password: my_password I am not sure if there is a info argument which is accepted by the cvs. Let me know if I am missing something or you need some additional info. Rohan. On Jun 12, 4:33 pm, Christian Hammond chip...@chipx86.com wrote: Can you show us what you tried? And the repository info from 'cvs info' on that repository? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Jun 12, 2011 at 1:25 PM, ROAAN rohan.raiza...@gmail.com wrote: Hi, Finally I upgraded my system and was able to install the ReviewBoard. However when I am trying to add the cvs repo. I always seem to be getting the error: A repository was not found at the specified path. I have tried different combinations of specifying the repo. There is no log being generated as well. Any help on how to set up the cvs repo would be appreciated. Thanks, Rohan. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
